-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PIMv6] Add new scenarios to multicast static_rp suite #11736
Conversation
cbc05d3
to
ec3402a
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-6775/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8 Topotests debian 10 amd64 part 8: Failed (click for details)Topotests debian 10 amd64 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6775/artifact/TOPO8DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-6775/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8 Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundSuccessful on other platforms/tests
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-6777/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8 Topotests debian 10 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8DEB10AMD64-6777/test Topology Tests failed for Topotests debian 10 amd64 part 8 Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-6777/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8 Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundSuccessful on other platforms/tests
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-6778/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8 Topotests debian 10 amd64 part 8: Failed (click for details)Topotests debian 10 amd64 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6778/artifact/TOPO8DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6778/artifact/TOPO8U18ARM64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundSuccessful on other platforms/tests
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-6822/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8 Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundTopotests debian 10 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8DEB10AMD64-6822/test Topology Tests failed for Topotests debian 10 amd64 part 8 Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-6822/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8 Successful on other platforms/tests
|
CI: rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundTopotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topotests Ubuntu 18.04 i386 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6845/artifact/TOPO8U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 8: No useful log foundTopotests debian 10 amd64 part 8: Failed (click for details)Topotests debian 10 amd64 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6845/artifact/TOPO8DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6845/artifact/TOPO8U18ARM64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 arm8 part 7: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 7: No useful log foundSuccessful on other platforms/tests
|
ci:rerun the failures are all snmp not related to this change. |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6932/artifact/TOPO8U18ARM64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundTopotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-6932/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8 Topotests debian 10 amd64 part 8: Failed (click for details)Topotests debian 10 amd64 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6932/artifact/TOPO8DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: No useful log foundSuccessful on other platforms/tests
|
Dependent on issue: #11724, will rerun CI once issue is fixed. |
@kuldeepkash : Please rebase the changes, fix for #11724 is merged. |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundTopotests debian 10 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8DEB10AMD64-7496/test Topology Tests failed for Topotests debian 10 amd64 part 8 Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: No useful log foundTopotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-7496/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8 Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-7496/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8 Topotests debian 10 amd64 part 2: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO2DEB10AMD64-7496/test Topology Tests failed for Topotests debian 10 amd64 part 2 Successful on other platforms/tests
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundTopotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-7509/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8 Topotests debian 10 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8DEB10AMD64-7509/test Topology Tests failed for Topotests debian 10 amd64 part 8 Topotests debian 10 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-7509/test Topology Tests failed for Topotests debian 10 amd64 part 9 Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-7509/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8 Successful on other platforms/tests
|
@mwinter-osr , We need latest socat version with the changes mentioned in below github link to run mld traffic: Github link: These changes were done by @eqvinox to make IPv6 join/traffic work. Thank you!! |
CI:rerun socat installed |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests Ubuntu 18.04 i386 part 8: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-8025/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8 Successful on other platforms/tests
|
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8025/ This is a comment from an automated CI system. |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8058/ This is a comment from an automated CI system. |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8187/ This is a comment from an automated CI system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nits, overall LGTM
|
||
Parameters: | ||
----------- | ||
* `tgen` : Topogen object | ||
* `server`: iperf server, from where IGMP join would be sent | ||
* `protocol_option`: Protocol options, ex: UDP6-RECV | ||
* `igmp_groups`: IGMP group for which join has to be sent | ||
* `mld_groups`: IGMP group for which join has to be sent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description should be changed too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems not? 😄
tests/topotests/multicast_pim6_static_rp_topo1/test_multicast_pim6_static_rp1.py
Outdated
Show resolved
Hide resolved
tests/topotests/multicast_pim6_static_rp_topo1/test_multicast_pim6_static_rp1.py
Outdated
Show resolved
Hide resolved
tests/topotests/multicast_pim6_static_rp_topo1/test_multicast_pim6_static_rp1.py
Outdated
Show resolved
Hide resolved
tests/topotests/multicast_pim6_static_rp_topo1/test_multicast_pim6_static_rp2.py
Outdated
Show resolved
Hide resolved
tests/topotests/multicast_pim6_static_rp_topo1/test_multicast_pim6_static_rp2.py
Outdated
Show resolved
Hide resolved
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-8215/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8 Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundTopotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-8215/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8 Topotests debian 10 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8DEB10AMD64-8215/test Topology Tests failed for Topotests debian 10 amd64 part 8 Successful on other platforms/tests
|
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 1: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 1: No useful log foundSuccessful on other platforms/tests
|
ci:rerun BGP failure (test_bgp_bfd_down_notification) not related to this change. |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundSuccessful on other platforms/tests
|
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-8236/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8 Successful on other platforms/tests
|
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8239/ This is a comment from an automated CI system. |
CI: rerun |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundSuccessful on other platforms/tests
|
Enhanced or added new libraries to support multicast pimv6 automation Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
Automated new scenarios to multicast pimv6 static rp test suite. Added new folder multicast_pim6_static_rp_topo1 for pimv6 static_rp automation. Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
Added pim6d marker to pytest.ini file, to run tests pim6d marker based, if added to scripts. Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8244/ This is a comment from an automated CI system. |
CI: rerun |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8245/ This is a comment from an automated CI system. |
ci:rerun Running to ensure test cases are stable. |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8259/ This is a comment from an automated CI system. |
ci: rerun one more time |
I think if this passes we can get this merged. Seems stable now. |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8262/ This is a comment from an automated CI system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
multicast pimv6 automation
static rp test suite.
Signed-off-by: Kuldeep Kashyap kashyapk@vmware.com