pim6d: Implementing "show ipv6 mld groups" CLI #11571

SaiGomathiN · 2022-07-08T13:00:32Z

This helps to display the MLD group information.
Modified the igmp_group_count of struct pim_instance to gm_group_count
to be used for both IGMP and MLD.

NetDEF-CI · 2022-07-08T19:57:03Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6371/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI · 2022-07-08T20:15:32Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6372/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

mobash-rasool · 2022-07-13T05:43:01Z

pimd/pim_instance.h

@@ -172,7 +172,7 @@ struct pim_instance {
 	int gm_socket;
 	struct thread *t_gm_recv;

-	unsigned int igmp_group_count;
+	unsigned int gm_group_count;


Right now this is not being incremented in the MLD code.

mobash-rasool · 2022-07-13T06:00:38Z

pimd/pim6_mld.c

+							       json_groups);
+				}
+
+				json_group = json_object_new_object();


This will add multiple rows in the array for the same group. Think of when we have (S1, G) and (S2, G), then we should only display it once. But this will display it twice. You can use similar logic to json_object_object_get_ex

Modifying igmp_group_count of struct pim_instance to gm_group_count which is to be used for both IGMP and MLD. Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>

NetDEF-CI · 2022-07-18T08:42:00Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6528/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6528/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6528/artifact/DEB11AMD64/ErrorLog/log_make.txt)

 1014 |    CPP_NOTICE("need S,G PRUNE => NO_INFO transition here");
pimd/pim6_mld.c: In function gm_show_groups:
pimd/pim6_mld.c:2922:24: error: format %pPA expects argument of type pim_addr {aka struct in6_addr} *, but argument 3 has type const char * [-Werror=format=]
 2922 |    vty_out(vty, "%-15pPAs  ", json_object_get_string(json_tmp));
cc1: all warnings being treated as errors
make[1]: *** [Makefile:12421: pimd/pim6d-pim6_mld.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.6528/frr-source'
make: *** [Makefile:6374: all] Error 2

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6528/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests

Ubuntu 22.04 amd64 build
Fedora 29 amd64 build
Ubuntu 18.04 arm8 build
Debian 9 amd64 build
Ubuntu 20.04 amd64 build
Ubuntu 18.04 ppc64le build
Debian 10 amd64 build
Ubuntu 16.04 arm7 build
Ubuntu 16.04 i386 build
CentOS 7 amd64 build
Ubuntu 18.04 i386 build
Ubuntu 18.04 amd64 build
Ubuntu 18.04 arm7 build
FreeBSD 11 amd64 build
Ubuntu 16.04 arm8 build
Redhat 9 amd64 build
Ubuntu 16.04 amd64 build
Redhat 8 amd64 build
NetBSD 9 amd64 build
OpenBSD 7 amd64 build
FreeBSD 12 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6528/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6528/artifact/DEB11AMD64/ErrorLog/log_make.txt)

 1014 |    CPP_NOTICE("need S,G PRUNE => NO_INFO transition here");
pimd/pim6_mld.c: In function gm_show_groups:
pimd/pim6_mld.c:2922:24: error: format %pPA expects argument of type pim_addr {aka struct in6_addr} *, but argument 3 has type const char * [-Werror=format=]
 2922 |    vty_out(vty, "%-15pPAs  ", json_object_get_string(json_tmp));
cc1: all warnings being treated as errors
make[1]: *** [Makefile:12421: pimd/pim6d-pim6_mld.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.6528/frr-source'
make: *** [Makefile:6374: all] Error 2

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6528/artifact/DEB11AMD64/config.status/config.status

Report for pim6_mld.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #3009: FILE: /tmp/f1-21693/pim6_mld.c:3009:

To Display MLD Group information Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>

Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>

NetDEF-CI · 2022-07-18T08:51:54Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6529/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6529/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6529/artifact/DEB11AMD64/ErrorLog/log_make.txt)

 1014 |    CPP_NOTICE("need S,G PRUNE => NO_INFO transition here");
pimd/pim6_mld.c: In function gm_show_groups:
pimd/pim6_mld.c:2919:24: error: format %pPA expects argument of type pim_addr {aka struct in6_addr} *, but argument 3 has type const char * [-Werror=format=]
 2919 |    vty_out(vty, "%-15pPAs  ",
 2920 |     json_object_get_string(json_tmp));
cc1: all warnings being treated as errors
make[1]: *** [Makefile:12421: pimd/pim6d-pim6_mld.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.6529/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6529/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests

Fedora 29 amd64 build
Ubuntu 18.04 arm8 build
Ubuntu 20.04 amd64 build
Debian 9 amd64 build
Redhat 9 amd64 build
Ubuntu 18.04 ppc64le build
Debian 10 amd64 build
Ubuntu 22.04 amd64 build
FreeBSD 11 amd64 build
Ubuntu 16.04 arm7 build
Ubuntu 18.04 i386 build
Ubuntu 16.04 i386 build
Ubuntu 18.04 amd64 build
Ubuntu 18.04 arm7 build
Ubuntu 16.04 amd64 build
NetBSD 9 amd64 build
Ubuntu 16.04 arm8 build
CentOS 7 amd64 build
Redhat 8 amd64 build
OpenBSD 7 amd64 build
FreeBSD 12 amd64 build

NetDEF-CI · 2022-07-18T09:38:41Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6530/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6530/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6530/artifact/DEB11AMD64/ErrorLog/log_make.txt)

 1014 |    CPP_NOTICE("need S,G PRUNE => NO_INFO transition here");
pimd/pim6_mld.c: In function gm_show_groups:
pimd/pim6_mld.c:2919:24: error: format %pPA expects argument of type pim_addr {aka struct in6_addr} *, but argument 3 has type const char * [-Werror=format=]
 2919 |    vty_out(vty, "%-15pPAs  ",
 2920 |     json_object_get_string(json_tmp));
cc1: all warnings being treated as errors
make[1]: *** [Makefile:12421: pimd/pim6d-pim6_mld.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.6530/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6530/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests

Fedora 29 amd64 build
Ubuntu 20.04 amd64 build
OpenBSD 7 amd64 build
Ubuntu 18.04 arm8 build
Debian 9 amd64 build
Redhat 8 amd64 build
Redhat 9 amd64 build
Debian 10 amd64 build
Ubuntu 18.04 ppc64le build
Ubuntu 16.04 arm7 build
Ubuntu 22.04 amd64 build
FreeBSD 11 amd64 build
Ubuntu 16.04 arm8 build
Ubuntu 18.04 amd64 build
Ubuntu 18.04 i386 build
NetBSD 9 amd64 build
Ubuntu 16.04 amd64 build
Ubuntu 18.04 arm7 build
CentOS 7 amd64 build
Ubuntu 16.04 i386 build
FreeBSD 12 amd64 build

NetDEF-CI · 2022-07-18T11:02:39Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6532/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topotests Ubuntu 18.04 arm8 part 9: Incomplete

(check logs for details)

Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-6532/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6532/artifact/TOPO8U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 9: Incomplete

(check logs for details)

Topotests Ubuntu 18.04 i386 part 9: Incomplete

(check logs for details)

Topotests debian 10 amd64 part 9: Incomplete

(check logs for details)

Successful on other platforms/tests

Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 arm8 part 4
Ubuntu 20.04 deb pkg check
Ubuntu 18.04 deb pkg check
Debian 10 deb pkg check
IPv6 protocols on Ubuntu 18.04
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
IPv4 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 3
Debian 9 deb pkg check
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 5
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 4
Static analyzer (clang)
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 1
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 8
IPv4 ldp protocol on Ubuntu 18.04
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 2
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 7
Fedora 29 rpm pkg check
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 9
CentOS 7 rpm pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 2

frrbot bot added documentation pim labels Jul 8, 2022

github-actions bot added the master label Jul 8, 2022

SaiGomathiN force-pushed the mlg-groups branch from 1f47334 to a2a5ce7 Compare July 8, 2022 13:05

mobash-rasool added the pimv6 label Jul 8, 2022

mobash-rasool reviewed Jul 13, 2022

View reviewed changes

pimd: Modifying member of pim_instance to accomodate IPv6 changes

13c6935

Modifying igmp_group_count of struct pim_instance to gm_group_count which is to be used for both IGMP and MLD. Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>

SaiGomathiN force-pushed the mlg-groups branch 3 times, most recently from f8ae8b0 to 4728b2d Compare July 18, 2022 08:34

SaiGomathiN added 2 commits July 18, 2022 01:46

pim6d: Implementing "show mld groups" CLI

1c253bb

To Display MLD Group information Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>

doc: Updated the doc for show ipv6 mld groups command

076942f

Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>

SaiGomathiN force-pushed the mlg-groups branch from 4728b2d to 076942f Compare July 18, 2022 08:46

SaiGomathiN closed this Aug 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pim6d: Implementing "show ipv6 mld groups" CLI #11571

pim6d: Implementing "show ipv6 mld groups" CLI #11571

SaiGomathiN commented Jul 8, 2022

NetDEF-CI commented Jul 8, 2022 •

edited

Loading

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Jul 8, 2022 •

edited

Loading

Continuous Integration Result: SUCCESSFUL

mobash-rasool Jul 13, 2022

mobash-rasool Jul 13, 2022

NetDEF-CI commented Jul 18, 2022 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Jul 18, 2022 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

NetDEF-CI commented Jul 18, 2022 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

NetDEF-CI commented Jul 18, 2022

pim6d: Implementing "show ipv6 mld groups" CLI #11571

pim6d: Implementing "show ipv6 mld groups" CLI #11571

Conversation

SaiGomathiN commented Jul 8, 2022

NetDEF-CI commented Jul 8, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Jul 8, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

mobash-rasool Jul 13, 2022

Choose a reason for hiding this comment

mobash-rasool Jul 13, 2022

Choose a reason for hiding this comment

NetDEF-CI commented Jul 18, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Jul 18, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

NetDEF-CI commented Jul 18, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

NetDEF-CI commented Jul 18, 2022

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

NetDEF-CI commented Jul 8, 2022 •

edited

Loading

NetDEF-CI commented Jul 8, 2022 •

edited

Loading

NetDEF-CI commented Jul 18, 2022 •

edited

Loading

NetDEF-CI commented Jul 18, 2022 •

edited

Loading

NetDEF-CI commented Jul 18, 2022 •

edited

Loading