bfdd: add IPv4 BFD Echo support that loops pkts in forwarding plane #11371

lynnemorrison · 2022-06-08T18:02:54Z

Modify the existing BFD Echo code to send an Echo message that will
be looped in the peers forwarding plane. The existing Echo code
only works with other FRR implementations because the Echo packet
must go up to BFD to be turned around and forwarded back to the
local router. The new BFD Echo code sets the src/dst IP of the
packet to be the local router's IP and sets the dest MAC to be the
peers MAC address. The peer receives the packet and because it
is not it's IP address it forwards it back to the local router.

Signed-off-by: Lynne Morrison lynne.morrison@ibm.com

NetDEF-CI · 2022-06-08T18:57:00Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5821/frr-source'
bfdd/bfd_packet.c: In function 'bp_echo_send_fp':
bfdd/bfd_packet.c:152:21: error: storage size of 'sadr_ll' isn't known
In file included from /usr/include/machine/endian.h:6,
bfdd/bfd_packet.c:163:31: error: 'ETH_P_IP' undeclared (first use in this function)
bfdd/bfd_packet.c:163:31: note: each undeclared identifier is reported only once for each function it appears in
bfdd/bfd_packet.c:152:21: error: unused variable 'sadr_ll' [-Werror=unused-variable]
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:217:5: error: 'struct udphdr' has no member named 'check'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/CI009BUILD/config.log/config.log.gz

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5821/frr-source'
bfdd/bfd_packet.c: In function 'bp_echo_send_fp':
bfdd/bfd_packet.c:152:21: error: storage size of 'sadr_ll' isn't known
In file included from /usr/include/machine/endian.h:6:0,
bfdd/bfd_packet.c:163:31: error: 'ETH_P_IP' undeclared (first use in this function); did you mean 'TH_FIN'?
bfdd/bfd_packet.c:163:31: note: each undeclared identifier is reported only once for each function it appears in
bfdd/bfd_packet.c:152:21: error: unused variable 'sadr_ll' [-Werror=unused-variable]
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:217:5: error: 'struct udphdr' has no member named 'check'

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/FBSD12AMD64/config.log/config.log.gz

NetBSD 9 amd64 build: Failed (click for details)

NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.5821/frr-source'
bfdd/bfd_packet.c: In function 'bp_echo_send_fp':
bfdd/bfd_packet.c:152:21: error: storage size of 'sadr_ll' isn't known
In file included from /usr/include/stdint.h:35:0,
bfdd/bfd_packet.c:163:31: error: 'ETH_P_IP' undeclared (first use in this function); did you mean 'TH_FIN'?
bfdd/bfd_packet.c:163:31: note: each undeclared identifier is reported only once for each function it appears in
bfdd/bfd_packet.c:152:21: error: unused variable 'sadr_ll' [-Werror=unused-variable]
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:217:5: error: 'struct udphdr' has no member named 'check'

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/CI012BUILD/config.status/config.status

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.5821/frr-source'
bfdd/bfd_packet.c:152:21: error: variable has incomplete type 'struct sockaddr_ll'
bfdd/bfd_packet.c:152:9: note: forward declaration of 'struct sockaddr_ll'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:217:7: error: no member named 'check' in 'struct udphdr'

OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/CI011BUILD/config.status/config.status
OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/CI011BUILD/config.log/config.log.gz

Successful on other platforms/tests

Ubuntu 22.04 amd64 build
Ubuntu 20.04 amd64 build
Ubuntu 18.04 arm8 build
Debian 9 amd64 build
Ubuntu 18.04 ppc64le build
Fedora 29 amd64 build
Debian 10 amd64 build
Ubuntu 18.04 arm7 build
CentOS 7 amd64 build
Ubuntu 16.04 arm7 build
Debian 11 amd64 build
Redhat 9 amd64 build
Ubuntu 16.04 i386 build
Ubuntu 18.04 amd64 build
Ubuntu 16.04 amd64 build
Ubuntu 16.04 arm8 build
Ubuntu 18.04 i386 build
Redhat 8 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5821/frr-source'
bfdd/bfd_packet.c: In function 'bp_echo_send_fp':
bfdd/bfd_packet.c:152:21: error: storage size of 'sadr_ll' isn't known
In file included from /usr/include/machine/endian.h:6,
bfdd/bfd_packet.c:163:31: error: 'ETH_P_IP' undeclared (first use in this function)
bfdd/bfd_packet.c:163:31: note: each undeclared identifier is reported only once for each function it appears in
bfdd/bfd_packet.c:152:21: error: unused variable 'sadr_ll' [-Werror=unused-variable]
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:217:5: error: 'struct udphdr' has no member named 'check'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/CI009BUILD/config.log/config.log.gz

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5821/frr-source'
bfdd/bfd_packet.c: In function 'bp_echo_send_fp':
bfdd/bfd_packet.c:152:21: error: storage size of 'sadr_ll' isn't known
In file included from /usr/include/machine/endian.h:6:0,
bfdd/bfd_packet.c:163:31: error: 'ETH_P_IP' undeclared (first use in this function); did you mean 'TH_FIN'?
bfdd/bfd_packet.c:163:31: note: each undeclared identifier is reported only once for each function it appears in
bfdd/bfd_packet.c:152:21: error: unused variable 'sadr_ll' [-Werror=unused-variable]
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:217:5: error: 'struct udphdr' has no member named 'check'

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/FBSD12AMD64/config.log/config.log.gz

NetBSD 9 amd64 build: Failed (click for details)

NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.5821/frr-source'
bfdd/bfd_packet.c: In function 'bp_echo_send_fp':
bfdd/bfd_packet.c:152:21: error: storage size of 'sadr_ll' isn't known
In file included from /usr/include/stdint.h:35:0,
bfdd/bfd_packet.c:163:31: error: 'ETH_P_IP' undeclared (first use in this function); did you mean 'TH_FIN'?
bfdd/bfd_packet.c:163:31: note: each undeclared identifier is reported only once for each function it appears in
bfdd/bfd_packet.c:152:21: error: unused variable 'sadr_ll' [-Werror=unused-variable]
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:217:5: error: 'struct udphdr' has no member named 'check'

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/CI012BUILD/config.status/config.status

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.5821/frr-source'
bfdd/bfd_packet.c:152:21: error: variable has incomplete type 'struct sockaddr_ll'
bfdd/bfd_packet.c:152:9: note: forward declaration of 'struct sockaddr_ll'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:217:7: error: no member named 'check' in 'struct udphdr'

OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/CI011BUILD/config.status/config.status
OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5821/artifact/CI011BUILD/config.log/config.log.gz

Report for bfd_packet.c | 58 issues
===============================================
< WARNING: externs should be avoided in .c files
< #52: FILE: /tmp/f1-15812/bfd_packet.c:52:
< WARNING: externs should be avoided in .c files
< #62: FILE: /tmp/f1-15812/bfd_packet.c:62:
< WARNING: externs should be avoided in .c files
< #64: FILE: /tmp/f1-15812/bfd_packet.c:64:
< WARNING: externs should be avoided in .c files
< #66: FILE: /tmp/f1-15812/bfd_packet.c:66:
< ERROR: code indent should use tabs where possible
< #67: FILE: /tmp/f1-15812/bfd_packet.c:67:
< ERROR: do not initialise statics to 0
< #240: FILE: /tmp/f1-15812/bfd_packet.c:240:
< WARNING: Missing a blank line after declarations
< #271: FILE: /tmp/f1-15812/bfd_packet.c:271:
< ERROR: space required after that ',' (ctx:VxV)
< #271: FILE: /tmp/f1-15812/bfd_packet.c:271:
< ERROR: space required after that ',' (ctx:VxV)
< #271: FILE: /tmp/f1-15812/bfd_packet.c:271:
< WARNING: C99 // comments do not match recommendation
< #273: FILE: /tmp/f1-15812/bfd_packet.c:273:
< WARNING: Prefer using '"%s...", __func__' to using 'bfd_recv_ipv4_fp', this function's name, in a string
< #517: FILE: /tmp/f1-15812/bfd_packet.c:517:
< ERROR: "(foo*)" should be "(foo *)"
< #523: FILE: /tmp/f1-15812/bfd_packet.c:523:
< WARNING: suspect code indent for conditional statements (16, 20)
< #529: FILE: /tmp/f1-15812/bfd_packet.c:529:
< WARNING: Statements should start on a tabstop
< #530: FILE: /tmp/f1-15812/bfd_packet.c:530:
< WARNING: Prefer using '"%s...", __func__' to using 'bfd_recv_ipv4_fp', this function's name, in a string
< #533: FILE: /tmp/f1-15812/bfd_packet.c:533:
< ERROR: code indent should use tabs where possible
< #1062: FILE: /tmp/f1-15812/bfd_packet.c:1062:
< ERROR: space required before the open brace '{'
< #1063: FILE: /tmp/f1-15812/bfd_packet.c:1063:
< WARNING: C99 // comments do not match recommendation
< #1510: FILE: /tmp/f1-15812/bfd_packet.c:1510:
< WARNING: C99 // comments do not match recommendation
< #1541: FILE: /tmp/f1-15812/bfd_packet.c:1541:
< ERROR: "(foo*)" should be "(foo *)"
< #1590: FILE: /tmp/f1-15812/bfd_packet.c:1590:
< ERROR: bzero() is deprecated; use memset()#1592: FILE: /tmp/f1-15812/bfd_packet.c:1592:
< +		bzero(&arpreq_, sizeof(struct arpreq));
< 
< ERROR: space required after that ',' (ctx:VxO)
< #1594: FILE: /tmp/f1-15812/bfd_packet.c:1594:
< ERROR: space required before that '&' (ctx:OxV)
< #1594: FILE: /tmp/f1-15812/bfd_packet.c:1594:
< ERROR: space required after that ',' (ctx:VxV)
< #1594: FILE: /tmp/f1-15812/bfd_packet.c:1594:
< ERROR: space required after that ',' (ctx:VxV)
< #1595: FILE: /tmp/f1-15812/bfd_packet.c:1595:
< ERROR: strcpy() is error-prone; please use strlcpy()#1595: FILE: /tmp/f1-15812/bfd_packet.c:1595:
< +		strcpy(arpreq_.arp_dev,ifp->name);
< 
< ERROR: space prohibited before that close parenthesis ')'
< #1597: FILE: /tmp/f1-15812/bfd_packet.c:1597:
< ERROR: space required before the open parenthesis '('
< #1597: FILE: /tmp/f1-15812/bfd_packet.c:1597:

NetDEF-CI · 2022-06-08T19:00:51Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5823/frr-source'
bfdd/bfd_packet.c: In function 'bp_echo_send_fp':
bfdd/bfd_packet.c:152:21: error: storage size of 'sadr_ll' isn't known
In file included from /usr/include/machine/endian.h:6,
bfdd/bfd_packet.c:163:31: error: 'ETH_P_IP' undeclared (first use in this function)
bfdd/bfd_packet.c:163:31: note: each undeclared identifier is reported only once for each function it appears in
bfdd/bfd_packet.c:152:21: error: unused variable 'sadr_ll' [-Werror=unused-variable]
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:217:5: error: 'struct udphdr' has no member named 'check'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/CI009BUILD/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.5823/frr-source'
bfdd/bfd_packet.c:152:21: error: variable has incomplete type 'struct sockaddr_ll'
bfdd/bfd_packet.c:152:9: note: forward declaration of 'struct sockaddr_ll'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:217:7: error: no member named 'check' in 'struct udphdr'

OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/CI011BUILD/config.status/config.status
OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/CI011BUILD/config.log/config.log.gz

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5823/frr-source'
bfdd/bfd_packet.c: In function 'bp_echo_send_fp':
bfdd/bfd_packet.c:152:21: error: storage size of 'sadr_ll' isn't known
In file included from /usr/include/machine/endian.h:6:0,
bfdd/bfd_packet.c:163:31: error: 'ETH_P_IP' undeclared (first use in this function); did you mean 'TH_FIN'?
bfdd/bfd_packet.c:163:31: note: each undeclared identifier is reported only once for each function it appears in
bfdd/bfd_packet.c:152:21: error: unused variable 'sadr_ll' [-Werror=unused-variable]
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:217:5: error: 'struct udphdr' has no member named 'check'

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/FBSD12AMD64/config.log/config.log.gz

NetBSD 9 amd64 build: Failed (click for details)

NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.5823/frr-source'
bfdd/bfd_packet.c: In function 'bp_echo_send_fp':
bfdd/bfd_packet.c:152:21: error: storage size of 'sadr_ll' isn't known
In file included from /usr/include/stdint.h:35:0,
bfdd/bfd_packet.c:163:31: error: 'ETH_P_IP' undeclared (first use in this function); did you mean 'TH_FIN'?
bfdd/bfd_packet.c:163:31: note: each undeclared identifier is reported only once for each function it appears in
bfdd/bfd_packet.c:152:21: error: unused variable 'sadr_ll' [-Werror=unused-variable]
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:217:5: error: 'struct udphdr' has no member named 'check'

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/CI012BUILD/config.status/config.status

Successful on other platforms/tests

Fedora 29 amd64 build
Ubuntu 22.04 amd64 build
Ubuntu 18.04 arm8 build
Debian 9 amd64 build
Ubuntu 20.04 amd64 build
Ubuntu 18.04 ppc64le build
Debian 10 amd64 build
CentOS 7 amd64 build
Ubuntu 16.04 arm7 build
Ubuntu 18.04 arm7 build
Debian 11 amd64 build
Ubuntu 16.04 i386 build
Ubuntu 16.04 arm8 build
Ubuntu 18.04 amd64 build
Ubuntu 16.04 amd64 build
Redhat 9 amd64 build
Redhat 8 amd64 build
Ubuntu 18.04 i386 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5823/frr-source'
bfdd/bfd_packet.c: In function 'bp_echo_send_fp':
bfdd/bfd_packet.c:152:21: error: storage size of 'sadr_ll' isn't known
In file included from /usr/include/machine/endian.h:6,
bfdd/bfd_packet.c:163:31: error: 'ETH_P_IP' undeclared (first use in this function)
bfdd/bfd_packet.c:163:31: note: each undeclared identifier is reported only once for each function it appears in
bfdd/bfd_packet.c:152:21: error: unused variable 'sadr_ll' [-Werror=unused-variable]
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:217:5: error: 'struct udphdr' has no member named 'check'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/CI009BUILD/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.5823/frr-source'
bfdd/bfd_packet.c:152:21: error: variable has incomplete type 'struct sockaddr_ll'
bfdd/bfd_packet.c:152:9: note: forward declaration of 'struct sockaddr_ll'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:217:7: error: no member named 'check' in 'struct udphdr'

OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/CI011BUILD/config.status/config.status
OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/CI011BUILD/config.log/config.log.gz

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5823/frr-source'
bfdd/bfd_packet.c: In function 'bp_echo_send_fp':
bfdd/bfd_packet.c:152:21: error: storage size of 'sadr_ll' isn't known
In file included from /usr/include/machine/endian.h:6:0,
bfdd/bfd_packet.c:163:31: error: 'ETH_P_IP' undeclared (first use in this function); did you mean 'TH_FIN'?
bfdd/bfd_packet.c:163:31: note: each undeclared identifier is reported only once for each function it appears in
bfdd/bfd_packet.c:152:21: error: unused variable 'sadr_ll' [-Werror=unused-variable]
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:217:5: error: 'struct udphdr' has no member named 'check'

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/FBSD12AMD64/config.log/config.log.gz

NetBSD 9 amd64 build: Failed (click for details)

NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.5823/frr-source'
bfdd/bfd_packet.c: In function 'bp_echo_send_fp':
bfdd/bfd_packet.c:152:21: error: storage size of 'sadr_ll' isn't known
In file included from /usr/include/stdint.h:35:0,
bfdd/bfd_packet.c:163:31: error: 'ETH_P_IP' undeclared (first use in this function); did you mean 'TH_FIN'?
bfdd/bfd_packet.c:163:31: note: each undeclared identifier is reported only once for each function it appears in
bfdd/bfd_packet.c:152:21: error: unused variable 'sadr_ll' [-Werror=unused-variable]
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:217:5: error: 'struct udphdr' has no member named 'check'

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5823/artifact/CI012BUILD/config.status/config.status

Report for bfd_packet.c | 28 issues
===============================================
< WARNING: externs should be avoided in .c files
< #52: FILE: /tmp/f1-30382/bfd_packet.c:52:
< WARNING: externs should be avoided in .c files
< #62: FILE: /tmp/f1-30382/bfd_packet.c:62:
< WARNING: externs should be avoided in .c files
< #64: FILE: /tmp/f1-30382/bfd_packet.c:64:
< WARNING: externs should be avoided in .c files
< #66: FILE: /tmp/f1-30382/bfd_packet.c:66:
< ERROR: do not initialise statics to 0
< #240: FILE: /tmp/f1-30382/bfd_packet.c:240:
< WARNING: Missing a blank line after declarations
< #271: FILE: /tmp/f1-30382/bfd_packet.c:271:
< WARNING: C99 // comments do not match recommendation
< #273: FILE: /tmp/f1-30382/bfd_packet.c:273:
< WARNING: Prefer using '"%s...", __func__' to using 'bfd_recv_ipv4_fp', this function's name, in a string
< #516: FILE: /tmp/f1-30382/bfd_packet.c:516:
< WARNING: Prefer using '"%s...", __func__' to using 'bfd_recv_ipv4_fp', this function's name, in a string
< #532: FILE: /tmp/f1-30382/bfd_packet.c:532:
< WARNING: C99 // comments do not match recommendation
< #1509: FILE: /tmp/f1-30382/bfd_packet.c:1509:
< WARNING: C99 // comments do not match recommendation
< #1535: FILE: /tmp/f1-30382/bfd_packet.c:1535:
< ERROR: bzero() is deprecated; use memset()#1586: FILE: /tmp/f1-30382/bfd_packet.c:1586:
< +		bzero(&arpreq_, sizeof(struct arpreq));
< 
< ERROR: strcpy() is error-prone; please use strlcpy()#1589: FILE: /tmp/f1-30382/bfd_packet.c:1589:
< +		strcpy(arpreq_.arp_dev, ifp->name);
<

rzalamena

Thanks for implementing the BFD echo the correct way, please make the adjustments to pass FRR coding standards/style and CI.

bfdd/bfd_packet.c

bfdd/bfd.c

bfdd/bfd_packet.c

rzalamena · 2022-06-08T19:10:06Z

bfdd/bfd_packet.c

+		memcpy(&addr->sin_addr.s_addr, &peer->sa_sin.sin_addr, 4);
+		strcpy(arpreq_.arp_dev, ifp->name);
+
+		if (ioctl(sd, SIOCGARP, &arpreq_) < 0) {


This ioctl is Linux specific, so this could should either be adapted or made Linux specific.

there is an ARP API that has been developed for NHRP.
what about using ZEBRA_NEIGH_DISCOVER ?

@pguibert6WIND I'm not familiar with NHRP, but it seems ZEBRA_NEIGH_DISCOVER doesn't return anything even as async response. How can we get the peer MAC address this way? Capture the ARP request response?

bfdd/bfd_packet.c

NetDEF-CI · 2022-06-08T21:07:27Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5824/frr-source'
bfdd/bfd_packet.c: In function 'bp_echo_send_fp':
bfdd/bfd_packet.c:152:21: error: storage size of 'sadr_ll' isn't known
In file included from /usr/include/machine/endian.h:6,
bfdd/bfd_packet.c:163:31: error: 'ETH_P_IP' undeclared (first use in this function)
bfdd/bfd_packet.c:163:31: note: each undeclared identifier is reported only once for each function it appears in
bfdd/bfd_packet.c:152:21: error: unused variable 'sadr_ll' [-Werror=unused-variable]
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:217:5: error: 'struct udphdr' has no member named 'check'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/CI009BUILD/config.log/config.log.gz

NetBSD 9 amd64 build: Failed (click for details)

NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.5824/frr-source'
bfdd/bfd_packet.c: In function 'bp_echo_send_fp':
bfdd/bfd_packet.c:152:21: error: storage size of 'sadr_ll' isn't known
In file included from /usr/include/stdint.h:35:0,
bfdd/bfd_packet.c:163:31: error: 'ETH_P_IP' undeclared (first use in this function); did you mean 'TH_FIN'?
bfdd/bfd_packet.c:163:31: note: each undeclared identifier is reported only once for each function it appears in
bfdd/bfd_packet.c:152:21: error: unused variable 'sadr_ll' [-Werror=unused-variable]
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:217:5: error: 'struct udphdr' has no member named 'check'

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/CI012BUILD/config.status/config.status

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.5824/frr-source'
bfdd/bfd_packet.c:152:21: error: variable has incomplete type 'struct sockaddr_ll'
bfdd/bfd_packet.c:152:9: note: forward declaration of 'struct sockaddr_ll'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:217:7: error: no member named 'check' in 'struct udphdr'

OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/CI011BUILD/config.status/config.status
OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/CI011BUILD/config.log/config.log.gz

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5824/frr-source'
bfdd/bfd_packet.c: In function 'bp_echo_send_fp':
bfdd/bfd_packet.c:152:21: error: storage size of 'sadr_ll' isn't known
In file included from /usr/include/machine/endian.h:6:0,
bfdd/bfd_packet.c:163:31: error: 'ETH_P_IP' undeclared (first use in this function); did you mean 'TH_FIN'?
bfdd/bfd_packet.c:163:31: note: each undeclared identifier is reported only once for each function it appears in
bfdd/bfd_packet.c:152:21: error: unused variable 'sadr_ll' [-Werror=unused-variable]
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:217:5: error: 'struct udphdr' has no member named 'check'

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/FBSD12AMD64/config.log/config.log.gz

Successful on other platforms/tests

Ubuntu 22.04 amd64 build
Fedora 29 amd64 build
Ubuntu 18.04 arm8 build
Debian 9 amd64 build
Ubuntu 20.04 amd64 build
Ubuntu 18.04 ppc64le build
Debian 10 amd64 build
Ubuntu 16.04 arm7 build
CentOS 7 amd64 build
Ubuntu 16.04 i386 build
Ubuntu 18.04 i386 build
Ubuntu 18.04 amd64 build
Ubuntu 18.04 arm7 build
Debian 11 amd64 build
Ubuntu 16.04 arm8 build
Redhat 9 amd64 build
Ubuntu 16.04 amd64 build
Redhat 8 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5824/frr-source'
bfdd/bfd_packet.c: In function 'bp_echo_send_fp':
bfdd/bfd_packet.c:152:21: error: storage size of 'sadr_ll' isn't known
In file included from /usr/include/machine/endian.h:6,
bfdd/bfd_packet.c:163:31: error: 'ETH_P_IP' undeclared (first use in this function)
bfdd/bfd_packet.c:163:31: note: each undeclared identifier is reported only once for each function it appears in
bfdd/bfd_packet.c:152:21: error: unused variable 'sadr_ll' [-Werror=unused-variable]
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:217:5: error: 'struct udphdr' has no member named 'check'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/CI009BUILD/config.log/config.log.gz

NetBSD 9 amd64 build: Failed (click for details)

NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.5824/frr-source'
bfdd/bfd_packet.c: In function 'bp_echo_send_fp':
bfdd/bfd_packet.c:152:21: error: storage size of 'sadr_ll' isn't known
In file included from /usr/include/stdint.h:35:0,
bfdd/bfd_packet.c:163:31: error: 'ETH_P_IP' undeclared (first use in this function); did you mean 'TH_FIN'?
bfdd/bfd_packet.c:163:31: note: each undeclared identifier is reported only once for each function it appears in
bfdd/bfd_packet.c:152:21: error: unused variable 'sadr_ll' [-Werror=unused-variable]
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:217:5: error: 'struct udphdr' has no member named 'check'

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/CI012BUILD/config.status/config.status

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.5824/frr-source'
bfdd/bfd_packet.c:152:21: error: variable has incomplete type 'struct sockaddr_ll'
bfdd/bfd_packet.c:152:9: note: forward declaration of 'struct sockaddr_ll'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:163:31: error: use of undeclared identifier 'ETH_P_IP'
bfdd/bfd_packet.c:217:7: error: no member named 'check' in 'struct udphdr'

OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/CI011BUILD/config.status/config.status
OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/CI011BUILD/config.log/config.log.gz

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5824/frr-source'
bfdd/bfd_packet.c: In function 'bp_echo_send_fp':
bfdd/bfd_packet.c:152:21: error: storage size of 'sadr_ll' isn't known
In file included from /usr/include/machine/endian.h:6:0,
bfdd/bfd_packet.c:163:31: error: 'ETH_P_IP' undeclared (first use in this function); did you mean 'TH_FIN'?
bfdd/bfd_packet.c:163:31: note: each undeclared identifier is reported only once for each function it appears in
bfdd/bfd_packet.c:152:21: error: unused variable 'sadr_ll' [-Werror=unused-variable]
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:217:5: error: 'struct udphdr' has no member named 'check'

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5824/artifact/FBSD12AMD64/config.log/config.log.gz

Report for bfd_packet.c | 25 issues
===============================================
< WARNING: externs should be avoided in .c files
< #52: FILE: /tmp/f1-32014/bfd_packet.c:52:
< WARNING: externs should be avoided in .c files
< #62: FILE: /tmp/f1-32014/bfd_packet.c:62:
< WARNING: externs should be avoided in .c files
< #64: FILE: /tmp/f1-32014/bfd_packet.c:64:
< WARNING: externs should be avoided in .c files
< #66: FILE: /tmp/f1-32014/bfd_packet.c:66:
< ERROR: do not initialise statics to 0
< #240: FILE: /tmp/f1-32014/bfd_packet.c:240:
< WARNING: Missing a blank line after declarations
< #271: FILE: /tmp/f1-32014/bfd_packet.c:271:
< WARNING: C99 // comments do not match recommendation
< #273: FILE: /tmp/f1-32014/bfd_packet.c:273:
< WARNING: Prefer using '"%s...", __func__' to using 'bfd_recv_ipv4_fp', this function's name, in a string
< #516: FILE: /tmp/f1-32014/bfd_packet.c:516:
< WARNING: Prefer using '"%s...", __func__' to using 'bfd_recv_ipv4_fp', this function's name, in a string
< #532: FILE: /tmp/f1-32014/bfd_packet.c:532:
< WARNING: C99 // comments do not match recommendation
< #1509: FILE: /tmp/f1-32014/bfd_packet.c:1509:
< WARNING: C99 // comments do not match recommendation
< #1535: FILE: /tmp/f1-32014/bfd_packet.c:1535:
< ERROR: bzero() is deprecated; use memset()#1586: FILE: /tmp/f1-32014/bfd_packet.c:1586:
< +		bzero(&arpreq_, sizeof(struct arpreq));
<

pguibert6WIND

The commit log is not clear enough.
it seems we are not compliant yet with RFC (as per the text "Current implementation of echo mode works only when the peer is also FRR for IPv6"), but the commit log says "add IPv4 BFD echo support that matches RFC". So we can think that we are compliant with other vendors.
all system calls on BFDD should be wrapped to zebra. No ioctl get ARP requested from inside BFD.

pguibert6WIND · 2022-06-09T07:43:34Z

bfdd/bfd_packet.c

+		memcpy(&addr->sin_addr.s_addr, &peer->sa_sin.sin_addr, 4);
+		strcpy(arpreq_.arp_dev, ifp->name);
+
+		if (ioctl(sd, SIOCGARP, &arpreq_) < 0) {


there is an ARP API that has been developed for NHRP.
what about using ZEBRA_NEIGH_DISCOVER ?

NetDEF-CI · 2022-06-09T16:18:20Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

NetBSD 9 amd64 build: Failed (click for details)

NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.5842/frr-source'
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:214:5: error: 'struct udphdr' has no member named 'check'
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:237:5: error: "BFD_LINUX" is not defined, evaluates to 0 [-Werror=undef]
 #if BFD_LINUX
bfdd/bfd_packet.c: In function 'bfd_recv_cb':
bfdd/bfd_packet.c:926:4: error: implicit declaration of function 'bfd_peer_mac_set'; did you mean 'bp_peer_socket'? [-Werror=implicit-function-declaration]
bfdd/bfd_packet.c: At top level:

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/CI012BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5842/frr-source'
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:214:5: error: 'struct udphdr' has no member named 'check'
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:237:5: error: "BFD_LINUX" is not defined, evaluates to 0 [-Werror=undef]
 #if BFD_LINUX
bfdd/bfd_packet.c: In function 'bfd_recv_cb':
bfdd/bfd_packet.c:926:4: error: implicit declaration of function 'bfd_peer_mac_set'; did you mean 'bp_peer_socket'? [-Werror=implicit-function-declaration]
bfdd/bfd_packet.c: At top level:

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/FBSD12AMD64/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.5842/frr-source'
bfdd/bfd_packet.c:214:7: error: no member named 'check' in 'struct udphdr'
bfdd/bfd_packet.c:237:5: error: 'BFD_LINUX' is not defined, evaluates to 0 [-Werror,-Wundef]
#if BFD_LINUX
bfdd/bfd_packet.c:926:4: error: implicit declaration of function 'bfd_peer_mac_set' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
bfdd/bfd_packet.c:1507:32: error: array has incomplete element type 'struct sock_filter'
struct sock_filter my_filterudp[] = {
bfdd/bfd_packet.c:1507:8: note: forward declaration of 'struct sock_filter'

OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/CI011BUILD/config.status/config.status
OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/CI011BUILD/config.log/config.log.gz

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5842/frr-source'
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:214:5: error: 'struct udphdr' has no member named 'check'
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:237:5: error: "BFD_LINUX" is not defined, evaluates to 0 [-Werror=undef]
bfdd/bfd_packet.c: In function 'bfd_recv_cb':
bfdd/bfd_packet.c:926:4: error: implicit declaration of function 'bfd_peer_mac_set'; did you mean 'bp_peer_socket'? [-Werror=implicit-function-declaration]
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:1507:20: error: array type has incomplete element type 'struct sock_filter'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/CI009BUILD/config.log/config.log.gz

Successful on other platforms/tests

Ubuntu 18.04 amd64 build
Ubuntu 16.04 arm8 build
Debian 11 amd64 build
Ubuntu 18.04 i386 build
Ubuntu 16.04 amd64 build
Ubuntu 18.04 arm7 build
CentOS 7 amd64 build
Ubuntu 16.04 i386 build
Fedora 29 amd64 build
Ubuntu 20.04 amd64 build
Ubuntu 18.04 arm8 build
Debian 9 amd64 build
Redhat 8 amd64 build
Redhat 9 amd64 build
Debian 10 amd64 build
Ubuntu 18.04 ppc64le build
Ubuntu 16.04 arm7 build
Ubuntu 22.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

NetBSD 9 amd64 build: Failed (click for details)

NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.5842/frr-source'
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:214:5: error: 'struct udphdr' has no member named 'check'
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:237:5: error: "BFD_LINUX" is not defined, evaluates to 0 [-Werror=undef]
 #if BFD_LINUX
bfdd/bfd_packet.c: In function 'bfd_recv_cb':
bfdd/bfd_packet.c:926:4: error: implicit declaration of function 'bfd_peer_mac_set'; did you mean 'bp_peer_socket'? [-Werror=implicit-function-declaration]
bfdd/bfd_packet.c: At top level:

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/CI012BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5842/frr-source'
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:214:5: error: 'struct udphdr' has no member named 'check'
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:237:5: error: "BFD_LINUX" is not defined, evaluates to 0 [-Werror=undef]
 #if BFD_LINUX
bfdd/bfd_packet.c: In function 'bfd_recv_cb':
bfdd/bfd_packet.c:926:4: error: implicit declaration of function 'bfd_peer_mac_set'; did you mean 'bp_peer_socket'? [-Werror=implicit-function-declaration]
bfdd/bfd_packet.c: At top level:

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/FBSD12AMD64/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.5842/frr-source'
bfdd/bfd_packet.c:214:7: error: no member named 'check' in 'struct udphdr'
bfdd/bfd_packet.c:237:5: error: 'BFD_LINUX' is not defined, evaluates to 0 [-Werror,-Wundef]
#if BFD_LINUX
bfdd/bfd_packet.c:926:4: error: implicit declaration of function 'bfd_peer_mac_set' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
bfdd/bfd_packet.c:1507:32: error: array has incomplete element type 'struct sock_filter'
struct sock_filter my_filterudp[] = {
bfdd/bfd_packet.c:1507:8: note: forward declaration of 'struct sock_filter'

OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/CI011BUILD/config.status/config.status
OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/CI011BUILD/config.log/config.log.gz

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5842/frr-source'
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:214:5: error: 'struct udphdr' has no member named 'check'
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:237:5: error: "BFD_LINUX" is not defined, evaluates to 0 [-Werror=undef]
bfdd/bfd_packet.c: In function 'bfd_recv_cb':
bfdd/bfd_packet.c:926:4: error: implicit declaration of function 'bfd_peer_mac_set'; did you mean 'bp_peer_socket'? [-Werror=implicit-function-declaration]
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:1507:20: error: array type has incomplete element type 'struct sock_filter'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5842/artifact/CI009BUILD/config.log/config.log.gz

Report for bfd_packet.c | 25 issues
===============================================
< WARNING: externs should be avoided in .c files
< #63: FILE: /tmp/f1-26969/bfd_packet.c:63:
< WARNING: externs should be avoided in .c files
< #65: FILE: /tmp/f1-26969/bfd_packet.c:65:
< WARNING: externs should be avoided in .c files
< #67: FILE: /tmp/f1-26969/bfd_packet.c:67:
< ERROR: do not initialise statics to 0
< #238: FILE: /tmp/f1-26969/bfd_packet.c:238:
< WARNING: Missing a blank line after declarations
< #269: FILE: /tmp/f1-26969/bfd_packet.c:269:
< WARNING: C99 // comments do not match recommendation
< #271: FILE: /tmp/f1-26969/bfd_packet.c:271:
< WARNING: Prefer using '"%s...", __func__' to using 'bfd_recv_ipv4_fp', this function's name, in a string
< #506: FILE: /tmp/f1-26969/bfd_packet.c:506:
< WARNING: Prefer using '"%s...", __func__' to using 'bfd_recv_ipv4_fp', this function's name, in a string
< #522: FILE: /tmp/f1-26969/bfd_packet.c:522:
< ERROR: exactly one space required after that #ifdef
< #1029: FILE: /tmp/f1-26969/bfd_packet.c:1029:
< WARNING: C99 // comments do not match recommendation
< #1506: FILE: /tmp/f1-26969/bfd_packet.c:1506:
< WARNING: C99 // comments do not match recommendation
< #1539: FILE: /tmp/f1-26969/bfd_packet.c:1539:
< ERROR: bzero() is deprecated; use memset()#1595: FILE: /tmp/f1-26969/bfd_packet.c:1595:
< +		bzero(&arpreq_, sizeof(struct arpreq));
<

NetDEF-CI · 2022-06-09T16:24:42Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

NetBSD 9 amd64 build: Failed (click for details)

NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.5843/frr-source'
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:214:5: error: 'struct udphdr' has no member named 'check'
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:237:5: error: "BFD_LINUX" is not defined, evaluates to 0 [-Werror=undef]
 #if BFD_LINUX
bfdd/bfd_packet.c: In function 'bfd_recv_cb':
bfdd/bfd_packet.c:926:4: error: implicit declaration of function 'bfd_peer_mac_set'; did you mean 'bp_peer_socket'? [-Werror=implicit-function-declaration]
bfdd/bfd_packet.c: At top level:

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/CI012BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5843/frr-source'
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:214:5: error: 'struct udphdr' has no member named 'check'
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:237:5: error: "BFD_LINUX" is not defined, evaluates to 0 [-Werror=undef]
 #if BFD_LINUX
bfdd/bfd_packet.c: In function 'bfd_recv_cb':
bfdd/bfd_packet.c:926:4: error: implicit declaration of function 'bfd_peer_mac_set'; did you mean 'bp_peer_socket'? [-Werror=implicit-function-declaration]
bfdd/bfd_packet.c: At top level:

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/FBSD12AMD64/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.5843/frr-source'
bfdd/bfd_packet.c:214:7: error: no member named 'check' in 'struct udphdr'
bfdd/bfd_packet.c:237:5: error: 'BFD_LINUX' is not defined, evaluates to 0 [-Werror,-Wundef]
#if BFD_LINUX
bfdd/bfd_packet.c:926:4: error: implicit declaration of function 'bfd_peer_mac_set' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
bfdd/bfd_packet.c:1507:32: error: array has incomplete element type 'struct sock_filter'
struct sock_filter my_filterudp[] = {
bfdd/bfd_packet.c:1507:8: note: forward declaration of 'struct sock_filter'

OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/CI011BUILD/config.status/config.status
OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/CI011BUILD/config.log/config.log.gz

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5843/frr-source'
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:214:5: error: 'struct udphdr' has no member named 'check'
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:237:5: error: "BFD_LINUX" is not defined, evaluates to 0 [-Werror=undef]
bfdd/bfd_packet.c: In function 'bfd_recv_cb':
bfdd/bfd_packet.c:926:4: error: implicit declaration of function 'bfd_peer_mac_set'; did you mean 'bp_peer_socket'? [-Werror=implicit-function-declaration]
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:1507:20: error: array type has incomplete element type 'struct sock_filter'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/CI009BUILD/config.log/config.log.gz

Successful on other platforms/tests

Ubuntu 16.04 arm8 build
Ubuntu 18.04 amd64 build
Ubuntu 16.04 amd64 build
Ubuntu 18.04 i386 build
CentOS 7 amd64 build
Ubuntu 18.04 arm7 build
Debian 11 amd64 build
Ubuntu 16.04 i386 build
Fedora 29 amd64 build
Redhat 8 amd64 build
Ubuntu 18.04 arm8 build
Debian 9 amd64 build
Debian 10 amd64 build
Ubuntu 20.04 amd64 build
Redhat 9 amd64 build
Ubuntu 18.04 ppc64le build
Ubuntu 16.04 arm7 build
Ubuntu 22.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

NetBSD 9 amd64 build: Failed (click for details)

NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.5843/frr-source'
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:214:5: error: 'struct udphdr' has no member named 'check'
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:237:5: error: "BFD_LINUX" is not defined, evaluates to 0 [-Werror=undef]
 #if BFD_LINUX
bfdd/bfd_packet.c: In function 'bfd_recv_cb':
bfdd/bfd_packet.c:926:4: error: implicit declaration of function 'bfd_peer_mac_set'; did you mean 'bp_peer_socket'? [-Werror=implicit-function-declaration]
bfdd/bfd_packet.c: At top level:

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/CI012BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5843/frr-source'
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:214:5: error: 'struct udphdr' has no member named 'check'
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:237:5: error: "BFD_LINUX" is not defined, evaluates to 0 [-Werror=undef]
 #if BFD_LINUX
bfdd/bfd_packet.c: In function 'bfd_recv_cb':
bfdd/bfd_packet.c:926:4: error: implicit declaration of function 'bfd_peer_mac_set'; did you mean 'bp_peer_socket'? [-Werror=implicit-function-declaration]
bfdd/bfd_packet.c: At top level:

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/FBSD12AMD64/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.5843/frr-source'
bfdd/bfd_packet.c:214:7: error: no member named 'check' in 'struct udphdr'
bfdd/bfd_packet.c:237:5: error: 'BFD_LINUX' is not defined, evaluates to 0 [-Werror,-Wundef]
#if BFD_LINUX
bfdd/bfd_packet.c:926:4: error: implicit declaration of function 'bfd_peer_mac_set' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
bfdd/bfd_packet.c:1507:32: error: array has incomplete element type 'struct sock_filter'
struct sock_filter my_filterudp[] = {
bfdd/bfd_packet.c:1507:8: note: forward declaration of 'struct sock_filter'

OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/CI011BUILD/config.status/config.status
OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/CI011BUILD/config.log/config.log.gz

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5843/frr-source'
bfdd/bfd_packet.c: In function 'bfd_pkt_checksum':
bfdd/bfd_packet.c:214:5: error: 'struct udphdr' has no member named 'check'
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:237:5: error: "BFD_LINUX" is not defined, evaluates to 0 [-Werror=undef]
bfdd/bfd_packet.c: In function 'bfd_recv_cb':
bfdd/bfd_packet.c:926:4: error: implicit declaration of function 'bfd_peer_mac_set'; did you mean 'bp_peer_socket'? [-Werror=implicit-function-declaration]
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:1507:20: error: array type has incomplete element type 'struct sock_filter'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5843/artifact/CI009BUILD/config.log/config.log.gz

Report for bfd_packet.c | 23 issues
===============================================
< WARNING: externs should be avoided in .c files
< #63: FILE: /tmp/f1-22281/bfd_packet.c:63:
< WARNING: externs should be avoided in .c files
< #65: FILE: /tmp/f1-22281/bfd_packet.c:65:
< WARNING: externs should be avoided in .c files
< #67: FILE: /tmp/f1-22281/bfd_packet.c:67:
< ERROR: do not initialise statics to 0
< #238: FILE: /tmp/f1-22281/bfd_packet.c:238:
< WARNING: Missing a blank line after declarations
< #269: FILE: /tmp/f1-22281/bfd_packet.c:269:
< WARNING: C99 // comments do not match recommendation
< #271: FILE: /tmp/f1-22281/bfd_packet.c:271:
< WARNING: Prefer using '"%s...", __func__' to using 'bfd_recv_ipv4_fp', this function's name, in a string
< #506: FILE: /tmp/f1-22281/bfd_packet.c:506:
< WARNING: Prefer using '"%s...", __func__' to using 'bfd_recv_ipv4_fp', this function's name, in a string
< #522: FILE: /tmp/f1-22281/bfd_packet.c:522:
< WARNING: C99 // comments do not match recommendation
< #1506: FILE: /tmp/f1-22281/bfd_packet.c:1506:
< WARNING: C99 // comments do not match recommendation
< #1539: FILE: /tmp/f1-22281/bfd_packet.c:1539:
< ERROR: bzero() is deprecated; use memset()#1595: FILE: /tmp/f1-22281/bfd_packet.c:1595:
< +		bzero(&arpreq_, sizeof(struct arpreq));
<

bfdd/bfd_packet.c

NetDEF-CI · 2022-06-09T18:50:15Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

NetBSD 9 amd64 build: Failed (click for details)

NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.5847/frr-source'
bfdd/bfd_packet.c: In function 'bfd_recv_cb':
bfdd/bfd_packet.c:876:4: error: implicit declaration of function 'bfd_peer_mac_set'; did you mean 'bp_peer_socket'? [-Werror=implicit-function-declaration]
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:1507:20: error: array type has incomplete element type 'struct sock_filter'
 struct sock_filter my_filterudp[] = {
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10322: bfdd/bfd_packet.o] Error 1
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/CI012BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5847/frr-source'
bfdd/bfd_packet.c: In function 'bfd_recv_cb':
bfdd/bfd_packet.c:876:4: error: implicit declaration of function 'bfd_peer_mac_set'; did you mean 'bp_peer_socket'? [-Werror=implicit-function-declaration]
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:1507:20: error: array type has incomplete element type 'struct sock_filter'
 struct sock_filter my_filterudp[] = {
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10318: bfdd/bfd_packet.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/FBSD12AMD64/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.5847/frr-source'
bfdd/bfd_packet.c:876:4: error: implicit declaration of function 'bfd_peer_mac_set' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
bfdd/bfd_packet.c:1507:32: error: array has incomplete element type 'struct sock_filter'
struct sock_filter my_filterudp[] = {
bfdd/bfd_packet.c:1507:8: note: forward declaration of 'struct sock_filter'
struct sock_filter my_filterudp[] = {
2 errors generated.
gmake[1]: *** [Makefile:10321: bfdd/bfd_packet.o] Error 1

OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/CI011BUILD/config.status/config.status
OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/CI011BUILD/config.log/config.log.gz

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5847/frr-source'
bfdd/bfd_packet.c: In function 'bfd_recv_cb':
bfdd/bfd_packet.c:876:4: error: implicit declaration of function 'bfd_peer_mac_set'; did you mean 'bp_peer_socket'? [-Werror=implicit-function-declaration]
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:1507:20: error: array type has incomplete element type 'struct sock_filter'
 1507 | struct sock_filter my_filterudp[] = {
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10321: bfdd/bfd_packet.o] Error 1
/usr/home/ci/cibuild.5847/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/CI009BUILD/config.log/config.log.gz

Successful on other platforms/tests

Ubuntu 18.04 i386 build
Fedora 29 amd64 build
Ubuntu 18.04 arm7 build
Debian 11 amd64 build
Ubuntu 16.04 i386 build
Ubuntu 18.04 arm8 build
Redhat 8 amd64 build
Debian 10 amd64 build
CentOS 7 amd64 build
Ubuntu 16.04 arm7 build
Ubuntu 22.04 amd64 build
Debian 9 amd64 build
Ubuntu 18.04 amd64 build
Ubuntu 16.04 arm8 build
Ubuntu 16.04 amd64 build
Ubuntu 20.04 amd64 build
Redhat 9 amd64 build
Ubuntu 18.04 ppc64le build

Warnings Generated during build:

Checkout code: Successful with additional warnings

NetBSD 9 amd64 build: Failed (click for details)

NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.5847/frr-source'
bfdd/bfd_packet.c: In function 'bfd_recv_cb':
bfdd/bfd_packet.c:876:4: error: implicit declaration of function 'bfd_peer_mac_set'; did you mean 'bp_peer_socket'? [-Werror=implicit-function-declaration]
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:1507:20: error: array type has incomplete element type 'struct sock_filter'
 struct sock_filter my_filterudp[] = {
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10322: bfdd/bfd_packet.o] Error 1
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/CI012BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5847/frr-source'
bfdd/bfd_packet.c: In function 'bfd_recv_cb':
bfdd/bfd_packet.c:876:4: error: implicit declaration of function 'bfd_peer_mac_set'; did you mean 'bp_peer_socket'? [-Werror=implicit-function-declaration]
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:1507:20: error: array type has incomplete element type 'struct sock_filter'
 struct sock_filter my_filterudp[] = {
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10318: bfdd/bfd_packet.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/FBSD12AMD64/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.5847/frr-source'
bfdd/bfd_packet.c:876:4: error: implicit declaration of function 'bfd_peer_mac_set' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
bfdd/bfd_packet.c:1507:32: error: array has incomplete element type 'struct sock_filter'
struct sock_filter my_filterudp[] = {
bfdd/bfd_packet.c:1507:8: note: forward declaration of 'struct sock_filter'
struct sock_filter my_filterudp[] = {
2 errors generated.
gmake[1]: *** [Makefile:10321: bfdd/bfd_packet.o] Error 1

OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/CI011BUILD/config.status/config.status
OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/CI011BUILD/config.log/config.log.gz

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.5847/frr-source'
bfdd/bfd_packet.c: In function 'bfd_recv_cb':
bfdd/bfd_packet.c:876:4: error: implicit declaration of function 'bfd_peer_mac_set'; did you mean 'bp_peer_socket'? [-Werror=implicit-function-declaration]
bfdd/bfd_packet.c: At top level:
bfdd/bfd_packet.c:1507:20: error: array type has incomplete element type 'struct sock_filter'
 1507 | struct sock_filter my_filterudp[] = {
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10321: bfdd/bfd_packet.o] Error 1
/usr/home/ci/cibuild.5847/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5847/artifact/CI009BUILD/config.log/config.log.gz

Report for bfd_packet.c | 23 issues
===============================================
< WARNING: externs should be avoided in .c files
< #63: FILE: /tmp/f1-27226/bfd_packet.c:63:
< WARNING: externs should be avoided in .c files
< #65: FILE: /tmp/f1-27226/bfd_packet.c:65:
< WARNING: externs should be avoided in .c files
< #67: FILE: /tmp/f1-27226/bfd_packet.c:67:
< ERROR: do not initialise statics to 0
< #188: FILE: /tmp/f1-27226/bfd_packet.c:188:
< WARNING: Missing a blank line after declarations
< #219: FILE: /tmp/f1-27226/bfd_packet.c:219:
< WARNING: C99 // comments do not match recommendation
< #221: FILE: /tmp/f1-27226/bfd_packet.c:221:
< WARNING: Prefer using '"%s...", __func__' to using 'bfd_recv_ipv4_fp', this function's name, in a string
< #456: FILE: /tmp/f1-27226/bfd_packet.c:456:
< WARNING: Prefer using '"%s...", __func__' to using 'bfd_recv_ipv4_fp', this function's name, in a string
< #472: FILE: /tmp/f1-27226/bfd_packet.c:472:
< WARNING: C99 // comments do not match recommendation
< #1506: FILE: /tmp/f1-27226/bfd_packet.c:1506:
< WARNING: C99 // comments do not match recommendation
< #1539: FILE: /tmp/f1-27226/bfd_packet.c:1539:
< ERROR: bzero() is deprecated; use memset()#1595: FILE: /tmp/f1-27226/bfd_packet.c:1595:
< +		bzero(&arpreq_, sizeof(struct arpreq));
<

NetDEF-CI · 2022-06-09T19:00:17Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

NetBSD 9 amd64 build: Failed (click for details)

NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.5848/frr-source'
bfdd/bfd_packet.c:1509:20: error: array type has incomplete element type 'struct sock_filter'
 struct sock_filter my_filterudp[] = {
gmake[1]: *** [Makefile:10322: bfdd/bfd_packet.o] Error 1
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:16704: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.
doc/user/_build/texinfo/frr.texi:16714: warning: @image file `frr-figures/fig_topologies_full.txt' (for text) unreadable: No such file or directory.

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/CI012BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/usr/home/ci/cibuild.5848/frr-source'
bfdd/bfd_packet.c:1509:20: error: array type has incomplete element type 'struct sock_filter'
 struct sock_filter my_filterudp[] = {
gmake[1]: *** [Makefile:10318: bfdd/bfd_packet.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/usr/home/ci/cibuild.5848/frr-source'
gmake: *** [Makefile:6350: all] Error 2

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/FBSD12AMD64/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.5848/frr-source'
bfdd/bfd_packet.c:1509:32: error: array has incomplete element type 'struct sock_filter'
struct sock_filter my_filterudp[] = {
bfdd/bfd_packet.c:1509:8: note: forward declaration of 'struct sock_filter'
struct sock_filter my_filterudp[] = {
1 error generated.
gmake[1]: *** [Makefile:10321: bfdd/bfd_packet.o] Error 1
/home/ci/cibuild.5848/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd

OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/CI011BUILD/config.status/config.status
OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/CI011BUILD/config.log/config.log.gz

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/usr/home/ci/cibuild.5848/frr-source'
bfdd/bfd_packet.c:1509:20: error: array type has incomplete element type 'struct sock_filter'
 1509 | struct sock_filter my_filterudp[] = {
gmake[1]: *** [Makefile:10321: bfdd/bfd_packet.o] Error 1
/usr/home/ci/cibuild.5848/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/usr/home/ci/cibuild.5848/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/usr/home/ci/cibuild.5848/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd
/usr/home/ci/cibuild.5848/frr-source/doc/user/isisd.rst:67: WARNING: duplicate clicmd description of log-adjacency-changes, other instance in fabricd

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/CI009BUILD/config.log/config.log.gz

Successful on other platforms/tests

Ubuntu 18.04 ppc64le build
Ubuntu 16.04 i386 build
Fedora 29 amd64 build
Debian 11 amd64 build
Ubuntu 18.04 arm7 build
Ubuntu 18.04 arm8 build
Redhat 8 amd64 build
Debian 10 amd64 build
Ubuntu 16.04 arm7 build
CentOS 7 amd64 build
Ubuntu 18.04 i386 build
Ubuntu 18.04 amd64 build
Ubuntu 22.04 amd64 build
Debian 9 amd64 build
Redhat 9 amd64 build
Ubuntu 16.04 arm8 build
Ubuntu 20.04 amd64 build
Ubuntu 16.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

NetBSD 9 amd64 build: Failed (click for details)

NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.5848/frr-source'
bfdd/bfd_packet.c:1509:20: error: array type has incomplete element type 'struct sock_filter'
 struct sock_filter my_filterudp[] = {
gmake[1]: *** [Makefile:10322: bfdd/bfd_packet.o] Error 1
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:16704: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.
doc/user/_build/texinfo/frr.texi:16714: warning: @image file `frr-figures/fig_topologies_full.txt' (for text) unreadable: No such file or directory.

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/CI012BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/usr/home/ci/cibuild.5848/frr-source'
bfdd/bfd_packet.c:1509:20: error: array type has incomplete element type 'struct sock_filter'
 struct sock_filter my_filterudp[] = {
gmake[1]: *** [Makefile:10318: bfdd/bfd_packet.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/usr/home/ci/cibuild.5848/frr-source'
gmake: *** [Makefile:6350: all] Error 2

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/FBSD12AMD64/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.5848/frr-source'
bfdd/bfd_packet.c:1509:32: error: array has incomplete element type 'struct sock_filter'
struct sock_filter my_filterudp[] = {
bfdd/bfd_packet.c:1509:8: note: forward declaration of 'struct sock_filter'
struct sock_filter my_filterudp[] = {
1 error generated.
gmake[1]: *** [Makefile:10321: bfdd/bfd_packet.o] Error 1
/home/ci/cibuild.5848/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd

OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/CI011BUILD/config.status/config.status
OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/CI011BUILD/config.log/config.log.gz

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/usr/home/ci/cibuild.5848/frr-source'
bfdd/bfd_packet.c:1509:20: error: array type has incomplete element type 'struct sock_filter'
 1509 | struct sock_filter my_filterudp[] = {
gmake[1]: *** [Makefile:10321: bfdd/bfd_packet.o] Error 1
/usr/home/ci/cibuild.5848/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/usr/home/ci/cibuild.5848/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/usr/home/ci/cibuild.5848/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd
/usr/home/ci/cibuild.5848/frr-source/doc/user/isisd.rst:67: WARNING: duplicate clicmd description of log-adjacency-changes, other instance in fabricd

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5848/artifact/CI009BUILD/config.log/config.log.gz

Report for bfd_packet.c | 23 issues
===============================================
< WARNING: externs should be avoided in .c files
< #63: FILE: /tmp/f1-21355/bfd_packet.c:63:
< WARNING: externs should be avoided in .c files
< #65: FILE: /tmp/f1-21355/bfd_packet.c:65:
< WARNING: externs should be avoided in .c files
< #67: FILE: /tmp/f1-21355/bfd_packet.c:67:
< ERROR: do not initialise statics to 0
< #188: FILE: /tmp/f1-21355/bfd_packet.c:188:
< WARNING: Missing a blank line after declarations
< #219: FILE: /tmp/f1-21355/bfd_packet.c:219:
< WARNING: C99 // comments do not match recommendation
< #221: FILE: /tmp/f1-21355/bfd_packet.c:221:
< WARNING: Prefer using '"%s...", __func__' to using 'bfd_recv_ipv4_fp', this function's name, in a string
< #456: FILE: /tmp/f1-21355/bfd_packet.c:456:
< WARNING: Prefer using '"%s...", __func__' to using 'bfd_recv_ipv4_fp', this function's name, in a string
< #472: FILE: /tmp/f1-21355/bfd_packet.c:472:
< WARNING: C99 // comments do not match recommendation
< #1508: FILE: /tmp/f1-21355/bfd_packet.c:1508:
< WARNING: C99 // comments do not match recommendation
< #1541: FILE: /tmp/f1-21355/bfd_packet.c:1541:
< ERROR: bzero() is deprecated; use memset()#1597: FILE: /tmp/f1-21355/bfd_packet.c:1597:
< +		bzero(&arpreq_, sizeof(struct arpreq));
<

NetDEF-CI · 2022-06-09T21:33:40Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5849/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-5849/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5849/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-5849/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5849/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 6
IPv4 ldp protocol on Ubuntu 18.04
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 7
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 arm8 part 4
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Addresssanitizer topotests part 2
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 8
IPv4 protocols on Ubuntu 18.04
Topotests debian 10 amd64 part 7
Static analyzer (clang)
Topotests Ubuntu 18.04 arm8 part 0
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 9
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 5
Addresssanitizer topotests part 6
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Topotests debian 10 amd64 part 1
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 5
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 4

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-5849/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5849/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-5849/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5849/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Report for bfd_packet.c | 23 issues
===============================================
< WARNING: externs should be avoided in .c files
< #63: FILE: /tmp/f1-7482/bfd_packet.c:63:
< WARNING: externs should be avoided in .c files
< #65: FILE: /tmp/f1-7482/bfd_packet.c:65:
< WARNING: externs should be avoided in .c files
< #67: FILE: /tmp/f1-7482/bfd_packet.c:67:
< ERROR: do not initialise statics to 0
< #188: FILE: /tmp/f1-7482/bfd_packet.c:188:
< WARNING: Missing a blank line after declarations
< #219: FILE: /tmp/f1-7482/bfd_packet.c:219:
< WARNING: C99 // comments do not match recommendation
< #221: FILE: /tmp/f1-7482/bfd_packet.c:221:
< WARNING: Prefer using '"%s...", __func__' to using 'bfd_recv_ipv4_fp', this function's name, in a string
< #456: FILE: /tmp/f1-7482/bfd_packet.c:456:
< WARNING: Prefer using '"%s...", __func__' to using 'bfd_recv_ipv4_fp', this function's name, in a string
< #472: FILE: /tmp/f1-7482/bfd_packet.c:472:
< WARNING: C99 // comments do not match recommendation
< #1509: FILE: /tmp/f1-7482/bfd_packet.c:1509:
< WARNING: C99 // comments do not match recommendation
< #1536: FILE: /tmp/f1-7482/bfd_packet.c:1536:
< ERROR: bzero() is deprecated; use memset()#1607: FILE: /tmp/f1-7482/bfd_packet.c:1607:
< +		bzero(&arpreq_, sizeof(struct arpreq));
<

NetDEF-CI · 2022-06-10T19:04:20Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5874/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for bfd_packet.c | 23 issues
===============================================
< WARNING: externs should be avoided in .c files
< #63: FILE: /tmp/f1-4883/bfd_packet.c:63:
< WARNING: externs should be avoided in .c files
< #65: FILE: /tmp/f1-4883/bfd_packet.c:65:
< WARNING: externs should be avoided in .c files
< #67: FILE: /tmp/f1-4883/bfd_packet.c:67:
< ERROR: do not initialise statics to 0
< #188: FILE: /tmp/f1-4883/bfd_packet.c:188:
< WARNING: Missing a blank line after declarations
< #219: FILE: /tmp/f1-4883/bfd_packet.c:219:
< WARNING: C99 // comments do not match recommendation
< #221: FILE: /tmp/f1-4883/bfd_packet.c:221:
< WARNING: Prefer using '"%s...", __func__' to using 'bfd_recv_ipv4_fp', this function's name, in a string
< #456: FILE: /tmp/f1-4883/bfd_packet.c:456:
< WARNING: Prefer using '"%s...", __func__' to using 'bfd_recv_ipv4_fp', this function's name, in a string
< #472: FILE: /tmp/f1-4883/bfd_packet.c:472:
< WARNING: C99 // comments do not match recommendation
< #1509: FILE: /tmp/f1-4883/bfd_packet.c:1509:
< WARNING: C99 // comments do not match recommendation
< #1536: FILE: /tmp/f1-4883/bfd_packet.c:1536:
< ERROR: bzero() is deprecated; use memset()#1607: FILE: /tmp/f1-4883/bfd_packet.c:1607:
< +		bzero(&arpreq_, sizeof(struct arpreq));
<

NetDEF-CI · 2022-06-10T20:39:47Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5875/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-5875/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5875/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 8
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 arm8 part 4
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 3
Static analyzer (clang)
IPv4 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 arm8 part 2
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 0
IPv4 ldp protocol on Ubuntu 18.04
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 7
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Debian 10 deb pkg check
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests debian 10 amd64 part 7
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 8
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 i386 part 7
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-5875/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5875/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Report for bfd_packet.c | 8 issues
===============================================
< WARNING: externs should be avoided in .c files
< #63: FILE: /tmp/f1-7149/bfd_packet.c:63:
< WARNING: externs should be avoided in .c files
< #65: FILE: /tmp/f1-7149/bfd_packet.c:65:
< WARNING: externs should be avoided in .c files
< #67: FILE: /tmp/f1-7149/bfd_packet.c:67:
< ERROR: do not initialise statics to 0
< #188: FILE: /tmp/f1-7149/bfd_packet.c:188:

NetDEF-CI · 2022-06-13T22:52:37Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5900/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-5900/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5900/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topotests debian 10 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1DEB10AMD64-5900/test

Topology Tests failed for Topotests debian 10 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5900/artifact/TOPO1DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-5900/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5900/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 1: No useful log found

Successful on other platforms/tests

Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 9
Ubuntu 18.04 deb pkg check
Debian 10 deb pkg check
IPv6 protocols on Ubuntu 18.04
Debian 9 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
IPv4 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 5
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 0
Static analyzer (clang)
Topotests Ubuntu 18.04 i386 part 6
Addresssanitizer topotests part 2
IPv4 ldp protocol on Ubuntu 18.04
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 9
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 6
CentOS 7 rpm pkg check
Fedora 29 rpm pkg check
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 i386 part 5

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-5900/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5900/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topotests debian 10 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1DEB10AMD64-5900/test

Topology Tests failed for Topotests debian 10 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5900/artifact/TOPO1DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-5900/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5900/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 1: No useful log found

Report for bfd_packet.c | 8 issues
===============================================
< WARNING: externs should be avoided in .c files
< #63: FILE: /tmp/f1-8619/bfd_packet.c:63:
< WARNING: externs should be avoided in .c files
< #65: FILE: /tmp/f1-8619/bfd_packet.c:65:
< WARNING: externs should be avoided in .c files
< #67: FILE: /tmp/f1-8619/bfd_packet.c:67:
< ERROR: do not initialise statics to 0
< #188: FILE: /tmp/f1-8619/bfd_packet.c:188:

NetDEF-CI · 2022-06-14T01:27:48Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5901/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Successful on other platforms/tests

Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Debian 9 deb pkg check
Debian 10 deb pkg check
IPv4 protocols on Ubuntu 18.04
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 5
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 4
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 8
Static analyzer (clang)
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 6
IPv4 ldp protocol on Ubuntu 18.04
Topotests debian 10 amd64 part 5
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 6
Topotests debian 10 amd64 part 9
CentOS 7 rpm pkg check
Fedora 29 rpm pkg check
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 8
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 i386 part 5

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Report for bfd_packet.c | 8 issues
===============================================
< WARNING: externs should be avoided in .c files
< #63: FILE: /tmp/f1-18644/bfd_packet.c:63:
< WARNING: externs should be avoided in .c files
< #65: FILE: /tmp/f1-18644/bfd_packet.c:65:
< WARNING: externs should be avoided in .c files
< #67: FILE: /tmp/f1-18644/bfd_packet.c:67:
< ERROR: do not initialise statics to 0
< #188: FILE: /tmp/f1-18644/bfd_packet.c:188:

bfdd/bfd.c

NetDEF-CI · 2022-06-20T18:23:44Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6027/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for bfd.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #751: FILE: /tmp/f1-22662/bfd.c:751:
Report for bfd_packet.c | 8 issues
===============================================
< WARNING: externs should be avoided in .c files
< #64: FILE: /tmp/f1-22662/bfd_packet.c:64:
< WARNING: externs should be avoided in .c files
< #66: FILE: /tmp/f1-22662/bfd_packet.c:66:
< WARNING: externs should be avoided in .c files
< #68: FILE: /tmp/f1-22662/bfd_packet.c:68:
< WARNING: line over 80 characters
< #1568: FILE: /tmp/f1-22662/bfd_packet.c:1568:

NetDEF-CI · 2022-06-21T09:59:54Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6033/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-6033/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6033/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 1
Debian 9 deb pkg check
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 1
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 8
IPv4 protocols on Ubuntu 18.04
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 9
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 5
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 0
Static analyzer (clang)
Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 6
IPv4 ldp protocol on Ubuntu 18.04
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 6
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 5
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 3
CentOS 7 rpm pkg check
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 4
Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 3
IPv6 protocols on Ubuntu 18.04

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-6033/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6033/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Report for bfd_packet.c | 6 issues
===============================================
< WARNING: externs should be avoided in .c files
< #64: FILE: /tmp/f1-17508/bfd_packet.c:64:
< WARNING: externs should be avoided in .c files
< #66: FILE: /tmp/f1-17508/bfd_packet.c:66:
< WARNING: externs should be avoided in .c files
< #68: FILE: /tmp/f1-17508/bfd_packet.c:68:

rzalamena · 2022-06-21T11:00:54Z

CI:rerun ospf basic functionality single area convergence failure

NetDEF-CI · 2022-06-21T15:30:11Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6047/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Static analyzer (clang)
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 5
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 6
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 3
Debian 9 deb pkg check
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests debian 10 amd64 part 0
IPv4 ldp protocol on Ubuntu 18.04
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 2
IPv6 protocols on Ubuntu 18.04
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 8
Debian 10 deb pkg check
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 2
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
IPv4 protocols on Ubuntu 18.04
CentOS 7 rpm pkg check
Addresssanitizer topotests part 9

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Report for bfd_packet.c | 6 issues
===============================================
< WARNING: externs should be avoided in .c files
< #64: FILE: /tmp/f1-21428/bfd_packet.c:64:
< WARNING: externs should be avoided in .c files
< #66: FILE: /tmp/f1-21428/bfd_packet.c:66:
< WARNING: externs should be avoided in .c files
< #68: FILE: /tmp/f1-21428/bfd_packet.c:68:

donaldsharp · 2022-06-21T15:34:39Z

ci:rerun

NetDEF-CI · 2022-06-21T18:57:14Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6062/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-6062/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6062/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-6062/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6062/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 arm8 part 5
Topotests debian 10 amd64 part 1
Fedora 29 rpm pkg check
CentOS 7 rpm pkg check
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 i386 part 5
Static analyzer (clang)
Ubuntu 18.04 deb pkg check
Debian 9 deb pkg check
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 8
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 9
Addresssanitizer topotests part 2
IPv4 ldp protocol on Ubuntu 18.04
Topotests Ubuntu 18.04 arm8 part 2
Ubuntu 20.04 deb pkg check
Ubuntu 16.04 deb pkg check
IPv4 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 i386 part 6
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 7
Debian 10 deb pkg check
Addresssanitizer topotests part 3
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 0

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-6062/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6062/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-6062/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6062/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Report for bfd_packet.c | 6 issues
===============================================
< WARNING: externs should be avoided in .c files
< #64: FILE: /tmp/f1-698/bfd_packet.c:64:
< WARNING: externs should be avoided in .c files
< #66: FILE: /tmp/f1-698/bfd_packet.c:66:
< WARNING: externs should be avoided in .c files
< #68: FILE: /tmp/f1-698/bfd_packet.c:68:

rampxxxx · 2022-06-22T12:27:13Z

ci:rerun

NetDEF-CI · 2022-06-22T14:39:53Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6079/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-6079/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6079/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-6079/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6079/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 0
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Ubuntu 18.04 deb pkg check
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 2
IPv6 protocols on Ubuntu 18.04
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 8
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 arm8 part 3
Debian 9 deb pkg check
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 4
IPv4 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 7
Static analyzer (clang)
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 0
IPv4 ldp protocol on Ubuntu 18.04
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Ubuntu 20.04 deb pkg check
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 5

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-6079/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6079/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-6079/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6079/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Report for bfd_packet.c | 6 issues
===============================================
< WARNING: externs should be avoided in .c files
< #64: FILE: /tmp/f1-7508/bfd_packet.c:64:
< WARNING: externs should be avoided in .c files
< #66: FILE: /tmp/f1-7508/bfd_packet.c:66:
< WARNING: externs should be avoided in .c files
< #68: FILE: /tmp/f1-7508/bfd_packet.c:68:

rampxxxx · 2022-06-23T06:19:04Z

ci:rerun test_bgp_fast_convergence

NetDEF-CI · 2022-06-23T08:31:13Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6097/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6097/artifact/TOPO1U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 1: No useful log found

Successful on other platforms/tests

Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 6
IPv4 ldp protocol on Ubuntu 18.04
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 6
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 5
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 3
CentOS 7 rpm pkg check
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 4
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 9
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 3
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 1
Debian 9 deb pkg check
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 1
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 8
IPv4 protocols on Ubuntu 18.04
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 9
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 5
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 0
Static analyzer (clang)
Topotests debian 10 amd64 part 3

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6097/artifact/TOPO1U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 1: No useful log found

Report for bfd_packet.c | 6 issues
===============================================
< WARNING: externs should be avoided in .c files
< #64: FILE: /tmp/f1-9237/bfd_packet.c:64:
< WARNING: externs should be avoided in .c files
< #66: FILE: /tmp/f1-9237/bfd_packet.c:66:
< WARNING: externs should be avoided in .c files
< #68: FILE: /tmp/f1-9237/bfd_packet.c:68:

rampxxxx · 2022-06-23T11:10:46Z

ci:rerun test_bgp_fast_convergence augmented run_and_expect

NetDEF-CI · 2022-06-23T11:12:37Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6098/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-6098/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6098/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Topotests debian 10 amd64 part 0
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 6
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 1
IPv4 ldp protocol on Ubuntu 18.04
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 5
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 i386 part 2
Fedora 29 rpm pkg check
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Topotests debian 10 amd64 part 8
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 9
Addresssanitizer topotests part 2
IPv6 protocols on Ubuntu 18.04
Static analyzer (clang)
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Topotests debian 10 amd64 part 7
IPv4 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 arm8 part 0
Debian 9 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 9
Ubuntu 20.04 deb pkg check
Debian 10 deb pkg check
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 1
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 5
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 3

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-6098/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6098/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Report for bfd_packet.c | 6 issues
===============================================
< WARNING: externs should be avoided in .c files
< #64: FILE: /tmp/f1-7626/bfd_packet.c:64:
< WARNING: externs should be avoided in .c files
< #66: FILE: /tmp/f1-7626/bfd_packet.c:66:
< WARNING: externs should be avoided in .c files
< #68: FILE: /tmp/f1-7626/bfd_packet.c:68:

NetDEF-CI · 2022-06-23T13:32:18Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6102/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-6102/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6102/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
Topotests debian 10 amd64 part 0
IPv4 ldp protocol on Ubuntu 18.04
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 3
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 3
Topotests debian 10 amd64 part 8
IPv6 protocols on Ubuntu 18.04
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 9
Addresssanitizer topotests part 2
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 4
IPv4 protocols on Ubuntu 18.04
Static analyzer (clang)
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 9
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Debian 9 deb pkg check
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 5
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 6
Ubuntu 20.04 deb pkg check
Topotests debian 10 amd64 part 6
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 4
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 1

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-6102/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6102/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Report for bfd_packet.c | 6 issues
===============================================
< WARNING: externs should be avoided in .c files
< #64: FILE: /tmp/f1-21718/bfd_packet.c:64:
< WARNING: externs should be avoided in .c files
< #66: FILE: /tmp/f1-21718/bfd_packet.c:66:
< WARNING: externs should be avoided in .c files
< #68: FILE: /tmp/f1-21718/bfd_packet.c:68:

bfdd/bfd_packet.c

Modify the existing BFD Echo code to send an Echo message that will be looped in the peers forwarding plane. The existing Echo code only works with other FRR implementations because the Echo packet must go up to BFD to be turned around and forwarded back to the local router. The new BFD Echo code sets the src/dst IP of the packet to be the local router's IP and sets the dest MAC to be the peers MAC address. The peer receives the packet and because it is not it's IP address it forwards it back to the local router. Signed-off-by: Lynne Morrison <lynne.morrison@ibm.com>

NetDEF-CI · 2022-06-27T22:36:58Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6152/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-6152/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6152/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-6152/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6152/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Topotests debian 10 amd64 part 9: Failed (click for details)

Topotests debian 10 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6152/artifact/TOPO9DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 9: No useful log found

Successful on other platforms/tests

Debian 10 deb pkg check
Topotests Ubuntu 18.04 arm8 part 4
IPv6 protocols on Ubuntu 18.04
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 9
Addresssanitizer topotests part 1
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 4
Ubuntu 18.04 deb pkg check
IPv4 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 i386 part 8
Debian 9 deb pkg check
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 8
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 1
Static analyzer (clang)
Topotests Ubuntu 18.04 arm8 part 0
IPv4 ldp protocol on Ubuntu 18.04
Ubuntu 16.04 deb pkg check
Topotests debian 10 amd64 part 2
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 6
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 7
Fedora 29 rpm pkg check
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 7
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 i386 part 0

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-6152/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6152/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-6152/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6152/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Topotests debian 10 amd64 part 9: Failed (click for details)

Topotests debian 10 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6152/artifact/TOPO9DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 9: No useful log found

Report for bfd_packet.c | 6 issues
===============================================
< WARNING: externs should be avoided in .c files
< #64: FILE: /tmp/f1-11648/bfd_packet.c:64:
< WARNING: externs should be avoided in .c files
< #66: FILE: /tmp/f1-11648/bfd_packet.c:66:
< WARNING: externs should be avoided in .c files
< #68: FILE: /tmp/f1-11648/bfd_packet.c:68:

Increase BFD Echo timers to make test stable. Signed-off-by: Lynne Morrison <lynne.morrison@ibm.com>

NetDEF-CI · 2022-06-28T15:27:39Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6166/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for bfd_packet.c | 6 issues
===============================================
< WARNING: externs should be avoided in .c files
< #64: FILE: /tmp/f1-10543/bfd_packet.c:64:
< WARNING: externs should be avoided in .c files
< #66: FILE: /tmp/f1-10543/bfd_packet.c:66:
< WARNING: externs should be avoided in .c files
< #68: FILE: /tmp/f1-10543/bfd_packet.c:68:

rgirada

Looking Good to me.

frrbot bot added the bfd label Jun 8, 2022

github-actions bot added the master label Jun 8, 2022

lynnemorrison force-pushed the feat_bfd_ipv4_echo_fwd_path branch from 7ec96c2 to 0a3a4df Compare June 8, 2022 18:10

rzalamena self-requested a review June 8, 2022 18:15

rzalamena requested changes Jun 8, 2022

View reviewed changes

lynnemorrison force-pushed the feat_bfd_ipv4_echo_fwd_path branch from 0a3a4df to 603c043 Compare June 8, 2022 20:34

pguibert6WIND requested changes Jun 9, 2022

View reviewed changes

lynnemorrison force-pushed the feat_bfd_ipv4_echo_fwd_path branch 2 times, most recently from 753da8d to ecbf9f0 Compare June 9, 2022 15:43

lynnemorrison force-pushed the feat_bfd_ipv4_echo_fwd_path branch from ecbf9f0 to 57fcdaf Compare June 9, 2022 17:27

rzalamena reviewed Jun 9, 2022

View reviewed changes

bfdd/bfd_packet.c Outdated Show resolved Hide resolved

rzalamena reviewed Jun 9, 2022

View reviewed changes

bfdd/bfd_packet.c Outdated Show resolved Hide resolved

lynnemorrison force-pushed the feat_bfd_ipv4_echo_fwd_path branch 2 times, most recently from 35be10b to 71dd76e Compare June 9, 2022 18:48

frrbot bot added the tests Topotests, make check, etc label Jun 10, 2022

lynnemorrison force-pushed the feat_bfd_ipv4_echo_fwd_path branch from 100bfc4 to 46e387c Compare June 10, 2022 18:25

lynnemorrison force-pushed the feat_bfd_ipv4_echo_fwd_path branch from 46e387c to f7d72b2 Compare June 13, 2022 20:39

lynnemorrison force-pushed the feat_bfd_ipv4_echo_fwd_path branch from f7d72b2 to c75cba4 Compare June 13, 2022 23:14

rzalamena reviewed Jun 20, 2022

View reviewed changes

bfdd/bfd.c Show resolved Hide resolved

rampxxxx force-pushed the feat_bfd_ipv4_echo_fwd_path branch from afb8f2c to 2a14f83 Compare June 20, 2022 15:46

rzalamena approved these changes Jun 20, 2022

View reviewed changes

rampxxxx force-pushed the feat_bfd_ipv4_echo_fwd_path branch from 2a14f83 to 94db7ee Compare June 21, 2022 07:05

rampxxxx force-pushed the feat_bfd_ipv4_echo_fwd_path branch from 94db7ee to 3143276 Compare June 23, 2022 08:58

rgirada reviewed Jun 27, 2022

View reviewed changes

bfdd/bfd_packet.c Outdated Show resolved Hide resolved

lynnemorrison force-pushed the feat_bfd_ipv4_echo_fwd_path branch from 3143276 to af07fa3 Compare June 27, 2022 20:23

tests: update timers in BFD VRF test

0fb24aa

Increase BFD Echo timers to make test stable. Signed-off-by: Lynne Morrison <lynne.morrison@ibm.com>

lynnemorrison force-pushed the feat_bfd_ipv4_echo_fwd_path branch from af07fa3 to 0fb24aa Compare June 28, 2022 11:54

lynnemorrison changed the title ~~bfdd: add IPv4 BFD Echo support that matches RFC~~ bfdd: add IPv4 BFD Echo support that loops pkts in forwarding plane Jun 28, 2022

rzalamena requested a review from pguibert6WIND June 29, 2022 14:04

rgirada approved these changes Jun 30, 2022

View reviewed changes

rzalamena merged commit da82615 into FRRouting:master Jul 5, 2022

rzalamena mentioned this pull request Aug 5, 2022

BFDD: Add RTT to BFD IPV4 Echo packet processing #11668

Merged

bfdd: add IPv4 BFD Echo support that loops pkts in forwarding plane #11371

bfdd: add IPv4 BFD Echo support that loops pkts in forwarding plane #11371

Conversation

lynnemorrison commented Jun 8, 2022

NetDEF-CI commented Jun 8, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 8, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

rzalamena left a comment

Choose a reason for hiding this comment

rzalamena Jun 8, 2022

Choose a reason for hiding this comment

pguibert6WIND Jun 9, 2022

Choose a reason for hiding this comment

rzalamena Jun 9, 2022

Choose a reason for hiding this comment

NetDEF-CI commented Jun 8, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

pguibert6WIND left a comment

Choose a reason for hiding this comment

pguibert6WIND Jun 9, 2022

Choose a reason for hiding this comment

NetDEF-CI commented Jun 9, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 9, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 9, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 9, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 9, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 10, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Jun 10, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 13, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 14, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 20, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Jun 8, 2022 •

edited

Loading

NetDEF-CI commented Jun 8, 2022 •

edited

Loading

NetDEF-CI commented Jun 8, 2022 •

edited

Loading

NetDEF-CI commented Jun 9, 2022 •

edited

Loading

NetDEF-CI commented Jun 9, 2022 •

edited

Loading

NetDEF-CI commented Jun 9, 2022 •

edited

Loading

NetDEF-CI commented Jun 9, 2022 •

edited

Loading

NetDEF-CI commented Jun 9, 2022 •

edited

Loading

NetDEF-CI commented Jun 10, 2022 •

edited

Loading

NetDEF-CI commented Jun 10, 2022 •

edited

Loading

NetDEF-CI commented Jun 13, 2022 •

edited

Loading

NetDEF-CI commented Jun 14, 2022 •

edited

Loading

NetDEF-CI commented Jun 20, 2022 •

edited

Loading

NetDEF-CI commented Jun 21, 2022 •

edited

Loading

NetDEF-CI commented Jun 21, 2022 •

edited

Loading

NetDEF-CI commented Jun 21, 2022 •

edited

Loading

NetDEF-CI commented Jun 22, 2022 •

edited

Loading

NetDEF-CI commented Jun 23, 2022 •

edited

Loading

NetDEF-CI commented Jun 23, 2022 •

edited

Loading