-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgmtd: Revert changes related to local validation. #11166
Conversation
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests Ubuntu 18.04 i386 part 4: Failed (click for details)Topotests Ubuntu 18.04 i386 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO4U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 4: No useful log foundTopotests debian 10 amd64 part 7: Failed (click for details)Topotests debian 10 amd64 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO7DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 7: No useful log foundTopotests Ubuntu 18.04 arm8 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-5271/test Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0:
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO9U18AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 9: No useful log foundAddresssanitizer topotests part 8: Incomplete(check logs for details)Topotests debian 10 amd64 part 2: Failed (click for details)Topotests debian 10 amd64 part 2: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO2DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 2: No useful log foundTopotests Ubuntu 18.04 arm8 part 5: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 5: No useful log foundTopotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO6U18AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 6: No useful log foundTopotests Ubuntu 18.04 amd64 part 1: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TP1U1804AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 1: No useful log foundTopotests debian 10 amd64 part 1: Failed (click for details)Topotests debian 10 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO1DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 1: No useful log foundTopotests debian 10 amd64 part 6: Failed (click for details)Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO6DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 6: No useful log foundTopotests Ubuntu 18.04 arm8 part 1: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 1: No useful log foundTopotests debian 10 amd64 part 4: Failed (click for details)Topotests debian 10 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO4DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 4: No useful log foundTopotests debian 10 amd64 part 3: Failed (click for details)Topotests debian 10 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO3DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 3: No useful log foundTopotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topotests Ubuntu 18.04 i386 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO9U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 9: No useful log foundTopotests Ubuntu 18.04 arm8 part 7: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 7: No useful log foundAddresssanitizer topotests part 9: Incomplete(check logs for details)Topotests debian 10 amd64 part 5: Failed (click for details)Topotests debian 10 amd64 part 5: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO5DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 5: No useful log foundTopotests Ubuntu 18.04 arm8 part 2: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO2U18ARM8-5271/test Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 2:
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO2U18ARM8/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)Topotests Ubuntu 18.04 i386 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO1U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 1: No useful log foundTopotests Ubuntu 18.04 i386 part 7: Failed (click for details)Topotests Ubuntu 18.04 i386 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO7U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 7: No useful log foundTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO6U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 6: No useful log foundTopotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests Ubuntu 18.04 i386 part 2: Failed (click for details)Topotests Ubuntu 18.04 i386 part 2: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO2U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 2: No useful log foundTopotests Ubuntu 18.04 amd64 part 5: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 5: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO5U18AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 5: No useful log foundTopotests Ubuntu 18.04 amd64 part 7: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO7U18AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 7: No useful log foundTopotests Ubuntu 18.04 i386 part 5: Failed (click for details)Topotests Ubuntu 18.04 i386 part 5: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO5U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 5: No useful log foundTopotests Ubuntu 18.04 i386 part 0: Failed (click for details)Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO0U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 0: No useful log foundTopotests Ubuntu 18.04 i386 part 3: Failed (click for details)Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO3U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 3: No useful log foundTopotests Ubuntu 18.04 amd64 part 2: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 2: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TP2U1804AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 2: No useful log foundTopotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TP4U1804AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 4: No useful log foundTopotests Ubuntu 18.04 arm8 part 4: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 4: No useful log foundTopotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: No useful log foundTopotests Ubuntu 18.04 amd64 part 0: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPOU1804/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 0: No useful log foundTopotests Ubuntu 18.04 amd64 part 3: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TP3U1804AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 3: No useful log foundTopotests debian 10 amd64 part 9: Failed (click for details)Topotests debian 10 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5271/artifact/TOPO9DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 9: No useful log foundSuccessful on other platforms/tests
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteAddresssanitizer topotests part 8: Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: No useful log foundAddresssanitizer topotests part 9: Incomplete(check logs for details)Successful on other platforms/tests
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests Ubuntu 18.04 arm8 part 5: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 5: No useful log foundTopotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topotests Ubuntu 18.04 i386 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO9U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 9: No useful log foundTopotests debian 10 amd64 part 1: Failed (click for details)Topotests debian 10 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO1DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 1: No useful log foundTopotests debian 10 amd64 part 7: Failed (click for details)Topotests debian 10 amd64 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO7DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 7: No useful log foundTopotests Ubuntu 18.04 arm8 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-5287/test Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0:
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 0: Failed (click for details)Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO0U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 0: No useful log foundTopotests Ubuntu 18.04 i386 part 5: Failed (click for details)Topotests Ubuntu 18.04 i386 part 5: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO5U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 5: No useful log foundTopotests debian 10 amd64 part 2: Failed (click for details)Topotests debian 10 amd64 part 2: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO2DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 2: No useful log foundTopotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO6U18AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 6: No useful log foundTopotests debian 10 amd64 part 3: Failed (click for details)Topotests debian 10 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO3DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 3: No useful log foundTopotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests Ubuntu 18.04 amd64 part 1: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TP1U1804AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 1: No useful log foundTopotests Ubuntu 18.04 i386 part 4: Failed (click for details)Topotests Ubuntu 18.04 i386 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO4U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 4: No useful log foundTopotests debian 10 amd64 part 6: Failed (click for details)Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO6DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 6: No useful log foundTopotests Ubuntu 18.04 arm8 part 1: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 1: No useful log foundAddresssanitizer topotests part 8: Incomplete(check logs for details)Topotests debian 10 amd64 part 5: Failed (click for details)Topotests debian 10 amd64 part 5: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO5DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 5: No useful log foundTopotests Ubuntu 18.04 i386 part 7: Failed (click for details)Topotests Ubuntu 18.04 i386 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO7U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 7: No useful log foundTopotests debian 10 amd64 part 4: Failed (click for details)Topotests debian 10 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO4DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 4: No useful log foundTopotests Ubuntu 18.04 i386 part 2: Failed (click for details)Topotests Ubuntu 18.04 i386 part 2: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO2U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 2: No useful log foundTopotests Ubuntu 18.04 amd64 part 3: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TP3U1804AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 3: No useful log foundTopotests debian 10 amd64 part 9: Failed (click for details)Topotests debian 10 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO9DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 9: No useful log foundTopotests Ubuntu 18.04 amd64 part 2: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 2: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TP2U1804AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 2: No useful log foundTopotests Ubuntu 18.04 i386 part 1: Failed (click for details)Topotests Ubuntu 18.04 i386 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO1U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 1: No useful log foundTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO6U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 6: No useful log foundTopotests Ubuntu 18.04 arm8 part 4: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 4: No useful log foundTopotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TP4U1804AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 4: No useful log foundTopotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: No useful log foundTopotests Ubuntu 18.04 amd64 part 0: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPOU1804/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 0: No useful log foundTopotests Ubuntu 18.04 amd64 part 5: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 5: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO5U18AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 5: No useful log foundTopotests Ubuntu 18.04 arm8 part 7: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 7: No useful log foundTopotests Ubuntu 18.04 amd64 part 7: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO7U18AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 7: No useful log foundAddresssanitizer topotests part 9: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO9U18AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 9: No useful log foundTopotests Ubuntu 18.04 i386 part 3: Failed (click for details)Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO3U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 3: No useful log foundTopotests Ubuntu 18.04 arm8 part 2: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO2U18ARM8-5287/test Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 2:
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5287/artifact/TOPO2U18ARM8/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteAddresssanitizer topotests part 8: Incomplete(check logs for details)Topotests debian 10 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-5291/test Topology Tests failed for Topotests debian 10 amd64 part 9 Addresssanitizer topotests part 9: Incomplete(check logs for details)Successful on other platforms/tests
|
ci:rerun previous run failed due to CI infra failure |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteAddresssanitizer topotests part 8: Incomplete(check logs for details)Addresssanitizer topotests part 9: Incomplete(check logs for details)Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-5299/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8 Successful on other platforms/tests
|
ci:rerun previous run failed due to CI infra failure |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteAddresssanitizer topotests part 8: Incomplete(check logs for details)Addresssanitizer topotests part 9: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-5309/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9 Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-5309/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9 Successful on other platforms/tests
|
ci:rerun previous run failed due to CI infra failure |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteAddresssanitizer topotests part 8: Incomplete(check logs for details)Addresssanitizer topotests part 9: Incomplete(check logs for details)IPv4 ldp protocol on Ubuntu 18.04: Failed (click for details)RFC Compliance Test ANVL-LDP-9.5 failing: Successful on other platforms/tests
|
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5426/ This is a comment from an automated CI system. CLANG Static Analyzer Summary
4 Static Analyzer issues remaining.See details at |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedIPv4 ldp protocol on Ubuntu 18.04: Failed (click for details)RFC Compliance Test ANVL-LDP-9.5 failing: Successful on other platforms/tests
|
@@ -141,6 +143,9 @@ static int nb_node_new_cb(const struct lysc_node *snode, void *arg) | |||
assert(snode->priv == NULL); | |||
((struct lysc_node *)snode)->priv = nb_node; | |||
|
|||
if (module && module->ignore_cbs) | |||
SET_FLAG(nb_node->flags, F_NB_NODE_IGNORE_CBS); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these nodes even created in the first place if the module supports no callbacks? If they serve no purpose this code should be changed to not create the nb_nodes and all the rest of the state etc that goes along with them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for the Mgmtd deamon where we need the nb_nodes to populate config data trees and the corresponding schema. This is useful for yang schema-based validations and for fetching the equivalent of "show running config".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Libyang2 has constructed it's own tree for validation and the output of "show running config". In fact the nb_node's hang off a "priv" pointer in the corresponding libyang2 schema node.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@choppsv1 Most of the code (including the API needed to do yang-validation) in lib/northbound,c needs a nb_node as parameter. Hence it is going to be lot difficult to avoid creating the nb_nodes on MGMTd. Hence added this new flag on the nb_nodes and then used it to avoid calling callbacks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to revist this later. We should be able to do validation w/o requiring a bunch of dummy nodes.
@@ -1528,6 +1569,9 @@ static int nb_callback_configuration(struct nb_context *context, | |||
union nb_resource *resource; | |||
int ret = NB_ERR; | |||
|
|||
if (CHECK_FLAG(nb_node->flags, F_NB_NODE_IGNORE_CBS)) | |||
return NB_OK; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check here is done prior to calling nb_callback_{create,modify,destroy,move}
, then in each of those called functions the check is done again. That secpmd redundant check should just be an assert.
However, I don't know why this code is even being invoked in the first place for a module with no callbacks -- as mentioned in an earlier comment. This comment applies to the other top level checks (pre_validate, apply_finish etc..)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nb_init() which is invoked by frr_init calls nb_validate_callbacks() for all FRR daemons. These changes tries to avoid that for YANG modules that are marked with 'ignore_cbs'.
Was adding static_nb.c and static_nb_config.c as a library to mgmt. Had put all the local variables inside ifdefs. As local validation is not used now, these changes can be reverted now. If the ignore callback is set in the nb_node then return without calling the callbacks. Signed-off-by: Yash Ranjan <ranjany@vmware.com>
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedIPv4 ldp protocol on Ubuntu 18.04: Failed (click for details)RFC Compliance Test ANVL-LDP-9.5 failing: Successful on other platforms/tests
|
@choppsv1 can you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/FRRouting/frr/blob/master/staticd/static_main.c#L167
Is there some reason this same code was not copied to mgmtd. This was the solution that I suggested a while back.
Sorry, we might have missed this. Honestly, I am noticing this 'backup_config_file' for the first time. We can push this change as part of the topotest PR. |
Was adding static_nb.c and static_nb_config.c as
a library to mgmt. Had put all the local variables
inside ifdefs. As local validation is not used now,
these changes can be reverted now.
Co-authored-by: Pushpasis Sarkar pushpasis@gmail.com
Signed-off-by: Yash Ranjan ranjany@vmware.com