zebra: set ZEBRA_IFC_DOWN on connected routes for inactive interfaces (backport #11004) #11057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
If you are in a situation where you have multiple addresses on an interface, zebra creates one connected route for them. The issue is that the rib entry is not created if addresses were added before the interface was running. We add the address to a running interface in a typical flow. Therefore, we handle the route & rib creation within a single ADD event. In the opposite case, we create the route entries without activating them. These are considered to be active since ZEBRA_IFC_DOWN is not set. On the following interface UP, we ignore the same ADDR_ADD as it overlaps with the existing prefixes -> rib is never created. The minimal reproducible setup: ----------------------------------------- ip link add name dummy0 type dummy ip addr flush dev dummy0 ip link set dummy0 down ip addr add 192.168.1.7/24 dev dummy0 ip addr add 192.168.1.8/24 dev dummy0 ip link set dummy0 up vtysh -c 'show ip route' | grep dummy0 Signed-off-by: Volodymyr Huti <v.huti@vyos.io> (cherry picked from commit 7fb9825)
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-4962/ This is a comment from an automated CI system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #11004 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com