pim6d: Handle receive of pimv6 register packet #10707

mobash-rasool · 2022-03-02T08:55:53Z

Handle receive of pimv6 register packet

Once the send register flow is handled, will move the pim_register.c to pim_common in subdir.am

Signed-off-by: Mobashshera Rasool mrasool@vmware.com

eqvinox · 2022-03-02T10:22:42Z

This should probably be combined with the register changes in #10661 (and the mroute changes be separate)

mobash-rasool · 2022-03-02T11:10:48Z

This should probably be combined with the register changes in #10661 (and the mroute changes be separate)

Yeah David, I have discussed with Saranya, she is going to split the "mroute" and "sending of register msg" changes into 2 separate PRs. We will keep this PR to handle the receive of register packet. This PR is ready for review.

NetDEF-CI · 2022-03-02T11:14:57Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3850/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for pim_msg.h | 4 issues
===============================================
< WARNING: do not add new typedefs
< #168: FILE: /tmp/f1-1154/pim_msg.h:168:
< WARNING: do not add new typedefs
< #171: FILE: /tmp/f1-1154/pim_msg.h:171:

NetDEF-CI · 2022-03-02T12:54:24Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3853/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for pim_msg.h | 4 issues
===============================================
< WARNING: do not add new typedefs
< #168: FILE: /tmp/f1-12531/pim_msg.h:168:
< WARNING: do not add new typedefs
< #171: FILE: /tmp/f1-12531/pim_msg.h:171:

eqvinox

has room for a few minor improvements

eqvinox · 2022-03-10T10:09:46Z

pimd/pim_register.c

 			if (PIM_DEBUG_PIM_PACKETS)
 				zlog_debug(
 					"%s: Received Register message with Border bit set",
 					__func__);

-			if (pimbr.s_addr == pim_br_unknown.s_addr)
+			if (!pim_addr_cmp(pimbr, PIMADDR_ANY))


pim_addr_is_any here

eqvinox · 2022-03-10T10:11:58Z

pimd/pim_msg.h

@@ -158,10 +161,16 @@ struct pim_encoded_source_ipv6 {
 typedef struct pim_encoded_ipv4_unicast pim_encoded_unicast;
 typedef struct pim_encoded_group_ipv4   pim_encoded_group;
 typedef struct pim_encoded_source_ipv4  pim_encoded_source;
+typedef struct ip                       ipv_hdr;


Can be done better: create two (for each IP version, in ifdef) pim_sgaddr pim_sgaddr_from_iphdr(const void *iphdr) helper functions ⇒ no need for ipv_hdr + IPV_SRC + IPV_DST

IPv4 uses "struct ip" and IPv6 uses "struct ip6_hdr" as headers. Get the src and dst in pim_sgaddr. Added api pim_sgaddr_from_iphdr to do so. Signed-off-by: Mobashshera Rasool <mrasool@vmwaer.com>

Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

NetDEF-CI · 2022-03-10T13:29:22Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-4039/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-4039/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-4039/artifact/TOPO9U18AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Fedora 29 rpm pkg check
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 0
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 arm8 part 8
CentOS 7 rpm pkg check
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
IPv6 protocols on Ubuntu 18.04
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 8
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 1
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 4
IPv4 protocols on Ubuntu 18.04
Addresssanitizer topotests part 4
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 5
Static analyzer (clang)
IPv4 ldp protocol on Ubuntu 18.04
Topotests Ubuntu 18.04 arm8 part 0
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2

NetDEF-CI · 2022-03-10T13:39:26Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-4040/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-4040/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-4040/artifact/TOPO9DEB10AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 7
Fedora 29 rpm pkg check
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 7
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 6
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 2
Debian 10 deb pkg check
Topotests Ubuntu 18.04 arm8 part 4
IPv6 protocols on Ubuntu 18.04
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 1
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 4
Ubuntu 18.04 deb pkg check
IPv4 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 i386 part 8
Debian 9 deb pkg check
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 8
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
IPv4 ldp protocol on Ubuntu 18.04
Ubuntu 16.04 deb pkg check
Topotests debian 10 amd64 part 2
Addresssanitizer topotests part 0

mobash-rasool · 2022-03-10T14:31:06Z

ospf test case has failed which is unrelated to this change. rerunning the ci.

mobash-rasool · 2022-03-10T14:31:13Z

ci:rerun

NetDEF-CI · 2022-03-10T17:01:50Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-4044/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

mobash-rasool added pim pimv6 labels Mar 2, 2022

mobash-rasool changed the title ~~pim6d: Handle receive of pimv6 register packet~~ <WIP> pim6d: Handle receive of pimv6 register packet Mar 2, 2022

mobash-rasool changed the title ~~<WIP> pim6d: Handle receive of pimv6 register packet~~ pim6d: Handle receive of pimv6 register packet Mar 2, 2022

mobash-rasool marked this pull request as ready for review March 2, 2022 10:57

mobash-rasool requested a review from eqvinox March 2, 2022 11:12

mobash-rasool mentioned this pull request Mar 7, 2022

Pim6d: Mroute oil #10661

Merged

eqvinox requested changes Mar 10, 2022

View reviewed changes

pim6d: Abstract api to get src and dst from ip hdr

d1fd950

IPv4 uses "struct ip" and IPv6 uses "struct ip6_hdr" as headers. Get the src and dst in pim_sgaddr. Added api pim_sgaddr_from_iphdr to do so. Signed-off-by: Mobashshera Rasool <mrasool@vmwaer.com>

mobash-rasool force-pushed the pimv6-register-recv branch from 2a132b1 to 5792446 Compare March 10, 2022 11:22

mobash-rasool added 3 commits March 10, 2022 03:24

pim6d: Parsing pimv6 register msg

c7842d2

Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

pim6d: Handle B bit changes for IPv6

a141ea6

Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

pim6d: Replace pim_br_unknown with PIMADDR_ANY

e782863

Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

mobash-rasool force-pushed the pimv6-register-recv branch from 5792446 to e782863 Compare March 10, 2022 11:25

mobash-rasool requested a review from eqvinox March 10, 2022 11:42

eqvinox approved these changes Mar 10, 2022

View reviewed changes

eqvinox merged commit f1bfead into FRRouting:master Mar 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pim6d: Handle receive of pimv6 register packet #10707

pim6d: Handle receive of pimv6 register packet #10707

mobash-rasool commented Mar 2, 2022

eqvinox commented Mar 2, 2022

mobash-rasool commented Mar 2, 2022

NetDEF-CI commented Mar 2, 2022 •

edited

Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Mar 2, 2022 •

edited

Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

eqvinox left a comment

eqvinox Mar 10, 2022

mobash-rasool Mar 10, 2022

eqvinox Mar 10, 2022

mobash-rasool Mar 10, 2022

NetDEF-CI commented Mar 10, 2022 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

NetDEF-CI commented Mar 10, 2022 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

mobash-rasool commented Mar 10, 2022

mobash-rasool commented Mar 10, 2022

NetDEF-CI commented Mar 10, 2022

pim6d: Handle receive of pimv6 register packet #10707

pim6d: Handle receive of pimv6 register packet #10707

Conversation

mobash-rasool commented Mar 2, 2022

eqvinox commented Mar 2, 2022

mobash-rasool commented Mar 2, 2022

NetDEF-CI commented Mar 2, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Mar 2, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

eqvinox left a comment

Choose a reason for hiding this comment

eqvinox Mar 10, 2022

Choose a reason for hiding this comment

mobash-rasool Mar 10, 2022

Choose a reason for hiding this comment

eqvinox Mar 10, 2022

Choose a reason for hiding this comment

mobash-rasool Mar 10, 2022

Choose a reason for hiding this comment

NetDEF-CI commented Mar 10, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

NetDEF-CI commented Mar 10, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

mobash-rasool commented Mar 10, 2022

mobash-rasool commented Mar 10, 2022

NetDEF-CI commented Mar 10, 2022

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Mar 2, 2022 •

edited

Loading

NetDEF-CI commented Mar 2, 2022 •

edited

Loading

NetDEF-CI commented Mar 10, 2022 •

edited

Loading

NetDEF-CI commented Mar 10, 2022 •

edited

Loading