pimd: fix missing the first round on wheel timer #10626
Conversation
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3571/ This is a comment from an automated CI system. |
`wheel_add_timer` will not *update* currrent wheel timer's wake-up time. It means next wake-up time is set before this insertion, and can't be changed. So added timers in this round between `current slot` and `nexttime slot` will unluckily miss the current round. Clearly it will lead to this problem: You expect to be woken up within 30s, you maybe be woken up within 60s. Yes, it is bad luck to miss the first round, but won't miss any more rounds. Coincidentally, pimd has one of the most important judgement for this time. If missed the first round, pimd will miss all the world. This fix is small and convervative. Just doubles the desired time interval.
anlancs
force-pushed
the
pimd-wheel-timer
branch
from
4c71d8b to
9630446
Compare
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3587/ This is a comment from an automated CI system. |
|
Okay, thanks for @donaldsharp |
One wheel timer issue, let's see what you think.
Please check commit log.