Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: Flush local new_attr after it's already interned for bgp_update() #10568

Closed
wants to merge 1 commit into from
Closed

bgpd: Flush local new_attr after it's already interned for bgp_update() #10568

wants to merge 1 commit into from

Conversation

ton31337
Copy link
Member

No description provided.

@ton31337
bgpd: Flush local new_attr after it's already interned for bgp_update()
252826e 
Not used anywhere in bgp_update() later.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
@frrbot frrbot bot added the bgp label Feb 11, 2022
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3391/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

idryzhov
idryzhov requested changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@idryzhov idryzhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you think it is needed?
From what I see, after bgp_attr_intern, all attributes will have refcnt > 0 and a subsequent call to bgp_attr_flush will do nothing because it frees only attributes with refcnt == 0.

@ton31337 ton31337 closed this Feb 11, 2022
@ton31337 ton31337 deleted the fix/flush_bgp_update branch February 11, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idryzhov idryzhov idryzhov requested changes

Assignees
No one assigned
Labels
bgp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ton31337 @NetDEF-CI @idryzhov