Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isisd: use base64 to encode the binary data. #10566

Merged
merged 1 commit into from
Feb 28, 2022
Merged

isisd: use base64 to encode the binary data. #10566

merged 1 commit into from
Feb 28, 2022

Conversation

whichbug
Copy link

This pull request fixes #10505. Please refer to #10505 for details.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 11, 2022 •
edited
Loading

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3385/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
<stdin>:87: trailing whitespace.
 * 
<stdin>:89: trailing whitespace.
 * 
<stdin>:96: trailing whitespace.
 * 
<stdin>:104: trailing whitespace.
 * 
warning: 4 lines add whitespace errors.
Report for base64.c | 213 issues
===============================================
ERROR: trailing whitespace
#5: FILE: /tmp/f1-14533/base64.c:5:
+ * $

ERROR: trailing whitespace
#7: FILE: /tmp/f1-14533/base64.c:7:
+ * $

ERROR: trailing whitespace
#14: FILE: /tmp/f1-14533/base64.c:14:
+ * $

ERROR: trailing whitespace
#22: FILE: /tmp/f1-14533/base64.c:22:
+ * $

ERROR: that open brace { should be on the previous line
#91: FILE: /tmp/f1-14533/base64.c:91:
+static const unsigned char pr2six[256] =
+{

WARNING: please, no spaces at the start of a line
#93: FILE: /tmp/f1-14533/base64.c:93:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#94: FILE: /tmp/f1-14533/base64.c:94:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#95: FILE: /tmp/f1-14533/base64.c:95:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 62, 64, 64, 64, 63,$

WARNING: please, no spaces at the start of a line
#96: FILE: /tmp/f1-14533/base64.c:96:
+    52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#97: FILE: /tmp/f1-14533/base64.c:97:
+    64,  0,  1,  2,  3,  4,  5,  6,  7,  8,  9, 10, 11, 12, 13, 14,$

WARNING: please, no spaces at the start of a line
#98: FILE: /tmp/f1-14533/base64.c:98:
+    15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#99: FILE: /tmp/f1-14533/base64.c:99:
+    64, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40,$

WARNING: please, no spaces at the start of a line
#100: FILE: /tmp/f1-14533/base64.c:100:
+    41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#101: FILE: /tmp/f1-14533/base64.c:101:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#102: FILE: /tmp/f1-14533/base64.c:102:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#103: FILE: /tmp/f1-14533/base64.c:103:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#104: FILE: /tmp/f1-14533/base64.c:104:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#105: FILE: /tmp/f1-14533/base64.c:105:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#106: FILE: /tmp/f1-14533/base64.c:106:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#107: FILE: /tmp/f1-14533/base64.c:107:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#108: FILE: /tmp/f1-14533/base64.c:108:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64$

WARNING: please, no spaces at the start of a line
#113: FILE: /tmp/f1-14533/base64.c:113:
+    int nbytesdecoded;$

WARNING: Missing a blank line after declarations
#114: FILE: /tmp/f1-14533/base64.c:114:
+    int nbytesdecoded;
+    register const unsigned char *bufin;

WARNING: please, no spaces at the start of a line
#114: FILE: /tmp/f1-14533/base64.c:114:
+    register const unsigned char *bufin;$

WARNING: please, no spaces at the start of a line
#115: FILE: /tmp/f1-14533/base64.c:115:
+    register int nprbytes;$

WARNING: please, no spaces at the start of a line
#117: FILE: /tmp/f1-14533/base64.c:117:
+    bufin = (const unsigned char *) bufcoded;$

WARNING: please, no spaces at the start of a line
#118: FILE: /tmp/f1-14533/base64.c:118:
+    while (pr2six[*(bufin++)] <= 63);$

ERROR: trailing statements should be on next line
#118: FILE: /tmp/f1-14533/base64.c:118:
+    while (pr2six[*(bufin++)] <= 63);

WARNING: please, no spaces at the start of a line
#120: FILE: /tmp/f1-14533/base64.c:120:
+    nprbytes = (bufin - (const unsigned char *) bufcoded) - 1;$

WARNING: please, no spaces at the start of a line
#121: FILE: /tmp/f1-14533/base64.c:121:
+    nbytesdecoded = ((nprbytes + 3) / 4) * 3;$

WARNING: please, no spaces at the start of a line
#123: FILE: /tmp/f1-14533/base64.c:123:
+    return nbytesdecoded + 1;$

WARNING: please, no spaces at the start of a line
#128: FILE: /tmp/f1-14533/base64.c:128:
+    int nbytesdecoded;$

WARNING: please, no spaces at the start of a line
#129: FILE: /tmp/f1-14533/base64.c:129:
+    register const unsigned char *bufin;$

WARNING: please, no spaces at the start of a line
#130: FILE: /tmp/f1-14533/base64.c:130:
+    register unsigned char *bufout;$

WARNING: please, no spaces at the start of a line
#131: FILE: /tmp/f1-14533/base64.c:131:
+    register int nprbytes;$

WARNING: please, no spaces at the start of a line
#133: FILE: /tmp/f1-14533/base64.c:133:
+    bufin = (const unsigned char *) bufcoded;$

WARNING: please, no spaces at the start of a line
#134: FILE: /tmp/f1-14533/base64.c:134:
+    while (pr2six[*(bufin++)] <= 63);$

ERROR: trailing statements should be on next line
#134: FILE: /tmp/f1-14533/base64.c:134:
+    while (pr2six[*(bufin++)] <= 63);

WARNING: please, no spaces at the start of a line
#135: FILE: /tmp/f1-14533/base64.c:135:
+    nprbytes = (bufin - (const unsigned char *) bufcoded) - 1;$

WARNING: please, no spaces at the start of a line
#136: FILE: /tmp/f1-14533/base64.c:136:
+    nbytesdecoded = ((nprbytes + 3) / 4) * 3;$

WARNING: please, no spaces at the start of a line
#138: FILE: /tmp/f1-14533/base64.c:138:
+    bufout = (unsigned char *) bufplain;$

WARNING: please, no spaces at the start of a line
#139: FILE: /tmp/f1-14533/base64.c:139:
+    bufin = (const unsigned char *) bufcoded;$

WARNING: please, no spaces at the start of a line
#141: FILE: /tmp/f1-14533/base64.c:141:
+    while (nprbytes > 4) {$

WARNING: suspect code indent for conditional statements (4, 4)
#141: FILE: /tmp/f1-14533/base64.c:141:
+    while (nprbytes > 4) {
+    *(bufout++) =

WARNING: please, no spaces at the start of a line
#142: FILE: /tmp/f1-14533/base64.c:142:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#143: FILE: /tmp/f1-14533/base64.c:143:
+        (unsigned char) (pr2six[*bufin] << 2 | pr2six[bufin[1]] >> 4);$

WARNING: please, no spaces at the start of a line
#143: FILE: /tmp/f1-14533/base64.c:143:
+        (unsigned char) (pr2six[*bufin] << 2 | pr2six[bufin[1]] >> 4);$

WARNING: please, no spaces at the start of a line
#144: FILE: /tmp/f1-14533/base64.c:144:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#145: FILE: /tmp/f1-14533/base64.c:145:
+        (unsigned char) (pr2six[bufin[1]] << 4 | pr2six[bufin[2]] >> 2);$

WARNING: please, no spaces at the start of a line
#145: FILE: /tmp/f1-14533/base64.c:145:
+        (unsigned char) (pr2six[bufin[1]] << 4 | pr2six[bufin[2]] >> 2);$

WARNING: please, no spaces at the start of a line
#146: FILE: /tmp/f1-14533/base64.c:146:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#147: FILE: /tmp/f1-14533/base64.c:147:
+        (unsigned char) (pr2six[bufin[2]] << 6 | pr2six[bufin[3]]);$

WARNING: please, no spaces at the start of a line
#147: FILE: /tmp/f1-14533/base64.c:147:
+        (unsigned char) (pr2six[bufin[2]] << 6 | pr2six[bufin[3]]);$

WARNING: please, no spaces at the start of a line
#148: FILE: /tmp/f1-14533/base64.c:148:
+    bufin += 4;$

WARNING: please, no spaces at the start of a line
#149: FILE: /tmp/f1-14533/base64.c:149:
+    nprbytes -= 4;$

WARNING: please, no spaces at the start of a line
#150: FILE: /tmp/f1-14533/base64.c:150:
+    }$

WARNING: please, no spaces at the start of a line
#153: FILE: /tmp/f1-14533/base64.c:153:
+    if (nprbytes > 1) {$

WARNING: suspect code indent for conditional statements (4, 4)
#153: FILE: /tmp/f1-14533/base64.c:153:
+    if (nprbytes > 1) {
+    *(bufout++) =

WARNING: please, no spaces at the start of a line
#154: FILE: /tmp/f1-14533/base64.c:154:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#155: FILE: /tmp/f1-14533/base64.c:155:
+        (unsigned char) (pr2six[*bufin] << 2 | pr2six[bufin[1]] >> 4);$

WARNING: please, no spaces at the start of a line
#155: FILE: /tmp/f1-14533/base64.c:155:
+        (unsigned char) (pr2six[*bufin] << 2 | pr2six[bufin[1]] >> 4);$

WARNING: please, no spaces at the start of a line
#156: FILE: /tmp/f1-14533/base64.c:156:
+    }$

WARNING: please, no spaces at the start of a line
#157: FILE: /tmp/f1-14533/base64.c:157:
+    if (nprbytes > 2) {$

WARNING: suspect code indent for conditional statements (4, 4)
#157: FILE: /tmp/f1-14533/base64.c:157:
+    if (nprbytes > 2) {
+    *(bufout++) =

WARNING: please, no spaces at the start of a line
#158: FILE: /tmp/f1-14533/base64.c:158:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#159: FILE: /tmp/f1-14533/base64.c:159:
+        (unsigned char) (pr2six[bufin[1]] << 4 | pr2six[bufin[2]] >> 2);$

WARNING: please, no spaces at the start of a line
#159: FILE: /tmp/f1-14533/base64.c:159:
+        (unsigned char) (pr2six[bufin[1]] << 4 | pr2six[bufin[2]] >> 2);$

WARNING: please, no spaces at the start of a line
#160: FILE: /tmp/f1-14533/base64.c:160:
+    }$

WARNING: please, no spaces at the start of a line
#161: FILE: /tmp/f1-14533/base64.c:161:
+    if (nprbytes > 3) {$

WARNING: suspect code indent for conditional statements (4, 4)
#161: FILE: /tmp/f1-14533/base64.c:161:
+    if (nprbytes > 3) {
+    *(bufout++) =

WARNING: please, no spaces at the start of a line
#162: FILE: /tmp/f1-14533/base64.c:162:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#163: FILE: /tmp/f1-14533/base64.c:163:
+        (unsigned char) (pr2six[bufin[2]] << 6 | pr2six[bufin[3]]);$

WARNING: please, no spaces at the start of a line
#163: FILE: /tmp/f1-14533/base64.c:163:
+        (unsigned char) (pr2six[bufin[2]] << 6 | pr2six[bufin[3]]);$

WARNING: please, no spaces at the start of a line
#164: FILE: /tmp/f1-14533/base64.c:164:
+    }$

WARNING: please, no spaces at the start of a line
#166: FILE: /tmp/f1-14533/base64.c:166:
+    *(bufout++) = '\0';$

WARNING: please, no spaces at the start of a line
#167: FILE: /tmp/f1-14533/base64.c:167:
+    nbytesdecoded -= (4 - nprbytes) & 3;$

WARNING: please, no spaces at the start of a line
#168: FILE: /tmp/f1-14533/base64.c:168:
+    return nbytesdecoded;$

WARNING: please, no spaces at the start of a line
#172: FILE: /tmp/f1-14533/base64.c:172:
+    "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";$

WARNING: please, no spaces at the start of a line
#176: FILE: /tmp/f1-14533/base64.c:176:
+    return ((len + 2) / 3 * 4) + 1;$

WARNING: please, no spaces at the start of a line
#181: FILE: /tmp/f1-14533/base64.c:181:
+    int i;$

WARNING: please, no spaces at the start of a line
#182: FILE: /tmp/f1-14533/base64.c:182:
+    char *p;$

WARNING: please, no spaces at the start of a line
#184: FILE: /tmp/f1-14533/base64.c:184:
+    p = encoded;$

WARNING: please, no spaces at the start of a line
#185: FILE: /tmp/f1-14533/base64.c:185:
+    for (i = 0; i < len - 2; i += 3) {$

WARNING: suspect code indent for conditional statements (4, 4)
#185: FILE: /tmp/f1-14533/base64.c:185:
+    for (i = 0; i < len - 2; i += 3) {
+    *p++ = basis_64[(string[i] >> 2) & 0x3F];

WARNING: please, no spaces at the start of a line
#186: FILE: /tmp/f1-14533/base64.c:186:
+    *p++ = basis_64[(string[i] >> 2) & 0x3F];$

WARNING: please, no spaces at the start of a line
#187: FILE: /tmp/f1-14533/base64.c:187:
+    *p++ = basis_64[((string[i] & 0x3) << 4) |$

ERROR: code indent should use tabs where possible
#188: FILE: /tmp/f1-14533/base64.c:188:
+                    ((int) (string[i + 1] & 0xF0) >> 4)];$

WARNING: please, no spaces at the start of a line
#188: FILE: /tmp/f1-14533/base64.c:188:
+                    ((int) (string[i + 1] & 0xF0) >> 4)];$

WARNING: please, no spaces at the start of a line
#189: FILE: /tmp/f1-14533/base64.c:189:
+    *p++ = basis_64[((string[i + 1] & 0xF) << 2) |$

ERROR: code indent should use tabs where possible
#190: FILE: /tmp/f1-14533/base64.c:190:
+                    ((int) (string[i + 2] & 0xC0) >> 6)];$

WARNING: please, no spaces at the start of a line
#190: FILE: /tmp/f1-14533/base64.c:190:
+                    ((int) (string[i + 2] & 0xC0) >> 6)];$

WARNING: please, no spaces at the start of a line
#191: FILE: /tmp/f1-14533/base64.c:191:
+    *p++ = basis_64[string[i + 2] & 0x3F];$

WARNING: please, no spaces at the start of a line
#192: FILE: /tmp/f1-14533/base64.c:192:
+    }$

WARNING: please, no spaces at the start of a line
#193: FILE: /tmp/f1-14533/base64.c:193:
+    if (i < len) {$

WARNING: suspect code indent for conditional statements (4, 4)
#193: FILE: /tmp/f1-14533/base64.c:193:
+    if (i < len) {
+    *p++ = basis_64[(string[i] >> 2) & 0x3F];

WARNING: please, no spaces at the start of a line
#194: FILE: /tmp/f1-14533/base64.c:194:
+    *p++ = basis_64[(string[i] >> 2) & 0x3F];$

WARNING: please, no spaces at the start of a line
#195: FILE: /tmp/f1-14533/base64.c:195:
+    if (i == (len - 1)) {$

ERROR: code indent should use tabs where possible
#196: FILE: /tmp/f1-14533/base64.c:196:
+        *p++ = basis_64[((string[i] & 0x3) << 4)];$

WARNING: please, no spaces at the start of a line
#196: FILE: /tmp/f1-14533/base64.c:196:
+        *p++ = basis_64[((string[i] & 0x3) << 4)];$

ERROR: code indent should use tabs where possible
#197: FILE: /tmp/f1-14533/base64.c:197:
+        *p++ = '=';$

WARNING: please, no spaces at the start of a line
#197: FILE: /tmp/f1-14533/base64.c:197:
+        *p++ = '=';$

WARNING: please, no spaces at the start of a line
#198: FILE: /tmp/f1-14533/base64.c:198:
+    }$

WARNING: please, no spaces at the start of a line
#199: FILE: /tmp/f1-14533/base64.c:199:
+    else {$

ERROR: else should follow close brace '}'
#199: FILE: /tmp/f1-14533/base64.c:199:
+    }
+    else {

ERROR: code indent should use tabs where possible
#200: FILE: /tmp/f1-14533/base64.c:200:
+        *p++ = basis_64[((string[i] & 0x3) << 4) |$

WARNING: please, no spaces at the start of a line
#200: FILE: /tmp/f1-14533/base64.c:200:
+        *p++ = basis_64[((string[i] & 0x3) << 4) |$

ERROR: code indent should use tabs where possible
#201: FILE: /tmp/f1-14533/base64.c:201:
+                        ((int) (string[i + 1] & 0xF0) >> 4)];$

WARNING: please, no spaces at the start of a line
#201: FILE: /tmp/f1-14533/base64.c:201:
+                        ((int) (string[i + 1] & 0xF0) >> 4)];$

ERROR: code indent should use tabs where possible
#202: FILE: /tmp/f1-14533/base64.c:202:
+        *p++ = basis_64[((string[i + 1] & 0xF) << 2)];$

WARNING: please, no spaces at the start of a line
#202: FILE: /tmp/f1-14533/base64.c:202:
+        *p++ = basis_64[((string[i + 1] & 0xF) << 2)];$

WARNING: please, no spaces at the start of a line
#203: FILE: /tmp/f1-14533/base64.c:203:
+    }$

WARNING: please, no spaces at the start of a line
#204: FILE: /tmp/f1-14533/base64.c:204:
+    *p++ = '=';$

WARNING: please, no spaces at the start of a line
#205: FILE: /tmp/f1-14533/base64.c:205:
+    }$

WARNING: please, no spaces at the start of a line
#207: FILE: /tmp/f1-14533/base64.c:207:
+    *p++ = '\0';$

WARNING: please, no spaces at the start of a line
#208: FILE: /tmp/f1-14533/base64.c:208:
+    return p - encoded;$
Report for base64.h | 35 issues
===============================================
WARNING: Block comments should align the * on each line
#2: FILE: /tmp/f1-14533/base64.h:2:
+/*
+* Copyright (c) 2003 Apple Computer, Inc. All rights reserved.

WARNING: Block comments should align the * on each line
#26: FILE: /tmp/f1-14533/base64.h:26:
+/* ====================================================================
+* Copyright (c) 1995-1999 The Apache Group.  All rights reserved.

ERROR: "foo * bar" should be "foo *bar"
#92: FILE: /tmp/f1-14533/base64.h:92:
+int Base64encode(char * coded_dst, const char *plain_src,int len_plain_src);

ERROR: space required after that ',' (ctx:VxV)
#92: FILE: /tmp/f1-14533/base64.h:92:
+int Base64encode(char * coded_dst, const char *plain_src,int len_plain_src);
                                                         ^

ERROR: "foo * bar" should be "foo *bar"
#94: FILE: /tmp/f1-14533/base64.h:94:
+int Base64decode_len(const char * coded_src);

ERROR: "foo * bar" should be "foo *bar"
#95: FILE: /tmp/f1-14533/base64.h:95:
+int Base64decode(char * plain_dst, const char *coded_src);

WARNING: adding a line without newline at end of file
#101: FILE: /tmp/f1-14533/base64.h:101:
+#endif //_BASE64_H_

WARNING: C99 // comments do not match recommendation
#101: FILE: /tmp/f1-14533/base64.h:101:
+#endif //_BASE64_H_
Report for yang_wrappers.c | 6 issues
===============================================
< WARNING: Missing a blank line after declarations
< #688: FILE: /tmp/f1-14533/yang_wrappers.c:688:
< WARNING: Missing a blank line after declarations
< #690: FILE: /tmp/f1-14533/yang_wrappers.c:690:
< WARNING: Missing a blank line after declarations
< #701: FILE: /tmp/f1-14533/yang_wrappers.c:701:

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 11, 2022 •
edited
Loading

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3386/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
<stdin>:87: trailing whitespace.
 * 
<stdin>:89: trailing whitespace.
 * 
<stdin>:96: trailing whitespace.
 * 
<stdin>:104: trailing whitespace.
 * 
warning: 4 lines add whitespace errors.
Report for base64.c | 213 issues
===============================================
ERROR: trailing whitespace
#5: FILE: /tmp/f1-24185/base64.c:5:
+ * $

ERROR: trailing whitespace
#7: FILE: /tmp/f1-24185/base64.c:7:
+ * $

ERROR: trailing whitespace
#14: FILE: /tmp/f1-24185/base64.c:14:
+ * $

ERROR: trailing whitespace
#22: FILE: /tmp/f1-24185/base64.c:22:
+ * $

ERROR: that open brace { should be on the previous line
#91: FILE: /tmp/f1-24185/base64.c:91:
+static const unsigned char pr2six[256] =
+{

WARNING: please, no spaces at the start of a line
#93: FILE: /tmp/f1-24185/base64.c:93:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#94: FILE: /tmp/f1-24185/base64.c:94:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#95: FILE: /tmp/f1-24185/base64.c:95:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 62, 64, 64, 64, 63,$

WARNING: please, no spaces at the start of a line
#96: FILE: /tmp/f1-24185/base64.c:96:
+    52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#97: FILE: /tmp/f1-24185/base64.c:97:
+    64,  0,  1,  2,  3,  4,  5,  6,  7,  8,  9, 10, 11, 12, 13, 14,$

WARNING: please, no spaces at the start of a line
#98: FILE: /tmp/f1-24185/base64.c:98:
+    15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#99: FILE: /tmp/f1-24185/base64.c:99:
+    64, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40,$

WARNING: please, no spaces at the start of a line
#100: FILE: /tmp/f1-24185/base64.c:100:
+    41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#101: FILE: /tmp/f1-24185/base64.c:101:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#102: FILE: /tmp/f1-24185/base64.c:102:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#103: FILE: /tmp/f1-24185/base64.c:103:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#104: FILE: /tmp/f1-24185/base64.c:104:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#105: FILE: /tmp/f1-24185/base64.c:105:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#106: FILE: /tmp/f1-24185/base64.c:106:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#107: FILE: /tmp/f1-24185/base64.c:107:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#108: FILE: /tmp/f1-24185/base64.c:108:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64$

WARNING: please, no spaces at the start of a line
#113: FILE: /tmp/f1-24185/base64.c:113:
+    int nbytesdecoded;$

WARNING: Missing a blank line after declarations
#114: FILE: /tmp/f1-24185/base64.c:114:
+    int nbytesdecoded;
+    register const unsigned char *bufin;

WARNING: please, no spaces at the start of a line
#114: FILE: /tmp/f1-24185/base64.c:114:
+    register const unsigned char *bufin;$

WARNING: please, no spaces at the start of a line
#115: FILE: /tmp/f1-24185/base64.c:115:
+    register int nprbytes;$

WARNING: please, no spaces at the start of a line
#117: FILE: /tmp/f1-24185/base64.c:117:
+    bufin = (const unsigned char *) bufcoded;$

WARNING: please, no spaces at the start of a line
#118: FILE: /tmp/f1-24185/base64.c:118:
+    while (pr2six[*(bufin++)] <= 63);$

ERROR: trailing statements should be on next line
#118: FILE: /tmp/f1-24185/base64.c:118:
+    while (pr2six[*(bufin++)] <= 63);

WARNING: please, no spaces at the start of a line
#120: FILE: /tmp/f1-24185/base64.c:120:
+    nprbytes = (bufin - (const unsigned char *) bufcoded) - 1;$

WARNING: please, no spaces at the start of a line
#121: FILE: /tmp/f1-24185/base64.c:121:
+    nbytesdecoded = ((nprbytes + 3) / 4) * 3;$

WARNING: please, no spaces at the start of a line
#123: FILE: /tmp/f1-24185/base64.c:123:
+    return nbytesdecoded + 1;$

WARNING: please, no spaces at the start of a line
#128: FILE: /tmp/f1-24185/base64.c:128:
+    int nbytesdecoded;$

WARNING: please, no spaces at the start of a line
#129: FILE: /tmp/f1-24185/base64.c:129:
+    register const unsigned char *bufin;$

WARNING: please, no spaces at the start of a line
#130: FILE: /tmp/f1-24185/base64.c:130:
+    register unsigned char *bufout;$

WARNING: please, no spaces at the start of a line
#131: FILE: /tmp/f1-24185/base64.c:131:
+    register int nprbytes;$

WARNING: please, no spaces at the start of a line
#133: FILE: /tmp/f1-24185/base64.c:133:
+    bufin = (const unsigned char *) bufcoded;$

WARNING: please, no spaces at the start of a line
#134: FILE: /tmp/f1-24185/base64.c:134:
+    while (pr2six[*(bufin++)] <= 63);$

ERROR: trailing statements should be on next line
#134: FILE: /tmp/f1-24185/base64.c:134:
+    while (pr2six[*(bufin++)] <= 63);

WARNING: please, no spaces at the start of a line
#135: FILE: /tmp/f1-24185/base64.c:135:
+    nprbytes = (bufin - (const unsigned char *) bufcoded) - 1;$

WARNING: please, no spaces at the start of a line
#136: FILE: /tmp/f1-24185/base64.c:136:
+    nbytesdecoded = ((nprbytes + 3) / 4) * 3;$

WARNING: please, no spaces at the start of a line
#138: FILE: /tmp/f1-24185/base64.c:138:
+    bufout = (unsigned char *) bufplain;$

WARNING: please, no spaces at the start of a line
#139: FILE: /tmp/f1-24185/base64.c:139:
+    bufin = (const unsigned char *) bufcoded;$

WARNING: please, no spaces at the start of a line
#141: FILE: /tmp/f1-24185/base64.c:141:
+    while (nprbytes > 4) {$

WARNING: suspect code indent for conditional statements (4, 4)
#141: FILE: /tmp/f1-24185/base64.c:141:
+    while (nprbytes > 4) {
+    *(bufout++) =

WARNING: please, no spaces at the start of a line
#142: FILE: /tmp/f1-24185/base64.c:142:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#143: FILE: /tmp/f1-24185/base64.c:143:
+        (unsigned char) (pr2six[*bufin] << 2 | pr2six[bufin[1]] >> 4);$

WARNING: please, no spaces at the start of a line
#143: FILE: /tmp/f1-24185/base64.c:143:
+        (unsigned char) (pr2six[*bufin] << 2 | pr2six[bufin[1]] >> 4);$

WARNING: please, no spaces at the start of a line
#144: FILE: /tmp/f1-24185/base64.c:144:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#145: FILE: /tmp/f1-24185/base64.c:145:
+        (unsigned char) (pr2six[bufin[1]] << 4 | pr2six[bufin[2]] >> 2);$

WARNING: please, no spaces at the start of a line
#145: FILE: /tmp/f1-24185/base64.c:145:
+        (unsigned char) (pr2six[bufin[1]] << 4 | pr2six[bufin[2]] >> 2);$

WARNING: please, no spaces at the start of a line
#146: FILE: /tmp/f1-24185/base64.c:146:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#147: FILE: /tmp/f1-24185/base64.c:147:
+        (unsigned char) (pr2six[bufin[2]] << 6 | pr2six[bufin[3]]);$

WARNING: please, no spaces at the start of a line
#147: FILE: /tmp/f1-24185/base64.c:147:
+        (unsigned char) (pr2six[bufin[2]] << 6 | pr2six[bufin[3]]);$

WARNING: please, no spaces at the start of a line
#148: FILE: /tmp/f1-24185/base64.c:148:
+    bufin += 4;$

WARNING: please, no spaces at the start of a line
#149: FILE: /tmp/f1-24185/base64.c:149:
+    nprbytes -= 4;$

WARNING: please, no spaces at the start of a line
#150: FILE: /tmp/f1-24185/base64.c:150:
+    }$

WARNING: please, no spaces at the start of a line
#153: FILE: /tmp/f1-24185/base64.c:153:
+    if (nprbytes > 1) {$

WARNING: suspect code indent for conditional statements (4, 4)
#153: FILE: /tmp/f1-24185/base64.c:153:
+    if (nprbytes > 1) {
+    *(bufout++) =

WARNING: please, no spaces at the start of a line
#154: FILE: /tmp/f1-24185/base64.c:154:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#155: FILE: /tmp/f1-24185/base64.c:155:
+        (unsigned char) (pr2six[*bufin] << 2 | pr2six[bufin[1]] >> 4);$

WARNING: please, no spaces at the start of a line
#155: FILE: /tmp/f1-24185/base64.c:155:
+        (unsigned char) (pr2six[*bufin] << 2 | pr2six[bufin[1]] >> 4);$

WARNING: please, no spaces at the start of a line
#156: FILE: /tmp/f1-24185/base64.c:156:
+    }$

WARNING: please, no spaces at the start of a line
#157: FILE: /tmp/f1-24185/base64.c:157:
+    if (nprbytes > 2) {$

WARNING: suspect code indent for conditional statements (4, 4)
#157: FILE: /tmp/f1-24185/base64.c:157:
+    if (nprbytes > 2) {
+    *(bufout++) =

WARNING: please, no spaces at the start of a line
#158: FILE: /tmp/f1-24185/base64.c:158:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#159: FILE: /tmp/f1-24185/base64.c:159:
+        (unsigned char) (pr2six[bufin[1]] << 4 | pr2six[bufin[2]] >> 2);$

WARNING: please, no spaces at the start of a line
#159: FILE: /tmp/f1-24185/base64.c:159:
+        (unsigned char) (pr2six[bufin[1]] << 4 | pr2six[bufin[2]] >> 2);$

WARNING: please, no spaces at the start of a line
#160: FILE: /tmp/f1-24185/base64.c:160:
+    }$

WARNING: please, no spaces at the start of a line
#161: FILE: /tmp/f1-24185/base64.c:161:
+    if (nprbytes > 3) {$

WARNING: suspect code indent for conditional statements (4, 4)
#161: FILE: /tmp/f1-24185/base64.c:161:
+    if (nprbytes > 3) {
+    *(bufout++) =

WARNING: please, no spaces at the start of a line
#162: FILE: /tmp/f1-24185/base64.c:162:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#163: FILE: /tmp/f1-24185/base64.c:163:
+        (unsigned char) (pr2six[bufin[2]] << 6 | pr2six[bufin[3]]);$

WARNING: please, no spaces at the start of a line
#163: FILE: /tmp/f1-24185/base64.c:163:
+        (unsigned char) (pr2six[bufin[2]] << 6 | pr2six[bufin[3]]);$

WARNING: please, no spaces at the start of a line
#164: FILE: /tmp/f1-24185/base64.c:164:
+    }$

WARNING: please, no spaces at the start of a line
#166: FILE: /tmp/f1-24185/base64.c:166:
+    *(bufout++) = '\0';$

WARNING: please, no spaces at the start of a line
#167: FILE: /tmp/f1-24185/base64.c:167:
+    nbytesdecoded -= (4 - nprbytes) & 3;$

WARNING: please, no spaces at the start of a line
#168: FILE: /tmp/f1-24185/base64.c:168:
+    return nbytesdecoded;$

WARNING: please, no spaces at the start of a line
#172: FILE: /tmp/f1-24185/base64.c:172:
+    "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";$

WARNING: please, no spaces at the start of a line
#176: FILE: /tmp/f1-24185/base64.c:176:
+    return ((len + 2) / 3 * 4) + 1;$

WARNING: please, no spaces at the start of a line
#181: FILE: /tmp/f1-24185/base64.c:181:
+    int i;$

WARNING: please, no spaces at the start of a line
#182: FILE: /tmp/f1-24185/base64.c:182:
+    char *p;$

WARNING: please, no spaces at the start of a line
#184: FILE: /tmp/f1-24185/base64.c:184:
+    p = encoded;$

WARNING: please, no spaces at the start of a line
#185: FILE: /tmp/f1-24185/base64.c:185:
+    for (i = 0; i < len - 2; i += 3) {$

WARNING: suspect code indent for conditional statements (4, 4)
#185: FILE: /tmp/f1-24185/base64.c:185:
+    for (i = 0; i < len - 2; i += 3) {
+    *p++ = basis_64[(string[i] >> 2) & 0x3F];

WARNING: please, no spaces at the start of a line
#186: FILE: /tmp/f1-24185/base64.c:186:
+    *p++ = basis_64[(string[i] >> 2) & 0x3F];$

WARNING: please, no spaces at the start of a line
#187: FILE: /tmp/f1-24185/base64.c:187:
+    *p++ = basis_64[((string[i] & 0x3) << 4) |$

ERROR: code indent should use tabs where possible
#188: FILE: /tmp/f1-24185/base64.c:188:
+                    ((int) (string[i + 1] & 0xF0) >> 4)];$

WARNING: please, no spaces at the start of a line
#188: FILE: /tmp/f1-24185/base64.c:188:
+                    ((int) (string[i + 1] & 0xF0) >> 4)];$

WARNING: please, no spaces at the start of a line
#189: FILE: /tmp/f1-24185/base64.c:189:
+    *p++ = basis_64[((string[i + 1] & 0xF) << 2) |$

ERROR: code indent should use tabs where possible
#190: FILE: /tmp/f1-24185/base64.c:190:
+                    ((int) (string[i + 2] & 0xC0) >> 6)];$

WARNING: please, no spaces at the start of a line
#190: FILE: /tmp/f1-24185/base64.c:190:
+                    ((int) (string[i + 2] & 0xC0) >> 6)];$

WARNING: please, no spaces at the start of a line
#191: FILE: /tmp/f1-24185/base64.c:191:
+    *p++ = basis_64[string[i + 2] & 0x3F];$

WARNING: please, no spaces at the start of a line
#192: FILE: /tmp/f1-24185/base64.c:192:
+    }$

WARNING: please, no spaces at the start of a line
#193: FILE: /tmp/f1-24185/base64.c:193:
+    if (i < len) {$

WARNING: suspect code indent for conditional statements (4, 4)
#193: FILE: /tmp/f1-24185/base64.c:193:
+    if (i < len) {
+    *p++ = basis_64[(string[i] >> 2) & 0x3F];

WARNING: please, no spaces at the start of a line
#194: FILE: /tmp/f1-24185/base64.c:194:
+    *p++ = basis_64[(string[i] >> 2) & 0x3F];$

WARNING: please, no spaces at the start of a line
#195: FILE: /tmp/f1-24185/base64.c:195:
+    if (i == (len - 1)) {$

ERROR: code indent should use tabs where possible
#196: FILE: /tmp/f1-24185/base64.c:196:
+        *p++ = basis_64[((string[i] & 0x3) << 4)];$

WARNING: please, no spaces at the start of a line
#196: FILE: /tmp/f1-24185/base64.c:196:
+        *p++ = basis_64[((string[i] & 0x3) << 4)];$

ERROR: code indent should use tabs where possible
#197: FILE: /tmp/f1-24185/base64.c:197:
+        *p++ = '=';$

WARNING: please, no spaces at the start of a line
#197: FILE: /tmp/f1-24185/base64.c:197:
+        *p++ = '=';$

WARNING: please, no spaces at the start of a line
#198: FILE: /tmp/f1-24185/base64.c:198:
+    }$

WARNING: please, no spaces at the start of a line
#199: FILE: /tmp/f1-24185/base64.c:199:
+    else {$

ERROR: else should follow close brace '}'
#199: FILE: /tmp/f1-24185/base64.c:199:
+    }
+    else {

ERROR: code indent should use tabs where possible
#200: FILE: /tmp/f1-24185/base64.c:200:
+        *p++ = basis_64[((string[i] & 0x3) << 4) |$

WARNING: please, no spaces at the start of a line
#200: FILE: /tmp/f1-24185/base64.c:200:
+        *p++ = basis_64[((string[i] & 0x3) << 4) |$

ERROR: code indent should use tabs where possible
#201: FILE: /tmp/f1-24185/base64.c:201:
+                        ((int) (string[i + 1] & 0xF0) >> 4)];$

WARNING: please, no spaces at the start of a line
#201: FILE: /tmp/f1-24185/base64.c:201:
+                        ((int) (string[i + 1] & 0xF0) >> 4)];$

ERROR: code indent should use tabs where possible
#202: FILE: /tmp/f1-24185/base64.c:202:
+        *p++ = basis_64[((string[i + 1] & 0xF) << 2)];$

WARNING: please, no spaces at the start of a line
#202: FILE: /tmp/f1-24185/base64.c:202:
+        *p++ = basis_64[((string[i + 1] & 0xF) << 2)];$

WARNING: please, no spaces at the start of a line
#203: FILE: /tmp/f1-24185/base64.c:203:
+    }$

WARNING: please, no spaces at the start of a line
#204: FILE: /tmp/f1-24185/base64.c:204:
+    *p++ = '=';$

WARNING: please, no spaces at the start of a line
#205: FILE: /tmp/f1-24185/base64.c:205:
+    }$

WARNING: please, no spaces at the start of a line
#207: FILE: /tmp/f1-24185/base64.c:207:
+    *p++ = '\0';$

WARNING: please, no spaces at the start of a line
#208: FILE: /tmp/f1-24185/base64.c:208:
+    return p - encoded;$
Report for base64.h | 35 issues
===============================================
WARNING: Block comments should align the * on each line
#2: FILE: /tmp/f1-24185/base64.h:2:
+/*
+* Copyright (c) 2003 Apple Computer, Inc. All rights reserved.

WARNING: Block comments should align the * on each line
#26: FILE: /tmp/f1-24185/base64.h:26:
+/* ====================================================================
+* Copyright (c) 1995-1999 The Apache Group.  All rights reserved.

ERROR: "foo * bar" should be "foo *bar"
#92: FILE: /tmp/f1-24185/base64.h:92:
+int Base64encode(char * coded_dst, const char *plain_src,int len_plain_src);

ERROR: space required after that ',' (ctx:VxV)
#92: FILE: /tmp/f1-24185/base64.h:92:
+int Base64encode(char * coded_dst, const char *plain_src,int len_plain_src);
                                                         ^

ERROR: "foo * bar" should be "foo *bar"
#94: FILE: /tmp/f1-24185/base64.h:94:
+int Base64decode_len(const char * coded_src);

ERROR: "foo * bar" should be "foo *bar"
#95: FILE: /tmp/f1-24185/base64.h:95:
+int Base64decode(char * plain_dst, const char *coded_src);

WARNING: adding a line without newline at end of file
#101: FILE: /tmp/f1-24185/base64.h:101:
+#endif //_BASE64_H_

WARNING: C99 // comments do not match recommendation
#101: FILE: /tmp/f1-24185/base64.h:101:
+#endif //_BASE64_H_
Report for yang_wrappers.c | 6 issues
===============================================
< WARNING: Missing a blank line after declarations
< #688: FILE: /tmp/f1-24185/yang_wrappers.c:688:
< WARNING: Missing a blank line after declarations
< #690: FILE: /tmp/f1-24185/yang_wrappers.c:690:
< WARNING: Missing a blank line after declarations
< #701: FILE: /tmp/f1-24185/yang_wrappers.c:701:

idryzhov
idryzhov requested changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@idryzhov idryzhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one comment to the code, please, check it.
Other than that, I'm not sure we can just copy base64 implementation with another license to our code base. But I'm not an expert, so we'll need other people to check this out.

lib/yang_wrappers.c Outdated
int decode_len = Base64decode_len(canon);
char *value_str = (char *)malloc(decode_len);
Base64decode(value_str, canon);
if (strlcpy(buf, value_str, size) >= size) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't use strlcpy here. value_str is a binary data, not a NULL-terminated string.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have changed it to memcpy.

@whichbug
Copy link
Author

I have one comment to the code, please, check it. Other than that, I'm not sure we can just copy base64 implementation with another license to our code base. But I'm not an expert, so we'll need other people to check this out.

I looked at other files in frr/lib. It seems there are a few third-party files, e.g., skiplist.h, which has a different license with others like defaults.h. Anyway, please let me know when you are sure about how to handle such new files.

@donaldsharp
Copy link
Member

It's not as simple as someone else is using a different license The license must be compatible with what we are using. If it is not compatible then we will not accept it. At this moment we are looking into figuring out if this license is compatible for us to allow this to integrate.

@whichbug
Copy link
Author

It's not as simple as someone else is using a different license The license must be compatible with what we are using. If it is not compatible then we will not accept it. At this moment we are looking into figuring out if this license is compatible for us to allow this to integrate.

Sure. Let me know when you figure it out.

@Jafaral
Copy link
Member

Jafaral commented Feb 11, 2022

Mixed messages at https://www.gnu.org/philosophy/apsl.en.html , but the recommendation is to avoid using it.

I suggest we use a different implementation, ex:

https://salsa.debian.org/alteholz/libb64/-/tree/master/

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 11, 2022 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3396/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Successful on other platforms/tests
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 2
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 2
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 amd64 part 7
  • Fedora 29 rpm pkg check
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests debian 10 amd64 part 0
  • Addresssanitizer topotests part 9
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 amd64 part 3
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests debian 10 amd64 part 7
  • Topotests debian 10 amd64 part 3
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 amd64 part 6
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 arm8 part 4
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 9
  • Ubuntu 18.04 deb pkg check
  • Debian 10 deb pkg check
  • IPv6 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 i386 part 8
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests Ubuntu 18.04 amd64 part 9
  • Addresssanitizer topotests part 7
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 9
  • Static analyzer (clang)
  • Addresssanitizer topotests part 5
  • Topotests debian 10 amd64 part 1
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 8
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 16.04 deb pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found 
<stdin>:87: trailing whitespace.
 * 
<stdin>:89: trailing whitespace.
 * 
<stdin>:96: trailing whitespace.
 * 
<stdin>:104: trailing whitespace.
 * 
warning: 4 lines add whitespace errors.
Report for base64.c | 213 issues
===============================================
ERROR: trailing whitespace
#5: FILE: /tmp/f1-30676/base64.c:5:
+ * $

ERROR: trailing whitespace
#7: FILE: /tmp/f1-30676/base64.c:7:
+ * $

ERROR: trailing whitespace
#14: FILE: /tmp/f1-30676/base64.c:14:
+ * $

ERROR: trailing whitespace
#22: FILE: /tmp/f1-30676/base64.c:22:
+ * $

ERROR: that open brace { should be on the previous line
#91: FILE: /tmp/f1-30676/base64.c:91:
+static const unsigned char pr2six[256] =
+{

WARNING: please, no spaces at the start of a line
#93: FILE: /tmp/f1-30676/base64.c:93:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#94: FILE: /tmp/f1-30676/base64.c:94:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#95: FILE: /tmp/f1-30676/base64.c:95:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 62, 64, 64, 64, 63,$

WARNING: please, no spaces at the start of a line
#96: FILE: /tmp/f1-30676/base64.c:96:
+    52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#97: FILE: /tmp/f1-30676/base64.c:97:
+    64,  0,  1,  2,  3,  4,  5,  6,  7,  8,  9, 10, 11, 12, 13, 14,$

WARNING: please, no spaces at the start of a line
#98: FILE: /tmp/f1-30676/base64.c:98:
+    15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#99: FILE: /tmp/f1-30676/base64.c:99:
+    64, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40,$

WARNING: please, no spaces at the start of a line
#100: FILE: /tmp/f1-30676/base64.c:100:
+    41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#101: FILE: /tmp/f1-30676/base64.c:101:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#102: FILE: /tmp/f1-30676/base64.c:102:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#103: FILE: /tmp/f1-30676/base64.c:103:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#104: FILE: /tmp/f1-30676/base64.c:104:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#105: FILE: /tmp/f1-30676/base64.c:105:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#106: FILE: /tmp/f1-30676/base64.c:106:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#107: FILE: /tmp/f1-30676/base64.c:107:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#108: FILE: /tmp/f1-30676/base64.c:108:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64$

WARNING: please, no spaces at the start of a line
#113: FILE: /tmp/f1-30676/base64.c:113:
+    int nbytesdecoded;$

WARNING: Missing a blank line after declarations
#114: FILE: /tmp/f1-30676/base64.c:114:
+    int nbytesdecoded;
+    register const unsigned char *bufin;

WARNING: please, no spaces at the start of a line
#114: FILE: /tmp/f1-30676/base64.c:114:
+    register const unsigned char *bufin;$

WARNING: please, no spaces at the start of a line
#115: FILE: /tmp/f1-30676/base64.c:115:
+    register int nprbytes;$

WARNING: please, no spaces at the start of a line
#117: FILE: /tmp/f1-30676/base64.c:117:
+    bufin = (const unsigned char *) bufcoded;$

WARNING: please, no spaces at the start of a line
#118: FILE: /tmp/f1-30676/base64.c:118:
+    while (pr2six[*(bufin++)] <= 63);$

ERROR: trailing statements should be on next line
#118: FILE: /tmp/f1-30676/base64.c:118:
+    while (pr2six[*(bufin++)] <= 63);

WARNING: please, no spaces at the start of a line
#120: FILE: /tmp/f1-30676/base64.c:120:
+    nprbytes = (bufin - (const unsigned char *) bufcoded) - 1;$

WARNING: please, no spaces at the start of a line
#121: FILE: /tmp/f1-30676/base64.c:121:
+    nbytesdecoded = ((nprbytes + 3) / 4) * 3;$

WARNING: please, no spaces at the start of a line
#123: FILE: /tmp/f1-30676/base64.c:123:
+    return nbytesdecoded + 1;$

WARNING: please, no spaces at the start of a line
#128: FILE: /tmp/f1-30676/base64.c:128:
+    int nbytesdecoded;$

WARNING: please, no spaces at the start of a line
#129: FILE: /tmp/f1-30676/base64.c:129:
+    register const unsigned char *bufin;$

WARNING: please, no spaces at the start of a line
#130: FILE: /tmp/f1-30676/base64.c:130:
+    register unsigned char *bufout;$

WARNING: please, no spaces at the start of a line
#131: FILE: /tmp/f1-30676/base64.c:131:
+    register int nprbytes;$

WARNING: please, no spaces at the start of a line
#133: FILE: /tmp/f1-30676/base64.c:133:
+    bufin = (const unsigned char *) bufcoded;$

WARNING: please, no spaces at the start of a line
#134: FILE: /tmp/f1-30676/base64.c:134:
+    while (pr2six[*(bufin++)] <= 63);$

ERROR: trailing statements should be on next line
#134: FILE: /tmp/f1-30676/base64.c:134:
+    while (pr2six[*(bufin++)] <= 63);

WARNING: please, no spaces at the start of a line
#135: FILE: /tmp/f1-30676/base64.c:135:
+    nprbytes = (bufin - (const unsigned char *) bufcoded) - 1;$

WARNING: please, no spaces at the start of a line
#136: FILE: /tmp/f1-30676/base64.c:136:
+    nbytesdecoded = ((nprbytes + 3) / 4) * 3;$

WARNING: please, no spaces at the start of a line
#138: FILE: /tmp/f1-30676/base64.c:138:
+    bufout = (unsigned char *) bufplain;$

WARNING: please, no spaces at the start of a line
#139: FILE: /tmp/f1-30676/base64.c:139:
+    bufin = (const unsigned char *) bufcoded;$

WARNING: please, no spaces at the start of a line
#141: FILE: /tmp/f1-30676/base64.c:141:
+    while (nprbytes > 4) {$

WARNING: suspect code indent for conditional statements (4, 4)
#141: FILE: /tmp/f1-30676/base64.c:141:
+    while (nprbytes > 4) {
+    *(bufout++) =

WARNING: please, no spaces at the start of a line
#142: FILE: /tmp/f1-30676/base64.c:142:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#143: FILE: /tmp/f1-30676/base64.c:143:
+        (unsigned char) (pr2six[*bufin] << 2 | pr2six[bufin[1]] >> 4);$

WARNING: please, no spaces at the start of a line
#143: FILE: /tmp/f1-30676/base64.c:143:
+        (unsigned char) (pr2six[*bufin] << 2 | pr2six[bufin[1]] >> 4);$

WARNING: please, no spaces at the start of a line
#144: FILE: /tmp/f1-30676/base64.c:144:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#145: FILE: /tmp/f1-30676/base64.c:145:
+        (unsigned char) (pr2six[bufin[1]] << 4 | pr2six[bufin[2]] >> 2);$

WARNING: please, no spaces at the start of a line
#145: FILE: /tmp/f1-30676/base64.c:145:
+        (unsigned char) (pr2six[bufin[1]] << 4 | pr2six[bufin[2]] >> 2);$

WARNING: please, no spaces at the start of a line
#146: FILE: /tmp/f1-30676/base64.c:146:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#147: FILE: /tmp/f1-30676/base64.c:147:
+        (unsigned char) (pr2six[bufin[2]] << 6 | pr2six[bufin[3]]);$

WARNING: please, no spaces at the start of a line
#147: FILE: /tmp/f1-30676/base64.c:147:
+        (unsigned char) (pr2six[bufin[2]] << 6 | pr2six[bufin[3]]);$

WARNING: please, no spaces at the start of a line
#148: FILE: /tmp/f1-30676/base64.c:148:
+    bufin += 4;$

WARNING: please, no spaces at the start of a line
#149: FILE: /tmp/f1-30676/base64.c:149:
+    nprbytes -= 4;$

WARNING: please, no spaces at the start of a line
#150: FILE: /tmp/f1-30676/base64.c:150:
+    }$

WARNING: please, no spaces at the start of a line
#153: FILE: /tmp/f1-30676/base64.c:153:
+    if (nprbytes > 1) {$

WARNING: suspect code indent for conditional statements (4, 4)
#153: FILE: /tmp/f1-30676/base64.c:153:
+    if (nprbytes > 1) {
+    *(bufout++) =

WARNING: please, no spaces at the start of a line
#154: FILE: /tmp/f1-30676/base64.c:154:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#155: FILE: /tmp/f1-30676/base64.c:155:
+        (unsigned char) (pr2six[*bufin] << 2 | pr2six[bufin[1]] >> 4);$

WARNING: please, no spaces at the start of a line
#155: FILE: /tmp/f1-30676/base64.c:155:
+        (unsigned char) (pr2six[*bufin] << 2 | pr2six[bufin[1]] >> 4);$

WARNING: please, no spaces at the start of a line
#156: FILE: /tmp/f1-30676/base64.c:156:
+    }$

WARNING: please, no spaces at the start of a line
#157: FILE: /tmp/f1-30676/base64.c:157:
+    if (nprbytes > 2) {$

WARNING: suspect code indent for conditional statements (4, 4)
#157: FILE: /tmp/f1-30676/base64.c:157:
+    if (nprbytes > 2) {
+    *(bufout++) =

WARNING: please, no spaces at the start of a line
#158: FILE: /tmp/f1-30676/base64.c:158:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#159: FILE: /tmp/f1-30676/base64.c:159:
+        (unsigned char) (pr2six[bufin[1]] << 4 | pr2six[bufin[2]] >> 2);$

WARNING: please, no spaces at the start of a line
#159: FILE: /tmp/f1-30676/base64.c:159:
+        (unsigned char) (pr2six[bufin[1]] << 4 | pr2six[bufin[2]] >> 2);$

WARNING: please, no spaces at the start of a line
#160: FILE: /tmp/f1-30676/base64.c:160:
+    }$

WARNING: please, no spaces at the start of a line
#161: FILE: /tmp/f1-30676/base64.c:161:
+    if (nprbytes > 3) {$

WARNING: suspect code indent for conditional statements (4, 4)
#161: FILE: /tmp/f1-30676/base64.c:161:
+    if (nprbytes > 3) {
+    *(bufout++) =

WARNING: please, no spaces at the start of a line
#162: FILE: /tmp/f1-30676/base64.c:162:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#163: FILE: /tmp/f1-30676/base64.c:163:
+        (unsigned char) (pr2six[bufin[2]] << 6 | pr2six[bufin[3]]);$

WARNING: please, no spaces at the start of a line
#163: FILE: /tmp/f1-30676/base64.c:163:
+        (unsigned char) (pr2six[bufin[2]] << 6 | pr2six[bufin[3]]);$

WARNING: please, no spaces at the start of a line
#164: FILE: /tmp/f1-30676/base64.c:164:
+    }$

WARNING: please, no spaces at the start of a line
#166: FILE: /tmp/f1-30676/base64.c:166:
+    *(bufout++) = '\0';$

WARNING: please, no spaces at the start of a line
#167: FILE: /tmp/f1-30676/base64.c:167:
+    nbytesdecoded -= (4 - nprbytes) & 3;$

WARNING: please, no spaces at the start of a line
#168: FILE: /tmp/f1-30676/base64.c:168:
+    return nbytesdecoded;$

WARNING: please, no spaces at the start of a line
#172: FILE: /tmp/f1-30676/base64.c:172:
+    "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";$

WARNING: please, no spaces at the start of a line
#176: FILE: /tmp/f1-30676/base64.c:176:
+    return ((len + 2) / 3 * 4) + 1;$

WARNING: please, no spaces at the start of a line
#181: FILE: /tmp/f1-30676/base64.c:181:
+    int i;$

WARNING: please, no spaces at the start of a line
#182: FILE: /tmp/f1-30676/base64.c:182:
+    char *p;$

WARNING: please, no spaces at the start of a line
#184: FILE: /tmp/f1-30676/base64.c:184:
+    p = encoded;$

WARNING: please, no spaces at the start of a line
#185: FILE: /tmp/f1-30676/base64.c:185:
+    for (i = 0; i < len - 2; i += 3) {$

WARNING: suspect code indent for conditional statements (4, 4)
#185: FILE: /tmp/f1-30676/base64.c:185:
+    for (i = 0; i < len - 2; i += 3) {
+    *p++ = basis_64[(string[i] >> 2) & 0x3F];

WARNING: please, no spaces at the start of a line
#186: FILE: /tmp/f1-30676/base64.c:186:
+    *p++ = basis_64[(string[i] >> 2) & 0x3F];$

WARNING: please, no spaces at the start of a line
#187: FILE: /tmp/f1-30676/base64.c:187:
+    *p++ = basis_64[((string[i] & 0x3) << 4) |$

ERROR: code indent should use tabs where possible
#188: FILE: /tmp/f1-30676/base64.c:188:
+                    ((int) (string[i + 1] & 0xF0) >> 4)];$

WARNING: please, no spaces at the start of a line
#188: FILE: /tmp/f1-30676/base64.c:188:
+                    ((int) (string[i + 1] & 0xF0) >> 4)];$

WARNING: please, no spaces at the start of a line
#189: FILE: /tmp/f1-30676/base64.c:189:
+    *p++ = basis_64[((string[i + 1] & 0xF) << 2) |$

ERROR: code indent should use tabs where possible
#190: FILE: /tmp/f1-30676/base64.c:190:
+                    ((int) (string[i + 2] & 0xC0) >> 6)];$

WARNING: please, no spaces at the start of a line
#190: FILE: /tmp/f1-30676/base64.c:190:
+                    ((int) (string[i + 2] & 0xC0) >> 6)];$

WARNING: please, no spaces at the start of a line
#191: FILE: /tmp/f1-30676/base64.c:191:
+    *p++ = basis_64[string[i + 2] & 0x3F];$

WARNING: please, no spaces at the start of a line
#192: FILE: /tmp/f1-30676/base64.c:192:
+    }$

WARNING: please, no spaces at the start of a line
#193: FILE: /tmp/f1-30676/base64.c:193:
+    if (i < len) {$

WARNING: suspect code indent for conditional statements (4, 4)
#193: FILE: /tmp/f1-30676/base64.c:193:
+    if (i < len) {
+    *p++ = basis_64[(string[i] >> 2) & 0x3F];

WARNING: please, no spaces at the start of a line
#194: FILE: /tmp/f1-30676/base64.c:194:
+    *p++ = basis_64[(string[i] >> 2) & 0x3F];$

WARNING: please, no spaces at the start of a line
#195: FILE: /tmp/f1-30676/base64.c:195:
+    if (i == (len - 1)) {$

ERROR: code indent should use tabs where possible
#196: FILE: /tmp/f1-30676/base64.c:196:
+        *p++ = basis_64[((string[i] & 0x3) << 4)];$

WARNING: please, no spaces at the start of a line
#196: FILE: /tmp/f1-30676/base64.c:196:
+        *p++ = basis_64[((string[i] & 0x3) << 4)];$

ERROR: code indent should use tabs where possible
#197: FILE: /tmp/f1-30676/base64.c:197:
+        *p++ = '=';$

WARNING: please, no spaces at the start of a line
#197: FILE: /tmp/f1-30676/base64.c:197:
+        *p++ = '=';$

WARNING: please, no spaces at the start of a line
#198: FILE: /tmp/f1-30676/base64.c:198:
+    }$

WARNING: please, no spaces at the start of a line
#199: FILE: /tmp/f1-30676/base64.c:199:
+    else {$

ERROR: else should follow close brace '}'
#199: FILE: /tmp/f1-30676/base64.c:199:
+    }
+    else {

ERROR: code indent should use tabs where possible
#200: FILE: /tmp/f1-30676/base64.c:200:
+        *p++ = basis_64[((string[i] & 0x3) << 4) |$

WARNING: please, no spaces at the start of a line
#200: FILE: /tmp/f1-30676/base64.c:200:
+        *p++ = basis_64[((string[i] & 0x3) << 4) |$

ERROR: code indent should use tabs where possible
#201: FILE: /tmp/f1-30676/base64.c:201:
+                        ((int) (string[i + 1] & 0xF0) >> 4)];$

WARNING: please, no spaces at the start of a line
#201: FILE: /tmp/f1-30676/base64.c:201:
+                        ((int) (string[i + 1] & 0xF0) >> 4)];$

ERROR: code indent should use tabs where possible
#202: FILE: /tmp/f1-30676/base64.c:202:
+        *p++ = basis_64[((string[i + 1] & 0xF) << 2)];$

WARNING: please, no spaces at the start of a line
#202: FILE: /tmp/f1-30676/base64.c:202:
+        *p++ = basis_64[((string[i + 1] & 0xF) << 2)];$

WARNING: please, no spaces at the start of a line
#203: FILE: /tmp/f1-30676/base64.c:203:
+    }$

WARNING: please, no spaces at the start of a line
#204: FILE: /tmp/f1-30676/base64.c:204:
+    *p++ = '=';$

WARNING: please, no spaces at the start of a line
#205: FILE: /tmp/f1-30676/base64.c:205:
+    }$

WARNING: please, no spaces at the start of a line
#207: FILE: /tmp/f1-30676/base64.c:207:
+    *p++ = '\0';$

WARNING: please, no spaces at the start of a line
#208: FILE: /tmp/f1-30676/base64.c:208:
+    return p - encoded;$
Report for base64.h | 35 issues
===============================================
WARNING: Block comments should align the * on each line
#2: FILE: /tmp/f1-30676/base64.h:2:
+/*
+* Copyright (c) 2003 Apple Computer, Inc. All rights reserved.

WARNING: Block comments should align the * on each line
#26: FILE: /tmp/f1-30676/base64.h:26:
+/* ====================================================================
+* Copyright (c) 1995-1999 The Apache Group.  All rights reserved.

ERROR: "foo * bar" should be "foo *bar"
#92: FILE: /tmp/f1-30676/base64.h:92:
+int Base64encode(char * coded_dst, const char *plain_src,int len_plain_src);

ERROR: space required after that ',' (ctx:VxV)
#92: FILE: /tmp/f1-30676/base64.h:92:
+int Base64encode(char * coded_dst, const char *plain_src,int len_plain_src);
                                                         ^

ERROR: "foo * bar" should be "foo *bar"
#94: FILE: /tmp/f1-30676/base64.h:94:
+int Base64decode_len(const char * coded_src);

ERROR: "foo * bar" should be "foo *bar"
#95: FILE: /tmp/f1-30676/base64.h:95:
+int Base64decode(char * plain_dst, const char *coded_src);

WARNING: adding a line without newline at end of file
#101: FILE: /tmp/f1-30676/base64.h:101:
+#endif //_BASE64_H_

WARNING: C99 // comments do not match recommendation
#101: FILE: /tmp/f1-30676/base64.h:101:
+#endif //_BASE64_H_
Report for yang_wrappers.c | 6 issues
===============================================
< WARNING: Missing a blank line after declarations
< #688: FILE: /tmp/f1-30676/yang_wrappers.c:688:
< WARNING: Missing a blank line after declarations
< #690: FILE: /tmp/f1-30676/yang_wrappers.c:690:
< WARNING: Missing a blank line after declarations
< #701: FILE: /tmp/f1-30676/yang_wrappers.c:701:

@whichbug
Copy link
Author

Mixed messages at https://www.gnu.org/philosophy/apsl.en.html , but the recommendation is to avoid using it.

I suggest we use a different implementation, ex:

https://salsa.debian.org/alteholz/libb64/-/tree/master/

Do you reach a consensus on using this library https://salsa.debian.org/alteholz/libb64/-/tree/master/ ?

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 11, 2022 •
edited
Loading

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3399/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for base64.c | 197 issues
===============================================
ERROR: that open brace { should be on the previous line
#91: FILE: /tmp/f1-14805/base64.c:91:
+static const unsigned char pr2six[256] =
+{

WARNING: please, no spaces at the start of a line
#93: FILE: /tmp/f1-14805/base64.c:93:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#94: FILE: /tmp/f1-14805/base64.c:94:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#95: FILE: /tmp/f1-14805/base64.c:95:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 62, 64, 64, 64, 63,$

WARNING: please, no spaces at the start of a line
#96: FILE: /tmp/f1-14805/base64.c:96:
+    52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#97: FILE: /tmp/f1-14805/base64.c:97:
+    64,  0,  1,  2,  3,  4,  5,  6,  7,  8,  9, 10, 11, 12, 13, 14,$

WARNING: please, no spaces at the start of a line
#98: FILE: /tmp/f1-14805/base64.c:98:
+    15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#99: FILE: /tmp/f1-14805/base64.c:99:
+    64, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40,$

WARNING: please, no spaces at the start of a line
#100: FILE: /tmp/f1-14805/base64.c:100:
+    41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#101: FILE: /tmp/f1-14805/base64.c:101:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#102: FILE: /tmp/f1-14805/base64.c:102:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#103: FILE: /tmp/f1-14805/base64.c:103:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#104: FILE: /tmp/f1-14805/base64.c:104:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#105: FILE: /tmp/f1-14805/base64.c:105:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#106: FILE: /tmp/f1-14805/base64.c:106:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#107: FILE: /tmp/f1-14805/base64.c:107:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64,$

WARNING: please, no spaces at the start of a line
#108: FILE: /tmp/f1-14805/base64.c:108:
+    64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64, 64$

WARNING: please, no spaces at the start of a line
#113: FILE: /tmp/f1-14805/base64.c:113:
+    int nbytesdecoded;$

WARNING: Missing a blank line after declarations
#114: FILE: /tmp/f1-14805/base64.c:114:
+    int nbytesdecoded;
+    register const unsigned char *bufin;

WARNING: please, no spaces at the start of a line
#114: FILE: /tmp/f1-14805/base64.c:114:
+    register const unsigned char *bufin;$

WARNING: please, no spaces at the start of a line
#115: FILE: /tmp/f1-14805/base64.c:115:
+    register int nprbytes;$

WARNING: please, no spaces at the start of a line
#117: FILE: /tmp/f1-14805/base64.c:117:
+    bufin = (const unsigned char *) bufcoded;$

WARNING: please, no spaces at the start of a line
#118: FILE: /tmp/f1-14805/base64.c:118:
+    while (pr2six[*(bufin++)] <= 63);$

ERROR: trailing statements should be on next line
#118: FILE: /tmp/f1-14805/base64.c:118:
+    while (pr2six[*(bufin++)] <= 63);

WARNING: please, no spaces at the start of a line
#120: FILE: /tmp/f1-14805/base64.c:120:
+    nprbytes = (bufin - (const unsigned char *) bufcoded) - 1;$

WARNING: please, no spaces at the start of a line
#121: FILE: /tmp/f1-14805/base64.c:121:
+    nbytesdecoded = ((nprbytes + 3) / 4) * 3;$

WARNING: please, no spaces at the start of a line
#123: FILE: /tmp/f1-14805/base64.c:123:
+    return nbytesdecoded + 1;$

WARNING: please, no spaces at the start of a line
#128: FILE: /tmp/f1-14805/base64.c:128:
+    int nbytesdecoded;$

WARNING: please, no spaces at the start of a line
#129: FILE: /tmp/f1-14805/base64.c:129:
+    register const unsigned char *bufin;$

WARNING: please, no spaces at the start of a line
#130: FILE: /tmp/f1-14805/base64.c:130:
+    register unsigned char *bufout;$

WARNING: please, no spaces at the start of a line
#131: FILE: /tmp/f1-14805/base64.c:131:
+    register int nprbytes;$

WARNING: please, no spaces at the start of a line
#133: FILE: /tmp/f1-14805/base64.c:133:
+    bufin = (const unsigned char *) bufcoded;$

WARNING: please, no spaces at the start of a line
#134: FILE: /tmp/f1-14805/base64.c:134:
+    while (pr2six[*(bufin++)] <= 63);$

ERROR: trailing statements should be on next line
#134: FILE: /tmp/f1-14805/base64.c:134:
+    while (pr2six[*(bufin++)] <= 63);

WARNING: please, no spaces at the start of a line
#135: FILE: /tmp/f1-14805/base64.c:135:
+    nprbytes = (bufin - (const unsigned char *) bufcoded) - 1;$

WARNING: please, no spaces at the start of a line
#136: FILE: /tmp/f1-14805/base64.c:136:
+    nbytesdecoded = ((nprbytes + 3) / 4) * 3;$

WARNING: please, no spaces at the start of a line
#138: FILE: /tmp/f1-14805/base64.c:138:
+    bufout = (unsigned char *) bufplain;$

WARNING: please, no spaces at the start of a line
#139: FILE: /tmp/f1-14805/base64.c:139:
+    bufin = (const unsigned char *) bufcoded;$

WARNING: please, no spaces at the start of a line
#141: FILE: /tmp/f1-14805/base64.c:141:
+    while (nprbytes > 4) {$

WARNING: suspect code indent for conditional statements (4, 4)
#141: FILE: /tmp/f1-14805/base64.c:141:
+    while (nprbytes > 4) {
+    *(bufout++) =

WARNING: please, no spaces at the start of a line
#142: FILE: /tmp/f1-14805/base64.c:142:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#143: FILE: /tmp/f1-14805/base64.c:143:
+        (unsigned char) (pr2six[*bufin] << 2 | pr2six[bufin[1]] >> 4);$

WARNING: please, no spaces at the start of a line
#143: FILE: /tmp/f1-14805/base64.c:143:
+        (unsigned char) (pr2six[*bufin] << 2 | pr2six[bufin[1]] >> 4);$

WARNING: please, no spaces at the start of a line
#144: FILE: /tmp/f1-14805/base64.c:144:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#145: FILE: /tmp/f1-14805/base64.c:145:
+        (unsigned char) (pr2six[bufin[1]] << 4 | pr2six[bufin[2]] >> 2);$

WARNING: please, no spaces at the start of a line
#145: FILE: /tmp/f1-14805/base64.c:145:
+        (unsigned char) (pr2six[bufin[1]] << 4 | pr2six[bufin[2]] >> 2);$

WARNING: please, no spaces at the start of a line
#146: FILE: /tmp/f1-14805/base64.c:146:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#147: FILE: /tmp/f1-14805/base64.c:147:
+        (unsigned char) (pr2six[bufin[2]] << 6 | pr2six[bufin[3]]);$

WARNING: please, no spaces at the start of a line
#147: FILE: /tmp/f1-14805/base64.c:147:
+        (unsigned char) (pr2six[bufin[2]] << 6 | pr2six[bufin[3]]);$

WARNING: please, no spaces at the start of a line
#148: FILE: /tmp/f1-14805/base64.c:148:
+    bufin += 4;$

WARNING: please, no spaces at the start of a line
#149: FILE: /tmp/f1-14805/base64.c:149:
+    nprbytes -= 4;$

WARNING: please, no spaces at the start of a line
#150: FILE: /tmp/f1-14805/base64.c:150:
+    }$

WARNING: please, no spaces at the start of a line
#153: FILE: /tmp/f1-14805/base64.c:153:
+    if (nprbytes > 1) {$

WARNING: suspect code indent for conditional statements (4, 4)
#153: FILE: /tmp/f1-14805/base64.c:153:
+    if (nprbytes > 1) {
+    *(bufout++) =

WARNING: please, no spaces at the start of a line
#154: FILE: /tmp/f1-14805/base64.c:154:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#155: FILE: /tmp/f1-14805/base64.c:155:
+        (unsigned char) (pr2six[*bufin] << 2 | pr2six[bufin[1]] >> 4);$

WARNING: please, no spaces at the start of a line
#155: FILE: /tmp/f1-14805/base64.c:155:
+        (unsigned char) (pr2six[*bufin] << 2 | pr2six[bufin[1]] >> 4);$

WARNING: please, no spaces at the start of a line
#156: FILE: /tmp/f1-14805/base64.c:156:
+    }$

WARNING: please, no spaces at the start of a line
#157: FILE: /tmp/f1-14805/base64.c:157:
+    if (nprbytes > 2) {$

WARNING: suspect code indent for conditional statements (4, 4)
#157: FILE: /tmp/f1-14805/base64.c:157:
+    if (nprbytes > 2) {
+    *(bufout++) =

WARNING: please, no spaces at the start of a line
#158: FILE: /tmp/f1-14805/base64.c:158:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#159: FILE: /tmp/f1-14805/base64.c:159:
+        (unsigned char) (pr2six[bufin[1]] << 4 | pr2six[bufin[2]] >> 2);$

WARNING: please, no spaces at the start of a line
#159: FILE: /tmp/f1-14805/base64.c:159:
+        (unsigned char) (pr2six[bufin[1]] << 4 | pr2six[bufin[2]] >> 2);$

WARNING: please, no spaces at the start of a line
#160: FILE: /tmp/f1-14805/base64.c:160:
+    }$

WARNING: please, no spaces at the start of a line
#161: FILE: /tmp/f1-14805/base64.c:161:
+    if (nprbytes > 3) {$

WARNING: suspect code indent for conditional statements (4, 4)
#161: FILE: /tmp/f1-14805/base64.c:161:
+    if (nprbytes > 3) {
+    *(bufout++) =

WARNING: please, no spaces at the start of a line
#162: FILE: /tmp/f1-14805/base64.c:162:
+    *(bufout++) =$

ERROR: code indent should use tabs where possible
#163: FILE: /tmp/f1-14805/base64.c:163:
+        (unsigned char) (pr2six[bufin[2]] << 6 | pr2six[bufin[3]]);$

WARNING: please, no spaces at the start of a line
#163: FILE: /tmp/f1-14805/base64.c:163:
+        (unsigned char) (pr2six[bufin[2]] << 6 | pr2six[bufin[3]]);$

WARNING: please, no spaces at the start of a line
#164: FILE: /tmp/f1-14805/base64.c:164:
+    }$

WARNING: please, no spaces at the start of a line
#166: FILE: /tmp/f1-14805/base64.c:166:
+    *(bufout++) = '\0';$

WARNING: please, no spaces at the start of a line
#167: FILE: /tmp/f1-14805/base64.c:167:
+    nbytesdecoded -= (4 - nprbytes) & 3;$

WARNING: please, no spaces at the start of a line
#168: FILE: /tmp/f1-14805/base64.c:168:
+    return nbytesdecoded;$

WARNING: please, no spaces at the start of a line
#172: FILE: /tmp/f1-14805/base64.c:172:
+    "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";$

WARNING: please, no spaces at the start of a line
#176: FILE: /tmp/f1-14805/base64.c:176:
+    return ((len + 2) / 3 * 4) + 1;$

WARNING: please, no spaces at the start of a line
#181: FILE: /tmp/f1-14805/base64.c:181:
+    int i;$

WARNING: please, no spaces at the start of a line
#182: FILE: /tmp/f1-14805/base64.c:182:
+    char *p;$

WARNING: please, no spaces at the start of a line
#184: FILE: /tmp/f1-14805/base64.c:184:
+    p = encoded;$

WARNING: please, no spaces at the start of a line
#185: FILE: /tmp/f1-14805/base64.c:185:
+    for (i = 0; i < len - 2; i += 3) {$

WARNING: suspect code indent for conditional statements (4, 4)
#185: FILE: /tmp/f1-14805/base64.c:185:
+    for (i = 0; i < len - 2; i += 3) {
+    *p++ = basis_64[(string[i] >> 2) & 0x3F];

WARNING: please, no spaces at the start of a line
#186: FILE: /tmp/f1-14805/base64.c:186:
+    *p++ = basis_64[(string[i] >> 2) & 0x3F];$

WARNING: please, no spaces at the start of a line
#187: FILE: /tmp/f1-14805/base64.c:187:
+    *p++ = basis_64[((string[i] & 0x3) << 4) |$

ERROR: code indent should use tabs where possible
#188: FILE: /tmp/f1-14805/base64.c:188:
+                    ((int) (string[i + 1] & 0xF0) >> 4)];$

WARNING: please, no spaces at the start of a line
#188: FILE: /tmp/f1-14805/base64.c:188:
+                    ((int) (string[i + 1] & 0xF0) >> 4)];$

WARNING: please, no spaces at the start of a line
#189: FILE: /tmp/f1-14805/base64.c:189:
+    *p++ = basis_64[((string[i + 1] & 0xF) << 2) |$

ERROR: code indent should use tabs where possible
#190: FILE: /tmp/f1-14805/base64.c:190:
+                    ((int) (string[i + 2] & 0xC0) >> 6)];$

WARNING: please, no spaces at the start of a line
#190: FILE: /tmp/f1-14805/base64.c:190:
+                    ((int) (string[i + 2] & 0xC0) >> 6)];$

WARNING: please, no spaces at the start of a line
#191: FILE: /tmp/f1-14805/base64.c:191:
+    *p++ = basis_64[string[i + 2] & 0x3F];$

WARNING: please, no spaces at the start of a line
#192: FILE: /tmp/f1-14805/base64.c:192:
+    }$

WARNING: please, no spaces at the start of a line
#193: FILE: /tmp/f1-14805/base64.c:193:
+    if (i < len) {$

WARNING: suspect code indent for conditional statements (4, 4)
#193: FILE: /tmp/f1-14805/base64.c:193:
+    if (i < len) {
+    *p++ = basis_64[(string[i] >> 2) & 0x3F];

WARNING: please, no spaces at the start of a line
#194: FILE: /tmp/f1-14805/base64.c:194:
+    *p++ = basis_64[(string[i] >> 2) & 0x3F];$

WARNING: please, no spaces at the start of a line
#195: FILE: /tmp/f1-14805/base64.c:195:
+    if (i == (len - 1)) {$

ERROR: code indent should use tabs where possible
#196: FILE: /tmp/f1-14805/base64.c:196:
+        *p++ = basis_64[((string[i] & 0x3) << 4)];$

WARNING: please, no spaces at the start of a line
#196: FILE: /tmp/f1-14805/base64.c:196:
+        *p++ = basis_64[((string[i] & 0x3) << 4)];$

ERROR: code indent should use tabs where possible
#197: FILE: /tmp/f1-14805/base64.c:197:
+        *p++ = '=';$

WARNING: please, no spaces at the start of a line
#197: FILE: /tmp/f1-14805/base64.c:197:
+        *p++ = '=';$

WARNING: please, no spaces at the start of a line
#198: FILE: /tmp/f1-14805/base64.c:198:
+    }$

WARNING: please, no spaces at the start of a line
#199: FILE: /tmp/f1-14805/base64.c:199:
+    else {$

ERROR: else should follow close brace '}'
#199: FILE: /tmp/f1-14805/base64.c:199:
+    }
+    else {

ERROR: code indent should use tabs where possible
#200: FILE: /tmp/f1-14805/base64.c:200:
+        *p++ = basis_64[((string[i] & 0x3) << 4) |$

WARNING: please, no spaces at the start of a line
#200: FILE: /tmp/f1-14805/base64.c:200:
+        *p++ = basis_64[((string[i] & 0x3) << 4) |$

ERROR: code indent should use tabs where possible
#201: FILE: /tmp/f1-14805/base64.c:201:
+                        ((int) (string[i + 1] & 0xF0) >> 4)];$

WARNING: please, no spaces at the start of a line
#201: FILE: /tmp/f1-14805/base64.c:201:
+                        ((int) (string[i + 1] & 0xF0) >> 4)];$

ERROR: code indent should use tabs where possible
#202: FILE: /tmp/f1-14805/base64.c:202:
+        *p++ = basis_64[((string[i + 1] & 0xF) << 2)];$

WARNING: please, no spaces at the start of a line
#202: FILE: /tmp/f1-14805/base64.c:202:
+        *p++ = basis_64[((string[i + 1] & 0xF) << 2)];$

WARNING: please, no spaces at the start of a line
#203: FILE: /tmp/f1-14805/base64.c:203:
+    }$

WARNING: please, no spaces at the start of a line
#204: FILE: /tmp/f1-14805/base64.c:204:
+    *p++ = '=';$

WARNING: please, no spaces at the start of a line
#205: FILE: /tmp/f1-14805/base64.c:205:
+    }$

WARNING: please, no spaces at the start of a line
#207: FILE: /tmp/f1-14805/base64.c:207:
+    *p++ = '\0';$

WARNING: please, no spaces at the start of a line
#208: FILE: /tmp/f1-14805/base64.c:208:
+    return p - encoded;$
Report for base64.h | 31 issues
===============================================
WARNING: Block comments should align the * on each line
#2: FILE: /tmp/f1-14805/base64.h:2:
+/*
+* Copyright (c) 2003 Apple Computer, Inc. All rights reserved.

WARNING: Block comments should align the * on each line
#26: FILE: /tmp/f1-14805/base64.h:26:
+/* ====================================================================
+* Copyright (c) 1995-1999 The Apache Group.  All rights reserved.

ERROR: "foo * bar" should be "foo *bar"
#92: FILE: /tmp/f1-14805/base64.h:92:
+int Base64encode(char * coded_dst, const char *plain_src,int len_plain_src);

ERROR: space required after that ',' (ctx:VxV)
#92: FILE: /tmp/f1-14805/base64.h:92:
+int Base64encode(char * coded_dst, const char *plain_src,int len_plain_src);
                                                         ^

ERROR: "foo * bar" should be "foo *bar"
#94: FILE: /tmp/f1-14805/base64.h:94:
+int Base64decode_len(const char * coded_src);

ERROR: "foo * bar" should be "foo *bar"
#95: FILE: /tmp/f1-14805/base64.h:95:
+int Base64decode(char * plain_dst, const char *coded_src);

WARNING: C99 // comments do not match recommendation
#101: FILE: /tmp/f1-14805/base64.h:101:
+#endif //_BASE64_H_
Report for yang_wrappers.c | 6 issues
===============================================
< WARNING: Missing a blank line after declarations
< #688: FILE: /tmp/f1-14805/yang_wrappers.c:688:
< WARNING: Missing a blank line after declarations
< #690: FILE: /tmp/f1-14805/yang_wrappers.c:690:
< WARNING: Missing a blank line after declarations
< #701: FILE: /tmp/f1-14805/yang_wrappers.c:701:

@Jafaral
Copy link
Member

Jafaral commented Feb 18, 2022

@whichbug , let us go with libb64 source code please.

@whichbug whichbug force-pushed the master branch 2 times, most recently from 8adc385 to c683634 Compare February 19, 2022 23:10
@whichbug
Copy link
Author

whichbug commented Feb 19, 2022 •
edited
Loading

@whichbug , let us go with libb64 source code please.

updated. but you can see from the CI results that this libb64 leads to a lot of compiler warnings, and some warnings lead to failure of compiling. To eliminate these compilation failures, I have to slightly revise the code in libb64.

perhaps we need to find another reliable base64 lib. please suggest if more changes are required.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 19, 2022 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.3563/frr-source/doc/user/zebra.rst:1380: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
lib/base64.c: In function 'base64_encode_block':
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function 'base64_decode_block':
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/CI009BUILD/config.log/config.log.gz

Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/DEB10BUILD/config.log/config.log.gz

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/DEB10BUILD/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/CI101BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/DEB11AMD64/config.status/config.status

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/DEB11AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.3563/frr-source/doc/user/zebra.rst:1380: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Debian 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/DEB11AMD64/config.log/config.log.gz

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U16ARM8BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U1804AMD64/config.status/config.status
Ubuntu 18.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U1804AMD64/config.log/config.log.gz

Ubuntu 18.04 i386 build: Failed (click for details) Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U18I386BUILD/config.status/config.status

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here
Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/REDHAT8/config.log/config.log.gz

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/REDHAT8/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/REDHAT8/config.status/config.status

NetBSD 9 amd64 build: Failed (click for details) NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function 'base64_encode_block':
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function 'base64_decode_block':
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/CI012BUILD/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U2004AMD64BUILD/config.log/config.log.gz

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_encode_block:

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function 'base64_encode_block':
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function 'base64_decode_block':
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/FBSD12AMD64/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_encode_block:

Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U18ARM7BUILD/config.log/config.log.gz
Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U18ARM7BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/F29BUILD/config.status/config.status
Fedora 29 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/F29BUILD/config.log/config.log.gz

Ubuntu 18.04 arm8 build: Failed (click for details) Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_encode_block:
Successful on other platforms/tests
  • Ubuntu 16.04 i386 build
  • Ubuntu 16.04 amd64 build
  • OpenBSD 7 amd64 build
  • CentOS 7 amd64 build
  • Debian 9 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.3563/frr-source/doc/user/zebra.rst:1380: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
lib/base64.c: In function 'base64_encode_block':
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function 'base64_decode_block':
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/CI009BUILD/config.log/config.log.gz

Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/DEB10BUILD/config.log/config.log.gz

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/DEB10BUILD/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/CI101BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/DEB11AMD64/config.status/config.status

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/DEB11AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.3563/frr-source/doc/user/zebra.rst:1380: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Debian 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/DEB11AMD64/config.log/config.log.gz

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U16ARM8BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U1804AMD64/config.status/config.status
Ubuntu 18.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U1804AMD64/config.log/config.log.gz

Ubuntu 18.04 i386 build: Failed (click for details) Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U18I386BUILD/config.status/config.status

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here
Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/REDHAT8/config.log/config.log.gz

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/REDHAT8/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/REDHAT8/config.status/config.status

NetBSD 9 amd64 build: Failed (click for details) NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function 'base64_encode_block':
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function 'base64_decode_block':
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/CI012BUILD/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U2004AMD64BUILD/config.log/config.log.gz

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_encode_block:

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function 'base64_encode_block':
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function 'base64_decode_block':
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/FBSD12AMD64/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_encode_block:

Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U18ARM7BUILD/config.log/config.log.gz
Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U18ARM7BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/F29BUILD/config.status/config.status
Fedora 29 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/F29BUILD/config.log/config.log.gz

Ubuntu 18.04 arm8 build: Failed (click for details) Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3563/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3563/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_encode_block:

<stdin>:281: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Report for base64.c | 93 issues
===============================================
WARNING: Block comments use * on subsequent lines
#2: FILE: /tmp/f1-18189/base64.c:2:
+/*
+This is part of the libb64 project, and has been placed in the public domain.

ERROR: "foo* bar" should be "foo *bar"
#10: FILE: /tmp/f1-18189/base64.c:10:
+void base64_init_encodestate(base64_encodestate* state_in)

WARNING: line over 80 characters
#19: FILE: /tmp/f1-18189/base64.c:19:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";

ERROR: "foo* bar" should be "foo *bar"
#19: FILE: /tmp/f1-18189/base64.c:19:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";

WARNING: Missing a blank line after declarations
#20: FILE: /tmp/f1-18189/base64.c:20:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";
+	if (value_in > 63) return '=';

ERROR: trailing statements should be on next line
#20: FILE: /tmp/f1-18189/base64.c:20:
+	if (value_in > 63) return '=';

WARNING: line over 80 characters
#24: FILE: /tmp/f1-18189/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-18189/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-18189/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-18189/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#26: FILE: /tmp/f1-18189/base64.c:26:
+	const char* plainchar = plaintext_in;

ERROR: "foo* const bar" should be "foo * const bar"
#27: FILE: /tmp/f1-18189/base64.c:27:
+	const char* const plaintextend = plaintext_in + length_in;

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-18189/base64.c:28:
+	char* codechar = code_out;

ERROR: that open brace { should be on the previous line
#34: FILE: /tmp/f1-18189/base64.c:34:
+	switch (state_in->step)
+	{

ERROR: that open brace { should be on the previous line
#36: FILE: /tmp/f1-18189/base64.c:36:
+		while (1)
+		{

WARNING: suspect code indent for conditional statements (16, 16)
#36: FILE: /tmp/f1-18189/base64.c:36:
+		while (1)
+		{

ERROR: that open brace { should be on the previous line
#39: FILE: /tmp/f1-18189/base64.c:39:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#50: FILE: /tmp/f1-18189/base64.c:50:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#61: FILE: /tmp/f1-18189/base64.c:61:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#74: FILE: /tmp/f1-18189/base64.c:74:
+			if (state_in->stepcount == CHARS_PER_LINE/4)
+			{

ERROR: "foo* bar" should be "foo *bar"
#85: FILE: /tmp/f1-18189/base64.c:85:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#85: FILE: /tmp/f1-18189/base64.c:85:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#87: FILE: /tmp/f1-18189/base64.c:87:
+	char* codechar = code_out;

ERROR: that open brace { should be on the previous line
#89: FILE: /tmp/f1-18189/base64.c:89:
+	switch (state_in->step)
+	{

ERROR: space required after that ',' (ctx:VxO)
#112: FILE: /tmp/f1-18189/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#112: FILE: /tmp/f1-18189/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#112: FILE: /tmp/f1-18189/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#112: FILE: /tmp/f1-18189/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#112: FILE: /tmp/f1-18189/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#112: FILE: /tmp/f1-18189/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		         ^

ERROR: space required after that ',' (ctx:VxV)
#112: FILE: /tmp/f1-18189/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#112: FILE: /tmp/f1-18189/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#112: FILE: /tmp/f1-18189/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#112: FILE: /tmp/f1-18189/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#113: FILE: /tmp/f1-18189/base64.c:113:
+		55,56,57,58,59,60,61,-1,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#113: FILE: /tmp/f1-18189/base64.c:113:
+		55,56,57,58,59,60,61,-1,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#113: FILE: /tmp/f1-18189/base64.c:113:
+		55,56,57,58,59,60,61,-1,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#113: FILE: /tmp/f1-18189/base64.c:113:
+		55,56,57,58,59,60,61,-1,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#113: FILE: /tmp/f1-18189/base64.c:113:
+		55,56,57,58,59,60,61,-1,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#113: FILE: /tmp/f1-18189/base64.c:113:
+		55,56,57,58,59,60,61,-1,
 		                 ^

ERROR: space required after that ',' (ctx:VxO)
#113: FILE: /tmp/f1-18189/base64.c:113:
+		55,56,57,58,59,60,61,-1,
 		                    ^

ERROR: space required before that '-' (ctx:OxV)
#113: FILE: /tmp/f1-18189/base64.c:113:
+		55,56,57,58,59,60,61,-1,
 		                     ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-18189/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-18189/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-18189/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-18189/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-18189/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-18189/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		         ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-18189/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		           ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-18189/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		            ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-18189/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		              ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-18189/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		               ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-18189/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-18189/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		                   ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-18189/base64.c:115:
+		2, 3,4,5,6,7,8,9,
 		    ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-18189/base64.c:115:
+		2, 3,4,5,6,7,8,9,
 		      ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-18189/base64.c:115:
+		2, 3,4,5,6,7,8,9,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-18189/base64.c:115:
+		2, 3,4,5,6,7,8,9,
 		          ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-18189/base64.c:115:
+		2, 3,4,5,6,7,8,9,
 		            ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-18189/base64.c:115:
+		2, 3,4,5,6,7,8,9,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-18189/base64.c:116:
+		10,11,12,13,14,15,16,17,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-18189/base64.c:116:
+		10,11,12,13,14,15,16,17,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-18189/base64.c:116:
+		10,11,12,13,14,15,16,17,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-18189/base64.c:116:
+		10,11,12,13,14,15,16,17,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-18189/base64.c:116:
+		10,11,12,13,14,15,16,17,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-18189/base64.c:116:
+		10,11,12,13,14,15,16,17,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-18189/base64.c:116:
+		10,11,12,13,14,15,16,17,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-18189/base64.c:117:
+		18,19,20,21,22,23,24,25,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-18189/base64.c:117:
+		18,19,20,21,22,23,24,25,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-18189/base64.c:117:
+		18,19,20,21,22,23,24,25,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-18189/base64.c:117:
+		18,19,20,21,22,23,24,25,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-18189/base64.c:117:
+		18,19,20,21,22,23,24,25,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-18189/base64.c:117:
+		18,19,20,21,22,23,24,25,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-18189/base64.c:117:
+		18,19,20,21,22,23,24,25,
 		                    ^

ERROR: space required after that ',' (ctx:VxO)
#118: FILE: /tmp/f1-18189/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#118: FILE: /tmp/f1-18189/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#118: FILE: /tmp/f1-18189/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#118: FILE: /tmp/f1-18189/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#118: FILE: /tmp/f1-18189/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#118: FILE: /tmp/f1-18189/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		         ^

ERROR: space required after that ',' (ctx:VxO)
#118: FILE: /tmp/f1-18189/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		           ^

ERROR: space required before that '-' (ctx:OxV)
#118: FILE: /tmp/f1-18189/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		            ^

ERROR: space required after that ',' (ctx:VxO)
#118: FILE: /tmp/f1-18189/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		              ^

ERROR: space required before that '-' (ctx:OxV)
#118: FILE: /tmp/f1-18189/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		               ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-18189/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-18189/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-18189/base64.c:119:
+		28,29,30,31,32,33,34,35,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-18189/base64.c:119:
+		28,29,30,31,32,33,34,35,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-18189/base64.c:119:
+		28,29,30,31,32,33,34,35,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-18189/base64.c:119:
+		28,29,30,31,32,33,34,35,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-18189/base64.c:119:
+		28,29,30,31,32,33,34,35,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-18189/base64.c:119:
+		28,29,30,31,32,33,34,35,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-18189/base64.c:119:
+		28,29,30,31,32,33,34,35,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-18189/base64.c:120:
+		36,37,38,39,40,41,42,43,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-18189/base64.c:120:
+		36,37,38,39,40,41,42,43,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-18189/base64.c:120:
+		36,37,38,39,40,41,42,43,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-18189/base64.c:120:
+		36,37,38,39,40,41,42,43,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-18189/base64.c:120:
+		36,37,38,39,40,41,42,43,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-18189/base64.c:120:
+		36,37,38,39,40,41,42,43,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-18189/base64.c:120:
+		36,37,38,39,40,41,42,43,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-18189/base64.c:121:
+		44,45,46,47,48,49,50,51
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-18189/base64.c:121:
+		44,45,46,47,48,49,50,51
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-18189/base64.c:121:
+		44,45,46,47,48,49,50,51
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-18189/base64.c:121:
+		44,45,46,47,48,49,50,51
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-18189/base64.c:121:
+		44,45,46,47,48,49,50,51
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-18189/base64.c:121:
+		44,45,46,47,48,49,50,51
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-18189/base64.c:121:
+		44,45,46,47,48,49,50,51
 		                    ^

WARNING: Missing a blank line after declarations
#124: FILE: /tmp/f1-18189/base64.c:124:
+	static const char decoding_size = sizeof(decoding);
+	value_in -= 43;

ERROR: trailing statements should be on next line
#125: FILE: /tmp/f1-18189/base64.c:125:
+	if (value_in < 0 || value_in >= decoding_size) return -1;

ERROR: "foo* bar" should be "foo *bar"
#129: FILE: /tmp/f1-18189/base64.c:129:
+void base64_init_decodestate(base64_decodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#135: FILE: /tmp/f1-18189/base64.c:135:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#135: FILE: /tmp/f1-18189/base64.c:135:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#136: FILE: /tmp/f1-18189/base64.c:136:
+			base64_decodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#138: FILE: /tmp/f1-18189/base64.c:138:
+	const char* codechar = code_in;

ERROR: "foo* bar" should be "foo *bar"
#139: FILE: /tmp/f1-18189/base64.c:139:
+	char* plainchar = plaintext_out;

ERROR: that open brace { should be on the previous line
#144: FILE: /tmp/f1-18189/base64.c:144:
+	switch (state_in->step)
+	{

ERROR: that open brace { should be on the previous line
#146: FILE: /tmp/f1-18189/base64.c:146:
+		while (1)
+		{

WARNING: suspect code indent for conditional statements (16, 16)
#146: FILE: /tmp/f1-18189/base64.c:146:
+		while (1)
+		{

ERROR: that open brace { should be on the previous line
#150: FILE: /tmp/f1-18189/base64.c:150:
+				if (codechar == code_in+length_in)
+				{

WARNING: line over 80 characters
#156: FILE: /tmp/f1-18189/base64.c:156:
+				fragment = (char)base64_decode_value(*codechar++);

ERROR: that open brace { should be on the previous line
#161: FILE: /tmp/f1-18189/base64.c:161:
+				if (codechar == code_in+length_in)
+				{

WARNING: line over 80 characters
#167: FILE: /tmp/f1-18189/base64.c:167:
+				fragment = (char)base64_decode_value(*codechar++);

ERROR: that open brace { should be on the previous line
#173: FILE: /tmp/f1-18189/base64.c:173:
+				if (codechar == code_in+length_in)
+				{

WARNING: line over 80 characters
#179: FILE: /tmp/f1-18189/base64.c:179:
+				fragment = (char)base64_decode_value(*codechar++);

ERROR: that open brace { should be on the previous line
#185: FILE: /tmp/f1-18189/base64.c:185:
+				if (codechar == code_in+length_in)
+				{

WARNING: line over 80 characters
#191: FILE: /tmp/f1-18189/base64.c:191:
+				fragment = (char)base64_decode_value(*codechar++);
Report for base64.h | 85 issues
===============================================
WARNING: Block comments use * on subsequent lines
#2: FILE: /tmp/f1-18189/base64.h:2:
+/*
+This is part of the libb64 project, and has been placed in the public domain.

WARNING: do not add new typedefs
#9: FILE: /tmp/f1-18189/base64.h:9:
+typedef enum

ERROR: open brace '{' following enum go on the same line
#10: FILE: /tmp/f1-18189/base64.h:10:
+typedef enum
+{

WARNING: do not add new typedefs
#14: FILE: /tmp/f1-18189/base64.h:14:
+typedef struct

ERROR: open brace '{' following struct go on the same line
#15: FILE: /tmp/f1-18189/base64.h:15:
+typedef struct
+{

ERROR: "foo* bar" should be "foo *bar"
#21: FILE: /tmp/f1-18189/base64.h:21:
+void base64_init_encodestate(base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#25: FILE: /tmp/f1-18189/base64.h:25:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out,

ERROR: "foo* bar" should be "foo *bar"
#25: FILE: /tmp/f1-18189/base64.h:25:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out,

ERROR: "foo* bar" should be "foo *bar"
#26: FILE: /tmp/f1-18189/base64.h:26:
+			base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-18189/base64.h:28:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-18189/base64.h:28:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in);

WARNING: do not add new typedefs
#31: FILE: /tmp/f1-18189/base64.h:31:
+typedef enum

ERROR: open brace '{' following enum go on the same line
#32: FILE: /tmp/f1-18189/base64.h:32:
+typedef enum
+{

WARNING: do not add new typedefs
#36: FILE: /tmp/f1-18189/base64.h:36:
+typedef struct

ERROR: open brace '{' following struct go on the same line
#37: FILE: /tmp/f1-18189/base64.h:37:
+typedef struct
+{

ERROR: "foo* bar" should be "foo *bar"
#42: FILE: /tmp/f1-18189/base64.h:42:
+void base64_init_decodestate(base64_decodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#46: FILE: /tmp/f1-18189/base64.h:46:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#46: FILE: /tmp/f1-18189/base64.h:46:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#47: FILE: /tmp/f1-18189/base64.h:47:
+			base64_decodestate* state_in);

WARNING: C99 // comments do not match recommendation
#49: FILE: /tmp/f1-18189/base64.h:49:
+#endif //_BASE64_H_
Report for yang_wrappers.c | 8 issues
===============================================
< WARNING: Missing a blank line after declarations
< #688: FILE: /tmp/f1-18189/yang_wrappers.c:688:
< WARNING: Missing a blank line after declarations
< #691: FILE: /tmp/f1-18189/yang_wrappers.c:691:
< WARNING: Missing a blank line after declarations
< #696: FILE: /tmp/f1-18189/yang_wrappers.c:696:
< WARNING: Missing a blank line after declarations
< #709: FILE: /tmp/f1-18189/yang_wrappers.c:709:

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 19, 2022 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/DEB10BUILD/config.log/config.log.gz

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/DEB10BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.3562/frr-source/doc/user/zebra.rst:1380: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
lib/base64.c: In function 'base64_encode_block':
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function 'base64_decode_block':
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/CI009BUILD/config.log/config.log.gz

Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/CI101BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U16ARM8BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U1804AMD64/config.status/config.status
Ubuntu 18.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U1804AMD64/config.log/config.log.gz

Ubuntu 18.04 i386 build: Failed (click for details) Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U18I386BUILD/config.status/config.status

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U2004AMD64BUILD/config.log/config.log.gz

NetBSD 9 amd64 build: Failed (click for details) NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function 'base64_encode_block':
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function 'base64_decode_block':
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/CI012BUILD/config.status/config.status

Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/REDHAT8/config.log/config.log.gz

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/REDHAT8/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/REDHAT8/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_encode_block:

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function 'base64_encode_block':
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function 'base64_decode_block':
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/FBSD12AMD64/config.log/config.log.gz

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/F29BUILD/config.status/config.status
Fedora 29 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/F29BUILD/config.log/config.log.gz

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/DEB11AMD64/config.status/config.status

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/DEB11AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.3562/frr-source/doc/user/zebra.rst:1380: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Debian 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/DEB11AMD64/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_encode_block:

Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U18ARM7BUILD/config.log/config.log.gz
Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U18ARM7BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details) Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_encode_block:
Successful on other platforms/tests
  • Ubuntu 16.04 i386 build
  • OpenBSD 7 amd64 build
  • Ubuntu 16.04 amd64 build
  • CentOS 7 amd64 build
  • Debian 9 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/DEB10BUILD/config.log/config.log.gz

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/DEB10BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.3562/frr-source/doc/user/zebra.rst:1380: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
lib/base64.c: In function 'base64_encode_block':
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function 'base64_decode_block':
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/CI009BUILD/config.log/config.log.gz

Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/CI101BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U16ARM8BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U1804AMD64/config.status/config.status
Ubuntu 18.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U1804AMD64/config.log/config.log.gz

Ubuntu 18.04 i386 build: Failed (click for details) Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U18I386BUILD/config.status/config.status

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U2004AMD64BUILD/config.log/config.log.gz

NetBSD 9 amd64 build: Failed (click for details) NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function 'base64_encode_block':
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function 'base64_decode_block':
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/CI012BUILD/config.status/config.status

Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/REDHAT8/config.log/config.log.gz

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/REDHAT8/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/REDHAT8/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_encode_block:

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function 'base64_encode_block':
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function 'base64_decode_block':
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/FBSD12AMD64/config.log/config.log.gz

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/F29BUILD/config.status/config.status
Fedora 29 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/F29BUILD/config.log/config.log.gz

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/DEB11AMD64/config.status/config.status

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/DEB11AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.3562/frr-source/doc/user/zebra.rst:1380: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
lib/base64.c: In function base64_encode_block:
lib/base64.c:48:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:49:3: note: here
lib/base64.c:59:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:60:3: note: here
lib/base64.c: In function base64_decode_block:
lib/base64.c:158:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
lib/base64.c:159:3: note: here

Debian 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/DEB11AMD64/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_encode_block:

Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U18ARM7BUILD/config.log/config.log.gz
Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U18ARM7BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details) Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3562/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3562/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:125:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:157:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:168:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:180:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:192:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_encode_block:

<stdin>:281: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Report for base64.c | 93 issues
===============================================
WARNING: Block comments use * on subsequent lines
#2: FILE: /tmp/f1-8724/base64.c:2:
+/*
+This is part of the libb64 project, and has been placed in the public domain.

ERROR: "foo* bar" should be "foo *bar"
#10: FILE: /tmp/f1-8724/base64.c:10:
+void base64_init_encodestate(base64_encodestate* state_in)

WARNING: line over 80 characters
#19: FILE: /tmp/f1-8724/base64.c:19:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";

ERROR: "foo* bar" should be "foo *bar"
#19: FILE: /tmp/f1-8724/base64.c:19:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";

WARNING: Missing a blank line after declarations
#20: FILE: /tmp/f1-8724/base64.c:20:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";
+	if (value_in > 63) return '=';

ERROR: trailing statements should be on next line
#20: FILE: /tmp/f1-8724/base64.c:20:
+	if (value_in > 63) return '=';

WARNING: line over 80 characters
#24: FILE: /tmp/f1-8724/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-8724/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-8724/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-8724/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#26: FILE: /tmp/f1-8724/base64.c:26:
+	const char* plainchar = plaintext_in;

ERROR: "foo* const bar" should be "foo * const bar"
#27: FILE: /tmp/f1-8724/base64.c:27:
+	const char* const plaintextend = plaintext_in + length_in;

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-8724/base64.c:28:
+	char* codechar = code_out;

ERROR: that open brace { should be on the previous line
#34: FILE: /tmp/f1-8724/base64.c:34:
+	switch (state_in->step)
+	{

ERROR: that open brace { should be on the previous line
#36: FILE: /tmp/f1-8724/base64.c:36:
+		while (1)
+		{

WARNING: suspect code indent for conditional statements (16, 16)
#36: FILE: /tmp/f1-8724/base64.c:36:
+		while (1)
+		{

ERROR: that open brace { should be on the previous line
#39: FILE: /tmp/f1-8724/base64.c:39:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#50: FILE: /tmp/f1-8724/base64.c:50:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#61: FILE: /tmp/f1-8724/base64.c:61:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#74: FILE: /tmp/f1-8724/base64.c:74:
+			if (state_in->stepcount == CHARS_PER_LINE/4)
+			{

ERROR: "foo* bar" should be "foo *bar"
#85: FILE: /tmp/f1-8724/base64.c:85:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#85: FILE: /tmp/f1-8724/base64.c:85:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#87: FILE: /tmp/f1-8724/base64.c:87:
+	char* codechar = code_out;

ERROR: that open brace { should be on the previous line
#89: FILE: /tmp/f1-8724/base64.c:89:
+	switch (state_in->step)
+	{

ERROR: space required after that ',' (ctx:VxO)
#112: FILE: /tmp/f1-8724/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#112: FILE: /tmp/f1-8724/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#112: FILE: /tmp/f1-8724/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#112: FILE: /tmp/f1-8724/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#112: FILE: /tmp/f1-8724/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#112: FILE: /tmp/f1-8724/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		         ^

ERROR: space required after that ',' (ctx:VxV)
#112: FILE: /tmp/f1-8724/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#112: FILE: /tmp/f1-8724/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#112: FILE: /tmp/f1-8724/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#112: FILE: /tmp/f1-8724/base64.c:112:
+		62,-1,-1,-1,63,52,53,54,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#113: FILE: /tmp/f1-8724/base64.c:113:
+		55,56,57,58,59,60,61,-1,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#113: FILE: /tmp/f1-8724/base64.c:113:
+		55,56,57,58,59,60,61,-1,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#113: FILE: /tmp/f1-8724/base64.c:113:
+		55,56,57,58,59,60,61,-1,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#113: FILE: /tmp/f1-8724/base64.c:113:
+		55,56,57,58,59,60,61,-1,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#113: FILE: /tmp/f1-8724/base64.c:113:
+		55,56,57,58,59,60,61,-1,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#113: FILE: /tmp/f1-8724/base64.c:113:
+		55,56,57,58,59,60,61,-1,
 		                 ^

ERROR: space required after that ',' (ctx:VxO)
#113: FILE: /tmp/f1-8724/base64.c:113:
+		55,56,57,58,59,60,61,-1,
 		                    ^

ERROR: space required before that '-' (ctx:OxV)
#113: FILE: /tmp/f1-8724/base64.c:113:
+		55,56,57,58,59,60,61,-1,
 		                     ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-8724/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-8724/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-8724/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-8724/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-8724/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-8724/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		         ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-8724/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		           ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-8724/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		            ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-8724/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		              ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-8724/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		               ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-8724/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-8724/base64.c:114:
+		-1,-1,-2,-1,-1,-1,0,1,
 		                   ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-8724/base64.c:115:
+		2, 3,4,5,6,7,8,9,
 		    ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-8724/base64.c:115:
+		2, 3,4,5,6,7,8,9,
 		      ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-8724/base64.c:115:
+		2, 3,4,5,6,7,8,9,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-8724/base64.c:115:
+		2, 3,4,5,6,7,8,9,
 		          ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-8724/base64.c:115:
+		2, 3,4,5,6,7,8,9,
 		            ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-8724/base64.c:115:
+		2, 3,4,5,6,7,8,9,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-8724/base64.c:116:
+		10,11,12,13,14,15,16,17,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-8724/base64.c:116:
+		10,11,12,13,14,15,16,17,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-8724/base64.c:116:
+		10,11,12,13,14,15,16,17,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-8724/base64.c:116:
+		10,11,12,13,14,15,16,17,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-8724/base64.c:116:
+		10,11,12,13,14,15,16,17,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-8724/base64.c:116:
+		10,11,12,13,14,15,16,17,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-8724/base64.c:116:
+		10,11,12,13,14,15,16,17,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-8724/base64.c:117:
+		18,19,20,21,22,23,24,25,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-8724/base64.c:117:
+		18,19,20,21,22,23,24,25,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-8724/base64.c:117:
+		18,19,20,21,22,23,24,25,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-8724/base64.c:117:
+		18,19,20,21,22,23,24,25,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-8724/base64.c:117:
+		18,19,20,21,22,23,24,25,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-8724/base64.c:117:
+		18,19,20,21,22,23,24,25,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-8724/base64.c:117:
+		18,19,20,21,22,23,24,25,
 		                    ^

ERROR: space required after that ',' (ctx:VxO)
#118: FILE: /tmp/f1-8724/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#118: FILE: /tmp/f1-8724/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#118: FILE: /tmp/f1-8724/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#118: FILE: /tmp/f1-8724/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#118: FILE: /tmp/f1-8724/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#118: FILE: /tmp/f1-8724/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		         ^

ERROR: space required after that ',' (ctx:VxO)
#118: FILE: /tmp/f1-8724/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		           ^

ERROR: space required before that '-' (ctx:OxV)
#118: FILE: /tmp/f1-8724/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		            ^

ERROR: space required after that ',' (ctx:VxO)
#118: FILE: /tmp/f1-8724/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		              ^

ERROR: space required before that '-' (ctx:OxV)
#118: FILE: /tmp/f1-8724/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		               ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-8724/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-8724/base64.c:118:
+		-1,-1,-1,-1,-1,-1,26,27,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-8724/base64.c:119:
+		28,29,30,31,32,33,34,35,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-8724/base64.c:119:
+		28,29,30,31,32,33,34,35,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-8724/base64.c:119:
+		28,29,30,31,32,33,34,35,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-8724/base64.c:119:
+		28,29,30,31,32,33,34,35,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-8724/base64.c:119:
+		28,29,30,31,32,33,34,35,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-8724/base64.c:119:
+		28,29,30,31,32,33,34,35,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-8724/base64.c:119:
+		28,29,30,31,32,33,34,35,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-8724/base64.c:120:
+		36,37,38,39,40,41,42,43,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-8724/base64.c:120:
+		36,37,38,39,40,41,42,43,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-8724/base64.c:120:
+		36,37,38,39,40,41,42,43,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-8724/base64.c:120:
+		36,37,38,39,40,41,42,43,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-8724/base64.c:120:
+		36,37,38,39,40,41,42,43,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-8724/base64.c:120:
+		36,37,38,39,40,41,42,43,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-8724/base64.c:120:
+		36,37,38,39,40,41,42,43,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-8724/base64.c:121:
+		44,45,46,47,48,49,50,51
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-8724/base64.c:121:
+		44,45,46,47,48,49,50,51
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-8724/base64.c:121:
+		44,45,46,47,48,49,50,51
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-8724/base64.c:121:
+		44,45,46,47,48,49,50,51
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-8724/base64.c:121:
+		44,45,46,47,48,49,50,51
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-8724/base64.c:121:
+		44,45,46,47,48,49,50,51
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-8724/base64.c:121:
+		44,45,46,47,48,49,50,51
 		                    ^

WARNING: Missing a blank line after declarations
#124: FILE: /tmp/f1-8724/base64.c:124:
+	static const char decoding_size = sizeof(decoding);
+	value_in -= 43;

ERROR: trailing statements should be on next line
#125: FILE: /tmp/f1-8724/base64.c:125:
+	if (value_in < 0 || value_in >= decoding_size) return -1;

ERROR: "foo* bar" should be "foo *bar"
#129: FILE: /tmp/f1-8724/base64.c:129:
+void base64_init_decodestate(base64_decodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#135: FILE: /tmp/f1-8724/base64.c:135:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#135: FILE: /tmp/f1-8724/base64.c:135:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#136: FILE: /tmp/f1-8724/base64.c:136:
+			base64_decodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#138: FILE: /tmp/f1-8724/base64.c:138:
+	const char* codechar = code_in;

ERROR: "foo* bar" should be "foo *bar"
#139: FILE: /tmp/f1-8724/base64.c:139:
+	char* plainchar = plaintext_out;

ERROR: that open brace { should be on the previous line
#144: FILE: /tmp/f1-8724/base64.c:144:
+	switch (state_in->step)
+	{

ERROR: that open brace { should be on the previous line
#146: FILE: /tmp/f1-8724/base64.c:146:
+		while (1)
+		{

WARNING: suspect code indent for conditional statements (16, 16)
#146: FILE: /tmp/f1-8724/base64.c:146:
+		while (1)
+		{

ERROR: that open brace { should be on the previous line
#150: FILE: /tmp/f1-8724/base64.c:150:
+				if (codechar == code_in+length_in)
+				{

WARNING: line over 80 characters
#156: FILE: /tmp/f1-8724/base64.c:156:
+				fragment = (char)base64_decode_value(*codechar++);

ERROR: that open brace { should be on the previous line
#161: FILE: /tmp/f1-8724/base64.c:161:
+				if (codechar == code_in+length_in)
+				{

WARNING: line over 80 characters
#167: FILE: /tmp/f1-8724/base64.c:167:
+				fragment = (char)base64_decode_value(*codechar++);

ERROR: that open brace { should be on the previous line
#173: FILE: /tmp/f1-8724/base64.c:173:
+				if (codechar == code_in+length_in)
+				{

WARNING: line over 80 characters
#179: FILE: /tmp/f1-8724/base64.c:179:
+				fragment = (char)base64_decode_value(*codechar++);

ERROR: that open brace { should be on the previous line
#185: FILE: /tmp/f1-8724/base64.c:185:
+				if (codechar == code_in+length_in)
+				{

WARNING: line over 80 characters
#191: FILE: /tmp/f1-8724/base64.c:191:
+				fragment = (char)base64_decode_value(*codechar++);
Report for base64.h | 85 issues
===============================================
WARNING: Block comments use * on subsequent lines
#2: FILE: /tmp/f1-8724/base64.h:2:
+/*
+This is part of the libb64 project, and has been placed in the public domain.

WARNING: do not add new typedefs
#9: FILE: /tmp/f1-8724/base64.h:9:
+typedef enum

ERROR: open brace '{' following enum go on the same line
#10: FILE: /tmp/f1-8724/base64.h:10:
+typedef enum
+{

WARNING: do not add new typedefs
#14: FILE: /tmp/f1-8724/base64.h:14:
+typedef struct

ERROR: open brace '{' following struct go on the same line
#15: FILE: /tmp/f1-8724/base64.h:15:
+typedef struct
+{

ERROR: "foo* bar" should be "foo *bar"
#21: FILE: /tmp/f1-8724/base64.h:21:
+void base64_init_encodestate(base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#25: FILE: /tmp/f1-8724/base64.h:25:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out,

ERROR: "foo* bar" should be "foo *bar"
#25: FILE: /tmp/f1-8724/base64.h:25:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out,

ERROR: "foo* bar" should be "foo *bar"
#26: FILE: /tmp/f1-8724/base64.h:26:
+			base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-8724/base64.h:28:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-8724/base64.h:28:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in);

WARNING: do not add new typedefs
#31: FILE: /tmp/f1-8724/base64.h:31:
+typedef enum

ERROR: open brace '{' following enum go on the same line
#32: FILE: /tmp/f1-8724/base64.h:32:
+typedef enum
+{

WARNING: do not add new typedefs
#36: FILE: /tmp/f1-8724/base64.h:36:
+typedef struct

ERROR: open brace '{' following struct go on the same line
#37: FILE: /tmp/f1-8724/base64.h:37:
+typedef struct
+{

ERROR: "foo* bar" should be "foo *bar"
#42: FILE: /tmp/f1-8724/base64.h:42:
+void base64_init_decodestate(base64_decodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#46: FILE: /tmp/f1-8724/base64.h:46:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#46: FILE: /tmp/f1-8724/base64.h:46:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#47: FILE: /tmp/f1-8724/base64.h:47:
+			base64_decodestate* state_in);

WARNING: C99 // comments do not match recommendation
#49: FILE: /tmp/f1-8724/base64.h:49:
+#endif //_BASE64_H_
Report for yang_wrappers.c | 8 issues
===============================================
< WARNING: Missing a blank line after declarations
< #688: FILE: /tmp/f1-8724/yang_wrappers.c:688:
< WARNING: Missing a blank line after declarations
< #692: FILE: /tmp/f1-8724/yang_wrappers.c:692:
< WARNING: Missing a blank line after declarations
< #697: FILE: /tmp/f1-8724/yang_wrappers.c:697:
< WARNING: Missing a blank line after declarations
< #710: FILE: /tmp/f1-8724/yang_wrappers.c:710:

@whichbug whichbug force-pushed the master branch 2 times, most recently from 075c3ac to b90ea44 Compare February 20, 2022 00:21
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 20, 2022 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/CI101BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3564/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:159:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:171:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:184:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:197:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3564/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:159:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:171:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:184:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:197:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U16ARM8BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details) Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3564/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:159:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:171:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:184:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:197:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3564/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:159:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:171:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:184:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:197:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3564/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:159:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:171:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:184:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:197:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors

Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U18ARM7BUILD/config.log/config.log.gz
Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U18ARM7BUILD/config.status/config.status

Successful on other platforms/tests
  • FreeBSD 11 amd64 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 18.04 amd64 build
  • Debian 11 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 16.04 amd64 build
  • CentOS 7 amd64 build
  • Redhat 8 amd64 build
  • Ubuntu 18.04 i386 build
  • NetBSD 9 amd64 build
  • OpenBSD 7 amd64 build
  • Debian 9 amd64 build
  • Ubuntu 20.04 amd64 build
  • Debian 10 amd64 build
  • Fedora 29 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/CI101BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3564/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:159:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:171:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:184:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:197:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3564/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:159:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:171:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:184:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:197:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U16ARM8BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details) Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3564/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:159:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:171:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:184:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:197:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3564/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:159:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:171:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:184:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:197:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3564/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c: In function base64_decode_block:
lib/base64.c:159:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:171:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:184:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
lib/base64.c:197:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors

Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U18ARM7BUILD/config.log/config.log.gz
Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3564/artifact/U18ARM7BUILD/config.status/config.status

<stdin>:286: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Report for base64.c | 93 issues
===============================================
WARNING: Block comments use * on subsequent lines
#2: FILE: /tmp/f1-15866/base64.c:2:
+/*
+This is part of the libb64 project, and has been placed in the public domain.

ERROR: "foo* bar" should be "foo *bar"
#10: FILE: /tmp/f1-15866/base64.c:10:
+void base64_init_encodestate(base64_encodestate* state_in)

WARNING: line over 80 characters
#19: FILE: /tmp/f1-15866/base64.c:19:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";

ERROR: "foo* bar" should be "foo *bar"
#19: FILE: /tmp/f1-15866/base64.c:19:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";

WARNING: Missing a blank line after declarations
#20: FILE: /tmp/f1-15866/base64.c:20:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";
+	if (value_in > 63) return '=';

ERROR: trailing statements should be on next line
#20: FILE: /tmp/f1-15866/base64.c:20:
+	if (value_in > 63) return '=';

WARNING: line over 80 characters
#24: FILE: /tmp/f1-15866/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-15866/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-15866/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-15866/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#26: FILE: /tmp/f1-15866/base64.c:26:
+	const char* plainchar = plaintext_in;

ERROR: "foo* const bar" should be "foo * const bar"
#27: FILE: /tmp/f1-15866/base64.c:27:
+	const char* const plaintextend = plaintext_in + length_in;

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-15866/base64.c:28:
+	char* codechar = code_out;

ERROR: that open brace { should be on the previous line
#34: FILE: /tmp/f1-15866/base64.c:34:
+	switch (state_in->step)
+	{

ERROR: that open brace { should be on the previous line
#36: FILE: /tmp/f1-15866/base64.c:36:
+		while (1)
+		{

WARNING: suspect code indent for conditional statements (16, 16)
#36: FILE: /tmp/f1-15866/base64.c:36:
+		while (1)
+		{

ERROR: that open brace { should be on the previous line
#39: FILE: /tmp/f1-15866/base64.c:39:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#51: FILE: /tmp/f1-15866/base64.c:51:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#63: FILE: /tmp/f1-15866/base64.c:63:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#76: FILE: /tmp/f1-15866/base64.c:76:
+			if (state_in->stepcount == CHARS_PER_LINE/4)
+			{

ERROR: "foo* bar" should be "foo *bar"
#87: FILE: /tmp/f1-15866/base64.c:87:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#87: FILE: /tmp/f1-15866/base64.c:87:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#89: FILE: /tmp/f1-15866/base64.c:89:
+	char* codechar = code_out;

ERROR: that open brace { should be on the previous line
#91: FILE: /tmp/f1-15866/base64.c:91:
+	switch (state_in->step)
+	{

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-15866/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-15866/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-15866/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-15866/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-15866/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-15866/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		         ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-15866/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-15866/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-15866/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-15866/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-15866/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-15866/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-15866/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-15866/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-15866/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-15866/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		                 ^

ERROR: space required after that ',' (ctx:VxO)
#115: FILE: /tmp/f1-15866/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		                    ^

ERROR: space required before that '-' (ctx:OxV)
#115: FILE: /tmp/f1-15866/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		                     ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-15866/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-15866/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-15866/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-15866/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-15866/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-15866/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		         ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-15866/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		           ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-15866/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		            ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-15866/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		              ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-15866/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		               ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-15866/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-15866/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		                   ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-15866/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		    ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-15866/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		      ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-15866/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-15866/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		          ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-15866/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		            ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-15866/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-15866/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-15866/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-15866/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-15866/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-15866/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-15866/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-15866/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-15866/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-15866/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-15866/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-15866/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-15866/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-15866/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-15866/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		                    ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-15866/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-15866/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-15866/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-15866/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-15866/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-15866/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		         ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-15866/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		           ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-15866/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		            ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-15866/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		              ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-15866/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		               ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-15866/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-15866/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-15866/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-15866/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-15866/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-15866/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-15866/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-15866/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-15866/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-15866/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-15866/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-15866/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-15866/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-15866/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-15866/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-15866/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-15866/base64.c:123:
+		44,45,46,47,48,49,50,51
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-15866/base64.c:123:
+		44,45,46,47,48,49,50,51
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-15866/base64.c:123:
+		44,45,46,47,48,49,50,51
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-15866/base64.c:123:
+		44,45,46,47,48,49,50,51
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-15866/base64.c:123:
+		44,45,46,47,48,49,50,51
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-15866/base64.c:123:
+		44,45,46,47,48,49,50,51
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-15866/base64.c:123:
+		44,45,46,47,48,49,50,51
 		                    ^

WARNING: Missing a blank line after declarations
#126: FILE: /tmp/f1-15866/base64.c:126:
+	static const char decoding_size = sizeof(decoding);
+	value_in -= 43;

ERROR: trailing statements should be on next line
#127: FILE: /tmp/f1-15866/base64.c:127:
+	if (value_in < 0 || value_in >= decoding_size) return -1;

ERROR: "foo* bar" should be "foo *bar"
#131: FILE: /tmp/f1-15866/base64.c:131:
+void base64_init_decodestate(base64_decodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#137: FILE: /tmp/f1-15866/base64.c:137:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#137: FILE: /tmp/f1-15866/base64.c:137:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#138: FILE: /tmp/f1-15866/base64.c:138:
+			base64_decodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#140: FILE: /tmp/f1-15866/base64.c:140:
+	const char* codechar = code_in;

ERROR: "foo* bar" should be "foo *bar"
#141: FILE: /tmp/f1-15866/base64.c:141:
+	char* plainchar = plaintext_out;

ERROR: that open brace { should be on the previous line
#146: FILE: /tmp/f1-15866/base64.c:146:
+	switch (state_in->step)
+	{

ERROR: that open brace { should be on the previous line
#148: FILE: /tmp/f1-15866/base64.c:148:
+		while (1)
+		{

WARNING: suspect code indent for conditional statements (16, 16)
#148: FILE: /tmp/f1-15866/base64.c:148:
+		while (1)
+		{

ERROR: that open brace { should be on the previous line
#152: FILE: /tmp/f1-15866/base64.c:152:
+				if (codechar == code_in+length_in)
+				{

WARNING: line over 80 characters
#158: FILE: /tmp/f1-15866/base64.c:158:
+				fragment = (char)base64_decode_value(*codechar++);

ERROR: that open brace { should be on the previous line
#164: FILE: /tmp/f1-15866/base64.c:164:
+				if (codechar == code_in+length_in)
+				{

WARNING: line over 80 characters
#170: FILE: /tmp/f1-15866/base64.c:170:
+				fragment = (char)base64_decode_value(*codechar++);

ERROR: that open brace { should be on the previous line
#177: FILE: /tmp/f1-15866/base64.c:177:
+				if (codechar == code_in+length_in)
+				{

WARNING: line over 80 characters
#183: FILE: /tmp/f1-15866/base64.c:183:
+				fragment = (char)base64_decode_value(*codechar++);

ERROR: that open brace { should be on the previous line
#190: FILE: /tmp/f1-15866/base64.c:190:
+				if (codechar == code_in+length_in)
+				{

WARNING: line over 80 characters
#196: FILE: /tmp/f1-15866/base64.c:196:
+				fragment = (char)base64_decode_value(*codechar++);
Report for base64.h | 85 issues
===============================================
WARNING: Block comments use * on subsequent lines
#2: FILE: /tmp/f1-15866/base64.h:2:
+/*
+This is part of the libb64 project, and has been placed in the public domain.

WARNING: do not add new typedefs
#9: FILE: /tmp/f1-15866/base64.h:9:
+typedef enum

ERROR: open brace '{' following enum go on the same line
#10: FILE: /tmp/f1-15866/base64.h:10:
+typedef enum
+{

WARNING: do not add new typedefs
#14: FILE: /tmp/f1-15866/base64.h:14:
+typedef struct

ERROR: open brace '{' following struct go on the same line
#15: FILE: /tmp/f1-15866/base64.h:15:
+typedef struct
+{

ERROR: "foo* bar" should be "foo *bar"
#21: FILE: /tmp/f1-15866/base64.h:21:
+void base64_init_encodestate(base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#25: FILE: /tmp/f1-15866/base64.h:25:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out,

ERROR: "foo* bar" should be "foo *bar"
#25: FILE: /tmp/f1-15866/base64.h:25:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out,

ERROR: "foo* bar" should be "foo *bar"
#26: FILE: /tmp/f1-15866/base64.h:26:
+			base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-15866/base64.h:28:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-15866/base64.h:28:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in);

WARNING: do not add new typedefs
#31: FILE: /tmp/f1-15866/base64.h:31:
+typedef enum

ERROR: open brace '{' following enum go on the same line
#32: FILE: /tmp/f1-15866/base64.h:32:
+typedef enum
+{

WARNING: do not add new typedefs
#36: FILE: /tmp/f1-15866/base64.h:36:
+typedef struct

ERROR: open brace '{' following struct go on the same line
#37: FILE: /tmp/f1-15866/base64.h:37:
+typedef struct
+{

ERROR: "foo* bar" should be "foo *bar"
#42: FILE: /tmp/f1-15866/base64.h:42:
+void base64_init_decodestate(base64_decodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#46: FILE: /tmp/f1-15866/base64.h:46:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#46: FILE: /tmp/f1-15866/base64.h:46:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#47: FILE: /tmp/f1-15866/base64.h:47:
+			base64_decodestate* state_in);

WARNING: C99 // comments do not match recommendation
#49: FILE: /tmp/f1-15866/base64.h:49:
+#endif //_BASE64_H_
Report for yang_wrappers.c | 8 issues
===============================================
< WARNING: Missing a blank line after declarations
< #688: FILE: /tmp/f1-15866/yang_wrappers.c:688:
< WARNING: Missing a blank line after declarations
< #691: FILE: /tmp/f1-15866/yang_wrappers.c:691:
< WARNING: Missing a blank line after declarations
< #696: FILE: /tmp/f1-15866/yang_wrappers.c:696:
< WARNING: Missing a blank line after declarations
< #709: FILE: /tmp/f1-15866/yang_wrappers.c:709:

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 20, 2022 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3565/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
isisd/isis_cli.c: In function isis_sr_local_block_label_range_magic:
isisd/isis_cli.c:1574:1: note: #pragma message: Use of the local-block command is deprecated
 CPP_NOTICE("Use of the local-block command is deprecated")

Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U18ARM7BUILD/config.log/config.log.gz
Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U18ARM7BUILD/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/CI101BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3565/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
/home/ci/cibuild.3565/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.3565/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.3565/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3565/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
/home/ci/cibuild.3565/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.3565/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.3565/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U16ARM8BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details) Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3565/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
isisd/isis_cli.c: In function isis_sr_local_block_label_range_magic:
isisd/isis_cli.c:1574:1: note: #pragma message: Use of the local-block command is deprecated
 CPP_NOTICE("Use of the local-block command is deprecated")
Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3565/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
isisd/isis_cli.c: In function isis_sr_local_block_label_range_magic:
isisd/isis_cli.c:1574:1: note: #pragma message: Use of the local-block command is deprecated
 CPP_NOTICE("Use of the local-block command is deprecated")

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

Successful on other platforms/tests
  • CentOS 7 amd64 build
  • Debian 11 amd64 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 18.04 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 16.04 amd64 build
  • FreeBSD 12 amd64 build
  • NetBSD 9 amd64 build
  • Ubuntu 18.04 i386 build
  • Redhat 8 amd64 build
  • OpenBSD 7 amd64 build
  • Ubuntu 20.04 amd64 build
  • Debian 9 amd64 build
  • Fedora 29 amd64 build
  • Debian 10 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3565/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
isisd/isis_cli.c: In function isis_sr_local_block_label_range_magic:
isisd/isis_cli.c:1574:1: note: #pragma message: Use of the local-block command is deprecated
 CPP_NOTICE("Use of the local-block command is deprecated")

Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U18ARM7BUILD/config.log/config.log.gz
Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U18ARM7BUILD/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/CI101BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3565/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
/home/ci/cibuild.3565/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.3565/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.3565/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3565/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
/home/ci/cibuild.3565/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.3565/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.3565/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U16ARM8BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details) Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3565/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
isisd/isis_cli.c: In function isis_sr_local_block_label_range_magic:
isisd/isis_cli.c:1574:1: note: #pragma message: Use of the local-block command is deprecated
 CPP_NOTICE("Use of the local-block command is deprecated")
Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3565/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:15: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
isisd/isis_cli.c: In function isis_sr_local_block_label_range_magic:
isisd/isis_cli.c:1574:1: note: #pragma message: Use of the local-block command is deprecated
 CPP_NOTICE("Use of the local-block command is deprecated")

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3565/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

<stdin>:286: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Report for base64.c | 77 issues
===============================================
WARNING: Block comments use * on subsequent lines
#2: FILE: /tmp/f1-1729/base64.c:2:
+/*
+This is part of the libb64 project, and has been placed in the public domain.

ERROR: "foo* bar" should be "foo *bar"
#10: FILE: /tmp/f1-1729/base64.c:10:
+void base64_init_encodestate(base64_encodestate* state_in)

WARNING: line over 80 characters
#19: FILE: /tmp/f1-1729/base64.c:19:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";

ERROR: "foo* bar" should be "foo *bar"
#19: FILE: /tmp/f1-1729/base64.c:19:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";

WARNING: Missing a blank line after declarations
#20: FILE: /tmp/f1-1729/base64.c:20:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";
+	if (value_in > 63) return '=';

ERROR: trailing statements should be on next line
#20: FILE: /tmp/f1-1729/base64.c:20:
+	if (value_in > 63) return '=';

WARNING: line over 80 characters
#24: FILE: /tmp/f1-1729/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-1729/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-1729/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-1729/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#26: FILE: /tmp/f1-1729/base64.c:26:
+	const char* plainchar = plaintext_in;

ERROR: "foo* const bar" should be "foo * const bar"
#27: FILE: /tmp/f1-1729/base64.c:27:
+	const char* const plaintextend = plaintext_in + length_in;

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-1729/base64.c:28:
+	char* codechar = code_out;

ERROR: that open brace { should be on the previous line
#34: FILE: /tmp/f1-1729/base64.c:34:
+	switch (state_in->step)
+	{

ERROR: that open brace { should be on the previous line
#36: FILE: /tmp/f1-1729/base64.c:36:
+		while (1)
+		{

WARNING: suspect code indent for conditional statements (16, 16)
#36: FILE: /tmp/f1-1729/base64.c:36:
+		while (1)
+		{

ERROR: that open brace { should be on the previous line
#39: FILE: /tmp/f1-1729/base64.c:39:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#51: FILE: /tmp/f1-1729/base64.c:51:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#63: FILE: /tmp/f1-1729/base64.c:63:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#76: FILE: /tmp/f1-1729/base64.c:76:
+			if (state_in->stepcount == CHARS_PER_LINE/4)
+			{

ERROR: "foo* bar" should be "foo *bar"
#87: FILE: /tmp/f1-1729/base64.c:87:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#87: FILE: /tmp/f1-1729/base64.c:87:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#89: FILE: /tmp/f1-1729/base64.c:89:
+	char* codechar = code_out;

ERROR: that open brace { should be on the previous line
#91: FILE: /tmp/f1-1729/base64.c:91:
+	switch (state_in->step)
+	{

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-1729/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-1729/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-1729/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-1729/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-1729/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-1729/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		         ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-1729/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-1729/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-1729/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-1729/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-1729/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-1729/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-1729/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-1729/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-1729/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-1729/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		                 ^

ERROR: space required after that ',' (ctx:VxO)
#115: FILE: /tmp/f1-1729/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		                    ^

ERROR: space required before that '-' (ctx:OxV)
#115: FILE: /tmp/f1-1729/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		                     ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-1729/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-1729/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-1729/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-1729/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-1729/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-1729/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		         ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-1729/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		           ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-1729/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		            ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-1729/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		              ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-1729/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		               ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-1729/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-1729/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		                   ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-1729/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		    ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-1729/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		      ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-1729/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-1729/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		          ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-1729/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		            ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-1729/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-1729/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-1729/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-1729/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-1729/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-1729/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-1729/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-1729/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-1729/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-1729/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-1729/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-1729/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-1729/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-1729/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-1729/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		                    ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-1729/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-1729/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-1729/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-1729/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-1729/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-1729/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		         ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-1729/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		           ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-1729/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		            ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-1729/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		              ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-1729/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		               ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-1729/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-1729/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-1729/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-1729/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-1729/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-1729/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-1729/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-1729/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-1729/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-1729/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-1729/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-1729/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-1729/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-1729/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-1729/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-1729/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-1729/base64.c:123:
+		44,45,46,47,48,49,50,51
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-1729/base64.c:123:
+		44,45,46,47,48,49,50,51
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-1729/base64.c:123:
+		44,45,46,47,48,49,50,51
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-1729/base64.c:123:
+		44,45,46,47,48,49,50,51
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-1729/base64.c:123:
+		44,45,46,47,48,49,50,51
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-1729/base64.c:123:
+		44,45,46,47,48,49,50,51
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-1729/base64.c:123:
+		44,45,46,47,48,49,50,51
 		                    ^

WARNING: Missing a blank line after declarations
#126: FILE: /tmp/f1-1729/base64.c:126:
+	static const char decoding_size = sizeof(decoding);
+	value_in -= 43;

ERROR: trailing statements should be on next line
#127: FILE: /tmp/f1-1729/base64.c:127:
+	if (value_in < 0 || value_in >= decoding_size) return -1;

ERROR: "foo* bar" should be "foo *bar"
#131: FILE: /tmp/f1-1729/base64.c:131:
+void base64_init_decodestate(base64_decodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#137: FILE: /tmp/f1-1729/base64.c:137:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#137: FILE: /tmp/f1-1729/base64.c:137:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#138: FILE: /tmp/f1-1729/base64.c:138:
+			base64_decodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#140: FILE: /tmp/f1-1729/base64.c:140:
+	const char* codechar = code_in;

ERROR: "foo* bar" should be "foo *bar"
#141: FILE: /tmp/f1-1729/base64.c:141:
+	char* plainchar = plaintext_out;

ERROR: that open brace { should be on the previous line
#146: FILE: /tmp/f1-1729/base64.c:146:
+	switch (state_in->step)
+	{

ERROR: that open brace { should be on the previous line
#148: FILE: /tmp/f1-1729/base64.c:148:
+		while (1)
+		{

WARNING: suspect code indent for conditional statements (16, 16)
#148: FILE: /tmp/f1-1729/base64.c:148:
+		while (1)
+		{

ERROR: that open brace { should be on the previous line
#152: FILE: /tmp/f1-1729/base64.c:152:
+				if (codechar == code_in+length_in)
+				{

ERROR: that open brace { should be on the previous line
#164: FILE: /tmp/f1-1729/base64.c:164:
+				if (codechar == code_in+length_in)
+				{

ERROR: that open brace { should be on the previous line
#177: FILE: /tmp/f1-1729/base64.c:177:
+				if (codechar == code_in+length_in)
+				{

ERROR: that open brace { should be on the previous line
#190: FILE: /tmp/f1-1729/base64.c:190:
+				if (codechar == code_in+length_in)
+				{
Report for base64.h | 85 issues
===============================================
WARNING: Block comments use * on subsequent lines
#2: FILE: /tmp/f1-1729/base64.h:2:
+/*
+This is part of the libb64 project, and has been placed in the public domain.

WARNING: do not add new typedefs
#9: FILE: /tmp/f1-1729/base64.h:9:
+typedef enum

ERROR: open brace '{' following enum go on the same line
#10: FILE: /tmp/f1-1729/base64.h:10:
+typedef enum
+{

WARNING: do not add new typedefs
#14: FILE: /tmp/f1-1729/base64.h:14:
+typedef struct

ERROR: open brace '{' following struct go on the same line
#15: FILE: /tmp/f1-1729/base64.h:15:
+typedef struct
+{

ERROR: "foo* bar" should be "foo *bar"
#21: FILE: /tmp/f1-1729/base64.h:21:
+void base64_init_encodestate(base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#25: FILE: /tmp/f1-1729/base64.h:25:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out,

ERROR: "foo* bar" should be "foo *bar"
#25: FILE: /tmp/f1-1729/base64.h:25:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out,

ERROR: "foo* bar" should be "foo *bar"
#26: FILE: /tmp/f1-1729/base64.h:26:
+			base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-1729/base64.h:28:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-1729/base64.h:28:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in);

WARNING: do not add new typedefs
#31: FILE: /tmp/f1-1729/base64.h:31:
+typedef enum

ERROR: open brace '{' following enum go on the same line
#32: FILE: /tmp/f1-1729/base64.h:32:
+typedef enum
+{

WARNING: do not add new typedefs
#36: FILE: /tmp/f1-1729/base64.h:36:
+typedef struct

ERROR: open brace '{' following struct go on the same line
#37: FILE: /tmp/f1-1729/base64.h:37:
+typedef struct
+{

ERROR: "foo* bar" should be "foo *bar"
#42: FILE: /tmp/f1-1729/base64.h:42:
+void base64_init_decodestate(base64_decodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#46: FILE: /tmp/f1-1729/base64.h:46:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#46: FILE: /tmp/f1-1729/base64.h:46:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#47: FILE: /tmp/f1-1729/base64.h:47:
+			base64_decodestate* state_in);

WARNING: C99 // comments do not match recommendation
#49: FILE: /tmp/f1-1729/base64.h:49:
+#endif //_BASE64_H_
Report for yang_wrappers.c | 8 issues
===============================================
< WARNING: Missing a blank line after declarations
< #688: FILE: /tmp/f1-1729/yang_wrappers.c:688:
< WARNING: Missing a blank line after declarations
< #691: FILE: /tmp/f1-1729/yang_wrappers.c:691:
< WARNING: Missing a blank line after declarations
< #696: FILE: /tmp/f1-1729/yang_wrappers.c:696:
< WARNING: Missing a blank line after declarations
< #709: FILE: /tmp/f1-1729/yang_wrappers.c:709:

@whichbug whichbug force-pushed the master branch 3 times, most recently from de6945a to e5e412b Compare February 20, 2022 00:55
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 20, 2022 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/CI101BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3566/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
/home/ci/cibuild.3566/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.3566/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.3566/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3566/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
isisd/isis_cli.c: In function isis_sr_local_block_label_range_magic:
isisd/isis_cli.c:1574:1: note: #pragma message: Use of the local-block command is deprecated
 CPP_NOTICE("Use of the local-block command is deprecated")

Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U18ARM7BUILD/config.log/config.log.gz
Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U18ARM7BUILD/config.status/config.status

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3566/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
/home/ci/cibuild.3566/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.3566/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.3566/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U16ARM8BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details) Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3566/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
isisd/isis_cli.c: In function isis_sr_local_block_label_range_magic:
isisd/isis_cli.c:1574:1: note: #pragma message: Use of the local-block command is deprecated
 CPP_NOTICE("Use of the local-block command is deprecated")
Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3566/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
isisd/isis_cli.c: In function isis_sr_local_block_label_range_magic:
isisd/isis_cli.c:1574:1: note: #pragma message: Use of the local-block command is deprecated
 CPP_NOTICE("Use of the local-block command is deprecated")

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

Successful on other platforms/tests
  • Ubuntu 16.04 i386 build
  • CentOS 7 amd64 build
  • Ubuntu 18.04 amd64 build
  • Debian 11 amd64 build
  • FreeBSD 11 amd64 build
  • NetBSD 9 amd64 build
  • Ubuntu 16.04 amd64 build
  • OpenBSD 7 amd64 build
  • FreeBSD 12 amd64 build
  • Redhat 8 amd64 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 20.04 amd64 build
  • Debian 9 amd64 build
  • Debian 10 amd64 build
  • Fedora 29 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/CI101BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3566/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
/home/ci/cibuild.3566/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.3566/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.3566/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3566/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
isisd/isis_cli.c: In function isis_sr_local_block_label_range_magic:
isisd/isis_cli.c:1574:1: note: #pragma message: Use of the local-block command is deprecated
 CPP_NOTICE("Use of the local-block command is deprecated")

Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U18ARM7BUILD/config.log/config.log.gz
Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U18ARM7BUILD/config.status/config.status

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3566/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
/home/ci/cibuild.3566/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.3566/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.3566/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U16ARM8BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details) Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3566/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
isisd/isis_cli.c: In function isis_sr_local_block_label_range_magic:
isisd/isis_cli.c:1574:1: note: #pragma message: Use of the local-block command is deprecated
 CPP_NOTICE("Use of the local-block command is deprecated")
Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.3566/frr-source'
lib/base64.c: In function base64_decode_value:
lib/base64.c:127:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
Makefile:9605: recipe for target 'lib/base64.lo' failed
make[1]: *** [lib/base64.lo] Error 1
isisd/isis_cli.c: In function isis_sr_local_block_label_range_magic:
isisd/isis_cli.c:1574:1: note: #pragma message: Use of the local-block command is deprecated
 CPP_NOTICE("Use of the local-block command is deprecated")

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3566/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

<stdin>:286: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Report for base64.c | 77 issues
===============================================
WARNING: Block comments use * on subsequent lines
#2: FILE: /tmp/f1-5907/base64.c:2:
+/*
+This is part of the libb64 project, and has been placed in the public domain.

ERROR: "foo* bar" should be "foo *bar"
#10: FILE: /tmp/f1-5907/base64.c:10:
+void base64_init_encodestate(base64_encodestate* state_in)

WARNING: line over 80 characters
#19: FILE: /tmp/f1-5907/base64.c:19:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";

ERROR: "foo* bar" should be "foo *bar"
#19: FILE: /tmp/f1-5907/base64.c:19:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";

WARNING: Missing a blank line after declarations
#20: FILE: /tmp/f1-5907/base64.c:20:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";
+	if (value_in > 63) return '=';

ERROR: trailing statements should be on next line
#20: FILE: /tmp/f1-5907/base64.c:20:
+	if (value_in > 63) return '=';

WARNING: line over 80 characters
#24: FILE: /tmp/f1-5907/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-5907/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-5907/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-5907/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#26: FILE: /tmp/f1-5907/base64.c:26:
+	const char* plainchar = plaintext_in;

ERROR: "foo* const bar" should be "foo * const bar"
#27: FILE: /tmp/f1-5907/base64.c:27:
+	const char* const plaintextend = plaintext_in + length_in;

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-5907/base64.c:28:
+	char* codechar = code_out;

ERROR: that open brace { should be on the previous line
#34: FILE: /tmp/f1-5907/base64.c:34:
+	switch (state_in->step)
+	{

ERROR: that open brace { should be on the previous line
#36: FILE: /tmp/f1-5907/base64.c:36:
+		while (1)
+		{

WARNING: suspect code indent for conditional statements (16, 16)
#36: FILE: /tmp/f1-5907/base64.c:36:
+		while (1)
+		{

ERROR: that open brace { should be on the previous line
#39: FILE: /tmp/f1-5907/base64.c:39:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#51: FILE: /tmp/f1-5907/base64.c:51:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#63: FILE: /tmp/f1-5907/base64.c:63:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#76: FILE: /tmp/f1-5907/base64.c:76:
+			if (state_in->stepcount == CHARS_PER_LINE/4)
+			{

ERROR: "foo* bar" should be "foo *bar"
#87: FILE: /tmp/f1-5907/base64.c:87:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#87: FILE: /tmp/f1-5907/base64.c:87:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#89: FILE: /tmp/f1-5907/base64.c:89:
+	char* codechar = code_out;

ERROR: that open brace { should be on the previous line
#91: FILE: /tmp/f1-5907/base64.c:91:
+	switch (state_in->step)
+	{

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-5907/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-5907/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-5907/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-5907/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-5907/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-5907/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		         ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-5907/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-5907/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-5907/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-5907/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-5907/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-5907/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-5907/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-5907/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-5907/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-5907/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		                 ^

ERROR: space required after that ',' (ctx:VxO)
#115: FILE: /tmp/f1-5907/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		                    ^

ERROR: space required before that '-' (ctx:OxV)
#115: FILE: /tmp/f1-5907/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		                     ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-5907/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-5907/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-5907/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-5907/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-5907/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-5907/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		         ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-5907/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		           ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-5907/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		            ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-5907/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		              ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-5907/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		               ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-5907/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-5907/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		                   ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-5907/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		    ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-5907/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		      ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-5907/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-5907/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		          ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-5907/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		            ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-5907/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-5907/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-5907/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-5907/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-5907/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-5907/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-5907/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-5907/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-5907/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-5907/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-5907/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-5907/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-5907/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-5907/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-5907/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		                    ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-5907/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-5907/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-5907/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-5907/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-5907/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-5907/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		         ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-5907/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		           ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-5907/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		            ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-5907/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		              ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-5907/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		               ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-5907/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-5907/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-5907/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-5907/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-5907/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-5907/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-5907/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-5907/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-5907/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-5907/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-5907/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-5907/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-5907/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-5907/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-5907/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-5907/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-5907/base64.c:123:
+		44,45,46,47,48,49,50,51
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-5907/base64.c:123:
+		44,45,46,47,48,49,50,51
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-5907/base64.c:123:
+		44,45,46,47,48,49,50,51
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-5907/base64.c:123:
+		44,45,46,47,48,49,50,51
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-5907/base64.c:123:
+		44,45,46,47,48,49,50,51
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-5907/base64.c:123:
+		44,45,46,47,48,49,50,51
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-5907/base64.c:123:
+		44,45,46,47,48,49,50,51
 		                    ^

WARNING: Missing a blank line after declarations
#126: FILE: /tmp/f1-5907/base64.c:126:
+	static const char decoding_size = sizeof(decoding);
+	value_in -= 43;

ERROR: trailing statements should be on next line
#127: FILE: /tmp/f1-5907/base64.c:127:
+	if (((int)value_in) < 0 || value_in >= decoding_size) return -1;

ERROR: "foo* bar" should be "foo *bar"
#131: FILE: /tmp/f1-5907/base64.c:131:
+void base64_init_decodestate(base64_decodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#137: FILE: /tmp/f1-5907/base64.c:137:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#137: FILE: /tmp/f1-5907/base64.c:137:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#138: FILE: /tmp/f1-5907/base64.c:138:
+			base64_decodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#140: FILE: /tmp/f1-5907/base64.c:140:
+	const char* codechar = code_in;

ERROR: "foo* bar" should be "foo *bar"
#141: FILE: /tmp/f1-5907/base64.c:141:
+	char* plainchar = plaintext_out;

ERROR: that open brace { should be on the previous line
#146: FILE: /tmp/f1-5907/base64.c:146:
+	switch (state_in->step)
+	{

ERROR: that open brace { should be on the previous line
#148: FILE: /tmp/f1-5907/base64.c:148:
+		while (1)
+		{

WARNING: suspect code indent for conditional statements (16, 16)
#148: FILE: /tmp/f1-5907/base64.c:148:
+		while (1)
+		{

ERROR: that open brace { should be on the previous line
#152: FILE: /tmp/f1-5907/base64.c:152:
+				if (codechar == code_in+length_in)
+				{

ERROR: that open brace { should be on the previous line
#164: FILE: /tmp/f1-5907/base64.c:164:
+				if (codechar == code_in+length_in)
+				{

ERROR: that open brace { should be on the previous line
#177: FILE: /tmp/f1-5907/base64.c:177:
+				if (codechar == code_in+length_in)
+				{

ERROR: that open brace { should be on the previous line
#190: FILE: /tmp/f1-5907/base64.c:190:
+				if (codechar == code_in+length_in)
+				{
Report for base64.h | 85 issues
===============================================
WARNING: Block comments use * on subsequent lines
#2: FILE: /tmp/f1-5907/base64.h:2:
+/*
+This is part of the libb64 project, and has been placed in the public domain.

WARNING: do not add new typedefs
#9: FILE: /tmp/f1-5907/base64.h:9:
+typedef enum

ERROR: open brace '{' following enum go on the same line
#10: FILE: /tmp/f1-5907/base64.h:10:
+typedef enum
+{

WARNING: do not add new typedefs
#14: FILE: /tmp/f1-5907/base64.h:14:
+typedef struct

ERROR: open brace '{' following struct go on the same line
#15: FILE: /tmp/f1-5907/base64.h:15:
+typedef struct
+{

ERROR: "foo* bar" should be "foo *bar"
#21: FILE: /tmp/f1-5907/base64.h:21:
+void base64_init_encodestate(base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#25: FILE: /tmp/f1-5907/base64.h:25:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out,

ERROR: "foo* bar" should be "foo *bar"
#25: FILE: /tmp/f1-5907/base64.h:25:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out,

ERROR: "foo* bar" should be "foo *bar"
#26: FILE: /tmp/f1-5907/base64.h:26:
+			base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-5907/base64.h:28:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-5907/base64.h:28:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in);

WARNING: do not add new typedefs
#31: FILE: /tmp/f1-5907/base64.h:31:
+typedef enum

ERROR: open brace '{' following enum go on the same line
#32: FILE: /tmp/f1-5907/base64.h:32:
+typedef enum
+{

WARNING: do not add new typedefs
#36: FILE: /tmp/f1-5907/base64.h:36:
+typedef struct

ERROR: open brace '{' following struct go on the same line
#37: FILE: /tmp/f1-5907/base64.h:37:
+typedef struct
+{

ERROR: "foo* bar" should be "foo *bar"
#42: FILE: /tmp/f1-5907/base64.h:42:
+void base64_init_decodestate(base64_decodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#46: FILE: /tmp/f1-5907/base64.h:46:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#46: FILE: /tmp/f1-5907/base64.h:46:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#47: FILE: /tmp/f1-5907/base64.h:47:
+			base64_decodestate* state_in);

WARNING: C99 // comments do not match recommendation
#49: FILE: /tmp/f1-5907/base64.h:49:
+#endif //_BASE64_H_
Report for yang_wrappers.c | 8 issues
===============================================
< WARNING: Missing a blank line after declarations
< #688: FILE: /tmp/f1-5907/yang_wrappers.c:688:
< WARNING: Missing a blank line after declarations
< #691: FILE: /tmp/f1-5907/yang_wrappers.c:691:
< WARNING: Missing a blank line after declarations
< #696: FILE: /tmp/f1-5907/yang_wrappers.c:696:
< WARNING: Missing a blank line after declarations
< #709: FILE: /tmp/f1-5907/yang_wrappers.c:709:

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 20, 2022 •
edited
Loading

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3567/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
<stdin>:286: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Report for base64.c | 77 issues
===============================================
WARNING: Block comments use * on subsequent lines
#2: FILE: /tmp/f1-10645/base64.c:2:
+/*
+This is part of the libb64 project, and has been placed in the public domain.

ERROR: "foo* bar" should be "foo *bar"
#10: FILE: /tmp/f1-10645/base64.c:10:
+void base64_init_encodestate(base64_encodestate* state_in)

WARNING: line over 80 characters
#19: FILE: /tmp/f1-10645/base64.c:19:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";

ERROR: "foo* bar" should be "foo *bar"
#19: FILE: /tmp/f1-10645/base64.c:19:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";

WARNING: Missing a blank line after declarations
#20: FILE: /tmp/f1-10645/base64.c:20:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";
+	if (value_in > 63) return '=';

ERROR: trailing statements should be on next line
#20: FILE: /tmp/f1-10645/base64.c:20:
+	if (value_in > 63) return '=';

WARNING: line over 80 characters
#24: FILE: /tmp/f1-10645/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-10645/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-10645/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-10645/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#26: FILE: /tmp/f1-10645/base64.c:26:
+	const char* plainchar = plaintext_in;

ERROR: "foo* const bar" should be "foo * const bar"
#27: FILE: /tmp/f1-10645/base64.c:27:
+	const char* const plaintextend = plaintext_in + length_in;

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-10645/base64.c:28:
+	char* codechar = code_out;

ERROR: that open brace { should be on the previous line
#34: FILE: /tmp/f1-10645/base64.c:34:
+	switch (state_in->step)
+	{

ERROR: that open brace { should be on the previous line
#36: FILE: /tmp/f1-10645/base64.c:36:
+		while (1)
+		{

WARNING: suspect code indent for conditional statements (16, 16)
#36: FILE: /tmp/f1-10645/base64.c:36:
+		while (1)
+		{

ERROR: that open brace { should be on the previous line
#39: FILE: /tmp/f1-10645/base64.c:39:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#51: FILE: /tmp/f1-10645/base64.c:51:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#63: FILE: /tmp/f1-10645/base64.c:63:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#76: FILE: /tmp/f1-10645/base64.c:76:
+			if (state_in->stepcount == CHARS_PER_LINE/4)
+			{

ERROR: "foo* bar" should be "foo *bar"
#87: FILE: /tmp/f1-10645/base64.c:87:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#87: FILE: /tmp/f1-10645/base64.c:87:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#89: FILE: /tmp/f1-10645/base64.c:89:
+	char* codechar = code_out;

ERROR: that open brace { should be on the previous line
#91: FILE: /tmp/f1-10645/base64.c:91:
+	switch (state_in->step)
+	{

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-10645/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-10645/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-10645/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-10645/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-10645/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-10645/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		         ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-10645/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-10645/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-10645/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-10645/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-10645/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-10645/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-10645/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-10645/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-10645/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-10645/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		                 ^

ERROR: space required after that ',' (ctx:VxO)
#115: FILE: /tmp/f1-10645/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		                    ^

ERROR: space required before that '-' (ctx:OxV)
#115: FILE: /tmp/f1-10645/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		                     ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-10645/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-10645/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-10645/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-10645/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-10645/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-10645/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		         ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-10645/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		           ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-10645/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		            ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-10645/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		              ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-10645/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		               ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-10645/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-10645/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		                   ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-10645/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		    ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-10645/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		      ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-10645/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-10645/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		          ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-10645/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		            ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-10645/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-10645/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-10645/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-10645/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-10645/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-10645/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-10645/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-10645/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-10645/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-10645/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-10645/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-10645/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-10645/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-10645/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-10645/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		                    ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-10645/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-10645/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-10645/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-10645/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-10645/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-10645/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		         ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-10645/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		           ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-10645/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		            ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-10645/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		              ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-10645/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		               ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-10645/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-10645/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-10645/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-10645/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-10645/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-10645/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-10645/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-10645/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-10645/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-10645/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-10645/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-10645/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-10645/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-10645/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-10645/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-10645/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-10645/base64.c:123:
+		44,45,46,47,48,49,50,51
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-10645/base64.c:123:
+		44,45,46,47,48,49,50,51
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-10645/base64.c:123:
+		44,45,46,47,48,49,50,51
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-10645/base64.c:123:
+		44,45,46,47,48,49,50,51
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-10645/base64.c:123:
+		44,45,46,47,48,49,50,51
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-10645/base64.c:123:
+		44,45,46,47,48,49,50,51
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-10645/base64.c:123:
+		44,45,46,47,48,49,50,51
 		                    ^

WARNING: Missing a blank line after declarations
#126: FILE: /tmp/f1-10645/base64.c:126:
+	static const char decoding_size = sizeof(decoding);
+	value_in -= 43;

ERROR: trailing statements should be on next line
#127: FILE: /tmp/f1-10645/base64.c:127:
+	if (value_in < 0 || value_in >= decoding_size) return -1;

ERROR: "foo* bar" should be "foo *bar"
#131: FILE: /tmp/f1-10645/base64.c:131:
+void base64_init_decodestate(base64_decodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#137: FILE: /tmp/f1-10645/base64.c:137:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#137: FILE: /tmp/f1-10645/base64.c:137:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#138: FILE: /tmp/f1-10645/base64.c:138:
+			base64_decodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#140: FILE: /tmp/f1-10645/base64.c:140:
+	const char* codechar = code_in;

ERROR: "foo* bar" should be "foo *bar"
#141: FILE: /tmp/f1-10645/base64.c:141:
+	char* plainchar = plaintext_out;

ERROR: that open brace { should be on the previous line
#146: FILE: /tmp/f1-10645/base64.c:146:
+	switch (state_in->step)
+	{

ERROR: that open brace { should be on the previous line
#148: FILE: /tmp/f1-10645/base64.c:148:
+		while (1)
+		{

WARNING: suspect code indent for conditional statements (16, 16)
#148: FILE: /tmp/f1-10645/base64.c:148:
+		while (1)
+		{

ERROR: that open brace { should be on the previous line
#152: FILE: /tmp/f1-10645/base64.c:152:
+				if (codechar == code_in+length_in)
+				{

ERROR: that open brace { should be on the previous line
#164: FILE: /tmp/f1-10645/base64.c:164:
+				if (codechar == code_in+length_in)
+				{

ERROR: that open brace { should be on the previous line
#177: FILE: /tmp/f1-10645/base64.c:177:
+				if (codechar == code_in+length_in)
+				{

ERROR: that open brace { should be on the previous line
#190: FILE: /tmp/f1-10645/base64.c:190:
+				if (codechar == code_in+length_in)
+				{
Report for base64.h | 85 issues
===============================================
WARNING: Block comments use * on subsequent lines
#2: FILE: /tmp/f1-10645/base64.h:2:
+/*
+This is part of the libb64 project, and has been placed in the public domain.

WARNING: do not add new typedefs
#9: FILE: /tmp/f1-10645/base64.h:9:
+typedef enum

ERROR: open brace '{' following enum go on the same line
#10: FILE: /tmp/f1-10645/base64.h:10:
+typedef enum
+{

WARNING: do not add new typedefs
#14: FILE: /tmp/f1-10645/base64.h:14:
+typedef struct

ERROR: open brace '{' following struct go on the same line
#15: FILE: /tmp/f1-10645/base64.h:15:
+typedef struct
+{

ERROR: "foo* bar" should be "foo *bar"
#21: FILE: /tmp/f1-10645/base64.h:21:
+void base64_init_encodestate(base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#25: FILE: /tmp/f1-10645/base64.h:25:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out,

ERROR: "foo* bar" should be "foo *bar"
#25: FILE: /tmp/f1-10645/base64.h:25:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out,

ERROR: "foo* bar" should be "foo *bar"
#26: FILE: /tmp/f1-10645/base64.h:26:
+			base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-10645/base64.h:28:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-10645/base64.h:28:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in);

WARNING: do not add new typedefs
#31: FILE: /tmp/f1-10645/base64.h:31:
+typedef enum

ERROR: open brace '{' following enum go on the same line
#32: FILE: /tmp/f1-10645/base64.h:32:
+typedef enum
+{

WARNING: do not add new typedefs
#36: FILE: /tmp/f1-10645/base64.h:36:
+typedef struct

ERROR: open brace '{' following struct go on the same line
#37: FILE: /tmp/f1-10645/base64.h:37:
+typedef struct
+{

ERROR: "foo* bar" should be "foo *bar"
#42: FILE: /tmp/f1-10645/base64.h:42:
+void base64_init_decodestate(base64_decodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#46: FILE: /tmp/f1-10645/base64.h:46:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#46: FILE: /tmp/f1-10645/base64.h:46:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#47: FILE: /tmp/f1-10645/base64.h:47:
+			base64_decodestate* state_in);

WARNING: C99 // comments do not match recommendation
#49: FILE: /tmp/f1-10645/base64.h:49:
+#endif //_BASE64_H_
Report for yang_wrappers.c | 8 issues
===============================================
< WARNING: Missing a blank line after declarations
< #688: FILE: /tmp/f1-10645/yang_wrappers.c:688:
< WARNING: Missing a blank line after declarations
< #691: FILE: /tmp/f1-10645/yang_wrappers.c:691:
< WARNING: Missing a blank line after declarations
< #696: FILE: /tmp/f1-10645/yang_wrappers.c:696:
< WARNING: Missing a blank line after declarations
< #709: FILE: /tmp/f1-10645/yang_wrappers.c:709:

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 20, 2022 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3568/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4DEB10AMD64-3568/test

Topology Tests failed for Topotests debian 10 amd64 part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3568/artifact/TOPO4DEB10AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Topotests Ubuntu 18.04 arm8 part 3
  • Addresssanitizer topotests part 4
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 amd64 part 2
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests debian 10 amd64 part 8
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 arm8 part 4
  • IPv6 protocols on Ubuntu 18.04
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests debian 10 amd64 part 0
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 2
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 amd64 part 4
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 arm8 part 7
  • Debian 10 deb pkg check
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 amd64 part 7
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 i386 part 5
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 arm8 part 5
  • CentOS 7 rpm pkg check
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests debian 10 amd64 part 2
  • Static analyzer (clang)
  • Addresssanitizer topotests part 2
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 1
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests debian 10 amd64 part 5
  • Ubuntu 18.04 deb pkg check
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 6
  • Addresssanitizer topotests part 8
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 amd64 part 6

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests debian 10 amd64 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4DEB10AMD64-3568/test

Topology Tests failed for Topotests debian 10 amd64 part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3568/artifact/TOPO4DEB10AMD64/ErrorLog/log_topotests.txt

<stdin>:285: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Report for base64.c | 72 issues
===============================================
WARNING: Block comments use * on subsequent lines
#2: FILE: /tmp/f1-4770/base64.c:2:
+/*
+This is part of the libb64 project, and has been placed in the public domain.

ERROR: "foo* bar" should be "foo *bar"
#10: FILE: /tmp/f1-4770/base64.c:10:
+void base64_init_encodestate(base64_encodestate* state_in)

WARNING: line over 80 characters
#19: FILE: /tmp/f1-4770/base64.c:19:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";

ERROR: "foo* bar" should be "foo *bar"
#19: FILE: /tmp/f1-4770/base64.c:19:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";

WARNING: Missing a blank line after declarations
#20: FILE: /tmp/f1-4770/base64.c:20:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";
+	if (value_in > 63) return '=';

ERROR: trailing statements should be on next line
#20: FILE: /tmp/f1-4770/base64.c:20:
+	if (value_in > 63) return '=';

WARNING: line over 80 characters
#24: FILE: /tmp/f1-4770/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-4770/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-4770/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-4770/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#26: FILE: /tmp/f1-4770/base64.c:26:
+	const char* plainchar = plaintext_in;

ERROR: "foo* const bar" should be "foo * const bar"
#27: FILE: /tmp/f1-4770/base64.c:27:
+	const char* const plaintextend = plaintext_in + length_in;

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-4770/base64.c:28:
+	char* codechar = code_out;

ERROR: that open brace { should be on the previous line
#34: FILE: /tmp/f1-4770/base64.c:34:
+	switch (state_in->step)
+	{

ERROR: that open brace { should be on the previous line
#36: FILE: /tmp/f1-4770/base64.c:36:
+		while (1)
+		{

WARNING: suspect code indent for conditional statements (16, 16)
#36: FILE: /tmp/f1-4770/base64.c:36:
+		while (1)
+		{

ERROR: that open brace { should be on the previous line
#39: FILE: /tmp/f1-4770/base64.c:39:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#51: FILE: /tmp/f1-4770/base64.c:51:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#63: FILE: /tmp/f1-4770/base64.c:63:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#76: FILE: /tmp/f1-4770/base64.c:76:
+			if (state_in->stepcount == CHARS_PER_LINE/4)
+			{

ERROR: "foo* bar" should be "foo *bar"
#87: FILE: /tmp/f1-4770/base64.c:87:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#87: FILE: /tmp/f1-4770/base64.c:87:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#89: FILE: /tmp/f1-4770/base64.c:89:
+	char* codechar = code_out;

ERROR: that open brace { should be on the previous line
#91: FILE: /tmp/f1-4770/base64.c:91:
+	switch (state_in->step)
+	{

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-4770/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-4770/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-4770/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-4770/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-4770/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-4770/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		         ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-4770/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-4770/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-4770/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-4770/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-4770/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-4770/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-4770/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-4770/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-4770/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-4770/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		                 ^

ERROR: space required after that ',' (ctx:VxO)
#115: FILE: /tmp/f1-4770/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		                    ^

ERROR: space required before that '-' (ctx:OxV)
#115: FILE: /tmp/f1-4770/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		                     ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-4770/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-4770/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-4770/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-4770/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-4770/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-4770/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		         ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-4770/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		           ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-4770/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		            ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-4770/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		              ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-4770/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		               ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-4770/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-4770/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		                   ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-4770/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		    ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-4770/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		      ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-4770/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-4770/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		          ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-4770/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		            ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-4770/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-4770/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-4770/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-4770/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-4770/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-4770/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-4770/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-4770/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-4770/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-4770/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-4770/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-4770/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-4770/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-4770/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-4770/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		                    ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-4770/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-4770/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-4770/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-4770/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-4770/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-4770/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		         ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-4770/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		           ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-4770/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		            ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-4770/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		              ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-4770/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		               ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-4770/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-4770/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-4770/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-4770/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-4770/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-4770/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-4770/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-4770/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-4770/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-4770/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-4770/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-4770/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-4770/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-4770/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-4770/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-4770/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-4770/base64.c:123:
+		44,45,46,47,48,49,50,51
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-4770/base64.c:123:
+		44,45,46,47,48,49,50,51
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-4770/base64.c:123:
+		44,45,46,47,48,49,50,51
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-4770/base64.c:123:
+		44,45,46,47,48,49,50,51
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-4770/base64.c:123:
+		44,45,46,47,48,49,50,51
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-4770/base64.c:123:
+		44,45,46,47,48,49,50,51
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-4770/base64.c:123:
+		44,45,46,47,48,49,50,51
 		                    ^

ERROR: trailing statements should be on next line
#126: FILE: /tmp/f1-4770/base64.c:126:
+	if (value_in < 0 || value_in >= 80) return -1;

ERROR: "foo* bar" should be "foo *bar"
#130: FILE: /tmp/f1-4770/base64.c:130:
+void base64_init_decodestate(base64_decodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#136: FILE: /tmp/f1-4770/base64.c:136:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#136: FILE: /tmp/f1-4770/base64.c:136:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#137: FILE: /tmp/f1-4770/base64.c:137:
+			base64_decodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#139: FILE: /tmp/f1-4770/base64.c:139:
+	const char* codechar = code_in;

ERROR: "foo* bar" should be "foo *bar"
#140: FILE: /tmp/f1-4770/base64.c:140:
+	char* plainchar = plaintext_out;

ERROR: that open brace { should be on the previous line
#145: FILE: /tmp/f1-4770/base64.c:145:
+	switch (state_in->step)
+	{

ERROR: that open brace { should be on the previous line
#147: FILE: /tmp/f1-4770/base64.c:147:
+		while (1)
+		{

WARNING: suspect code indent for conditional statements (16, 16)
#147: FILE: /tmp/f1-4770/base64.c:147:
+		while (1)
+		{

ERROR: that open brace { should be on the previous line
#151: FILE: /tmp/f1-4770/base64.c:151:
+				if (codechar == code_in+length_in)
+				{

ERROR: that open brace { should be on the previous line
#163: FILE: /tmp/f1-4770/base64.c:163:
+				if (codechar == code_in+length_in)
+				{

ERROR: that open brace { should be on the previous line
#176: FILE: /tmp/f1-4770/base64.c:176:
+				if (codechar == code_in+length_in)
+				{

ERROR: that open brace { should be on the previous line
#189: FILE: /tmp/f1-4770/base64.c:189:
+				if (codechar == code_in+length_in)
+				{
Report for base64.h | 85 issues
===============================================
WARNING: Block comments use * on subsequent lines
#2: FILE: /tmp/f1-4770/base64.h:2:
+/*
+This is part of the libb64 project, and has been placed in the public domain.

WARNING: do not add new typedefs
#9: FILE: /tmp/f1-4770/base64.h:9:
+typedef enum

ERROR: open brace '{' following enum go on the same line
#10: FILE: /tmp/f1-4770/base64.h:10:
+typedef enum
+{

WARNING: do not add new typedefs
#14: FILE: /tmp/f1-4770/base64.h:14:
+typedef struct

ERROR: open brace '{' following struct go on the same line
#15: FILE: /tmp/f1-4770/base64.h:15:
+typedef struct
+{

ERROR: "foo* bar" should be "foo *bar"
#21: FILE: /tmp/f1-4770/base64.h:21:
+void base64_init_encodestate(base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#25: FILE: /tmp/f1-4770/base64.h:25:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out,

ERROR: "foo* bar" should be "foo *bar"
#25: FILE: /tmp/f1-4770/base64.h:25:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out,

ERROR: "foo* bar" should be "foo *bar"
#26: FILE: /tmp/f1-4770/base64.h:26:
+			base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-4770/base64.h:28:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-4770/base64.h:28:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in);

WARNING: do not add new typedefs
#31: FILE: /tmp/f1-4770/base64.h:31:
+typedef enum

ERROR: open brace '{' following enum go on the same line
#32: FILE: /tmp/f1-4770/base64.h:32:
+typedef enum
+{

WARNING: do not add new typedefs
#36: FILE: /tmp/f1-4770/base64.h:36:
+typedef struct

ERROR: open brace '{' following struct go on the same line
#37: FILE: /tmp/f1-4770/base64.h:37:
+typedef struct
+{

ERROR: "foo* bar" should be "foo *bar"
#42: FILE: /tmp/f1-4770/base64.h:42:
+void base64_init_decodestate(base64_decodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#46: FILE: /tmp/f1-4770/base64.h:46:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#46: FILE: /tmp/f1-4770/base64.h:46:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#47: FILE: /tmp/f1-4770/base64.h:47:
+			base64_decodestate* state_in);

WARNING: C99 // comments do not match recommendation
#49: FILE: /tmp/f1-4770/base64.h:49:
+#endif //_BASE64_H_
Report for yang_wrappers.c | 8 issues
===============================================
< WARNING: Missing a blank line after declarations
< #688: FILE: /tmp/f1-4770/yang_wrappers.c:688:
< WARNING: Missing a blank line after declarations
< #691: FILE: /tmp/f1-4770/yang_wrappers.c:691:
< WARNING: Missing a blank line after declarations
< #696: FILE: /tmp/f1-4770/yang_wrappers.c:696:
< WARNING: Missing a blank line after declarations
< #709: FILE: /tmp/f1-4770/yang_wrappers.c:709:

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 20, 2022 •
edited
Loading

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3569/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
<stdin>:285: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Report for base64.c | 72 issues
===============================================
WARNING: Block comments use * on subsequent lines
#2: FILE: /tmp/f1-11584/base64.c:2:
+/*
+This is part of the libb64 project, and has been placed in the public domain.

ERROR: "foo* bar" should be "foo *bar"
#10: FILE: /tmp/f1-11584/base64.c:10:
+void base64_init_encodestate(base64_encodestate* state_in)

WARNING: line over 80 characters
#19: FILE: /tmp/f1-11584/base64.c:19:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";

ERROR: "foo* bar" should be "foo *bar"
#19: FILE: /tmp/f1-11584/base64.c:19:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";

WARNING: Missing a blank line after declarations
#20: FILE: /tmp/f1-11584/base64.c:20:
+	static const char* encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";
+	if (value_in > 63) return '=';

ERROR: trailing statements should be on next line
#20: FILE: /tmp/f1-11584/base64.c:20:
+	if (value_in > 63) return '=';

WARNING: line over 80 characters
#24: FILE: /tmp/f1-11584/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-11584/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-11584/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#24: FILE: /tmp/f1-11584/base64.c:24:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#26: FILE: /tmp/f1-11584/base64.c:26:
+	const char* plainchar = plaintext_in;

ERROR: "foo* const bar" should be "foo * const bar"
#27: FILE: /tmp/f1-11584/base64.c:27:
+	const char* const plaintextend = plaintext_in + length_in;

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-11584/base64.c:28:
+	char* codechar = code_out;

ERROR: that open brace { should be on the previous line
#34: FILE: /tmp/f1-11584/base64.c:34:
+	switch (state_in->step)
+	{

ERROR: that open brace { should be on the previous line
#36: FILE: /tmp/f1-11584/base64.c:36:
+		while (1)
+		{

WARNING: suspect code indent for conditional statements (16, 16)
#36: FILE: /tmp/f1-11584/base64.c:36:
+		while (1)
+		{

ERROR: that open brace { should be on the previous line
#39: FILE: /tmp/f1-11584/base64.c:39:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#51: FILE: /tmp/f1-11584/base64.c:51:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#63: FILE: /tmp/f1-11584/base64.c:63:
+			if (plainchar == plaintextend)
+			{

ERROR: that open brace { should be on the previous line
#76: FILE: /tmp/f1-11584/base64.c:76:
+			if (state_in->stepcount == CHARS_PER_LINE/4)
+			{

ERROR: "foo* bar" should be "foo *bar"
#87: FILE: /tmp/f1-11584/base64.c:87:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#87: FILE: /tmp/f1-11584/base64.c:87:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#89: FILE: /tmp/f1-11584/base64.c:89:
+	char* codechar = code_out;

ERROR: that open brace { should be on the previous line
#91: FILE: /tmp/f1-11584/base64.c:91:
+	switch (state_in->step)
+	{

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-11584/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-11584/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-11584/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-11584/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#114: FILE: /tmp/f1-11584/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#114: FILE: /tmp/f1-11584/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		         ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-11584/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-11584/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-11584/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: /tmp/f1-11584/base64.c:114:
+		62,-1,-1,-1,63,52,53,54,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-11584/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-11584/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-11584/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-11584/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-11584/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#115: FILE: /tmp/f1-11584/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		                 ^

ERROR: space required after that ',' (ctx:VxO)
#115: FILE: /tmp/f1-11584/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		                    ^

ERROR: space required before that '-' (ctx:OxV)
#115: FILE: /tmp/f1-11584/base64.c:115:
+		55,56,57,58,59,60,61,-1,
 		                     ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-11584/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-11584/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-11584/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-11584/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-11584/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-11584/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		         ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-11584/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		           ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-11584/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		            ^

ERROR: space required after that ',' (ctx:VxO)
#116: FILE: /tmp/f1-11584/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		              ^

ERROR: space required before that '-' (ctx:OxV)
#116: FILE: /tmp/f1-11584/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		               ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-11584/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: /tmp/f1-11584/base64.c:116:
+		-1,-1,-2,-1,-1,-1,0,1,
 		                   ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-11584/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		    ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-11584/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		      ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-11584/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-11584/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		          ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-11584/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		            ^

ERROR: space required after that ',' (ctx:VxV)
#117: FILE: /tmp/f1-11584/base64.c:117:
+		2, 3,4,5,6,7,8,9,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-11584/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-11584/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-11584/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-11584/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-11584/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-11584/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#118: FILE: /tmp/f1-11584/base64.c:118:
+		10,11,12,13,14,15,16,17,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-11584/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-11584/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-11584/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-11584/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-11584/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-11584/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: /tmp/f1-11584/base64.c:119:
+		18,19,20,21,22,23,24,25,
 		                    ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-11584/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		  ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-11584/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		   ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-11584/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		     ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-11584/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		      ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-11584/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		        ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-11584/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		         ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-11584/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		           ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-11584/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		            ^

ERROR: space required after that ',' (ctx:VxO)
#120: FILE: /tmp/f1-11584/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		              ^

ERROR: space required before that '-' (ctx:OxV)
#120: FILE: /tmp/f1-11584/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		               ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-11584/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#120: FILE: /tmp/f1-11584/base64.c:120:
+		-1,-1,-1,-1,-1,-1,26,27,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-11584/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-11584/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-11584/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-11584/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-11584/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-11584/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#121: FILE: /tmp/f1-11584/base64.c:121:
+		28,29,30,31,32,33,34,35,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-11584/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-11584/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-11584/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-11584/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-11584/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-11584/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#122: FILE: /tmp/f1-11584/base64.c:122:
+		36,37,38,39,40,41,42,43,
 		                    ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-11584/base64.c:123:
+		44,45,46,47,48,49,50,51
 		  ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-11584/base64.c:123:
+		44,45,46,47,48,49,50,51
 		     ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-11584/base64.c:123:
+		44,45,46,47,48,49,50,51
 		        ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-11584/base64.c:123:
+		44,45,46,47,48,49,50,51
 		           ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-11584/base64.c:123:
+		44,45,46,47,48,49,50,51
 		              ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-11584/base64.c:123:
+		44,45,46,47,48,49,50,51
 		                 ^

ERROR: space required after that ',' (ctx:VxV)
#123: FILE: /tmp/f1-11584/base64.c:123:
+		44,45,46,47,48,49,50,51
 		                    ^

ERROR: trailing statements should be on next line
#126: FILE: /tmp/f1-11584/base64.c:126:
+	if (value_in < 0 || value_in >= 80) return -1;

ERROR: "foo* bar" should be "foo *bar"
#130: FILE: /tmp/f1-11584/base64.c:130:
+void base64_init_decodestate(base64_decodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#136: FILE: /tmp/f1-11584/base64.c:136:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#136: FILE: /tmp/f1-11584/base64.c:136:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#137: FILE: /tmp/f1-11584/base64.c:137:
+			base64_decodestate* state_in)

ERROR: "foo* bar" should be "foo *bar"
#139: FILE: /tmp/f1-11584/base64.c:139:
+	const char* codechar = code_in;

ERROR: "foo* bar" should be "foo *bar"
#140: FILE: /tmp/f1-11584/base64.c:140:
+	char* plainchar = plaintext_out;

ERROR: that open brace { should be on the previous line
#145: FILE: /tmp/f1-11584/base64.c:145:
+	switch (state_in->step)
+	{

ERROR: that open brace { should be on the previous line
#147: FILE: /tmp/f1-11584/base64.c:147:
+		while (1)
+		{

WARNING: suspect code indent for conditional statements (16, 16)
#147: FILE: /tmp/f1-11584/base64.c:147:
+		while (1)
+		{

ERROR: that open brace { should be on the previous line
#151: FILE: /tmp/f1-11584/base64.c:151:
+				if (codechar == code_in+length_in)
+				{

ERROR: that open brace { should be on the previous line
#163: FILE: /tmp/f1-11584/base64.c:163:
+				if (codechar == code_in+length_in)
+				{

ERROR: that open brace { should be on the previous line
#176: FILE: /tmp/f1-11584/base64.c:176:
+				if (codechar == code_in+length_in)
+				{

ERROR: that open brace { should be on the previous line
#189: FILE: /tmp/f1-11584/base64.c:189:
+				if (codechar == code_in+length_in)
+				{
Report for base64.h | 85 issues
===============================================
WARNING: Block comments use * on subsequent lines
#2: FILE: /tmp/f1-11584/base64.h:2:
+/*
+This is part of the libb64 project, and has been placed in the public domain.

WARNING: do not add new typedefs
#9: FILE: /tmp/f1-11584/base64.h:9:
+typedef enum

ERROR: open brace '{' following enum go on the same line
#10: FILE: /tmp/f1-11584/base64.h:10:
+typedef enum
+{

WARNING: do not add new typedefs
#14: FILE: /tmp/f1-11584/base64.h:14:
+typedef struct

ERROR: open brace '{' following struct go on the same line
#15: FILE: /tmp/f1-11584/base64.h:15:
+typedef struct
+{

ERROR: "foo* bar" should be "foo *bar"
#21: FILE: /tmp/f1-11584/base64.h:21:
+void base64_init_encodestate(base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#25: FILE: /tmp/f1-11584/base64.h:25:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out,

ERROR: "foo* bar" should be "foo *bar"
#25: FILE: /tmp/f1-11584/base64.h:25:
+int base64_encode_block(const char* plaintext_in, int length_in, char* code_out,

ERROR: "foo* bar" should be "foo *bar"
#26: FILE: /tmp/f1-11584/base64.h:26:
+			base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-11584/base64.h:28:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#28: FILE: /tmp/f1-11584/base64.h:28:
+int base64_encode_blockend(char* code_out, base64_encodestate* state_in);

WARNING: do not add new typedefs
#31: FILE: /tmp/f1-11584/base64.h:31:
+typedef enum

ERROR: open brace '{' following enum go on the same line
#32: FILE: /tmp/f1-11584/base64.h:32:
+typedef enum
+{

WARNING: do not add new typedefs
#36: FILE: /tmp/f1-11584/base64.h:36:
+typedef struct

ERROR: open brace '{' following struct go on the same line
#37: FILE: /tmp/f1-11584/base64.h:37:
+typedef struct
+{

ERROR: "foo* bar" should be "foo *bar"
#42: FILE: /tmp/f1-11584/base64.h:42:
+void base64_init_decodestate(base64_decodestate* state_in);

ERROR: "foo* bar" should be "foo *bar"
#46: FILE: /tmp/f1-11584/base64.h:46:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#46: FILE: /tmp/f1-11584/base64.h:46:
+int base64_decode_block(const char* code_in, int length_in, char* plaintext_out,

ERROR: "foo* bar" should be "foo *bar"
#47: FILE: /tmp/f1-11584/base64.h:47:
+			base64_decodestate* state_in);

WARNING: C99 // comments do not match recommendation
#49: FILE: /tmp/f1-11584/base64.h:49:
+#endif //_BASE64_H_
Report for yang_wrappers.c | 8 issues
===============================================
< WARNING: Missing a blank line after declarations
< #688: FILE: /tmp/f1-11584/yang_wrappers.c:688:
< WARNING: Missing a blank line after declarations
< #691: FILE: /tmp/f1-11584/yang_wrappers.c:691:
< WARNING: Missing a blank line after declarations
< #696: FILE: /tmp/f1-11584/yang_wrappers.c:696:
< WARNING: Missing a blank line after declarations
< #709: FILE: /tmp/f1-11584/yang_wrappers.c:709:

@whichbug
Copy link
Author

all required changes have been placed. but you can see from the previous CI results that this libb64 leads to a lot of compiling failures. To eliminate these failures, I have to slightly revise the code in libb64 by changing int base64_decode_value(char value_in) to signed char base64_decode_value(signed char value_in).

perhaps we need to find another reliable base64 lib. please suggest if more changes are required.

@whichbug whichbug requested a review from idryzhov February 20, 2022 04:57
@riw777 riw777 self-requested a review February 22, 2022 16:37
@Jafaral
Copy link
Member

Jafaral commented Feb 22, 2022

@whichbug can you please cleanup the style and we will merge it.

@whichbug whichbug force-pushed the master branch 2 times, most recently from e3b45c6 to 5493aee Compare February 22, 2022 17:01
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 22, 2022 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/artifact/DEB11AMD64/config.status/config.status

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/artifact/DEB11AMD64/ErrorLog/log_make.txt)

 1574 | CPP_NOTICE("Use of the local-block command is deprecated")
/usr/bin/ld: lib/.libs/yang_wrappers.o:/home/ci/cibuild.3613/frr-source/lib/base64.h:31: multiple definition of `base64_decodestep'; lib/.libs/base64.o:/home/ci/cibuild.3613/frr-source/lib/base64.h:31: first defined here
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:7499: lib/libfrr.la] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.3613/frr-source'
make: *** [Makefile:6306: all] Error 2

Debian 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/artifact/DEB11AMD64/config.log/config.log.gz

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/artifact/CI009BUILD/ErrorLog/log_make.txt)

 1574 | CPP_NOTICE("Use of the local-block command is deprecated")
/usr/local/bin/ld: lib/.libs/yang_wrappers.o:/usr/home/ci/cibuild.3613/frr-source/lib/base64.h:31: multiple definition of `base64_decodestep'; lib/.libs/base64.o:/usr/home/ci/cibuild.3613/frr-source/lib/base64.h:31: first defined here
collect2: error: ld returned 1 exit status
gmake[1]: *** [Makefile:7498: lib/libfrr.la] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.3613/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6305: all] Error 2

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/artifact/CI009BUILD/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/artifact/CI011BUILD/ErrorLog/log_make.txt)

 ^
1 warning generated.
ld: error: duplicate symbol: base64_decodestep
>>> defined at base64.h:31 (./lib/base64.h:31)
>>>            lib/.libs/base64.o:(base64_decodestep)
>>> defined at base64.h:31 (./lib/base64.h:31)
>>>            lib/.libs/yang_wrappers.o:(.bss+0x0)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[1]: *** [Makefile:7498: lib/libfrr.la] Error 1

OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/artifact/CI011BUILD/config.status/config.status
OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/artifact/CI011BUILD/config.log/config.log.gz

Successful on other platforms/tests
  • Ubuntu 18.04 arm8 build
  • Ubuntu 20.04 amd64 build
  • Debian 9 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Fedora 29 amd64 build
  • Debian 10 amd64 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 16.04 arm7 build
  • CentOS 7 amd64 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 16.04 amd64 build
  • NetBSD 9 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 16.04 arm8 build
  • Redhat 8 amd64 build
  • Ubuntu 18.04 i386 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/artifact/DEB11AMD64/config.status/config.status

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/artifact/DEB11AMD64/ErrorLog/log_make.txt)

 1574 | CPP_NOTICE("Use of the local-block command is deprecated")
/usr/bin/ld: lib/.libs/yang_wrappers.o:/home/ci/cibuild.3613/frr-source/lib/base64.h:31: multiple definition of `base64_decodestep'; lib/.libs/base64.o:/home/ci/cibuild.3613/frr-source/lib/base64.h:31: first defined here
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:7499: lib/libfrr.la] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.3613/frr-source'
make: *** [Makefile:6306: all] Error 2

Debian 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/artifact/DEB11AMD64/config.log/config.log.gz

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/artifact/CI009BUILD/ErrorLog/log_make.txt)

 1574 | CPP_NOTICE("Use of the local-block command is deprecated")
/usr/local/bin/ld: lib/.libs/yang_wrappers.o:/usr/home/ci/cibuild.3613/frr-source/lib/base64.h:31: multiple definition of `base64_decodestep'; lib/.libs/base64.o:/usr/home/ci/cibuild.3613/frr-source/lib/base64.h:31: first defined here
collect2: error: ld returned 1 exit status
gmake[1]: *** [Makefile:7498: lib/libfrr.la] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.3613/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6305: all] Error 2

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/artifact/CI009BUILD/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/artifact/CI011BUILD/ErrorLog/log_make.txt)

 ^
1 warning generated.
ld: error: duplicate symbol: base64_decodestep
>>> defined at base64.h:31 (./lib/base64.h:31)
>>>            lib/.libs/base64.o:(base64_decodestep)
>>> defined at base64.h:31 (./lib/base64.h:31)
>>>            lib/.libs/yang_wrappers.o:(.bss+0x0)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[1]: *** [Makefile:7498: lib/libfrr.la] Error 1

OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/artifact/CI011BUILD/config.status/config.status
OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3613/artifact/CI011BUILD/config.log/config.log.gz

Report for base64.c | 14 issues
===============================================
WARNING: line over 80 characters
#20: FILE: /tmp/f1-15006/base64.c:20:
+		"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";

WARNING: suspect code indent for conditional statements (16, 16)
#38: FILE: /tmp/f1-15006/base64.c:38:
+		while (1) {
+		case step_A:

WARNING: suspect code indent for conditional statements (16, 16)
#143: FILE: /tmp/f1-15006/base64.c:143:
+		while (1) {
+		case step_a:
Report for yang_wrappers.c | 8 issues
===============================================
< WARNING: Missing a blank line after declarations
< #688: FILE: /tmp/f1-15006/yang_wrappers.c:688:
< WARNING: Missing a blank line after declarations
< #691: FILE: /tmp/f1-15006/yang_wrappers.c:691:
< WARNING: Missing a blank line after declarations
< #696: FILE: /tmp/f1-15006/yang_wrappers.c:696:
< WARNING: Missing a blank line after declarations
< #709: FILE: /tmp/f1-15006/yang_wrappers.c:709:

idryzhov
idryzhov reviewed Feb 22, 2022
View reviewed changes
lib/yang_wrappers.c Outdated
return data;
}

void yang_dnode_get_binary_buf(char *buf, size_t size,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is unusable right now. The buf is populated with some binary data (not zero-terminated), and the caller has no idea about the length of this data. I propose to use the actual length as a return value.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@whichbug whichbug force-pushed the master branch 2 times, most recently from 4eb2b34 to a00d887 Compare February 22, 2022 18:28
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 22, 2022 •
edited
Loading

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3614/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for base64.c | 14 issues
===============================================
WARNING: line over 80 characters
#20: FILE: /tmp/f1-4970/base64.c:20:
+		"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";

WARNING: suspect code indent for conditional statements (16, 16)
#38: FILE: /tmp/f1-4970/base64.c:38:
+		while (1) {
+		case step_A:

WARNING: suspect code indent for conditional statements (16, 16)
#143: FILE: /tmp/f1-4970/base64.c:143:
+		while (1) {
+		case step_a:
Report for yang_wrappers.c | 8 issues
===============================================
< WARNING: Missing a blank line after declarations
< #688: FILE: /tmp/f1-4970/yang_wrappers.c:688:
< WARNING: Missing a blank line after declarations
< #691: FILE: /tmp/f1-4970/yang_wrappers.c:691:
< WARNING: Missing a blank line after declarations
< #696: FILE: /tmp/f1-4970/yang_wrappers.c:696:
< WARNING: Missing a blank line after declarations
< #709: FILE: /tmp/f1-4970/yang_wrappers.c:709:

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 22, 2022 •
edited
Loading

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3618/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for base64.c | 25 issues
===============================================
WARNING: quoted string split across lines
#21: FILE: /tmp/f1-30139/base64.c:21:
+		"ABCDEFGHIJKLMNOPQRSTUVWXYZ"
+		"abcdefghijklmnopqrstuvwxyz"

WARNING: break quoted strings at a space character
#21: FILE: /tmp/f1-30139/base64.c:21:
+		"ABCDEFGHIJKLMNOPQRSTUVWXYZ"
+		"abcdefghijklmnopqrstuvwxyz"

WARNING: quoted string split across lines
#22: FILE: /tmp/f1-30139/base64.c:22:
+		"abcdefghijklmnopqrstuvwxyz"
+		"0123456789+/";

WARNING: break quoted strings at a space character
#22: FILE: /tmp/f1-30139/base64.c:22:
+		"abcdefghijklmnopqrstuvwxyz"
+		"0123456789+/";

WARNING: suspect code indent for conditional statements (16, 16)
#145: FILE: /tmp/f1-30139/base64.c:145:
+		while (1) {
+		case step_a:
Report for yang_wrappers.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #700: FILE: /tmp/f1-30139/yang_wrappers.c:700:

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 22, 2022 •
edited
Loading

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3621/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for base64.c | 25 issues
===============================================
WARNING: quoted string split across lines
#21: FILE: /tmp/f1-25610/base64.c:21:
+		"ABCDEFGHIJKLMNOPQRSTUVWXYZ"
+		"abcdefghijklmnopqrstuvwxyz"

WARNING: break quoted strings at a space character
#21: FILE: /tmp/f1-25610/base64.c:21:
+		"ABCDEFGHIJKLMNOPQRSTUVWXYZ"
+		"abcdefghijklmnopqrstuvwxyz"

WARNING: quoted string split across lines
#22: FILE: /tmp/f1-25610/base64.c:22:
+		"abcdefghijklmnopqrstuvwxyz"
+		"0123456789+/";

WARNING: break quoted strings at a space character
#22: FILE: /tmp/f1-25610/base64.c:22:
+		"abcdefghijklmnopqrstuvwxyz"
+		"0123456789+/";

WARNING: suspect code indent for conditional statements (16, 16)
#145: FILE: /tmp/f1-25610/base64.c:145:
+		while (1) {
+		case step_a:
Report for yang_wrappers.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #700: FILE: /tmp/f1-25610/yang_wrappers.c:700:

isisd: fix FRRouting#10505 using base64 encoding
ac31334 
Using base64 instead of the raw string to encode
the binary data.

Signed-off-by: whichbug <whichbug@github.com>
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 22, 2022 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3622/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-3622/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3622/artifact/TOPO9U18AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Topotests Ubuntu 18.04 arm8 part 5
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 i386 part 9
  • Addresssanitizer topotests part 6
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 amd64 part 1
  • Static analyzer (clang)
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 2
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 6
  • Ubuntu 18.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 1
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests debian 10 amd64 part 6
  • Addresssanitizer topotests part 4
  • Debian 9 deb pkg check
  • Topotests debian 10 amd64 part 5
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 i386 part 7
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 amd64 part 2
  • Addresssanitizer topotests part 5
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 16.04 deb pkg check
  • Debian 10 deb pkg check
  • Topotests debian 10 amd64 part 8
  • IPv6 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 9
  • Addresssanitizer topotests part 2
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 7
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 7
  • Addresssanitizer topotests part 3
  • Fedora 29 rpm pkg check
  • Addresssanitizer topotests part 9
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 arm8 part 2

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-3622/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3622/artifact/TOPO9U18AMD64/ErrorLog/log_topotests.txt

Report for base64.c | 25 issues
===============================================
WARNING: quoted string split across lines
#21: FILE: /tmp/f1-32587/base64.c:21:
+		"ABCDEFGHIJKLMNOPQRSTUVWXYZ"
+		"abcdefghijklmnopqrstuvwxyz"

WARNING: break quoted strings at a space character
#21: FILE: /tmp/f1-32587/base64.c:21:
+		"ABCDEFGHIJKLMNOPQRSTUVWXYZ"
+		"abcdefghijklmnopqrstuvwxyz"

WARNING: quoted string split across lines
#22: FILE: /tmp/f1-32587/base64.c:22:
+		"abcdefghijklmnopqrstuvwxyz"
+		"0123456789+/";

WARNING: break quoted strings at a space character
#22: FILE: /tmp/f1-32587/base64.c:22:
+		"abcdefghijklmnopqrstuvwxyz"
+		"0123456789+/";

WARNING: suspect code indent for conditional statements (16, 16)
#145: FILE: /tmp/f1-32587/base64.c:145:
+		while (1) {
+		case step_a:
Report for yang_wrappers.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #700: FILE: /tmp/f1-32587/yang_wrappers.c:700:

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3623/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@whichbug
Copy link
Author

@whichbug can you please cleanup the style and we will merge it.

all issues addressed.

@whichbug whichbug requested a review from idryzhov February 22, 2022 22:29
riw777
riw777 approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit e3aa338 into FRRouting:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riw777 riw777 riw777 approved these changes

@idryzhov idryzhov Awaiting requested review from idryzhov

Assignees
No one assigned
Labels
bugfix isis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isisd: misusing strdup leads to stack overflow
6 participants
@whichbug @NetDEF-CI @donaldsharp @Jafaral @riw777 @idryzhov