Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pimd: fix misuse of xpath buf size constants #10395

Merged
merged 1 commit into from
Jan 25, 2022
Merged

pimd: fix misuse of xpath buf size constants #10395

merged 1 commit into from
Jan 25, 2022

Conversation

qlyoung
Copy link
Member

@qlyoung qlyoung commented Jan 20, 2022 •
edited
Loading

XPATH_MAXLEN denotes the maximum length of an XPATH. It does not make
sense to allocate a buffer intended to contain an XPATH with a size
larger than the maximum allowable size of an XPATH. Consequently this PR
removes buffers that do this. Prints into these buffers are now checked
for overflow.

This is an alternative to #10394.

Signed-off-by: Quentin Young qlyoung@nvidia.com

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 21, 2022 •
edited
Loading

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2908/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@patrasar
Copy link
Contributor

patrasar commented Jan 21, 2022 •
edited
Loading

@qlyoung It seems to be fixing the issue alternative to the below PR.
#10367

LGTM

eqvinox
eqvinox requested changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@eqvinox eqvinox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok in principle, but no assert please.

pimd/pim_cmd.c Outdated
printed = snprintf(group_list_xpath, sizeof(group_list_xpath),
"%s/group-list", rp_xpath);

assert(printed <= (int)sizeof(group_list_xpath) && "Xpath too long");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do NOT make this asserts, we're getting input from a user on a vty here, so that's where an error report should go, and not result in just crashing the daemon.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put asserts here to kind of force the issue, to make the point that this should never happen if XPATH_MAXLEN is actually the maximum length of an xpath.

Since the build's currently broken I can change it to vty error messages but I think this bears further consideration.

Copy link
Member Author

@qlyoung qlyoung Jan 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually all of these have the comparison backwards wrong too, it should be a strict < 😂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the assert/vty_out discussion – what do we expect users to do when they receive "Xpath too long" error? None of those commands has variable-length arguments (I don't count IP address as such), so there's actually nothing user can do in this case.
It's up to the developer to make sure that XPATH_MAX is enough so probably assert is better here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this @idryzhov. I'm not too concerned with that, I'm only concerned at the moment with fixing the build in a not totally wrong way.

idryzhov
idryzhov approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@idryzhov idryzhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is fine, but would be great to introduce a function for that, something like:

void xpath_format(char *s, const char *format, ...)
{
        int printed;

        va_list args;
        va_start(args, format);
        printed = vsnprintf(s, XPATH_MAXLEN, format, args);
        va_end(args);
        assert(printed <= XPATH_MAXLEN && "Xpath too long");
}

riw777
riw777 approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good other than David's comment ...

@qlyoung qlyoung force-pushed the fix-pim-xpath-buffer-sizes branch from d92847f to f80b9ee Compare January 21, 2022 20:23
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 21, 2022 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U1604I386/ErrorLog/log_make.txt)

 ^
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c:7411:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_igmp:
pimd/pim_cmd.c:7883:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_ssm:
pimd/pim_cmd.c:8437:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_sm:
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U18I386BUILD/ErrorLog/log_make.txt)

 ^~~~~~~~~~
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c:7411:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_igmp:
pimd/pim_cmd.c:7883:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_ssm:
pimd/pim_cmd.c:8437:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_sm:

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U1804AMD64/ErrorLog/log_make.txt)

 ^~~~~~~~~~
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c:7411:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_igmp:
pimd/pim_cmd.c:7883:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_ssm:
pimd/pim_cmd.c:8437:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_sm:
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/DEB11AMD64/ErrorLog/log_make.txt)

isisd/isis_cli.c:422:1: note: #pragma message: Use of `set-attached-bit` is deprecated please use attached-bit [send | receive]
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:14: error: comparison of integer expressions of different signedness: int and long unsigned int [-Werror=sign-compare]
 7402 |  if (printed >= sizeof(group_list_xpath)) {
pimd/pim_cmd.c:7411:14: error: comparison of integer expressions of different signedness: int and long unsigned int [-Werror=sign-compare]
 7411 |  if (printed >= sizeof(group_xpath)) {
pimd/pim_cmd.c: In function interface_no_ip_igmp:
pimd/pim_cmd.c:7883:14: error: comparison of integer expressions of different signedness: int and long unsigned int [-Werror=sign-compare]
 7883 |  if (printed >= sizeof(pim_if_xpath)) {

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/DEB11AMD64/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2928/frr-source'
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c:7411:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_igmp:
pimd/pim_cmd.c:7883:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_ssm:
pimd/pim_cmd.c:8437:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_sm:
FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/CI009BUILD/ErrorLog/log_make.txt)

isisd/isis_cli.c:422:1: note: '#pragma message: Use of `set-attached-bit` is deprecated please use attached-bit [send | receive]'
pimd/pim_cmd.c: In function 'no_ip_pim_rp':
pimd/pim_cmd.c:7402:14: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
 7402 |  if (printed >= sizeof(group_list_xpath)) {
pimd/pim_cmd.c:7411:14: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
 7411 |  if (printed >= sizeof(group_xpath)) {
pimd/pim_cmd.c: In function 'interface_no_ip_igmp':
pimd/pim_cmd.c:7883:14: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
 7883 |  if (printed >= sizeof(pim_if_xpath)) {
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2928/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c:7411:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_igmp:
pimd/pim_cmd.c:7883:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_ssm:
pimd/pim_cmd.c:8437:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_sm:
Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/CI014BUILD/ErrorLog/log_make.txt)

 ^
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c:7411:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_igmp:
pimd/pim_cmd.c:7883:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_ssm:
pimd/pim_cmd.c:8437:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_sm:
Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/REDHAT8/ErrorLog/log_make.txt)

 ^~~~~~~~~~
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:14: error: comparison of integer expressions of different signedness: int and long unsigned int [-Werror=sign-compare]
pimd/pim_cmd.c:7411:14: error: comparison of integer expressions of different signedness: int and long unsigned int [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_igmp:
pimd/pim_cmd.c:7883:14: error: comparison of integer expressions of different signedness: int and long unsigned int [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_ssm:
pimd/pim_cmd.c:8437:14: error: comparison of integer expressions of different signedness: int and long unsigned int [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_sm:

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/REDHAT8/config.log/config.log.gz

NetBSD 9 amd64 build: Failed (click for details) NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/CI012BUILD/config.status/config.status

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/CI012BUILD/ErrorLog/log_make.txt)

 ^~~~~~~~~~
pimd/pim_cmd.c: In function 'no_ip_pim_rp':
pimd/pim_cmd.c:7402:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c:7411:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function 'interface_no_ip_igmp':
pimd/pim_cmd.c:7883:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function 'interface_no_ip_pim_ssm':
pimd/pim_cmd.c:8437:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function 'interface_no_ip_pim_sm':

NetBSD 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/CI012BUILD/config.log/config.log.gz

FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

 ^~~~~~~~~~
pimd/pim_cmd.c: In function 'no_ip_pim_rp':
pimd/pim_cmd.c:7402:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c:7411:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function 'interface_no_ip_igmp':
pimd/pim_cmd.c:7883:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function 'interface_no_ip_pim_ssm':
pimd/pim_cmd.c:8437:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function 'interface_no_ip_pim_sm':
Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/F29BUILD/ErrorLog/log_make.txt)

 ^~~~~~~~~~
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:14: error: comparison of integer expressions of different signedness: int and long unsigned int [-Werror=sign-compare]
pimd/pim_cmd.c:7411:14: error: comparison of integer expressions of different signedness: int and long unsigned int [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_igmp:
pimd/pim_cmd.c:7883:14: error: comparison of integer expressions of different signedness: int and long unsigned int [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_ssm:
pimd/pim_cmd.c:8437:14: error: comparison of integer expressions of different signedness: int and long unsigned int [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_sm:
Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2928/frr-source'
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c:7411:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_igmp:
pimd/pim_cmd.c:7883:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_ssm:
pimd/pim_cmd.c:8437:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_sm:

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U18ARM8BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/CI021BUILD/ErrorLog/log_make.txt)

 ^~~~~~~~~~
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c:7411:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_igmp:
pimd/pim_cmd.c:7883:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_ssm:
pimd/pim_cmd.c:8437:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_sm:
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

isisd/isis_cli.c:422:1: note: #pragma message: Use of `set-attached-bit` is deprecated please use attached-bit [send | receive]
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:14: error: comparison of integer expressions of different signedness: int and long unsigned int [-Werror=sign-compare]
 7402 |  if (printed >= sizeof(group_list_xpath)) {
pimd/pim_cmd.c:7411:14: error: comparison of integer expressions of different signedness: int and long unsigned int [-Werror=sign-compare]
 7411 |  if (printed >= sizeof(group_xpath)) {
pimd/pim_cmd.c: In function interface_no_ip_igmp:
pimd/pim_cmd.c:7883:14: error: comparison of integer expressions of different signedness: int and long unsigned int [-Werror=sign-compare]
 7883 |  if (printed >= sizeof(pim_if_xpath)) {

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

 ^~~~~~~~~~
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c:7411:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_igmp:
pimd/pim_cmd.c:7883:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_ssm:
pimd/pim_cmd.c:8437:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_sm:
Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/DEB10BUILD/ErrorLog/log_make.txt)

 ^~~~~~~~~~
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:14: error: comparison of integer expressions of different signedness: int and long unsigned int [-Werror=sign-compare]
pimd/pim_cmd.c:7411:14: error: comparison of integer expressions of different signedness: int and long unsigned int [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_igmp:
pimd/pim_cmd.c:7883:14: error: comparison of integer expressions of different signedness: int and long unsigned int [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_ssm:
pimd/pim_cmd.c:8437:14: error: comparison of integer expressions of different signedness: int and long unsigned int [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_sm:

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/DEB10BUILD/config.log/config.log.gz

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2928/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c:7411:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_igmp:
pimd/pim_cmd.c:7883:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_ssm:
pimd/pim_cmd.c:8437:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
pimd/pim_cmd.c: In function interface_no_ip_pim_sm:

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2928/artifact/CI101BUILD/config.status/config.status

Successful on other platforms/tests
  • CentOS 7 amd64 build
  • OpenBSD 7 amd64 build

@qlyoung qlyoung requested a review from eqvinox January 21, 2022 20:43
@qlyoung qlyoung force-pushed the fix-pim-xpath-buffer-sizes branch from f80b9ee to 849fbc1 Compare January 21, 2022 20:44
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 21, 2022 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U18I386BUILD/ErrorLog/log_make.txt)

 ^~~~~~~~~~
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:49: error: expected ) before { token
pimd/pim_cmd.c:7402:2: error: this if clause does not guard... [-Werror=misleading-indentation]
pimd/pim_cmd.c:11347:0: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the if
 }
 
pimd/pim_cmd.c:11347:1: error: expected declaration or statement at end of input
 }

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U18I386BUILD/config.log/config.log.gz

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/DEB11AMD64/ErrorLog/log_make.txt)

isisd/isis_cli.c:422:1: note: #pragma message: Use of `set-attached-bit` is deprecated please use attached-bit [send | receive]
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:48: error: expected ) before { token
 7402 |  if (printed >= (int)(sizeof(group_list_xpath)) {
pimd/pim_cmd.c:7402:2: error: this if clause does not guard... [-Werror=misleading-indentation]
 7402 |  if (printed >= (int)(sizeof(group_list_xpath)) {
pimd/pim_cmd.c:11347: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the if
11347 | }
pimd/pim_cmd.c:11347:1: error: expected declaration or statement at end of input

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/DEB11AMD64/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U1604I386/ErrorLog/log_make.txt)

 ^
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:49: error: expected ) before { token
pimd/pim_cmd.c:11347:1: error: expected declaration or statement at end of input
 }
 ^
pimd/pim_cmd.c:7388:25: error: unused variable group_dnode [-Werror=unused-variable]
pimd/pim_cmd.c:7384:7: error: unused variable group_xpath [-Werror=unused-variable]
pimd/pim_cmd.c:7381:14: error: unused variable group_str [-Werror=unused-variable]
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U1804AMD64/ErrorLog/log_make.txt)

 ^~~~~~~~~~
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:49: error: expected ) before { token
pimd/pim_cmd.c:7402:2: error: this if clause does not guard... [-Werror=misleading-indentation]
pimd/pim_cmd.c:11347:0: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the if
 }
 
pimd/pim_cmd.c:11347:1: error: expected declaration or statement at end of input
 }
Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/CI014BUILD/ErrorLog/log_make.txt)

 ^
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:49: error: expected ) before { token
pimd/pim_cmd.c:11347:1: error: expected declaration or statement at end of input
 }
 ^
pimd/pim_cmd.c:7388:25: error: unused variable group_dnode [-Werror=unused-variable]
pimd/pim_cmd.c:7384:7: error: unused variable group_xpath [-Werror=unused-variable]
pimd/pim_cmd.c:7381:14: error: unused variable group_str [-Werror=unused-variable]
Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2929/frr-source'
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:49: error: expected ) before { token
pimd/pim_cmd.c:7402:2: error: this if clause does not guard... [-Werror=misleading-indentation]
pimd/pim_cmd.c:11347:0: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the if
 }
 
pimd/pim_cmd.c:11347:1: error: expected declaration or statement at end of input
 }
NetBSD 9 amd64 build: Failed (click for details) NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/CI012BUILD/config.status/config.status

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/CI012BUILD/ErrorLog/log_make.txt)

 ^~~~~~~~~~
pimd/pim_cmd.c: In function 'no_ip_pim_rp':
pimd/pim_cmd.c:7402:49: error: expected ')' before '{' token
pimd/pim_cmd.c:7402:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
pimd/pim_cmd.c:11347:0: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
 }
 
pimd/pim_cmd.c:11347:1: error: expected declaration or statement at end of input
 }

NetBSD 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/CI012BUILD/config.log/config.log.gz

CentOS 7 amd64 build: Failed (click for details) CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/CI005BUILD/config.status/config.status

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/CI005BUILD/ErrorLog/log_make.txt)

pimd/pim_msdp.c:719:9: warning: missing braces around initializer [-Wmissing-braces]
pimd/pim_msdp.c:719:9: warning: (near initialization for nexthop.last_lookup) [-Wmissing-braces]
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.  CC       bgpd/bgp_addpath.o
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed./home/ci/cibuild.2929/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2929/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2929/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2929/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2929/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2929/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2929/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:49: error: expected ) before { token
pimd/pim_cmd.c:11347:1: error: expected declaration or statement at end of input
 }
 ^
pimd/pim_cmd.c:7388:25: error: unused variable group_dnode [-Werror=unused-variable]
pimd/pim_cmd.c:7384:7: error: unused variable group_xpath [-Werror=unused-variable]
pimd/pim_cmd.c:7381:14: error: unused variable group_str [-Werror=unused-variable]
Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/REDHAT8/ErrorLog/log_make.txt)

 ^~~~~~~~~~
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:48: error: expected ) before { token
pimd/pim_cmd.c:7402:2: error: this if clause does not guard... [-Werror=misleading-indentation]
pimd/pim_cmd.c:11347: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the if
 }
 
pimd/pim_cmd.c:11347:1: error: expected declaration or statement at end of input
 }

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/REDHAT8/config.log/config.log.gz

FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

 ^~~~~~~~~~
pimd/pim_cmd.c: In function 'no_ip_pim_rp':
pimd/pim_cmd.c:7402:49: error: expected ')' before '{' token
pimd/pim_cmd.c:7402:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
pimd/pim_cmd.c:11347:0: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
 }
 
pimd/pim_cmd.c:11347:1: error: expected declaration or statement at end of input
 }
Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/F29BUILD/ErrorLog/log_make.txt)

 ^~~~~~~~~~
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:48: error: expected ) before { token
pimd/pim_cmd.c:7402:2: error: this if clause does not guard... [-Werror=misleading-indentation]
pimd/pim_cmd.c:11347: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the if
 }
 
pimd/pim_cmd.c:11347:1: error: expected declaration or statement at end of input
 }
Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.2929/frr-source'
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:49: error: expected ) before { token
pimd/pim_cmd.c:7402:2: error: this if clause does not guard... [-Werror=misleading-indentation]
pimd/pim_cmd.c:11347:0: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the if
 }
 
pimd/pim_cmd.c:11347:1: error: expected declaration or statement at end of input
 }

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U18ARM8BUILD/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

isisd/isis_cli.c:422:1: note: #pragma message: Use of `set-attached-bit` is deprecated please use attached-bit [send | receive]
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:48: error: expected ) before { token
 7402 |  if (printed >= (int)(sizeof(group_list_xpath)) {
pimd/pim_cmd.c:7402:2: error: this if clause does not guard... [-Werror=misleading-indentation]
 7402 |  if (printed >= (int)(sizeof(group_list_xpath)) {
pimd/pim_cmd.c:11347: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the if
11347 | }
pimd/pim_cmd.c:11347:1: error: expected declaration or statement at end of input

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U2004AMD64BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/CI021BUILD/ErrorLog/log_make.txt)

 ^~~~~~~~~~
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:49: error: expected ) before { token
pimd/pim_cmd.c:7402:2: error: this if clause does not guard... [-Werror=misleading-indentation]
pimd/pim_cmd.c:11347:0: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the if
 }
 
pimd/pim_cmd.c:11347:1: error: expected declaration or statement at end of input
 }
Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

 ^~~~~~~~~~
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:49: error: expected ) before { token
pimd/pim_cmd.c:7402:2: error: this if clause does not guard... [-Werror=misleading-indentation]
pimd/pim_cmd.c:11347:0: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the if
 }
 
pimd/pim_cmd.c:11347:1: error: expected declaration or statement at end of input
 }
Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/DEB10BUILD/ErrorLog/log_make.txt)

 ^~~~~~~~~~
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:48: error: expected ) before { token
pimd/pim_cmd.c:7402:2: error: this if clause does not guard... [-Werror=misleading-indentation]
pimd/pim_cmd.c:11347: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the if
 }
 
pimd/pim_cmd.c:11347:1: error: expected declaration or statement at end of input
 }

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/DEB10BUILD/config.log/config.log.gz

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/CI009BUILD/ErrorLog/log_make.txt)

isisd/isis_cli.c:422:1: note: '#pragma message: Use of `set-attached-bit` is deprecated please use attached-bit [send | receive]'
pimd/pim_cmd.c: In function 'no_ip_pim_rp':
pimd/pim_cmd.c:7402:48: error: expected ')' before '{' token
 7402 |  if (printed >= (int)(sizeof(group_list_xpath)) {
pimd/pim_cmd.c:7402:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
 7402 |  if (printed >= (int)(sizeof(group_list_xpath)) {
pimd/pim_cmd.c:11347: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
11347 | }
pimd/pim_cmd.c:11347:1: error: expected declaration or statement at end of input
Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2929/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
pimd/pim_cmd.c: In function no_ip_pim_rp:
pimd/pim_cmd.c:7402:49: error: expected ) before { token
pimd/pim_cmd.c:11347:1: error: expected declaration or statement at end of input
 }
 ^
pimd/pim_cmd.c:7388:25: error: unused variable group_dnode [-Werror=unused-variable]
pimd/pim_cmd.c:7384:7: error: unused variable group_xpath [-Werror=unused-variable]
pimd/pim_cmd.c:7381:14: error: unused variable group_str [-Werror=unused-variable]

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2929/artifact/CI101BUILD/config.status/config.status

Successful on other platforms/tests
  • OpenBSD 7 amd64 build

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jan 21, 2022 •
edited
Loading

Outdated results 🛑

Basic BGPD CI results: FAILURE

_ _
Result FAILURE git merge/10395 849fbc1 frr.github Build
Date 01/21/2022
Start 16:06:23
Finish 16:07:37
Run-Time 01:14
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details vncregress-2022-01-21-16:06:23.txt
Log make-2022-01-21-16:06:23.out.bz2
Memory

For details, please contact louberger

patrasar
patrasar reviewed Jan 24, 2022
View reviewed changes
patrasar
patrasar reviewed Jan 24, 2022
View reviewed changes
patrasar
patrasar reviewed Jan 24, 2022
View reviewed changes
patrasar
patrasar reviewed Jan 24, 2022
View reviewed changes
patrasar
patrasar reviewed Jan 24, 2022
View reviewed changes
patrasar
patrasar reviewed Jan 24, 2022
View reviewed changes
@patrasar patrasar self-requested a review January 24, 2022 14:16
@qlyoung
pimd: fix misuse of xpath buf size constants
d7073b2 
XPATH_MAXLEN denotes the maximum length of an XPATH. It does not make
sense to allocate a buffer intended to contain an XPATH with a size
larger than the maximum allowable size of an XPATH. Consequently this PR
removes buffers that do this. Prints into these buffers are now checked
for overflow.

Signed-off-by: Quentin Young <qlyoung@nvidia.com>
@qlyoung qlyoung force-pushed the fix-pim-xpath-buffer-sizes branch from 849fbc1 to d7073b2 Compare January 24, 2022 16:13
@qlyoung
Copy link
Member Author

qlyoung commented Jan 24, 2022

silly me :)

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2960/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@eqvinox eqvinox merged commit 414db8e into FRRouting:master Jan 25, 2022
@patrasar patrasar mentioned this pull request Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idryzhov idryzhov idryzhov approved these changes

@riw777 riw777 riw777 approved these changes

@eqvinox eqvinox eqvinox approved these changes

@donaldsharp donaldsharp Awaiting requested review from donaldsharp

@patrasar patrasar Awaiting requested review from patrasar

Assignees
No one assigned
Labels
bugfix pim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@qlyoung @NetDEF-CI @patrasar @LabN-CI @riw777 @idryzhov @eqvinox