Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: pass conditionals through clippy for DEFPY #10337

Merged
merged 1 commit into from
Jan 13, 2022
Merged

python: pass conditionals through clippy for DEFPY #10337

merged 1 commit into from
Jan 13, 2022

Conversation

eqvinox
Copy link
Contributor

@eqvinox eqvinox commented Jan 13, 2022

Track what conditionals apply when a DEFPY is encountered, and stack them around the autogenerated clippy wrapper. Otherwise conditional DEFPYs result in undefined function warnings.

@frrbot frrbot bot added the clippy label Jan 13, 2022
@eqvinox
python: pass conditionals through clippy for DEFPY
d11238b 
Track what conditionals apply when a DEFPY is encountered, and stack
them around the autogenerated clippy wrapper.  Otherwise conditional
DEFPYs result in undefined function warnings.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 13, 2022 •
edited
Loading

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2691/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@idryzhov
Copy link
Contributor

This is what I've been missing all this time! Thanks!
I'm not familiar with the code though so can't do the review :(

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2692/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@donaldsharp donaldsharp merged commit a8057c9 into FRRouting:master Jan 13, 2022
@eqvinox eqvinox deleted the clippy-conds branch January 14, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
clippy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eqvinox @NetDEF-CI @idryzhov @donaldsharp