build: add "--with-service-timeout" in configure.ac #10242
Merged
+25
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 4: No useful log foundSuccessful on other platforms/tests
|
|
Commit says 2 minutes, PR says 4 minutes, but the real change is 5 minutes 😄 Which is true? |
|
@ton31337 sorry for my mistake. |
|
I would recommend that we make this a configurable item instead of just changing it to an arbitrary time that works for slow systems. Why should we wait 5 minutes on a fast system if it's run into an issue. |
donaldsharp
requested changes
Dec 21, 2021
anlancs
force-pushed
the
fix-service-time
branch
from
822d24c to
c27d559
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 8: Failed (click for details)Topotests debian 10 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 8: No useful log foundTopotests debian 10 amd64 part 5: Failed (click for details)Topotests debian 10 amd64 part 5: No useful log foundSuccessful on other platforms/tests
|
|
@donaldsharp |
|
Agree with @donaldsharp. |
anlancs
force-pushed
the
fix-service-time
branch
from
c27d559 to
fc8fc0d
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests Ubuntu 18.04 i386 part 3: Incomplete(check logs for details)IPv6 protocols on Ubuntu 18.04: Incomplete(check logs for details)IPv4 protocols on Ubuntu 18.04: Incomplete(check logs for details)Successful on other platforms/tests
|
donaldsharp
requested changes
Jan 5, 2022
anlancs
force-pushed
the
fix-service-time
branch
from
fc8fc0d to
e472a96
Compare
anlancs
changed the title
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2515/ This is a comment from an automated CI system. |
ton31337
reviewed
Jan 6, 2022
configure.ac
Outdated
| @@ -932,6 +934,20 @@ AC_DEFINE_UNQUOTED([MULTIPATH_NUM], [$MPATH_NUM], [Maximum number of paths for a | |||
|
|
|||
| AC_DEFINE_UNQUOTED([VTYSH_PAGER], ["$VTYSH_PAGER"], [What pager to use]) | |||
|
|
|||
|
|
|||
| TIMEOUT_SEC=2 | |||
There was a problem hiding this comment.
OK！I will use TIMEOUT_MIN.
On lower CPU with lots of static routes, it will cost more than 2 minutes. 2 minutes is the default timeout value, we can adjust it by configure: ./configure --with-service-timeout=<digit> Signed-off-by: anlan_cs <anlan_cs@tom.com>
anlancs
force-pushed
the
fix-service-time
branch
from
e472a96 to
fc53921
Compare
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2541/ This is a comment from an automated CI system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build: add "--with-service-timeout" in configure.ac
On lower CPU with lots of static routes, it will cost more than 2
minutes.
2 minutes is the default timeout value, we can adjust it by configure:
./configure --with-service-timeout=
Signed-off-by: anlancs anlan_cs@tom.com