Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various tools / init script / daemons file cleanups #10176

Closed
wants to merge 6 commits into from
Closed

Various tools / init script / daemons file cleanups #10176

wants to merge 6 commits into from

Conversation

qlyoung
Copy link
Member

@qlyoung qlyoung commented Dec 6, 2021

  • We support 'wrap' variables in /etc/frr/daemons, but the explanation given there doesn't touch on some of the subtleties of using these variables.
    The variables were designed for use with Valgrind, which has special behavior when run with programs that daemonize; Valgrind will intercept the fork()'d child process and run itself instead of the child. This behavior allows it to follow the same forking semantics as the target program.
    For virtually every other wrapper, the wrap variables do not work as demonstrated because the wrapper programs do not daemonize. If the wrappers do not daemonize, they will block the init script. The examples given with "perf" for example simply do not work, because perf remains in the foreground even as it tracks forked children.
    This patch adds an explanation of the behavior expected by the init script and offers a solution for getting that behavior.
  • The explanation block for watchfrr_options was split into two blocks, one explaining the --netns option and one making a vague statement that the init script provides the list of daemons to start. The former can be merged with the latter and the latter is more useful when stated as a caveat for what you should actually use watchfrr_options for.
  • When starting a daemon, print the full command run by the init script to start it. This gives more information and is especially helpful when debugging wrap commands.
    Also add some more logs to vtysh_b to print the command used there, log when we exit early because frr.conf doesn't exist, and simplify the code path for creating the command to use.
  • Apply various shellcheck recommendations

@frrbot frrbot bot added the tools label Dec 6, 2021
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Dec 6, 2021 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1972/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Incomplete

Ubuntu 16.04 arm8 build: Incomplete (check logs for details)
Successful on other platforms/tests
  • Ubuntu 16.04 amd64 build
  • FreeBSD 12 amd64 build
  • CentOS 7 amd64 build
  • Ubuntu 18.04 i386 build
  • NetBSD 8 amd64 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 18.04 arm8 build
  • CentOS 8 amd64 build
  • Ubuntu 16.04 i386 build
  • Debian 11 amd64 build
  • Debian 10 amd64 build
  • OpenBSD 6 amd64 build
  • Fedora 29 amd64 build
  • FreeBSD 11 amd64 build
  • Debian 9 amd64 build
  • Ubuntu 16.04 arm7 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Ubuntu 18.04 amd64 build
### Basic Tests: Incomplete

@idryzhov
Copy link
Contributor

idryzhov commented Dec 6, 2021 •
edited
Loading

As you touch the daemons file, could you please also add a couple of words about frr_global_options to line 60?
Something like:

# If you want to pass a common option to all daemons, you can use the "frr_global_options" variable.
#
#frr_global_options=""

I want to refer to this option in my PR, and it would be easier if you add this description in this PR, otherwise there will be merge conflicts.

@qlyoung
Copy link
Member Author

qlyoung commented Dec 6, 2021

Sure

@qlyoung qlyoung requested a review from idryzhov December 6, 2021 16:36
eqvinox
eqvinox requested changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@eqvinox eqvinox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the += thing

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Dec 6, 2021 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1994/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 6: Failed (click for details) Topotests Ubuntu 18.04 i386 part 6: No useful log found
Topotests Ubuntu 18.04 i386 part 1: Failed (click for details) Topotests Ubuntu 18.04 i386 part 1: No useful log found
Topotests Ubuntu 18.04 amd64 part 5: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 5: No useful log found
Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 4: No useful log found
Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 1: No useful log found
Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 7: No useful log found
Topotests debian 10 amd64 part 6: Failed (click for details) Topotests debian 10 amd64 part 6: No useful log found
Topotests Ubuntu 18.04 i386 part 2: Failed (click for details) Topotests Ubuntu 18.04 i386 part 2: No useful log found
Topotests debian 10 amd64 part 5: Failed (click for details) Topotests debian 10 amd64 part 5: No useful log found
Topotests debian 10 amd64 part 0: Failed (click for details) Topotests debian 10 amd64 part 0: No useful log found
Topotests Ubuntu 18.04 arm8 part 2: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 2: No useful log found
Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 7: No useful log found
Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 8: No useful log found
Topotests debian 10 amd64 part 9: Failed (click for details) Topotests debian 10 amd64 part 9: No useful log found
Topotests Ubuntu 18.04 i386 part 7: Failed (click for details) Topotests Ubuntu 18.04 i386 part 7: No useful log found
Fedora 29 rpm pkg check: Failed (click for details) Fedora 29 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1994/artifact/F29RPMCHECK/ErrorLog/log_package_start.txt Fedora 29 rpm pkg check: No useful log found
CentOS 7 rpm pkg check: Failed (click for details) CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1994/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log found
Topotests debian 10 amd64 part 7: Failed (click for details) Topotests debian 10 amd64 part 7: No useful log found
Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 3: No useful log found
Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 0: No useful log found
Topotests Ubuntu 18.04 i386 part 5: Failed (click for details) Topotests Ubuntu 18.04 i386 part 5: No useful log found
Topotests Ubuntu 18.04 amd64 part 2: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 2: No useful log found
Topotests Ubuntu 18.04 i386 part 0: Failed (click for details) Topotests Ubuntu 18.04 i386 part 0: No useful log found
Topotests debian 10 amd64 part 8: Failed (click for details) Topotests debian 10 amd64 part 8: No useful log found
Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 4: No useful log found
Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 9: No useful log found
Topotests debian 10 amd64 part 3: Failed (click for details) Topotests debian 10 amd64 part 3: No useful log found
Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 1: No useful log found
Topotests Ubuntu 18.04 i386 part 4: Failed (click for details) Topotests Ubuntu 18.04 i386 part 4: No useful log found
Topotests Ubuntu 18.04 i386 part 9: Failed (click for details) Topotests Ubuntu 18.04 i386 part 9: No useful log found
Topotests Ubuntu 18.04 i386 part 3: Failed (click for details) Topotests Ubuntu 18.04 i386 part 3: No useful log found
Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 6: No useful log found
Topotests Ubuntu 18.04 i386 part 8: Failed (click for details) Topotests Ubuntu 18.04 i386 part 8: No useful log found
Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 9: No useful log found
Topotests debian 10 amd64 part 4: Failed (click for details) Topotests debian 10 amd64 part 4: No useful log found
Topotests Ubuntu 18.04 arm8 part 5: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 5: No useful log found
Topotests debian 10 amd64 part 1: Failed (click for details) Topotests debian 10 amd64 part 1: No useful log found
Topotests Ubuntu 18.04 arm8 part 3: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 3: No useful log found
Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 8: No useful log found
Topotests debian 10 amd64 part 2: Failed (click for details) Topotests debian 10 amd64 part 2: No useful log found
Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 0: No useful log found
Successful on other platforms/tests
  • Addresssanitizer topotests part 2
  • IPv4 ldp protocol on Ubuntu 18.04
  • Addresssanitizer topotests part 9
  • Addresssanitizer topotests part 3
  • Addresssanitizer topotests part 6
  • Ubuntu 20.04 deb pkg check
  • Debian 10 deb pkg check
  • Debian 9 deb pkg check
  • IPv6 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 1
  • Ubuntu 18.04 deb pkg check
  • IPv4 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 8
  • Addresssanitizer topotests part 7
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 5
  • Static analyzer (clang)
  • Ubuntu 16.04 deb pkg check
  • Addresssanitizer topotests part 0

@qlyoung qlyoung force-pushed the cleanup-daemons-file-wrap-explanation branch from cfe988b to df0c496 Compare December 9, 2021 18:57
@qlyoung qlyoung requested a review from eqvinox December 9, 2021 19:53
@qlyoung
Copy link
Member Author

qlyoung commented Dec 9, 2021

@eqvinox addressed your += comment

@qlyoung
Copy link
Member Author

qlyoung commented Dec 9, 2021

Looks like the package failed to install but it doesn't seem related

@qlyoung
Copy link
Member Author

qlyoung commented Dec 9, 2021

ci:rerun

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Dec 9, 2021 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2052/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 3: Failed (click for details) Topotests debian 10 amd64 part 3: No useful log found
Topotests debian 10 amd64 part 8: Failed (click for details) Topotests debian 10 amd64 part 8: No useful log found
Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 6: No useful log found
Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 4: No useful log found
Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 9: No useful log found
Topotests Ubuntu 18.04 i386 part 4: Failed (click for details) Topotests Ubuntu 18.04 i386 part 4: No useful log found
Topotests Ubuntu 18.04 arm8 part 3: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 3: No useful log found
Topotests Ubuntu 18.04 i386 part 9: Failed (click for details) Topotests Ubuntu 18.04 i386 part 9: No useful log found
Topotests Ubuntu 18.04 i386 part 3: Failed (click for details) Topotests Ubuntu 18.04 i386 part 3: No useful log found
Topotests Ubuntu 18.04 i386 part 8: Failed (click for details) Topotests Ubuntu 18.04 i386 part 8: No useful log found
Topotests Ubuntu 18.04 arm8 part 5: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 5: No useful log found
Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 9: No useful log found
Topotests debian 10 amd64 part 4: Failed (click for details) Topotests debian 10 amd64 part 4: No useful log found
Topotests debian 10 amd64 part 1: Failed (click for details) Topotests debian 10 amd64 part 1: No useful log found
Topotests debian 10 amd64 part 2: Failed (click for details) Topotests debian 10 amd64 part 2: No useful log found
Topotests Ubuntu 18.04 i386 part 6: Failed (click for details) Topotests Ubuntu 18.04 i386 part 6: No useful log found
Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 0: No useful log found
Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 8: No useful log found
Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 4: No useful log found
Topotests Ubuntu 18.04 i386 part 1: Failed (click for details) Topotests Ubuntu 18.04 i386 part 1: No useful log found
Topotests debian 10 amd64 part 6: Failed (click for details) Topotests debian 10 amd64 part 6: No useful log found
Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 1: No useful log found
Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 0: No useful log found
Topotests Ubuntu 18.04 amd64 part 5: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 5: No useful log found
Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests Ubuntu 18.04 arm8 part 2: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 2: No useful log found
Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 7: No useful log found
Fedora 29 rpm pkg check: Failed (click for details) Fedora 29 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2052/artifact/F29RPMCHECK/ErrorLog/log_package_start.txt Fedora 29 rpm pkg check: No useful log found
Topotests debian 10 amd64 part 5: Failed (click for details) Topotests debian 10 amd64 part 5: No useful log found
Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 7: No useful log found
Topotests debian 10 amd64 part 0: Failed (click for details) Topotests debian 10 amd64 part 0: No useful log found
CentOS 7 rpm pkg check: Failed (click for details) CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2052/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log found
Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 8: No useful log found
Topotests debian 10 amd64 part 9: Failed (click for details) Topotests debian 10 amd64 part 9: No useful log found
Topotests Ubuntu 18.04 i386 part 2: Failed (click for details) Topotests Ubuntu 18.04 i386 part 2: No useful log found
Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 3: No useful log found
Topotests Ubuntu 18.04 i386 part 7: Failed (click for details) Topotests Ubuntu 18.04 i386 part 7: No useful log found
Topotests Ubuntu 18.04 amd64 part 2: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 2: No useful log found
Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 1: No useful log found
Topotests Ubuntu 18.04 i386 part 5: Failed (click for details) Topotests Ubuntu 18.04 i386 part 5: No useful log found
Topotests Ubuntu 18.04 i386 part 0: Failed (click for details) Topotests Ubuntu 18.04 i386 part 0: No useful log found
Topotests debian 10 amd64 part 7: Failed (click for details) Topotests debian 10 amd64 part 7: No useful log found
Successful on other platforms/tests
  • Addresssanitizer topotests part 0
  • Ubuntu 20.04 deb pkg check
  • Ubuntu 18.04 deb pkg check
  • Debian 10 deb pkg check
  • IPv6 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 1
  • IPv4 protocols on Ubuntu 18.04
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 7
  • Static analyzer (clang)
  • Addresssanitizer topotests part 5
  • Ubuntu 16.04 deb pkg check
  • IPv4 ldp protocol on Ubuntu 18.04
  • Addresssanitizer topotests part 2
  • Addresssanitizer topotests part 3
  • Addresssanitizer topotests part 9
  • Addresssanitizer topotests part 8
  • Addresssanitizer topotests part 6

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Dec 9, 2021 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2054/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 3: Failed (click for details) Topotests debian 10 amd64 part 3: No useful log found
Topotests debian 10 amd64 part 8: Failed (click for details) Topotests debian 10 amd64 part 8: No useful log found
Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 6: No useful log found
Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 4: No useful log found
Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 9: No useful log found
Topotests Ubuntu 18.04 i386 part 4: Failed (click for details) Topotests Ubuntu 18.04 i386 part 4: No useful log found
Topotests Ubuntu 18.04 i386 part 9: Failed (click for details) Topotests Ubuntu 18.04 i386 part 9: No useful log found
Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 9: No useful log found
Topotests Ubuntu 18.04 i386 part 8: Failed (click for details) Topotests Ubuntu 18.04 i386 part 8: No useful log found
Topotests Ubuntu 18.04 i386 part 3: Failed (click for details) Topotests Ubuntu 18.04 i386 part 3: No useful log found
Topotests Ubuntu 18.04 arm8 part 5: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 5: No useful log found
Topotests debian 10 amd64 part 4: Failed (click for details) Topotests debian 10 amd64 part 4: No useful log found
Topotests Ubuntu 18.04 arm8 part 3: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 3: No useful log found
Topotests debian 10 amd64 part 1: Failed (click for details) Topotests debian 10 amd64 part 1: No useful log found
Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 0: No useful log found
Topotests debian 10 amd64 part 2: Failed (click for details) Topotests debian 10 amd64 part 2: No useful log found
Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 8: No useful log found
Topotests Ubuntu 18.04 i386 part 6: Failed (click for details) Topotests Ubuntu 18.04 i386 part 6: No useful log found
Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 4: No useful log found
Topotests Ubuntu 18.04 i386 part 1: Failed (click for details) Topotests Ubuntu 18.04 i386 part 1: No useful log found
Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 0: No useful log found
Topotests Ubuntu 18.04 amd64 part 5: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 5: No useful log found
Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 1: No useful log found
Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 7: No useful log found
Topotests debian 10 amd64 part 6: Failed (click for details) Topotests debian 10 amd64 part 6: No useful log found
Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 7: No useful log found
Fedora 29 rpm pkg check: Failed (click for details) Fedora 29 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2054/artifact/F29RPMCHECK/ErrorLog/log_package_start.txt Fedora 29 rpm pkg check: No useful log found
Topotests debian 10 amd64 part 0: Failed (click for details) Topotests debian 10 amd64 part 0: No useful log found
Topotests debian 10 amd64 part 5: Failed (click for details) Topotests debian 10 amd64 part 5: No useful log found
Topotests Ubuntu 18.04 arm8 part 2: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 2: No useful log found
Topotests Ubuntu 18.04 i386 part 7: Failed (click for details) Topotests Ubuntu 18.04 i386 part 7: No useful log found
Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 8: No useful log found
CentOS 7 rpm pkg check: Failed (click for details) CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2054/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log found
Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 3: No useful log found
Topotests Ubuntu 18.04 i386 part 2: Failed (click for details) Topotests Ubuntu 18.04 i386 part 2: No useful log found
Topotests debian 10 amd64 part 9: Failed (click for details) Topotests debian 10 amd64 part 9: No useful log found
Topotests Ubuntu 18.04 amd64 part 2: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 2: No useful log found
Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 1: No useful log found
Topotests Ubuntu 18.04 i386 part 5: Failed (click for details) Topotests Ubuntu 18.04 i386 part 5: No useful log found
Topotests debian 10 amd64 part 7: Failed (click for details) Topotests debian 10 amd64 part 7: No useful log found
Topotests Ubuntu 18.04 i386 part 0: Failed (click for details) Topotests Ubuntu 18.04 i386 part 0: No useful log found
Successful on other platforms/tests
  • Addresssanitizer topotests part 0
  • Debian 10 deb pkg check
  • IPv6 protocols on Ubuntu 18.04
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 20.04 deb pkg check
  • Addresssanitizer topotests part 1
  • IPv4 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 4
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 8
  • Addresssanitizer topotests part 7
  • Addresssanitizer topotests part 5
  • Static analyzer (clang)
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 16.04 deb pkg check
  • Addresssanitizer topotests part 2
  • Addresssanitizer topotests part 3
  • Addresssanitizer topotests part 9
  • Addresssanitizer topotests part 6

@eqvinox
Copy link
Contributor

eqvinox commented Dec 10, 2021

Looks like the package failed to install but it doesn't seem related

The tests might be doing edits to /etc/frr/daemons which don't work anymore after your changes 😞

eqvinox
eqvinox approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@eqvinox eqvinox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Dec 10, 2021 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2054/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 3: Failed (click for details) Topotests debian 10 amd64 part 3: No useful log found
Topotests debian 10 amd64 part 8: Failed (click for details) Topotests debian 10 amd64 part 8: No useful log found
Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 6: No useful log found
Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 4: No useful log found
Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 9: No useful log found
Topotests Ubuntu 18.04 i386 part 4: Failed (click for details) Topotests Ubuntu 18.04 i386 part 4: No useful log found
Topotests Ubuntu 18.04 i386 part 9: Failed (click for details) Topotests Ubuntu 18.04 i386 part 9: No useful log found
Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 9: No useful log found
Topotests Ubuntu 18.04 i386 part 8: Failed (click for details) Topotests Ubuntu 18.04 i386 part 8: No useful log found
Topotests Ubuntu 18.04 i386 part 3: Failed (click for details) Topotests Ubuntu 18.04 i386 part 3: No useful log found
Topotests Ubuntu 18.04 arm8 part 5: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 5: No useful log found
Topotests debian 10 amd64 part 4: Failed (click for details) Topotests debian 10 amd64 part 4: No useful log found
Topotests Ubuntu 18.04 arm8 part 3: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 3: No useful log found
Topotests debian 10 amd64 part 1: Failed (click for details) Topotests debian 10 amd64 part 1: No useful log found
Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 0: No useful log found
Topotests debian 10 amd64 part 2: Failed (click for details) Topotests debian 10 amd64 part 2: No useful log found
Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 8: No useful log found
Topotests Ubuntu 18.04 i386 part 6: Failed (click for details) Topotests Ubuntu 18.04 i386 part 6: No useful log found
Topotests Ubuntu 18.04 i386 part 1: Failed (click for details) Topotests Ubuntu 18.04 i386 part 1: No useful log found
Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 4: No useful log found
Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 0: No useful log found
Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests Ubuntu 18.04 amd64 part 5: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 5: No useful log found
Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 1: No useful log found
Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 7: No useful log found
Topotests debian 10 amd64 part 6: Failed (click for details) Topotests debian 10 amd64 part 6: No useful log found
Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 7: No useful log found
Fedora 29 rpm pkg check: Failed (click for details) Fedora 29 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2054/artifact/F29RPMCHECK/ErrorLog/log_package_start.txt Fedora 29 rpm pkg check: No useful log found
Topotests debian 10 amd64 part 0: Failed (click for details) Topotests debian 10 amd64 part 0: No useful log found
Topotests debian 10 amd64 part 5: Failed (click for details) Topotests debian 10 amd64 part 5: No useful log found
Topotests Ubuntu 18.04 arm8 part 2: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 2: No useful log found
Topotests Ubuntu 18.04 i386 part 7: Failed (click for details) Topotests Ubuntu 18.04 i386 part 7: No useful log found
Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 8: No useful log found
CentOS 7 rpm pkg check: Failed (click for details) CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2054/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log found
Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 3: No useful log found
Topotests Ubuntu 18.04 i386 part 2: Failed (click for details) Topotests Ubuntu 18.04 i386 part 2: No useful log found
Topotests debian 10 amd64 part 9: Failed (click for details) Topotests debian 10 amd64 part 9: No useful log found
Topotests Ubuntu 18.04 amd64 part 2: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 2: No useful log found
Topotests Ubuntu 18.04 i386 part 5: Failed (click for details) Topotests Ubuntu 18.04 i386 part 5: No useful log found
Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 1: No useful log found
Topotests debian 10 amd64 part 7: Failed (click for details) Topotests debian 10 amd64 part 7: No useful log found
Topotests Ubuntu 18.04 i386 part 0: Failed (click for details) Topotests Ubuntu 18.04 i386 part 0: No useful log found
Successful on other platforms/tests
  • Addresssanitizer topotests part 0
  • Debian 10 deb pkg check
  • IPv6 protocols on Ubuntu 18.04
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 20.04 deb pkg check
  • Addresssanitizer topotests part 1
  • IPv4 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 4
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 8
  • Addresssanitizer topotests part 7
  • Addresssanitizer topotests part 5
  • Static analyzer (clang)
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 16.04 deb pkg check
  • Addresssanitizer topotests part 2
  • Addresssanitizer topotests part 3
  • Addresssanitizer topotests part 9
  • Addresssanitizer topotests part 6

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 4, 2022 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2054/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 3: Failed (click for details) Topotests debian 10 amd64 part 3: No useful log found
Topotests debian 10 amd64 part 8: Failed (click for details) Topotests debian 10 amd64 part 8: No useful log found
Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 6: No useful log found
Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 4: No useful log found
Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 9: No useful log found
Topotests Ubuntu 18.04 i386 part 4: Failed (click for details) Topotests Ubuntu 18.04 i386 part 4: No useful log found
Topotests Ubuntu 18.04 i386 part 9: Failed (click for details) Topotests Ubuntu 18.04 i386 part 9: No useful log found
Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 9: No useful log found
Topotests Ubuntu 18.04 i386 part 8: Failed (click for details) Topotests Ubuntu 18.04 i386 part 8: No useful log found
Topotests Ubuntu 18.04 i386 part 3: Failed (click for details) Topotests Ubuntu 18.04 i386 part 3: No useful log found
Topotests Ubuntu 18.04 arm8 part 5: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 5: No useful log found
Topotests debian 10 amd64 part 4: Failed (click for details) Topotests debian 10 amd64 part 4: No useful log found
Topotests Ubuntu 18.04 arm8 part 3: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 3: No useful log found
Topotests debian 10 amd64 part 1: Failed (click for details) Topotests debian 10 amd64 part 1: No useful log found
Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 0: No useful log found
Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 8: No useful log found
Topotests debian 10 amd64 part 2: Failed (click for details) Topotests debian 10 amd64 part 2: No useful log found
Topotests Ubuntu 18.04 i386 part 6: Failed (click for details) Topotests Ubuntu 18.04 i386 part 6: No useful log found
Topotests Ubuntu 18.04 i386 part 1: Failed (click for details) Topotests Ubuntu 18.04 i386 part 1: No useful log found
Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 4: No useful log found
Topotests Ubuntu 18.04 amd64 part 5: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 5: No useful log found
Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 0: No useful log found
Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 1: No useful log found
Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 7: No useful log found
Topotests debian 10 amd64 part 6: Failed (click for details) Topotests debian 10 amd64 part 6: No useful log found
Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 7: No useful log found
Fedora 29 rpm pkg check: Failed (click for details) Fedora 29 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2054/artifact/F29RPMCHECK/ErrorLog/log_package_start.txt Fedora 29 rpm pkg check: No useful log found
Topotests debian 10 amd64 part 0: Failed (click for details) Topotests debian 10 amd64 part 0: No useful log found
Topotests debian 10 amd64 part 5: Failed (click for details) Topotests debian 10 amd64 part 5: No useful log found
Topotests Ubuntu 18.04 arm8 part 2: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 2: No useful log found
Topotests Ubuntu 18.04 i386 part 7: Failed (click for details) Topotests Ubuntu 18.04 i386 part 7: No useful log found
Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 8: No useful log found
CentOS 7 rpm pkg check: Failed (click for details) CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2054/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log found
Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 3: No useful log found
Topotests Ubuntu 18.04 i386 part 2: Failed (click for details) Topotests Ubuntu 18.04 i386 part 2: No useful log found
Topotests debian 10 amd64 part 9: Failed (click for details) Topotests debian 10 amd64 part 9: No useful log found
Topotests Ubuntu 18.04 amd64 part 2: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 2: No useful log found
Topotests Ubuntu 18.04 i386 part 5: Failed (click for details) Topotests Ubuntu 18.04 i386 part 5: No useful log found
Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 1: No useful log found
Topotests debian 10 amd64 part 7: Failed (click for details) Topotests debian 10 amd64 part 7: No useful log found
Topotests Ubuntu 18.04 i386 part 0: Failed (click for details) Topotests Ubuntu 18.04 i386 part 0: No useful log found
Successful on other platforms/tests
  • Addresssanitizer topotests part 0
  • Debian 10 deb pkg check
  • IPv6 protocols on Ubuntu 18.04
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 1
  • Ubuntu 20.04 deb pkg check
  • IPv4 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 4
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 8
  • Addresssanitizer topotests part 7
  • Addresssanitizer topotests part 5
  • Static analyzer (clang)
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 16.04 deb pkg check
  • Addresssanitizer topotests part 2
  • Addresssanitizer topotests part 3
  • Addresssanitizer topotests part 9
  • Addresssanitizer topotests part 6

@eqvinox
Copy link
Contributor

eqvinox commented Jan 4, 2022

@qlyoung can you rebase this to see if that fixes the tests?

@qlyoung
tools: improve explanation of 'wrap' options
90c745f 
We support 'wrap' variables in /etc/frr/daemons, but the explanation
given there doesn't touch on some of the subtleties of using these
variables.

The variables were designed for use with Valgrind, which has special
behavior when run with programs that daemonize; Valgrind will intercept
the fork()'d child process and run itself instead of the child. This
behavior allows it to follow the same forking semantics as the target
program.

For virtually every other wrapper, the wrap variables do not work as
demonstrated because the wrapper programs do not daemonize. If the
wrappers do not daemonize, they will block the init script. The examples
given with "perf" for example simply do not work, because perf remains
in the foreground even as it tracks forked children.

This patch adds an explanation of the behavior expected by the init
script and offers a solution for getting that behavior.

Signed-off-by: Quentin Young <qlyoung@nvidia.com>
@qlyoung
tools: improve explanation of watchfrr_options
7f17e42 
The explanation block for watchfrr_options was split into two blocks,
one explaining the --netns option and one making a vague statement that
the init script provides the list of daemons to start. The former can be
merged with the latter and the latter is more useful when stated as a
caveat for what you should actually use watchfrr_options for.

Signed-off-by: Quentin Young <qlyoung@nvidia.com>
@qlyoung
tools: clean up whitespace in daemons file
dcda225 
Bit easier to read this way.

Signed-off-by: Quentin Young <qlyoung@nvidia.com>
@qlyoung
tools: print daemon start cmd, vtysh_b cmd
5423bfa 
When starting a daemon, print the full command run by the init script to
start it. This gives more information and is especially helpful when
debugging wrap commands.

Also add some more logs to vtysh_b to print the command used there,
log when we exit early because frr.conf doesn't exist, and simplify the
code path for creating the command to use.

Signed-off-by: Quentin Young <qlyoung@nvidia.com>
@qlyoung
tools: apply various shellcheck recommendations
3809a04 
Signed-off-by: Quentin Young <qlyoung@nvidia.com>
@qlyoung
tools: document frr_global_options in daemons file
4794ede 
Signed-off-by: Quentin Young <qlyoung@nvidia.com>
@qlyoung qlyoung force-pushed the cleanup-daemons-file-wrap-explanation branch from df0c496 to 4794ede Compare January 28, 2022 20:01
@qlyoung
Copy link
Member Author

qlyoung commented Jan 28, 2022

@eqvinox rebased

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3059/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 2: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 2: No useful log found
Topotests Ubuntu 18.04 arm8 part 3: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 3: No useful log found
Topotests Ubuntu 18.04 i386 part 3: Failed (click for details) Topotests Ubuntu 18.04 i386 part 3: No useful log found
Topotests debian 10 amd64 part 4: Failed (click for details) Topotests debian 10 amd64 part 4: No useful log found
Topotests debian 10 amd64 part 3: Failed (click for details) Topotests debian 10 amd64 part 3: No useful log found
Topotests debian 10 amd64 part 8: Failed (click for details) Topotests debian 10 amd64 part 8: No useful log found
Topotests debian 10 amd64 part 9: Failed (click for details) Topotests debian 10 amd64 part 9: No useful log found
Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 4: No useful log found
Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 9: No useful log found
Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 3: No useful log found
Topotests debian 10 amd64 part 0: Failed (click for details) Topotests debian 10 amd64 part 0: No useful log found
Topotests Ubuntu 18.04 arm8 part 2: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 2: No useful log found
Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 7: No useful log found
Topotests Ubuntu 18.04 i386 part 6: Failed (click for details) Topotests Ubuntu 18.04 i386 part 6: No useful log found
Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 8: No useful log found
Topotests debian 10 amd64 part 2: Failed (click for details) Topotests debian 10 amd64 part 2: No useful log found
Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 0: No useful log found
Topotests Ubuntu 18.04 arm8 part 5: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 5: No useful log found
Topotests Ubuntu 18.04 i386 part 8: Failed (click for details) Topotests Ubuntu 18.04 i386 part 8: No useful log found
Topotests Ubuntu 18.04 i386 part 1: Failed (click for details) Topotests Ubuntu 18.04 i386 part 1: No useful log found
Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 9: No useful log found
Topotests Ubuntu 18.04 amd64 part 5: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 5: No useful log found
Fedora 29 rpm pkg check: Failed (click for details) Fedora 29 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3059/artifact/F29RPMCHECK/ErrorLog/log_package_start.txt Fedora 29 rpm pkg check: No useful log found
Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 7: No useful log found
Topotests debian 10 amd64 part 1: Failed (click for details) Topotests debian 10 amd64 part 1: No useful log found
Topotests Ubuntu 18.04 i386 part 5: Failed (click for details) Topotests Ubuntu 18.04 i386 part 5: No useful log found
Topotests Ubuntu 18.04 i386 part 0: Failed (click for details) Topotests Ubuntu 18.04 i386 part 0: No useful log found
CentOS 7 rpm pkg check: Failed (click for details) CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3059/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log found
Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 4: No useful log found
Topotests Ubuntu 18.04 i386 part 9: Failed (click for details) Topotests Ubuntu 18.04 i386 part 9: No useful log found
Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 0: No useful log found
Topotests debian 10 amd64 part 5: Failed (click for details) Topotests debian 10 amd64 part 5: No useful log found
Topotests Ubuntu 18.04 i386 part 4: Failed (click for details) Topotests Ubuntu 18.04 i386 part 4: No useful log found
Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 1: No useful log found
Topotests debian 10 amd64 part 7: Failed (click for details) Topotests debian 10 amd64 part 7: No useful log found
Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 6: No useful log found
Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 8: No useful log found
Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests Ubuntu 18.04 i386 part 2: Failed (click for details) Topotests Ubuntu 18.04 i386 part 2: No useful log found
Topotests debian 10 amd64 part 6: Failed (click for details) Topotests debian 10 amd64 part 6: No useful log found
Topotests Ubuntu 18.04 i386 part 7: Failed (click for details) Topotests Ubuntu 18.04 i386 part 7: No useful log found
Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 1: No useful log found
Successful on other platforms/tests
  • Addresssanitizer topotests part 5
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 0
  • IPv6 protocols on Ubuntu 18.04
  • Static analyzer (clang)
  • IPv4 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 9
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 16.04 deb pkg check
  • Addresssanitizer topotests part 7
  • Ubuntu 20.04 deb pkg check
  • Debian 10 deb pkg check
  • Addresssanitizer topotests part 3
  • Addresssanitizer topotests part 2
  • Addresssanitizer topotests part 1
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 8
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 6

@qlyoung
Copy link
Member Author

qlyoung commented Feb 2, 2022

@mwinter-osr any idea why this is failing CI? Perhaps CI is doing some file munging on /etc/frr/daemons that is now failing because of the changes to that file in this PR?

@donaldsharp
Copy link
Member

Pushed in via #11410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eqvinox eqvinox eqvinox approved these changes

@donaldsharp donaldsharp Awaiting requested review from donaldsharp

@idryzhov idryzhov Awaiting requested review from idryzhov

Assignees
No one assigned
Labels
tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qlyoung @NetDEF-CI @idryzhov @eqvinox @donaldsharp