build: assorted build system improvements, 2021-11 edition #10032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AC_PROG_LEX without either yywrap or noyywrap is obsolete`, says autoconf 2.70. Sadly, there is no transition window for this, in 2.69 the macro takes no arguments. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
`autoconf` finally arrived in the 2010s and tries to do ISO C11. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Purely aesthetic change to make these rules not stick out like a sore thumb. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
... to put related stuff next to each other. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
libtool, the radioactive dumpster fire of the GNU ecosystem. A module should not have a SONAME set. SONAMEs are for (versioned) libraries on search paths. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
It's not needed elsewhere & generates a bogus dependency. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
They're not needed elsewhere. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
These really serve no purpose other than slowing our build down. If there's a benefit to any of these, they can be readded. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
This comment has been minimized.
This comment has been minimized.
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1479/ This is a comment from an automated CI system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a bunch of random build system fixes, cleanups & improvements. Refer to individual commits for details please.