Skip to content

Commit

Permalink
Merge pull request #8440 from qlyoung/doc-describe-acceptable-commit-…
Browse files Browse the repository at this point in the history
…messages

doc: describe acceptable commit messages
  • Loading branch information
Jafaral authored Apr 11, 2021
2 parents 4c3e684 + 7bd4560 commit 8435eae
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions doc/developer/workflow.rst
Original file line number Diff line number Diff line change
Expand Up @@ -500,10 +500,22 @@ made. For example, a change in :file:`bgpd/rfapi` would be formatted as::
The first line should be no longer than 50 characters. Subsequent lines should
be wrapped to 72 characters.

The purpose of commit messages is to briefly summarize what the commit is
changing. Therefore, the extended summary portion should be in the form of an
English paragraph. Brief examples of program output are acceptable but if
present should be short (on the order of 10 lines) and clearly demonstrate what
has changed. The goal should be that someone with only passing familiarity with
the code in question can understand what is being changed.

Commit messages consisting entirely of program output are *unacceptable*. These
do not describe the behavior changed. For example, putting VTYSH output or the
result of test runs as the sole content of commit messages is unacceptable.

You must also sign off on your commit.

.. seealso:: :ref:`signing-off`


Source File Header
------------------

Expand Down

0 comments on commit 8435eae

Please sign in to comment.