Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete roles when deleting user #412

Merged
merged 1 commit into from
Jul 21, 2020
Merged

fix: delete roles when deleting user #412

merged 1 commit into from
Jul 21, 2020

Conversation

slowr
Copy link
Member

@slowr slowr commented Jul 20, 2020

Description of PR

This bug was raised by @pputerla in #410. We now delete the roles when also deleting the user to avoid issues with permissions when a user with same username is being re-registered after deletion.

What component(s) does this PR affect?

  • Back-End (Database, Detection/Configuration/etc. Microservices)
  • Front-End (Flask, API, UI, etc)
  • Monitor (RIPE RIS, BGPStream RV/RIS/CAIDA, etc.)
  • Docs (incl. wiki)
  • Build System

Does the PR require changes on other components? If yes, please mark the components:

  • Back-End (Database, Detection/Configuration/etc. Microservices)
  • Front-End (Flask, API, UI, etc)
  • Monitor (RIPE RIS, BGPStream RV/RIS/CAIDA, etc.)
  • Docs (incl. wiki)
  • Build System

Related Issue

Resolves #

Solution

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • None of the above

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.

@slowr slowr added bug Something isn't working frontend labels Jul 20, 2020
@slowr slowr added this to the release-.1.6.0 milestone Jul 20, 2020
@slowr slowr requested a review from vkotronis July 20, 2020 20:30
@slowr slowr self-assigned this Jul 20, 2020
@artemis-pr-bot
Copy link
Collaborator

🏃 Benchmark Results 🏃

  • RMQ Update inserts: 446/s
  • RMQ Hijack inserts: 146/s
  • PG Update inserts: 196/s
  • PG Update updates: 145/s
  • PG Hijack inserts: 145/s

@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #412 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #412   +/-   ##
=======================================
  Coverage   90.90%   90.90%           
=======================================
  Files           5        5           
  Lines        1859     1859           
=======================================
  Hits         1690     1690           
  Misses        169      169           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad51d4...aa209d1. Read the comment docs.

@slowr slowr merged commit e79c947 into master Jul 21, 2020
@slowr slowr deleted the roles-del-fix branch July 21, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants