Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various helm chart fixes and improvements #221

Merged
merged 5 commits into from
Sep 6, 2019

Conversation

alistairking
Copy link
Collaborator

Description of PR

Various fixes and improvements for the helm chart based on deployment in our Kubernetes environment.

Notable changes:

  • Prepend release name to Deployment names (to allow multiple releases)
  • Split PVC into one PVC per pod (since pods don't need to share data)
  • Move frontend user DB to a (new) PVC (to avoid data loss on pod restart)
  • Move postgres DB data to a PVC (to avoid data loss on pod restart)
  • Allow TLS to be disabled on ingress (our ingress does SSL-termination transparently)
  • Allow ingress annotations to be added (e.g., to add traefik annotations)
  • Fix bug in frontend ingress name (change backend to frontend)
  • Fix bug in ingress configuration: hosts parameter was ignored and host used instead.
  • Support extra configuration options for PVCs (to avoid having to modify PVC template directly)

What component(s) does this PR affect?

  • Helm Chart

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • None of the above

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.

@vkotronis
Copy link
Member

@alistairking https://semaphoreci.com/slowr/artemis/branches/pull-request-221/builds/1
could you check again the format?

Fix End of Files.........................................................Failed
hookid: end-of-file-fixer

Files were modified by this hook. Additional output:

Fixing artemis-chart/templates/pvc.yaml
Fixing artemis-chart/templates/secrets.yaml

Check the contributing guide and the pre-commit instructions ("Common guidelines").
Pre-commit will fix locally any issues when you commit, and then you need to add its changes and commit again until the checks pass successfully.

@slowr could you check the PR since you have more experience than me on k8? I will also try to install it locally on my laptop.

@vkotronis vkotronis added this to the release-1.3.0 milestone Sep 4, 2019
Copy link
Member

@slowr slowr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's fix the pre-commit hook warnings and go through CI before merging.

@alistairking alistairking removed their assignment Sep 5, 2019
@slowr slowr merged commit 355966c into FORTH-ICS-INSPIRE:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants