-
Notifications
You must be signed in to change notification settings - Fork 34
Added control of docker networks of containers #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Tested with 2 networks
|
I haven't ran the tests locally - I imagine they will need some fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically I would say it is courtesy to run the tests before opening a PR, but in this case I can sympathize with how pman's codebase is somewhat finicky and doing so might be inconvenient.
- It seems like supporting multiple Docker networks will be a non-trivial change to the code. Maybe we should support only a single Docker network instead. At startup, if
len(DOCKER_NETWORKS) > 1
, raise a configuration error. - Assuming you accept my proposal to limit our scope to supporting only 0–1 Docker networks, I would say just delete the whole
test_dockermgr.py
file.
Appreciate the suggestions @jennydaman I hope you can appreciate that without a I will work on your suggestions in time. Happy to go with the single network route for now and remove tests altogether. |
@Sharpz7 100% agree. (If i had the authority to enforce standards and |
I apologize for my editor automatically applying formatting to the file - let me know if you would like that undone. |
No description provided.