Open
Conversation
ericvaandering
requested changes
Jul 9, 2025
Collaborator
ericvaandering
left a comment
ericvaandering
left a comment
There was a problem hiding this comment.
And squash this next commit in with the previous two (so after your merge of main into your code).
|
|
||
| def produce_prom_metric(metric_name, metric_value, list_input, labels): | ||
| # loop over labels to get key,value pairs | ||
| # print(len(labels)) |
Collaborator
There was a problem hiding this comment.
Let's get rid of all these old print statements.
| print('}', end='') | ||
| print(f' {metric_value}') | ||
| extract_labels = ['vo', 'tapepool', 'vid', 'status'] | ||
|
|
Collaborator
There was a problem hiding this comment.
remove one of the blank lines
Collaborator
There was a problem hiding this comment.
Or all of them. You decide the style, but multiple blank lines is reserved for separating one function/class from another.
|
|
||
| cta_admin_output_json = json.loads(cta_admin_output) | ||
|
|
||
|
|
danijelaconc
force-pushed
the
common_function
branch
from
9707357 to
d58b2cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a common.py file with function that is common to all files. Removing shell=True from files. Adding quotations. All code was run and is working.