Changed the names checking if they worked so full committing#24
Open
scarletnorberg wants to merge 2 commits intoFNAL-CTA:mainfrom
Open
Changed the names checking if they worked so full committing#24scarletnorberg wants to merge 2 commits intoFNAL-CTA:mainfrom
scarletnorberg wants to merge 2 commits intoFNAL-CTA:mainfrom
Conversation
ericvaandering
requested changes
Mar 1, 2024
Collaborator
ericvaandering
left a comment
ericvaandering
left a comment
There was a problem hiding this comment.
Some changes to comments. Lastly, open an issue on yourself somewhere (maybe the sprint) to refactor both cta_admin scripts to remove produce_prom_metric and move it to a shared location.
| def produce_prom_metric(metric_name, metric_value, list_input, labels): | ||
| def produce_prom_metric(metric_name, metric_value, metric_input, labels): | ||
| # loop over labels to get key,value pairs | ||
| # print(len(labels)) |
Collaborator
There was a problem hiding this comment.
Put a comment in the triple-double quotes at the beginning describing what this function does. It's called a docstring.
Then remove all the commented out code like print statements.
The comment # loop over labels... ... Generally you only want to describe code which is doing something not obvious from reading the code. So I leave it to you if you want to include it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.