Skip to content

Update 07example.md to not have presence in the type definitions #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hassila
Copy link

@hassila hassila commented Apr 22, 2021

I removed the presence field in the type definitions as they were removed for 2.0 to be field-only (which was a great change).

I removed the presence field in the type definitions as they were removed for 2.0 to be field-only (which was a great change).
@hassila
Copy link
Author

hassila commented Jan 17, 2022

Hello? @kleihan or someone else?

@kleihan
Copy link
Member

kleihan commented Jan 18, 2022

@hassila sorry for dropping the ball on this, We will review and merge. There has been very little activity on SBE v2.0 RC3 since quite a while.

@hassila
Copy link
Author

hassila commented Jan 18, 2022

Thanks @kleihan - saw your commits for ISO preparation and thought it worthwhile to ping.

@kleihan
Copy link
Member

kleihan commented Jan 18, 2022

Thanks @kleihan - saw your commits for ISO preparation and thought it worthwhile to ping.

Note that the ISO submission will be SBE v1.0. Don has separated examples for proper validation into https://github.com/FIXTradingCommunity/fix-sbe-examples and these need to be reconciled into the spec.

Copy link
Member

@donmendelson donmendelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples pass XML validation in XMLSpy. Presence attribute is indeed allowed on type that is a member of a composite. In the XSD, see XML type memberDataType, described as "A simple type used as a member of a composite type". It has attribute group presenceAttributes. The main use in composites is to set members as constant so they need not be transmitted on the wire.

@hassila
Copy link
Author

hassila commented Jan 18, 2022

@donmendelson thanks for clarification - I can see the issue for composites (although there’s some dissonance, as a systematic consistent approach would perhaps be to allow one to specify presence attributes for the subfields of the composite when declaring a composite field. Defining it on the type really just becomes a mechanism for defining constant as you say). Anyway, guess we can close this as such re-engineering is probably not worthwhile for what is a fringe case really. Thanks for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants