Skip to content

Use qualified elements in schema #117 #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexeq
Copy link
Contributor

@alexeq alexeq commented Apr 28, 2020

Patch request for issue #117:

  • make elementFormDefault="qualified"
  • make 'messageSchema', 'types', and 'messages' top elements (to allow partial included XML's validation)
  • move 'message' inside 'messages' (to disallow it to be top-element in XML)
  • fix XML sample (namespaces, remove redundant attributes)

@donmendelson
Copy link
Member

@alexeq, thank you for contribution. SBE v2.0 Release Candidate 2 has already been published for public review. If this change is accepted, it will become part of v2.0 RC3. Please rename the folder and XSD file accordingly.

- make elementFormDefault="qualified"
- make 'messageSchema', 'types', and 'messages' top elements (to allow partial included XML's validation)
- move 'message' inside 'messages' (to disallow it to be top-element in XML)
- fix XML sample (namespaces, remove redundant attributes)
- fix type (XIinclude -> XInclude)
@alexeq alexeq force-pushed the use-qualified-elements branch from f27da58 to 05e01dd Compare April 29, 2020 00:24
@alexeq
Copy link
Contributor Author

alexeq commented Apr 29, 2020

Done (used force push), thanks for the RC3 template.

@donmendelson
Copy link
Member

I will recommend that this change be adopted as part of version 2.0 RC3 at the next meeting of High Performance Working Group on May 13.

@donmendelson donmendelson merged commit 40f2f26 into FIXTradingCommunity:master May 13, 2020
@alexeq alexeq deleted the use-qualified-elements branch June 7, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants