Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repository schema] Field type attribute does not distinguish between datatype and code set reference #170

Closed
donmendelson opened this issue Sep 22, 2022 · 2 comments

Comments

@donmendelson
Copy link
Member

Comment by Emil Rakadjiev in Orchestra working group collaboration:

...based on our experience with developing tooling around Orchestra, it's awkward to handle in the code. It has also been a source of confusion within our development team several times. Which I think is a sign for a "code smell".
Using a more explicit reference - mostly for the code set's scenario, but ideally also for whether it's a datatype or a code set - would be helpful in my opinion.

donmendelson added a commit to donmendelson/fix-orchestra that referenced this issue Sep 22, 2022
… datatype and code set reference FIXTradingCommunity#170

Note: Sample file does not pass validation due to schema changes.
@kleihan
Copy link
Member

kleihan commented Sep 23, 2022

Cleaner modelling to distinguish types from code sets explicitly. Conversion from v1.0 should be straightforward, changing type="xxxCodeSet" to codeSet="xxxCodeSet". Find instances with regular expression type=".*CodeSet"

donmendelson added a commit that referenced this issue Oct 19, 2022
[repository schema] Field type attribute does not distinguish between datatype and code set reference #170
@donmendelson donmendelson added this to the Orchestra v1.1RC1 milestone Oct 19, 2022
@kleihan
Copy link
Member

kleihan commented Jun 3, 2024

Implemented in RC1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants