add recover addr from sig api #903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyonRay
reviewed
Mar 13, 2024
src/main/java/org/fisco/bcos/sdk/v3/crypto/signature/Signature.java
Outdated
Show resolved
Hide resolved
src/main/java/org/fisco/bcos/sdk/v3/crypto/signature/Signature.java
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return getPubFromSig(Hex.toHexString(msgHash), signature); | ||
| } | ||
|
|
||
| public static String getPubFromSignature(String msgHash, SignatureResult signature) { |
Check notice
Code scanning / CodeQL
Useless parameter
| return getPubFromSig(Hex.toHexString(msgHash), signature); | ||
| } | ||
|
|
||
| public static String getPubFromSignature(String msgHash, SignatureResult signature) { |
Check notice
Code scanning / CodeQL
Useless parameter
src/main/java/org/fisco/bcos/sdk/v3/crypto/signature/HsmSM2Signature.java
Fixed
Show fixed
Hide fixed
kyonRay
approved these changes
Mar 13, 2024
Mojicode
force-pushed
the
feature/recAddrFromSig
branch
from
68ea122 to
98772ef
Compare
|
| return recoverAddress(Hex.toHexString(msgHash), signature); | ||
| } | ||
|
|
||
| public static String ecrecoverSignature(String msgHash, SignatureResult signature) { |
Check notice
Code scanning / CodeQL
Useless parameter
| return recoverAddress(Hex.toHexString(msgHash), signature); | ||
| } | ||
|
|
||
| public static String ecrecoverSignature(String msgHash, SignatureResult signature) { |
Check notice
Code scanning / CodeQL
Useless parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.