Skip to content

<fix>(transaction): fix assemble event decode error, fix event codec bug, upgrade jni and sdk version. #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2023
Merged

<fix>(transaction): fix assemble event decode error, fix event codec bug, upgrade jni and sdk version. #763

merged 1 commit into from
Apr 19, 2023

Conversation

kyonRay
Copy link
Member

@kyonRay kyonRay commented Apr 18, 2023

No description provided.

@kyonRay kyonRay force-pushed the master branch 4 times, most recently from aa2d86e to 994da2e Compare April 18, 2023 16:02
@codecov
Copy link

codecov bot commented Apr 18, 2023 •
edited
Loading

Codecov Report

Patch coverage: 9.37% and project coverage change: -0.11 ⚠️

Comparison is base (62d0e00) 30.28% compared to head (ea43f77) 30.17%.

❗ Current head ea43f77 differs from pull request most recent head 87a299e. Consider uploading reports for the commit 87a299e to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #763      +/-   ##
============================================
- Coverage     30.28%   30.17%   -0.11%     
- Complexity     1494     1495       +1     
============================================
  Files           385      385              
  Lines         14516    14573      +57     
  Branches       1649     1664      +15     
============================================
+ Hits           4396     4398       +2     
- Misses         9710     9758      +48     
- Partials        410      417       +7
Impacted Files Coverage Δ
...action/codec/decode/TransactionDecoderService.java 14.00% <0.00%> (-0.90%) ⬇️
...c/main/java/org/fisco/bcos/sdk/v3/codec/Utils.java 34.97% <9.80%> (-12.00%) ⬇️
...java/org/fisco/bcos/sdk/v3/codec/EventEncoder.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kyonRay kyonRay changed the title <fix>(transaction): fix assemble event decode error. <fix>(transaction): fix assemble event decode error, fix event codec bug, upgrade jni and sdk version. Apr 19, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 19, 2023
View reviewed changes
src/main/java/org/fisco/bcos/sdk/v3/codec/Utils.java
Comment on lines +77 to +79
Integer.parseInt(
cls.getSimpleName()
.substring(StaticArray.class.getSimpleName().length()));

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException

Potential uncaught 'java.lang.NumberFormatException'.
@kyonRay kyonRay merged commit cd77661 into FISCO-BCOS:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JimmyShi22 JimmyShi22 JimmyShi22 approved these changes

@ywy2090 ywy2090 ywy2090 approved these changes

@bxq2011hust bxq2011hust bxq2011hust approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kyonRay @JimmyShi22 @ywy2090 @bxq2011hust