Skip to content

<fix>(codec): fix codec exception not catch error. #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023
Merged

<fix>(codec): fix codec exception not catch error. #753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/ci_check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ build_node()
if [ "${node_type}" == "wasm" ];then
bash build_chain.sh -l 127.0.0.1:4 -e ./fisco-bcos -w "${2}"
else
bash build_chain.sh -l 127.0.0.1:4 -e ./fisco-bcos "${2}"
bash build_chain.sh -l 127.0.0.1:4 -A -e ./fisco-bcos "${2}"
fi
./nodes/127.0.0.1/fisco-bcos -v
cat nodes/127.0.0.1/node0/config.genesis
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-18.04, ubuntu-20.04, ubuntu-22.04, windows-2019, macos-12]
os: [ubuntu-20.04, ubuntu-22.04, windows-2019, macos-12]
steps:
- uses: actions/checkout@v2
with:
Expand Down
6 changes: 5 additions & 1 deletion src/integration-test/java/org/fisco/bcos/sdk/v3/test/precompiled/PrecompiledTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,14 @@ public void test1ConsensusService() throws ConfigException, ContractException, J
}

@Test
public void test3SystemConfigService() throws ConfigException, ContractException, JniException {
public void test3SystemConfigService() throws ConfigException, ContractException {
ConfigOption configOption = Config.load(configFile);
Client client = Client.build(GROUP, configOption);

if (client.isAuthCheck()) {
return;
}

CryptoKeyPair cryptoKeyPair = client.getCryptoSuite().getCryptoKeyPair();
SystemConfigService systemConfigService = new SystemConfigService(client, cryptoKeyPair);
this.testSystemConfigService(client, systemConfigService, "tx_count_limit");
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/org/fisco/bcos/sdk/v3/codec/ContractCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ public byte[] encodeMethodFromString(String abi, String methodName, List<String>
outputStream.write(methodId);
outputStream.write(encode);
return outputStream.toByteArray();
} catch (IOException e) {
} catch (Exception e) {
logger.error(" exception in encodeMethodFromString : {}", e.getMessage());
}
}
Expand Down Expand Up @@ -523,7 +523,7 @@ public byte[] encodeMethodByIdFromString(String abi, byte[] methodId, List<Strin
}
outputStream.write(encode);
return outputStream.toByteArray();
} catch (IOException e) {
} catch (Exception e) {
logger.error(" exception in encodeMethodByIdFromString : {}", e.getMessage());
}

Expand All @@ -546,7 +546,7 @@ public byte[] encodeMethodByInterfaceFromString(String methodInterface, List<Str
ContractCodecTools.encode(
contractCodecJsonWrapper.encode(inputABIObject, params), isWasm));
return outputStream.toByteArray();
} catch (IOException e) {
} catch (Exception e) {
logger.error(
" exception in encodeMethodByInterfaceFromString : {}", e.getMessage());
}
Expand Down