Skip to content

Conversation

ywy2090
Copy link
Collaborator

@ywy2090 ywy2090 commented Dec 26, 2022

No description provided.

@ghost
Copy link

ghost commented Dec 26, 2022

Sider has detected 4 warnings on analyzing the commit d954d52.

If the errors persist even after retrying, the following actions may resolve them:

If you still have problems, feel free to ask us via chat. 💬


You can turn off such notifications if unnecessary.

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Base: 32.12% // Head: 32.10% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (a3cdf4b) compared to base (6538e00).
Patch coverage: 20.00% of modified lines in pull request are covered.

❗ Current head a3cdf4b differs from pull request most recent head d954d52. Consider uploading reports for the commit d954d52 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##             release-3.1.2     #710      +/-   ##
===================================================
- Coverage            32.12%   32.10%   -0.02%     
- Complexity            1447     1449       +2     
===================================================
  Files                  375      375              
  Lines                13163    13185      +22     
  Branches              1497     1501       +4     
===================================================
+ Hits                  4228     4233       +5     
- Misses                8565     8579      +14     
- Partials               370      373       +3     
Impacted Files Coverage Δ
...main/java/org/fisco/bcos/sdk/v3/client/Client.java 0.00% <ø> (ø)
.../java/org/fisco/bcos/sdk/v3/client/ClientImpl.java 0.00% <0.00%> (ø)
...rg/fisco/bcos/sdk/v3/model/TransactionReceipt.java 35.92% <0.00%> (-1.46%) ⬇️
...k/v3/transaction/manager/TransactionProcessor.java 42.85% <15.38%> (-3.42%) ⬇️
...client/protocol/model/JsonTransactionResponse.java 64.86% <75.00%> (+0.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Override
protected void finalize() {
try {
super.finalize();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [Object.finalize](1) should be avoided because it has been deprecated.
@ywy2090 ywy2090 merged commit 69ba93e into FISCO-BCOS:release-3.1.2 Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant