Revise ruby valid logic to one line #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav1a1223
force-pushed
the
revise-ruby-logic-order
branch
from
361840d
to
63aa265
Compare
JulienBreux
suggested changes
Oct 5, 2016
| return false unless valid_email?(email) | ||
|
|
||
| !blacklisted?(email) | ||
| return valid_email?(email) && !blacklisted?(email) |
There was a problem hiding this comment.
valid_email?(email) && !blacklisted?(email)| return false if email.nil? | ||
|
|
||
| email =~ EMAIL_REGEX | ||
| return !email.nil? && !!(email =~ EMAIL_REGEX) |
There was a problem hiding this comment.
!email.nil? && !!(email =~ EMAIL_REGEX)| return false unless valid_email?(email) | ||
|
|
||
| !blacklisted?(email) | ||
| return valid_email?(email) && !blacklisted?(email) |
There was a problem hiding this comment.
valid_email?(email) && !blacklisted?(email)| return false if email.nil? | ||
|
|
||
| email =~ EMAIL_REGEX | ||
| return !email.nil? && !!(email =~ EMAIL_REGEX) |
There was a problem hiding this comment.
!email.nil? && !!(email =~ EMAIL_REGEX)
|
Hello @dav1a1223, as @JulienBreux said, just remove the return and I will accept this PR :) |
dav1a1223
force-pushed
the
revise-ruby-logic-order
branch
from
63aa265
to
ef62e81
Compare
|
OK, it's done. @FGRibreau @JulienBreux thanks a lot !! |
|
@dav1a1223 nice work, released in v3.0.16 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @FGRibreau ,
When I use this handy gem and read the source code,
I found the logic of
valid?andvalid_email?a little complex.So I took a look at
.pyand revise the logic to one line.Hoping that make it easier to understand :)
I'm a beginner to contribute open source, please give me your advice. :)
Thx a lot!!