Use class methods in PHP/Python; update README #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use class methods to avoid having to instantiate a class for PHP/Python. - Update README with latest running instructions.
|
Oh my! I did not see that there was a breaking change! is_valid was not there before and is not compatible with javascript camelCase standard |
|
v2.0.0 released |
FGRibreau
added a commit
that referenced
this pull request
Mar 19, 2016
…-readme Use class methods in PHP/Python; update README
|
Good point about the Javascript function name, I imagine I got slightly confused with all the different languages and styles - should I submit another PR to change it to camel case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP/Python.