Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go implementation #199

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Add go implementation #199

merged 2 commits into from
Oct 16, 2019

Conversation

F21
Copy link
Contributor

@F21 F21 commented Oct 2, 2019

As mentioned in #198, this adds the Go implementation. However, it does not work properly at the moment because the definitions in mail_checker.tmpl.go and the generated mail_checker.go conflicts with each other.

@F21 F21 mentioned this pull request Oct 11, 2019
@F21
Copy link
Contributor Author

F21 commented Oct 14, 2019

@FGRibreau I've now updated this pr with 2 commits:

  • The first commit changes generator.js to allow for the case where there is an underscore in the file extension.
  • The second commit adds the Go implementation.

This is to support cases such as Go where the compiler looks for all .go
files in the directory and reports functions and variables as redeclared
because they exist in both the template and generated file.
@FGRibreau FGRibreau merged commit 3958bdb into FGRibreau:master Oct 16, 2019
@FGRibreau
Copy link
Owner

Released in v3.3.0 🎉

@F21 F21 deleted the go branch October 16, 2019 20:55
@F21
Copy link
Contributor Author

F21 commented Oct 16, 2019

🎆 Thanks, @FGRibreau !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants