#169 Plain domain file with conversion to JSON #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGRibreau
requested changes
Mar 26, 2019
|
Released in v3.2.26 🎉 (for future reference: it's neither a new feature nor a breaking since list.json was never described to be publicly accessible). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, this is it. I am sorry for the code — my JavaScript and Node.js are terrible and are not going to be better. If you decide to throw it away — so be it.
I haven't changed the 'generation' step. Instead I have added 'conversion' step, which takes plain text file as input and converts it to list.json, which is then used by 'generation' step.