Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quadrature permutations for DG and some negating of vector-valued spaces #770

Merged
merged 204 commits into from
Feb 19, 2020
Merged

Quadrature permutations for DG and some negating of vector-valued spaces #770

merged 204 commits into from
Feb 19, 2020

Conversation

mscroggs
Copy link
Member

@mscroggs mscroggs commented Feb 14, 2020 •
edited
Loading

  • Pass facet rotation and reflection data into FFCx so that FFCx can use these to calculate quadrature permutations and vector direction swaps
  • Moved dof permutations into FFC, as these will likely eventually be calculated using data directly from FIAT.
  • The numbers of times each permutation should be applied to each cell is now stored in Topology.
  • High order vector-valued spaces are not yet supported on unordered meshes, and the meshes for these are currently ordered in the pipeline tests.

This pull request resolves #728 and resolves #645 and includes #634.

This is an updated version of #702, and is twinned with FEniCS/ffcx#201.

@mscroggs
Added test to check that FacetNormals are correct
e610cdb
@mscroggs
Remove extra space in comment
5ac75df
@mscroggs
Added np.real so the test runs in complex mode
467d8f7
@mscroggs
Replaced hacky grad test with VectorFunctionSpace test
45ad50c
@mscroggs
reactivate hex test
5a1f245
@mscroggs
Test for the value of the integral on each facet, not just that the t…
9d73411 
…otal is positive
@mscroggs
Added test to check that jumps are correct
a6db020
@mscroggs
Added DG pipeline test
bd29b7c
@mscroggs
Merge branch 'master' into mscroggs/dof_ordering_vectors
a2a2708
@mscroggs
Added test of average
acf28ac
@mscroggs
Test grads on DG spaces
f0d9d6c
@mscroggs
Edited tests to find the DG issue
320d33d
@mscroggs
Merge branch 'master' into mscroggs/dof_ordering_vectors
23732dd
@mscroggs
added test of f("+") and f("-")
dfb13d8
@mscroggs
flake8
96c3226
@mscroggs
simpler test
409d215
@mscroggs
Merge branch 'master' into mscroggs/dof_ordering_vectors
8e8e1e0
@mscroggs
Pass a permutation into tabulate_tensor
d9988ff
@mscroggs
Added docstring
de05c42
@mscroggs
Added quadrature permutation to matrix and vector assemblers
2665146
@mscroggs
Added permutation input for tabulate_tensor to test
15b9bf3
@mscroggs
rename branch
3d8e244
@mscroggs
Added FacetNormal direction test
1a2c0e4
@mscroggs
Added test that integral over facet is positive
bf7ea51
@mscroggs
Added integration test
a83b383
@mscroggs
Merge branch 'mscroggs/dof_ordering_vectors' into mscroggs/dof_orderi…
2123ca5 
…ng_dg
@mscroggs
Added integral test for triangles
1c7c571
@mscroggs
Added quad test
3f7b9d9
@mscroggs
Working on Matrix assembly
ce13eb2
@mscroggs
Merge branch 'master' into mscroggs/dof_ordering_dg
a5672f3
@mscroggs mscroggs mentioned this pull request Feb 14, 2020
Merged
@mscroggs
Copy link
Member Author

I believe the test currently failing will pass once #791 is merged

@mscroggs mscroggs linked an issue Feb 19, 2020 that may be closed by this pull request
Permuting the dofs of DG spaces #645
Closed
@garth-wells garth-wells merged commit 0b9ab98 into master Feb 19, 2020
@garth-wells garth-wells deleted the mscroggs/move_base_perms_to_ffc branch February 19, 2020 17:01
@mscroggs mscroggs mentioned this pull request Feb 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalhabera michalhabera michalhabera left review comments

@garth-wells garth-wells Awaiting requested review from garth-wells

@chrisrichardson chrisrichardson Awaiting requested review from chrisrichardson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in dof permutations Permuting the dofs of DG spaces
3 participants
@mscroggs @michalhabera @garth-wells