-
-
Notifications
You must be signed in to change notification settings - Fork 44
Expose gauss jacobi quadrature with alpha parameter #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| for (std::size_t i = 0; i < wts.size(); ++i) | ||
| { | ||
| pts[i] += 1.0; | ||
| pts[i] /= 2.0; | ||
| wts[i] *= 0.5; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samuel0007 I've added this scaling so that the rule matches the [0,1] interval used everywhere else. Is this compatible with what you needed this for?
|
For my application, I only need an exposed alpha and defined on [0,1] 👍 But I think from what I understand, one should have (for general alpha and beta) - as the weight function impacts when you pullback the integral: Which also match this small example I found online https://www.math.umd.edu/~petersd/460/html/gaussjacobi_ex.html Also maybe you might also want to use this rescaled function in the |
cpp/basix/quadrature.cpp
Outdated
| template std::vector<float> quadrature::get_gll_points(int); | ||
| template std::vector<double> quadrature::get_gll_points(int); | ||
|
|
||
| /// @cond DOXYGEN_SHOULD_SKIP_THIS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should go around all the explicit instantiations, e.g. if you look at get_gll_points in the generated docs, you will only see double at the moment, not T, because that was the last thing doxygen saw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess there may be other explicit instantiations in other files... worth checking (maybe not in this PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened #929 to remind me to do this
Co-authored-by: Chris Richardson <chris@bpi.cam.ac.uk>
Co-authored-by: Chris Richardson <chris@bpi.cam.ac.uk>
Co-authored-by: Chris Richardson <chris@bpi.cam.ac.uk>
…x into mscroggs/expose-gauss-jacobi
Resolves #922