Conversation
mscroggs
approved these changes
Apr 25, 2025
Member
|
Failing CI should pass again once FEniCS/dolfinx#3715 is merged |
mscroggs
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
clang-tidysupport for thecpp/build on theperformance*clang-tidy checks to showcase its capabilities.If accepted, this can be equivalently incorporated into the
python/build.The checks (configured in the
.clang-tidy) can be further extended or fine tuned, most interesting (besides the activatedperformance*) are probablymodernize*,cppcoreguidelines*and/orbugprone*for the FEniCS project - see https://clang.llvm.org/extra/clang-tidy/checks/list.html