Merged
Conversation
Member
|
What's the status of this? |
Member
|
I'm not wild about bringing DOLFINx into this. I'd favour defaulting to |
Member
I agree with Garth |
Member
Author
Needs a bit of work before it's ready. Should have time to do this work in the next couple of weeks |
…x into mscroggs/default_scalar_type
Member
Author
It was less work to fix that I thought it might be. Ready for review now |
garth-wells
reviewed
Apr 17, 2024
…x into mscroggs/default_scalar_type
garth-wells
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will allow us to do FEniCS/dolfinx#3136