Change to the Modified Gram Schmidt algorithm in orthogonalise (#679)#785
Merged
mscroggs merged 1 commit intoFEniCS:mainfrom Feb 9, 2024
Merged
Change to the Modified Gram Schmidt algorithm in orthogonalise (#679)#785mscroggs merged 1 commit intoFEniCS:mainfrom
mscroggs merged 1 commit intoFEniCS:mainfrom
Conversation
Member
|
Looks good; please run |
ampdes
force-pushed
the
update-orthogonalise-mgs
branch
from
c49b1be to
04eb676
Compare
…S#679) * change the orthogonalization algorithm to modified gram schmidt * norm is precomputed * first check row rank before orthogonalizing the rows
ampdes
force-pushed
the
update-orthogonalise-mgs
branch
from
04eb676 to
e6d92f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change the orthogonalization algorithm to modified gram schmidt
norm is precomputed
first check row rank before orthogonalizing the rows