Use visibility("default") attribute for libc overrides#1
Merged
Sonicadvance1 merged 1 commit intoFEX-Emu:masterfrom Dec 13, 2021
Merged
Use visibility("default") attribute for libc overrides#1Sonicadvance1 merged 1 commit intoFEX-Emu:masterfrom
Sonicadvance1 merged 1 commit intoFEX-Emu:masterfrom
Conversation
When building with -fvisibility=hidden, this must be added for the linker to properly consider the overridden symbols.
neobrain
force-pushed
the
fix_jemalloc_overrides
branch
from
43f4ab4 to
9c3fd4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents the linker from failing to override host libc functions. I'm guessing
attribute((used))is purely a compiler directive, whereas the linker only considers visibility (which is set tohiddenby default in our build configuration).Upstream jemalloc still uses
attribute((used)), and so did old versions of tcmalloc. However, recent versions of tcmalloc and mimalloc both adjust the visibility, so this seems like a reasonable way to follow.