Skip to content

Upgrade to Angular-v19 #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Upgrade to Angular-v19 #338

wants to merge 3 commits into from

Conversation

markizano
Copy link

Minimal updates here to support Angular 19.

markizano added 3 commits May 5, 2025 19:27
Kept components as not standalone to preserve as much legacy functionality.
In the latest rxjs updates, a value is required for next() calls.
This needs review as I (@markizano) am not 100% certain of the desired behaviour here.
@lenny-drillingllc
Copy link

Commenting to ping @FERNman and hopefully get this merged.

@FERNman
Copy link
Owner

FERNman commented Jun 3, 2025

Thanks for the ping @lenny-drillingllc, I'd have missed it otherwise. @markizano thanks for the PR! I assume the issue is that RxJS next no longer works without a parameter in projects using Angular 19? I'm not yet sure about merging this, as it's only compatible with Angular 19. Perhaps we can make the necessary changes to also support Angular 20 (#333) in one go.

@markizano
Copy link
Author

Thanks much @FERNman! That's correct, I noticed it throws an exception because now RxJS requires input to next() in order to provide some kind of value, even if null.

Angular-20 came out quick! Now I gotta upgrade my projects too! 😱

Thanks again!

@FERNman
Copy link
Owner

FERNman commented Jun 9, 2025

Hey @markizano and @lenny-drillingllc, I've just released a new version of this library that supports Angular up to version 20, including standalone components. Can you verify this works for you? If you're still having trouble, please let me know! As mentioned earlier, I'm not entirely sure about merging this PR as it is, since it drops support for Angular 16-18 (by upgrading the dependencies to v19). However, as I'm already on it, it might release a new version utilizing all the latest Angular features, including signals, new control flow syntax, and full SSR + standalone support.

@lenny-drillingllc
Copy link

@FERNman built for me in a v20 app. Nice work and thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants