Skip to content

feat: item.disabled 可以是个函数 & updateForm 可以存储冗余字段 #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 11, 2021

Conversation

levy9527
Copy link
Contributor

@levy9527 levy9527 commented Aug 11, 2021

Why

为了更方便!
且在 el-data-table 中,新增与编辑的表现是不一样的,需要能在 disabled 中拿到表单值。

How

兼容原来的写法

Test

unit pass

e2e pass
image

Docs

已更新

@auto-add-label auto-add-label bot added the enhancement New feature or request label Aug 11, 2021
@netlify
Copy link

netlify bot commented Aug 11, 2021

✔️ Deploy Preview for el-form-renderer ready!

🔨 Explore the source changes: 7195583

🔍 Inspect the deploy log: https://app.netlify.com/sites/el-form-renderer/deploys/61139c6d53e47c0007567a05

😎 Browse the preview: https://deploy-preview-217--el-form-renderer.netlify.app/

@2nthony
Copy link
Member

2nthony commented Aug 11, 2021

  • 被禁用的项目应该不需要校验
  • 被禁用的项目的值提交时是否保留。回复:要保留

人为操作过

image

@levy9527
Copy link
Contributor Author

  • 被禁用的项目应该不需要校验
  • 被禁用的项目的值提交时是否保留。回复:要保留

人为操作过

image

第一个问题,另一个 pr 再修改吧。而且似乎要改 el-form

@levy9527 levy9527 changed the title feat: item.disabled 可以是个函数 feat: item.disabled 可以是个函数 & updateForm 可以存储冗余字段 Aug 11, 2021
@levy9527 levy9527 merged commit 567d056 into dev Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants