feat: 扩展通过 name/prop 来设置 id 的写法 #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for el-form-renderer ready! 🔨 Explore the source changes: 4eb486e 🔍 Inspect the deploy log: https://app.netlify.com/sites/el-form-renderer/deploys/610ce7b40281a6000931d5c5 😎 Browse the preview: https://deploy-preview-216--el-form-renderer.netlify.app/ |
2nthony
approved these changes
Aug 6, 2021
yolofit
reviewed
Aug 6, 2021
| function setItemId(item) { | ||
| if (item.id) return | ||
| // name 是符合表单项直觉的命名； prop 是为了与 element 的 table 的 columns 匹配 | ||
| item.id = item.name || item.prop |
There was a problem hiding this comment.
这里取值优先级建议对调一下，优先prop > name, 避免用户已设置content item name，导致出错
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
为了符合直觉！为了效率！
Test
yes，unit test。
Docs
no