Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extras integration testing #233

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

mohsinkazmi
Copy link
Contributor

Add support for extras integration test
Fix the icmp responder polling example

Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
This patch adds extras integration testing support.
It tests the gomemif integration for poll mode and
interrupt mode.

Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Copy link
Contributor

@sknat sknat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just probably need to rebase this on top of #232

@sknat
Copy link
Contributor

sknat commented Sep 12, 2024

Thanks @ondrej-fabry for the merge !

@sknat sknat merged commit 026c565 into FDio:master Sep 12, 2024
10 checks passed
@ondrej-fabry
Copy link
Member

Thanks @ondrej-fabry for the merge !

Sorry it took a while.

@sknat
Copy link
Contributor

sknat commented Sep 13, 2024

No worries at all 😄

@mohsinkazmi mohsinkazmi deleted the extras-integration-testing branch September 16, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants