Gomemif improvemets #228
Merged
Gomemif improvemets #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packet reader function does not consider the length of the packet array to accommodate the number of receiving packets. It results in crash, if receiving packets are more than packet array length. This patch fixes this issue. Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
mohsinkazmi
force-pushed
the
gomemif-improvemets
branch
from
9ab283c
to
bc0b419
Compare
Previously, nested iterations over interfaces and queues were used to handle receive interrupts. This patch replaces that approach with a lookup-based solution. Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Previously, packets could starve in the receive queue if `rx_burst` read fewer packets than were enqueued. This patch ensures the queue remains interrupted, allowing the event handler to continue processing until all packets in the receive queue have been read. Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
sknat
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packet reader function does not consider the length of
the packet array to accommodate the number of receiving
packets. It results in crash, if receiving packets are
more than packet array length. This issue has been fixed.
Previously, nested iterations over interfaces and queues
were used to handle receive interrupts. It has been replaced
that approach with a lookup-based solution.
Previously, packets could starve in the receive queue
if
rx_burstread fewer packets than were enqueued.The fix ensures the queue remains interrupted,
allowing the event handler to continue processing
until all packets in the receive queue have been read.
fixes #85