Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exeflat: Update usage text for indirect file #187

Merged
merged 1 commit into from
Aug 18, 2024
Merged

exeflat: Update usage text for indirect file #187

merged 1 commit into from
Aug 18, 2024

Conversation

andrewbird
Copy link
Contributor

No description provided.

@andrewbird andrewbird merged commit 8f056cc into FDOS:master Aug 18, 2024
2 checks passed
@ecm-pushbx
Copy link
Contributor

ecm-pushbx commented Aug 18, 2024 •
edited by andrewbird
Loading

kernel/utils/exeflat.c

Line 445 in bf53e22

while( len-- > 0 ) {

What's the purpose of this loop? It seems to decrement len but repeatedly compares the same *str?

@ecm-pushbx
Copy link
Contributor

And len isn't used at all after this, it appears.

@ecm-pushbx
Copy link
Contributor

Fixed in 2ce6dc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewbird @ecm-pushbx @jmalak