ecm boot32 dl #120
Merged
ecm boot32 dl #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turned out that this loader was severely broken for many years, at least since 2012 (the git repo's creation). This variable was read as a word to set cx for a loop, but only the low byte had been written. The high byte happened to be 0EEh so cn_loop would always zero out the FAT sector to read. This _happened_ to work if the first root directory cluster and all the kernel file clusters were all referenced in the first sector of the FAT. Otherwise it would blow up.
|
Looks good! I'll use these changes to prepare a new SYS binary for my EDR repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the incompatibility noted in #119 and also another bug of the 8086 CHS FAT32 loader. The latter prevented successful loading if the kernel file's clusters did not fit within the first FAT sector.
Also, the 8086 CHS FAT32 loader will now emit an exclamation mark and a beep when an error occurs, rather than staying silent.