Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Sequence hierarchy to close #60 #65

Merged
merged 3 commits into from
Aug 5, 2020
Merged

Conversation

allysonlister
Copy link
Collaborator

@allysonlister allysonlister commented Aug 4, 2020

Note 1: clinical data item shows up in the diff below, though I didn't change it. This has come from an update of the external reference ontology, and has been updated in DRAO via Ontofox.

**Note 2: the IAO annotation property alternative term has various labels, some of which are in other languages (see image below). It seems that the Robot diff has picked up one of these other language labels to use instead of the English alternative term, but please note that there is no error in the way the OWL file is written. **
altterm

I have updated the development/refactored-IRIs-current.txt file with the following additions:

# List of refactored IRIs that have remained in DRAO.

Old IRI|New IRI
http://edamontology.org/data_2044|http://purl.obolibrary.org/obo/SO_0000001|Note: we are changing Sequence from EDAM to SO
http://edamontology.org/data_2976|http://purl.obolibrary.org/obo/SO_0000839|Note: we are changing Amino acid sequence from EDAM to SO

The following changes have been made, as compared by Robot diff on the master and branch version of DRAO-merged.owl:

Ontology comparison

Old

  • Ontology IRI: http://www.fairsharing.org/ontology/domain/DRAO.owl
  • Version IRI: None
  • Loaded from: file:/home/.../domain-ontology/development/build/DRAO-merged.owl

New

  • Ontology IRI: http://www.fairsharing.org/ontology/domain/DRAO.owl
  • Version IRI: None
  • Loaded from: file:/.../DRAO-merged-new.owl

Ontology imports

Ontology annotations

Nucleic acid sequence http://edamontology.org/data_2977

Removed

Added

Protein sequence http://edamontology.org/data_2976

Removed

Sequence http://edamontology.org/data_2044

Removed

clinical data item http://purl.obolibrary.org/obo/OGMS_0000123

Removed

  • clinical data item definition "a data item that is about a patient and is the specified output of a health care process assay or diagnostic process"

Added

  • clinical data item definition "A data item that is about a patient and is the specified output of a health care process assay or diagnostic process"

polypeptide_region http://purl.obolibrary.org/obo/SO_0000839

Added

region http://purl.obolibrary.org/obo/SO_0000001

Removed

Added

@allysonlister allysonlister added this to the DRAO 0.2.1 (COVID-19) milestone Aug 4, 2020
@allysonlister allysonlister linked an issue Aug 4, 2020 that may be closed by this pull request
@Drosophilic Drosophilic merged commit 0f66f33 into master Aug 5, 2020
@allysonlister allysonlister deleted the SequenceHierarchy branch August 5, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring sequence and its hierarchy
2 participants