Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/#685 add game_type to game_launch message #857

Merged
merged 17 commits into from
Nov 17, 2021
Merged

Issue/#685 add game_type to game_launch message #857

merged 17 commits into from
Nov 17, 2021

Conversation

KaukaHan
Copy link
Contributor

Closes #685

@KaukaHan
Copy link
Contributor Author

the unittests were successfull locally
semms like gw was causing the failure

Askaholic
Askaholic reviewed Nov 15, 2021
View reviewed changes
server/games/typedefs.py Outdated Show resolved Hide resolved
@Askaholic
Copy link
Collaborator

That test sometimes fails randomly as it has to deal with weak references.

@codecov
Copy link

codecov bot commented Nov 15, 2021 •
edited
Loading

Codecov Report

Merging #857 (da9b3ee) into develop (6d195ab) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
server/games/__init__.py 100.00% <ø> (ø)
server/games/custom_game.py 100.00% <ø> (ø)
server/games/game.py 95.67% <ø> (ø)
server/lobbyconnection.py 94.24% <ø> (ø)
server/games/typedefs.py 99.09% <100.00%> (+0.83%) ⬆️

@Askaholic
Copy link
Collaborator

Also check codacy, there is an unused import.

@Askaholic
Copy link
Collaborator

Oh you actually found a different unused import from the one codacy was complaining about :D

@Askaholic Askaholic changed the title Issue/#685 Issue/#685 add game_type to game_launch message Nov 17, 2021
@Askaholic Askaholic merged commit aac3d2c into FAForever:develop Nov 17, 2021
@KaukaHan KaukaHan deleted the issue/#685 branch November 17, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Askaholic Askaholic Askaholic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use game_type instead of init_mode in game_launch message
2 participants
@KaukaHan @Askaholic