Make RabbitMQ exchanges durable #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brutus5000
force-pushed
the
bugfix/#853-durable-exchange
branch
3 times, most recently
from
e552c8b
to
ef4f518
Compare
Fixes #853 As long as we do not have any session-related data, all exchanges and queues should be durable to avoid data loss on server restart.
Brutus5000
force-pushed
the
bugfix/#853-durable-exchange
branch
from
ef4f518
to
d5fa73e
Compare
Codecov Report
|
Askaholic
approved these changes
Oct 28, 2021
|
So will this need to be coordinated with an update of the league service too then? That's the only other app using rabbitmq so far right? |
|
I could squeeze it in into the rollout planned for tommorow but then we'd need to build a release for this PR as well. |
|
What I mean is, we need a corresponding PR on the league service side. |
|
Yes I was aware, I meant I could sneak it in since it it's easy to do, but I wasn't sure about the other changes on the develop branch here. So I opened a PR now and we have some time: FAForever/faf-league-service#36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #853
As long as we do not have any session-related data,
all exchanges and queues should be durable to avoid
data loss on server restart.