Issue/#838 Check for manual unrank game option #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
Askaholic
force-pushed
the
issue/#838-manual-unrank
branch
from
8292493
to
80c4cdf
Compare
Askaholic
force-pushed
the
issue/#838-manual-unrank
branch
2 times, most recently
from
56062a1
to
7df685e
Compare
Askaholic
requested review from
ChessBerry,
Cheyans,
Exselsior100,
KaletheQuick and
shalkya
|
Feel free to suggest better names for the new ValidityState |
|
Seeing no complaints, I'm going to merge as is |
Askaholic
force-pushed
the
issue/#838-manual-unrank
branch
from
7df685e
to
e8b63ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should add a validity state to the database just for this.
Closes #838