Use different search expansion for top players #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
Askaholic
approved these changes
Oct 13, 2021
| self._failed_matching_attempts * config.LADDER_TOP_PLAYER_SEARCH_EXPANSION_STEP, | ||
| config.LADDER_TOP_PLAYER_SEARCH_EXPANSION_MAX | ||
| ) | ||
| else: |
There was a problem hiding this comment.
Else isn't strictly necessary here, but I don't really care in this situation. Maybe you could say it helps readability in this case
There was a problem hiding this comment.
I'll let it in for the people like me that find code hard to read
Askaholic
reviewed
Oct 16, 2021
Askaholic
approved these changes
Oct 16, 2021
BlackYps
force-pushed
the
issue/#806-search-range-for-top-players
branch
from
e8699fd
to
3ce4a6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #806
This should enable 2k+ players to match all other 2k players if they are closer than 400 rating. I asked Tagada again and we wanted to have it 2k+ instead of 1.8k+.