Check for lobby scope in token during login #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm not sure why that test is failing because it uses the old password login |
|
When run by itself it passes just fine |
Codecov Report
|
|
Just a flakey test |
|
Also this is super important for enabling Gog link 🚀 wheeeeee |
|
Oh wait. This PR should instead remove the check for Steam link as this moves to the user service. |
|
The steam link check only happens when you login with password |
Askaholic
reviewed
Sep 24, 2021
|
So I'm assuming when you try to log in via the API and you're banned, you see the ban reason on the webpage? |
|
Correct |
Sheikah45
force-pushed
the
feature/check-token-scope
branch
from
f574088
to
396849a
Compare
Askaholic
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This asserts that the oauth token contains the lobby scope before allowing a player to login. This allows for players to be banned from just the game service. All oauth tokens from the clients currently have the lobby scope